ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix GroupBlock alignment 

closes RCX-2588
flag=block_editor

test plan:
  - create a page
  - put some stuff in a column
  - change horizontal alignment
  > expect the content to align correctly
  - change layout direction from column to row
  - change the vertical alignment
  > expect the contents to be correctly aligned
  - add a group block
  - put some stuff in it
  - resize it so it's larger than its contents
  - repeat the above exercise with the group

Change-Id: Ia6b23d70d174f85500b77d30e1e84365af705afc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360954
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
This commit is contained in:
Ed Schiebel 2024-10-24 09:52:50 -06:00
parent 330713980f
commit 03200fc815
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/shared/block-editor/react/assets/globalTemplates/blank.json
View File

@ -74,7 +74,7 @@
},
"isCanvas": true,
"props": {
"className": "",
"className": "group-block__inner",
"placeholderText": "Drop a block to add it here"
},
"displayName": "NoSections",

6
ui/shared/block-editor/react/style.css
View File

@ -351,6 +351,12 @@
&.end-align > .group-block__inner {
align-items: flex-end;
}
&.center-valign > .group-block__inner {
justify-content: center;
}
&.end-valign > .group-block__inner {
justify-content: flex-end;
}
}
&.enabled { /* always show the outline for a column */