Resolve error closing bluprint full-page modals

The Apps tab on the Course settings page uses `page` to manipulate its
contents. Unfortunatly this interferred with operation on the other
tabs.

fixes ADMIN-1000

test plan:
  - follow the steps in the ticket.
  > expect the UI to work as expected
  > expect no js error in the devtools console

Change-Id: Ic046d926c6fa040d081e920efd0b2c0f4c557c9d
Reviewed-on: https://gerrit.instructure.com/151025
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
This commit is contained in:
Ed Schiebel 2018-05-22 11:53:50 -04:00
parent 489b5d6ecf
commit 031d2db1d7
1 changed files with 11 additions and 7 deletions

View File

@ -63,6 +63,9 @@ import regularizePathname from '../external_apps/lib/regularizePathname'
}; };
const renderConfigurations = (ctx) => { const renderConfigurations = (ctx) => {
// router.start is only called when loading the Apps tab
// so we don't want to try anything here that hasn't happened.
if (targetNodeToRenderIn) {
ReactDOM.render( ReactDOM.render(
<Root> <Root>
<Configurations <Configurations
@ -71,6 +74,7 @@ import regularizePathname from '../external_apps/lib/regularizePathname'
</Root> </Root>
, targetNodeToRenderIn); , targetNodeToRenderIn);
} }
}
/** /**
* Route Configuration * Route Configuration