ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

make editing profile page accessible 

fixes CNVS-13993

Things were not being labeled correctly. They are now.

Test Plan

Given you've enabled profiles for your account
And you're using a screen reader
When you go to the profile page
And you edit the profile page
And you edit the "Bio" text
Then the bio text area should be labeled
And when you add or edit a link
Then the links title label should be read
And the links url should be read

Change-Id: I417948c62ec9fe34c805b350f0cdd39cde9c3109
Reviewed-on: https://gerrit.instructure.com/44272
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
This commit is contained in:
Sterling Cobb 2014-11-11 11:07:42 -07:00
parent 8b528e45eb
commit 01a1bffcb1
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/coffeescripts/bundles/profile_show.coffee
View File

@ -80,10 +80,10 @@ require [
@$linkFields ?= @$ '#profile_link_fields'
$row = $ """
<tr>
<td><input type="text" maxlength="255" name="link_titles[]" value="#{htmlEscape title}"></td>
<td><input aria-label="#{I18n.t("Link title")}" type="text" maxlength="255" name="link_titles[]" value="#{htmlEscape title}"></td>
<td>→</td>
<td><input type="text" name="link_urls[]" value="#{htmlEscape url}"></td>
<td><a href="#" data-event="removeLinkRow"><i class="icon-end"></i></a></td>
<td><input aria-label="#{I18n.t("Link Url")}" type="text" name="link_urls[]" value="#{htmlEscape url}"></td>
<td><a href="#" data-event="removeLinkRow"><span class="screenreader-only">#{I18n.t("Remove")}</span><i class="icon-end"></i></a></td>
</tr>
"""
@$linkFields.append $row

6
app/views/shared/_profile.html.erb
View File

@ -81,7 +81,7 @@
</div>
<div class="v-gutter">
<h2 class="h1 border border-b"><%= t :bio, "Bio" %></h2>
<h2 class="h1 border border-b"><label for="profile_bio" style="font-size: 22px"><%= t :bio, "Bio" %></label></h2>
<% if @user_data[:bio] %>
<div class="hide-if-editing"><%= raw format_message(@user_data[:bio]).first %></div>
<% else %>
@ -129,9 +129,9 @@
<div class="show-if-editing">
<table id="edit_links_table">
<thead>
<th><%= t :links_title, 'Title' %></th>
<th scope="col"><%= t :links_title, 'Title' %></th>
<th></th>
<th><%= t :links_url, 'URL' %></th>
<th scope="col"><%= t :links_url, 'URL' %></th>
</thead>
<tbody id="profile_link_fields"></tbody>
</table>