ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/package.json

363 lines
14 KiB
JSON
Raw Normal View History

AMD Conversion "Trivial" JavaScript / CoffeeScript changes -------------------------------------------------- For the most part, all javascript was simply wrapped in `require` or `define`. The dependencies were found with a script that matched regexes in the files, it errs on the side of listing too many dependencies, so its worth double checking each file's dependencies (over time, anyway). i18n API changes -------------------------------------------------- No longer have to do I18n.scoped calls, just list i18n as a dependency with the scope and it's imported already scoped require ['i18n!some_scope'], (I18n) -> I18n.t 'im_scoped', 'I'm scoped!' JS bundling now done with r.js, not Jammit -------------------------------------------------- We don't use jammit to bundle JS anymore. Simply list dependencies for your JS modules in the file and RequireJS handles the rest. To optimize the JavaScript, first make sure you have node.js 0.4.12+ installed and then run: $ rake js:build The app defaults to the optimized build in production. You can use non-optimized in production by putting ?debug_assets=true in the url just like before. You can also test the optimized JavaScript in development with ?optimized_js=true. Significant changes -------------------------------------------------- These files have "real" changes to them (unlike the JavaScript that is simply wrapped in require and define). Worth taking a really close look at: - app/helpers/application_helper.rb - app/views/layouts/application.html.erb - config/assets.yml - config/build.js - lib/handlebars/handlebars.rb - lib/i18n_extraction/js_extractor.rb - lib/tasks/canvas.rake - lib/tasks/i18n.rake - lib/tasks/js.rake Change-Id: I4bc5ecb1231f331aaded0fef2bcc1f3a9fe482a7 Reviewed-on: https://gerrit.instructure.com/6986 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Ryan Florence <ryanf@instructure.com>
2011-11-11 00:31:45 +08:00
{
"name": "canvas-lms",
upgrade karma everyone was getting build errors when they were npm install'ing. it was because karma 0.10 depended on an out-of-date version of chokiadr that does not compile against node 0.12 I also indicated that canvas is licenced agpl 3 so that you wouldn't always see an npm warning about not having one. also, let karma serve our css files so if any javascript references them in our quit tests, we don't see 404 warnings Change-Id: Iaa0377bc87b8f7ec8726d6cb82c0f8a103134b56 Reviewed-on: https://gerrit.instructure.com/58584 Tested-by: Jenkins Reviewed-by: Mike Nomitch <mnomitch@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2015-07-16 12:24:49 +08:00
"license": "AGPL-3.0",
AMD Conversion "Trivial" JavaScript / CoffeeScript changes -------------------------------------------------- For the most part, all javascript was simply wrapped in `require` or `define`. The dependencies were found with a script that matched regexes in the files, it errs on the side of listing too many dependencies, so its worth double checking each file's dependencies (over time, anyway). i18n API changes -------------------------------------------------- No longer have to do I18n.scoped calls, just list i18n as a dependency with the scope and it's imported already scoped require ['i18n!some_scope'], (I18n) -> I18n.t 'im_scoped', 'I'm scoped!' JS bundling now done with r.js, not Jammit -------------------------------------------------- We don't use jammit to bundle JS anymore. Simply list dependencies for your JS modules in the file and RequireJS handles the rest. To optimize the JavaScript, first make sure you have node.js 0.4.12+ installed and then run: $ rake js:build The app defaults to the optimized build in production. You can use non-optimized in production by putting ?debug_assets=true in the url just like before. You can also test the optimized JavaScript in development with ?optimized_js=true. Significant changes -------------------------------------------------- These files have "real" changes to them (unlike the JavaScript that is simply wrapped in require and define). Worth taking a really close look at: - app/helpers/application_helper.rb - app/views/layouts/application.html.erb - config/assets.yml - config/build.js - lib/handlebars/handlebars.rb - lib/i18n_extraction/js_extractor.rb - lib/tasks/canvas.rake - lib/tasks/i18n.rake - lib/tasks/js.rake Change-Id: I4bc5ecb1231f331aaded0fef2bcc1f3a9fe482a7 Reviewed-on: https://gerrit.instructure.com/6986 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Ryan Florence <ryanf@instructure.com>
2011-11-11 00:31:45 +08:00
"version": "0.0.0",
upgrade karma everyone was getting build errors when they were npm install'ing. it was because karma 0.10 depended on an out-of-date version of chokiadr that does not compile against node 0.12 I also indicated that canvas is licenced agpl 3 so that you wouldn't always see an npm warning about not having one. also, let karma serve our css files so if any javascript references them in our quit tests, we don't see 404 warnings Change-Id: Iaa0377bc87b8f7ec8726d6cb82c0f8a103134b56 Reviewed-on: https://gerrit.instructure.com/58584 Tested-by: Jenkins Reviewed-by: Mike Nomitch <mnomitch@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2015-07-16 12:24:49 +08:00
"engines": {
upgrade to node14 fixes FOO-1527 flag = none test plan: you can install node modules and run webpack Change-Id: I33347d791b0923f4471b555c6fac303b098b1ef4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/257333 Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com> Product-Review: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-01-26 03:16:32 +08:00
"node": ">=14.0.0",
[node12] bump "engines" in package.json refs FOO-1116 flag = none test plan: we can install `yarn install` Change-Id: I0e78958130368a11eb007d1ffddbd075f27d9380 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/254937 Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Ahmad Amireh <ahmad@instructure.com> Product-Review: Ahmad Amireh <ahmad@instructure.com>
2020-12-12 01:32:26 +08:00
"yarn": "^1.19.1"
upgrade karma everyone was getting build errors when they were npm install'ing. it was because karma 0.10 depended on an out-of-date version of chokiadr that does not compile against node 0.12 I also indicated that canvas is licenced agpl 3 so that you wouldn't always see an npm warning about not having one. also, let karma serve our css files so if any javascript references them in our quit tests, we don't see 404 warnings Change-Id: Iaa0377bc87b8f7ec8726d6cb82c0f8a103134b56 Reviewed-on: https://gerrit.instructure.com/58584 Tested-by: Jenkins Reviewed-by: Mike Nomitch <mnomitch@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2015-07-16 12:24:49 +08:00
},
Use yarn workspaces Run `script/nuke_node.sh` to clean everything up Run `yarn install` it should install everything for everything Run `yarn build` and `yarn test` they should work exactly as before Change-Id: I11a27ff2d705c6cbb3b3f9029dd8b32138706146 Reviewed-on: https://gerrit.instructure.com/151356 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-25 00:09:03 +08:00
"private": true,
"workspaces": {
"packages": [
spec: increase the timeout of canvas-rce specs Also: * update mocha-jsdom to eliminate a spec issue * fix some specs test plan: * Verify Jenkins passes Change-Id: Ib486336306719b5ca4160e15843a0aac084c5c92 Reviewed-on: https://gerrit.instructure.com/153972 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-06-15 22:04:23 +08:00
"gems/canvas_i18nliner",
treat anything in gems/plugins/* as a workspace Fixes: https://github.com/instructure/canvas-lms/issues/1323 This lets open source users continue putting their own plugins with npm deps In gems/plugins. They will still have to have a forked version Of yarn.lock though since that will be different for them than a “Default” install. Also, this means that everyone will see a bunch of warnings like this Every time they yarn install: Warning: gems/plugins/academic_benchmark is a dir… no package.json Warning: gems/plugins/account_reports is a dir.. has no package.json Warning: gems/plugins/canvas_geoip is a …, but has no package.json Warning: gems/plugins/demo_site is a directory, but has no package.json Warning: gems/plugins/instructure_misc_plugin is … has no package.json Warning: gems/plugins/moodle_importer is a d.., but has no package.json Warning: gems/plugins/qti_exporter is a dir…, but has no package.json Warning: gems/plugins/respondus_soap_endpoint is … no package.json Warning: gems/plugins/simply_versioned is a …, but has no package.json Test plan: * yarn install should work Change-Id: Ie65c8faf8b1022210cfb7eda8c25107facfe83b5 Reviewed-on: https://gerrit.instructure.com/158043 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-07-20 03:42:35 +08:00
"gems/plugins/*",
rename some things fixes FOO-1265 [skip-eslint=true] [pin-commit-analytics=7e49eefd7f59cbf43fd03bf8957bbbfa76f8d9d5] [pin-commit-demo_site=adade2e38e46a358a4643cd3db2fe5ccffe39ec5] [pin-commit-instructure_misc_plugin=47a3161102b0611af56d134fbd0c828ddc1b8abf] [pin-commit-migration_tool=0dbac2f5b421d894395605ce4b583ef0f7d60b22] [pin-commit-multiple_root_accounts=cc96d28c0d59bbe47acc64de4fdd8e1d2b029805] Change-Id: I14c07f20bd260cf0de1f48ceb70b3c2313edf2d2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258807 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Michael Ziwisky <mziwisky@instructure.com> QA-Review: Michael Ziwisky <mziwisky@instructure.com> Product-Review: Michael Ziwisky <mziwisky@instructure.com>
2021-04-06 07:44:00 +08:00
"ui/shared/*",
modernize canvas_quizzes fixes FOO-1409 flag = none no more client_apps, canvas_quizzes now lives as part of canvas-lms proper inside app/jsx/, which makes the build leaner and leaves us with one less thing to reason about logical changes: - converted from AMD to ES modules - upgraded to recent react + react-router - dropped RSVP in favor of native Promises - used CanvasModal instead of home-grown Dialog - removed dead code; notifications in particular were fishy as there had no dependents at all and did not even show up in the graph - ported tests to Jest, added more unit ones and two integration ones - removed "config.onError" and now throws errors where appropriate - disabled console statements in non-dev :: test plan :: - create a (old-school) quiz containing all types of questions - as 3 distinct students, take the quiz and try to randomize your answers at this point it's helpful to have a reference to compare the screens; I replicated the quiz on my production sandbox for this - go to /courses/:id/quizzes/:id/submissions/:id/log - verify it looks OK - click on a specific question in the stream and verify the question inspector widget works OK - go back to stream and push "View table" - verify the table and its controls are OK - go to /courses/:id/quizzes/:id/statistics - verify it looks OK - click on ? in the discrimination index chart and verify it displays a dialog with help content - click on "X respondents" in one of the charts and verify it displays a dialog with the respondent names - verify the interactive charts do interact as expected (no logic changed here so just a quick glance) - link to "View in SpeedGrader" for essay-like questions works Change-Id: I79af5ff4f1479503b5e2528b613255dde5bc45d3 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256118 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com> Product-Review: Simon Williams <simon@instructure.com>
2021-01-02 07:58:12 +08:00
"packages/*"
Use yarn workspaces Run `script/nuke_node.sh` to clean everything up Run `yarn install` it should install everything for everything Run `yarn build` and `yarn test` they should work exactly as before Change-Id: I11a27ff2d705c6cbb3b3f9029dd8b32138706146 Reviewed-on: https://gerrit.instructure.com/151356 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-25 00:09:03 +08:00
],
"nohoist": [
extend JS source files without relying on filepath fixes FOO-1435 flag = none instead of the bundler inferring the source file that an extension is meant for based on filepath, a plugin is now expected to explicitly map each source file to the extension file in its package.json manifest { "canvas": { "source-file-extensions": { "path/to/a.js": "path/to/extension-to-a.js" } } } this allows extensions to continue working even when the path of the source file no longer matches that of the extension inside the plugin == test plan - visit a page that contains an extended module and verify the extension is still applied Change-Id: Ida7d75b87aedc519502c969e6912a335af69abc0 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256222 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com> Product-Review: Simon Williams <simon@instructure.com>
2021-01-07 01:40:57 +08:00
"**/tinymce",
"**/tinymce/**"
Use yarn workspaces Run `script/nuke_node.sh` to clean everything up Run `yarn install` it should install everything for everything Run `yarn build` and `yarn test` they should work exactly as before Change-Id: I11a27ff2d705c6cbb3b3f9029dd8b32138706146 Reviewed-on: https://gerrit.instructure.com/151356 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-25 00:09:03 +08:00
]
},
move napa from "devDependencies" to "dependencies" Change-Id: I4dde9458868cd5c1c41b921414dff4b3dc9371de Reviewed-on: https://gerrit.instructure.com/29878 Reviewed-by: Simon Williams <simon@instructure.com> Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> Tested-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
2014-02-11 02:29:11 +08:00
"dependencies": {
Upgrade canvas-rce to 4.1.5 The only change is that some things that it actually used weren’t In it’s package.json and they were added. See https://diff.intrinsic.com/@instructure/canvas-rce-old/4.1.4/4.1.5 For the differences Test plan: * when we upgrade canvas’s instUI to 6.x we shouldn’t get failures about not being able to find @instructure/ui-alerts/lib/packages/alert.js Change-Id: Icff6d120bff55697defc73c092b2ca9782fc44e2 Reviewed-on: https://gerrit.instructure.com/207063 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-28 04:07:03 +08:00
"@instructure/canvas-rce-old": "4.1.5",
fix audio player and video player sizing closes LA-729 flag=rce_enhancements The original intent for the audio player was to size it so the buttons just fit. This ignored the fact that it's rendered w/in an iframe, so popup menus are clipped. This change sizes the player to leave room for those popups. While the ticket was written against the audio player, the same issues may occur in the video player, either for portrait videos or videos < 400px wide when closed captions are present. The original code for sizing the video player shrank the width to fit thea video's size, which clipped the buttons. This change sets a minimum width for the player and letter-boxes the video. test plan: - in the new rce - add an audio file > expect it to be wide enough to show all the buttons and tall enough for the speed and volume popups - add a vertical video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - Submit to upload > expect the player to be wide enough to show all the buttons - click the fullscreen button > expect the video to be the height of the screen and letterboxed - restore to windowed size > expect the video to return to its letterboxed size - click the video, then the Options button - change the video's size > expect the video to remain letterboxed - add a horizontal video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - submit to upload > expect the player to be sized to the size of the video - fullscreen > expect the video to be letterboxed in the fullscreen player (if the aspect ration of the video !== that of your monitor, or fill the screen if they match) - for the horizontal video, select Opitons and change the size to be "medium" or "custom" and < 400px wide and add subtitles > expect the video to be letterboxed in a 400px wide iframe. Change-Id: Ib5d08dbd7796985d00f656e38a642ab92939d614 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238432 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-26 23:37:35 +08:00
"@instructure/canvas-theme": "6",
"@instructure/debounce": "6",
filter non-actionable console logs everywhere else too I did this first for canvas’s jest tests, but this does it for karma/qUnit, canvas-rce, canvas-planner and dev mode too. test plan: * run `yarn test` * you should see a lot less react deprecation messages Change-Id: I5f5cee08d705b749526be87fd79cfc937c015145 Reviewed-on: https://gerrit.instructure.com/206879 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-27 11:41:36 +08:00
"@instructure/js-utils": ">=1",
Update instui and media-capture versions, reprise instui -> 6.24.0 @instructure/media-capture -> 7.1.0 the update to @instructure/media-capture is necessary to fix the audio recording bug described in LA-859. This change required a bump to INSTUI's version. Both updates are rolled into this change. closes LA-595 flag=none test plan: For the audio recording part: prereq: have notorious running. you must be loading canvas from localhost unless using https in order to enable the mic and webcam. - create or edit something with the rce - select Media > Upload/Record media - change to the Record tab - click on the "WebCam" button and select "No video" - record some audio and save > expect the audio to be uploaded and appear in the RCE - go to the speedgrader for a graded object - click on the Media Comment button - click on the "WebCam" button and select "No video" - record some audio and save > expec the audio comment to be uploaded and playable For the instui upgrade part: - make sure everything still works as expected - check with instui changelog for changes since 6.21 for guidance This commit reverts commit 7ede7985492e9630b8eb6b411a7b1217816cbe08, which reverted 81d493b7223c06d6c2c6681c8570fd4e136b85e9 which was prematurely merged. Reason for revert: get the oritinal patchset back in the queue, but hold off merging until after beta is cut from master. This will give the INSTUI change a chance to soak in dev for longer than the weekend before being deployed Change-Id: Iada67ee10a796e4b4b967b27a64f3e527e78249a Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/233037 Reviewed-by: Charley Kline <ckline@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-04-17 22:13:46 +08:00
"@instructure/media-capture": "~7.1.0",
change outcomes alignment component closes OUT-3593 flag=outcome_alignment_non_scoring_content Test plan: - with quiz_api, outcomes, canvas running, provision outcomes for account - in canvas rails console: Account.first.provision_outcomes - in a course, create some outcomes and groups - sync canvas outcomes to outcomes service - following instructions in outcomes-service canvas.rake re: canvas docker-compose config, run in outcomes-service: dc run --rm api bundle exec rake \ canvas:dump_canvas_data[outcomes.docker,db.canvas.docker] dc run --rm api bundle exec rake canvas:sync[outcomes.docker,true] - enable "Outcome alignment to non-scoring content" FF - create canvas course with wiki page - on wiki page show page, add outcomes to the page - verify that outcomes are retained on reload - in another course without outcomes, verify that outcomes widget does not appear Change-Id: Ie3af07642d818eaa529bff76b1ac7d81e575622b Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/235665 Reviewed-by: Augusto Callejas <acallejas@instructure.com> Reviewed-by: Pat Renner <prenner@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Augusto Callejas <acallejas@instructure.com> Product-Review: Jody Sailor
2020-04-29 23:38:46 +08:00
"@instructure/outcomes-ui": "^1.1.6",
bump npm-run-all version Change-Id: Ieae7ac480124e52050c79ca83c99a7fe698c48d5 Reviewed-on: https://gerrit.instructure.com/173262 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Gary Mei <gmei@instructure.com> Product-Review: Gary Mei <gmei@instructure.com>
2018-11-27 02:20:33 +08:00
"@instructure/react-crop": "^5.0.1",
[node12] upgrade to node 12.19.1 (LTS) fixes FOO-1116 flag = none this upgrade was problematic mostly because of Node's support for ES modules (ESM) that is still fairly recent and introduces some complexity around packaging. This is also the reason for the considerable hack related to @instructure packages (see inline documentation) that can be removed once we fix things upstream | test plan | | --------- | - install node 12 if needed (e.g. not on docker) - purge your node modules: rm -rf {.,client_apps/*,gems/*,gems/plugins/*,packages/*}/node_modules - make sure you can still build locally (native/docker) bundle exec rake canvas:compile_assets Change-Id: If9605ac428f0ff228f8852f0becb9fbac750f1f2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/253166 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> Reviewed-by: Charley Kline <ckline@instructure.com> QA-Review: Simon Williams <simon@instructure.com> QA-Review: Charley Kline <ckline@instructure.com> Product-Review: Charley Kline <ckline@instructure.com>
2020-12-03 07:53:26 +08:00
"@instructure/reactour": "https://github.com/instructure/reactour#b908434fe544703e26bc67c67c4111252c401f92",
Enable outcome alignment on Canvas pages closes OUT-3401 flag = none test plan: - check out/update canvas plugins needed for sharding: * multiple_root_accounts * demo_site * canvas_geoip - check out/update canvas plugin needed for provisioning: * uuid_provisioner - check out/update quiz repo: * quiz_api - check out/update outcomes service: * outcomes-service - add the following to the postgres container section of your docker-compose.override.yml in canvas: === ports: - "5432:5432" environment: VIRTUAL_HOST: db.canvas.docker === - update canvas configuration by adding example dynamic_settings to existing config/dynamic_settings.yml and by copying example uuid_provisioner.yml - in canvas rails console, enable the auto provision setting: > Setting.set('auto_provision_outcomes_service', 'true') - start up canvas, outcomes-service and quiz_api - create a new root account from canvas siteadmin http://canvas.docker/accounts/site_admin/root_accounts: * account name: outcomes * account domain: outcomes.canvas.docker - after a few minutes, verify in the outcomes rails console that a new shard has been created and registered for the second account, but not the first > ap AccountRegistry.all - create a course with outcomes in outcomes.canvas.docker - in the outcomes api docker container, dump canvas data and sync into the provisioned outcomes shard: > bundle exec rake canvas:dump_canvas_data[outcomes.outcomes.docker] > bundle exec rake canvas:sync[outcomes.outcomes.docker,true] - enable the outcome alignment feature flag: - http://canvas.docker/accounts/site_admin/settings - Feature Options tab - Find "Outcome alignment to non-scoring content" feature flag - Switch to "ON" - return to course created in new canvas account - create a canvas page in the course - load the newly created canvas page - confirm that an outcome alignment widget appears, and that it opens a side tray with course outcomes when attempting to align Change-Id: Ide6891493ea3c926d155d4aea9bc7aff5bdaa6fb Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/227463 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Michael Brewer-Davis <mbd@instructure.com> Reviewed-by: Pat Renner <prenner@instructure.com> QA-Review: Michael Brewer-Davis <mbd@instructure.com> Product-Review: Michael Brewer-Davis <mbd@instructure.com>
2020-02-21 07:38:23 +08:00
"@instructure/ready": ">=1",
fix audio player and video player sizing closes LA-729 flag=rce_enhancements The original intent for the audio player was to size it so the buttons just fit. This ignored the fact that it's rendered w/in an iframe, so popup menus are clipped. This change sizes the player to leave room for those popups. While the ticket was written against the audio player, the same issues may occur in the video player, either for portrait videos or videos < 400px wide when closed captions are present. The original code for sizing the video player shrank the width to fit thea video's size, which clipped the buttons. This change sets a minimum width for the player and letter-boxes the video. test plan: - in the new rce - add an audio file > expect it to be wide enough to show all the buttons and tall enough for the speed and volume popups - add a vertical video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - Submit to upload > expect the player to be wide enough to show all the buttons - click the fullscreen button > expect the video to be the height of the screen and letterboxed - restore to windowed size > expect the video to return to its letterboxed size - click the video, then the Options button - change the video's size > expect the video to remain letterboxed - add a horizontal video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - submit to upload > expect the player to be sized to the size of the video - fullscreen > expect the video to be letterboxed in the fullscreen player (if the aspect ration of the video !== that of your monitor, or fill the screen if they match) - for the horizontal video, select Opitons and change the size to be "medium" or "custom" and < 400px wide and add subtitles > expect the video to be letterboxed in a 400px wide iframe. Change-Id: Ib5d08dbd7796985d00f656e38a642ab92939d614 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238432 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-26 23:37:35 +08:00
"@instructure/ui-a11y": "6",
"@instructure/ui-alerts": "6",
"@instructure/ui-avatar": "6",
create MessageListHolder and MessageListItem This is the message collection on the left hand side of the Inbox. Test Plan: - Run Storybook - Verify that the MessageListHolder story is rendering as expected -- Unread converstaions should have an unread badge -- The number badge should show the total number of messages in the thread -- The checkbox should fire the onSelect action -- Mousing over a conversation should show its star button -- Clicking the star button on a conversation should fill in the icon and make the button persist even when moused out of the conversation -- Clicking the star button should fire the onStar callback closes VICE-844 Change-Id: Ia554f8fe9717934dcb72569360a7b180537583c1 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/253560 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Davis Hyer <dhyer@instructure.com> QA-Review: Davis Hyer <dhyer@instructure.com> Product-Review: Davis Hyer <dhyer@instructure.com>
2020-11-16 13:42:14 +08:00
"@instructure/ui-badge": "6",
fix audio player and video player sizing closes LA-729 flag=rce_enhancements The original intent for the audio player was to size it so the buttons just fit. This ignored the fact that it's rendered w/in an iframe, so popup menus are clipped. This change sizes the player to leave room for those popups. While the ticket was written against the audio player, the same issues may occur in the video player, either for portrait videos or videos < 400px wide when closed captions are present. The original code for sizing the video player shrank the width to fit thea video's size, which clipped the buttons. This change sets a minimum width for the player and letter-boxes the video. test plan: - in the new rce - add an audio file > expect it to be wide enough to show all the buttons and tall enough for the speed and volume popups - add a vertical video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - Submit to upload > expect the player to be wide enough to show all the buttons - click the fullscreen button > expect the video to be the height of the screen and letterboxed - restore to windowed size > expect the video to return to its letterboxed size - click the video, then the Options button - change the video's size > expect the video to remain letterboxed - add a horizontal video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - submit to upload > expect the player to be sized to the size of the video - fullscreen > expect the video to be letterboxed in the fullscreen player (if the aspect ration of the video !== that of your monitor, or fill the screen if they match) - for the horizontal video, select Opitons and change the size to be "medium" or "custom" and < 400px wide and add subtitles > expect the video to be letterboxed in a 400px wide iframe. Change-Id: Ib5d08dbd7796985d00f656e38a642ab92939d614 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238432 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-26 23:37:35 +08:00
"@instructure/ui-billboard": "6",
"@instructure/ui-breadcrumb": "6",
"@instructure/ui-buttons": "6",
finalize discussion post redesign fixes VICE-932, VICE-934 flag=none test plan: - checkout the storybook instances for: - PostMessage - PostToolbar - changes should reflect the latest designs qa risk: low Change-Id: I338a05de2e8c4d42c23d246c1d1fa893de963c20 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258269 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com> QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com> Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
2021-02-06 01:53:20 +08:00
"@instructure/ui-byline": "6",
fix audio player and video player sizing closes LA-729 flag=rce_enhancements The original intent for the audio player was to size it so the buttons just fit. This ignored the fact that it's rendered w/in an iframe, so popup menus are clipped. This change sizes the player to leave room for those popups. While the ticket was written against the audio player, the same issues may occur in the video player, either for portrait videos or videos < 400px wide when closed captions are present. The original code for sizing the video player shrank the width to fit thea video's size, which clipped the buttons. This change sets a minimum width for the player and letter-boxes the video. test plan: - in the new rce - add an audio file > expect it to be wide enough to show all the buttons and tall enough for the speed and volume popups - add a vertical video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - Submit to upload > expect the player to be wide enough to show all the buttons - click the fullscreen button > expect the video to be the height of the screen and letterboxed - restore to windowed size > expect the video to return to its letterboxed size - click the video, then the Options button - change the video's size > expect the video to remain letterboxed - add a horizontal video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - submit to upload > expect the player to be sized to the size of the video - fullscreen > expect the video to be letterboxed in the fullscreen player (if the aspect ration of the video !== that of your monitor, or fill the screen if they match) - for the horizontal video, select Opitons and change the size to be "medium" or "custom" and < 400px wide and add subtitles > expect the video to be letterboxed in a 400px wide iframe. Change-Id: Ib5d08dbd7796985d00f656e38a642ab92939d614 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238432 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-26 23:37:35 +08:00
"@instructure/ui-calendar": "6",
"@instructure/ui-checkbox": "6",
"@instructure/ui-date-input": "6",
"@instructure/ui-decorator": "6",
"@instructure/ui-editable": "6",
"@instructure/ui-elements": "6",
"@instructure/ui-file-drop": "6",
"@instructure/ui-flex": "6",
"@instructure/ui-focusable": "6",
"@instructure/ui-form-field": "6",
"@instructure/ui-forms": "6",
"@instructure/ui-grid": "6",
"@instructure/ui-heading": "6",
"@instructure/ui-i18n": "6",
Upgrade InstUI to latest minor / patch versions This change aims to fix tree-shaking issues introduced in InstUI 7 by the addition of `"type": "module"` to the packages' package.json files. It updates the following major versions to their latest minor / patch versions: * 7 -> 7.4.4 * 6 -> 6.27.0 It also updates @instructure/ui-icons from v6 to v7, since nothing has changed between those versions except the addition of new icons and a slight tweak to the "add" and "x" icons to make them more closely match product designs. It also updates @babel/core, @babel/runtime, and @babel/runtime-corejs3 to latest (7.13.10) to fix this babel issue: https://github.com/babel/babel/issues/12854. The dependency changes also shuffled around the webpack build a bit-- the assignment_edit bundle is now (slightly) over the max asset size limit, while quizzes_bundle and screenreader_gradebook are not any more. fixes LS-2016 flag = none Test plan: - Ensure everything in canvas still works and looks the same Change-Id: I262012c9b752cec617f425c57e8c276bc7870b21 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/260391 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Ahmad Amireh <ahmad@instructure.com> QA-Review: Ahmad Amireh <ahmad@instructure.com> Product-Review: Ahmad Amireh <ahmad@instructure.com>
2021-03-11 03:57:44 +08:00
"@instructure/ui-icons": "7",
fix audio player and video player sizing closes LA-729 flag=rce_enhancements The original intent for the audio player was to size it so the buttons just fit. This ignored the fact that it's rendered w/in an iframe, so popup menus are clipped. This change sizes the player to leave room for those popups. While the ticket was written against the audio player, the same issues may occur in the video player, either for portrait videos or videos < 400px wide when closed captions are present. The original code for sizing the video player shrank the width to fit thea video's size, which clipped the buttons. This change sets a minimum width for the player and letter-boxes the video. test plan: - in the new rce - add an audio file > expect it to be wide enough to show all the buttons and tall enough for the speed and volume popups - add a vertical video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - Submit to upload > expect the player to be wide enough to show all the buttons - click the fullscreen button > expect the video to be the height of the screen and letterboxed - restore to windowed size > expect the video to return to its letterboxed size - click the video, then the Options button - change the video's size > expect the video to remain letterboxed - add a horizontal video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - submit to upload > expect the player to be sized to the size of the video - fullscreen > expect the video to be letterboxed in the fullscreen player (if the aspect ration of the video !== that of your monitor, or fill the screen if they match) - for the horizontal video, select Opitons and change the size to be "medium" or "custom" and < 400px wide and add subtitles > expect the video to be letterboxed in a 400px wide iframe. Change-Id: Ib5d08dbd7796985d00f656e38a642ab92939d614 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238432 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-26 23:37:35 +08:00
"@instructure/ui-img": "6",
"@instructure/ui-layout": "6",
"@instructure/ui-link": "6",
"@instructure/ui-list": "6",
Add Auto Show Closed Captions user feature closes MAT-40 flag=auto_show_cc Requested by the Columbus Public Schools (my homies), create a setting so videos automatically show CCs when playing videos. test plan: - create RCE content and include a video - add a couple CC files in different languages, including the user's language (the .srt files don't have to be in another language, just tell canvas they are) - save > expect no CC without selecting them from the CC menu in the media player - click on the user's avatar to open the user's tray and choose Settings - enable the "Automaticaly show media captions" feature - refresh to the page with RCE content > expect the CCs in the user's language to automatically show - change the user's language to another one you have CCs for - refresh the page with the video > expect the new language's CCs - change the user's language to something not in the CC list and not English - refresh the video page > no CCs and nothing bad happens. note: I wanted to test with with various combinations of en, en-US, and en-GB but canvas won't let you add CCs in regional locales. I don't know why, but that's a problem for another day. Change-Id: I355fd12c5ea42fe5bc8e776a0c602c2857aaf4c6 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262500 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Nate Armstrong <narmstrong@instructure.com> QA-Review: Nate Armstrong <narmstrong@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2021-04-09 00:47:15 +08:00
"@instructure/ui-media-player": "^7.2",
fix audio player and video player sizing closes LA-729 flag=rce_enhancements The original intent for the audio player was to size it so the buttons just fit. This ignored the fact that it's rendered w/in an iframe, so popup menus are clipped. This change sizes the player to leave room for those popups. While the ticket was written against the audio player, the same issues may occur in the video player, either for portrait videos or videos < 400px wide when closed captions are present. The original code for sizing the video player shrank the width to fit thea video's size, which clipped the buttons. This change sets a minimum width for the player and letter-boxes the video. test plan: - in the new rce - add an audio file > expect it to be wide enough to show all the buttons and tall enough for the speed and volume popups - add a vertical video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - Submit to upload > expect the player to be wide enough to show all the buttons - click the fullscreen button > expect the video to be the height of the screen and letterboxed - restore to windowed size > expect the video to return to its letterboxed size - click the video, then the Options button - change the video's size > expect the video to remain letterboxed - add a horizontal video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - submit to upload > expect the player to be sized to the size of the video - fullscreen > expect the video to be letterboxed in the fullscreen player (if the aspect ration of the video !== that of your monitor, or fill the screen if they match) - for the horizontal video, select Opitons and change the size to be "medium" or "custom" and < 400px wide and add subtitles > expect the video to be letterboxed in a 400px wide iframe. Change-Id: Ib5d08dbd7796985d00f656e38a642ab92939d614 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238432 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-26 23:37:35 +08:00
"@instructure/ui-menu": "6",
Update InstUI component source modules via codemod Closes FOO-1717 flag = none This was the result of the InstUI codemod per the v7 upgrade guide instructions Test plan: * build still passes * no clue how we'd manually QA all this. Any ideas? Change-Id: I6ca72bfabca0628761be00d8bed27dda103e0711 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/260817 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Ahmad Amireh <ahmad@instructure.com> QA-Review: August Thornton <august@instructure.com> Product-Review: August Thornton <august@instructure.com>
2021-03-17 01:56:54 +08:00
"@instructure/ui-metric": "6",
fix audio player and video player sizing closes LA-729 flag=rce_enhancements The original intent for the audio player was to size it so the buttons just fit. This ignored the fact that it's rendered w/in an iframe, so popup menus are clipped. This change sizes the player to leave room for those popups. While the ticket was written against the audio player, the same issues may occur in the video player, either for portrait videos or videos < 400px wide when closed captions are present. The original code for sizing the video player shrank the width to fit thea video's size, which clipped the buttons. This change sets a minimum width for the player and letter-boxes the video. test plan: - in the new rce - add an audio file > expect it to be wide enough to show all the buttons and tall enough for the speed and volume popups - add a vertical video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - Submit to upload > expect the player to be wide enough to show all the buttons - click the fullscreen button > expect the video to be the height of the screen and letterboxed - restore to windowed size > expect the video to return to its letterboxed size - click the video, then the Options button - change the video's size > expect the video to remain letterboxed - add a horizontal video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - submit to upload > expect the player to be sized to the size of the video - fullscreen > expect the video to be letterboxed in the fullscreen player (if the aspect ration of the video !== that of your monitor, or fill the screen if they match) - for the horizontal video, select Opitons and change the size to be "medium" or "custom" and < 400px wide and add subtitles > expect the video to be letterboxed in a 400px wide iframe. Change-Id: Ib5d08dbd7796985d00f656e38a642ab92939d614 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238432 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-26 23:37:35 +08:00
"@instructure/ui-modal": "6",
"@instructure/ui-motion": "6",
"@instructure/ui-number-input": "6",
"@instructure/ui-overlays": "6",
"@instructure/ui-pagination": "6",
Update InstUI component source modules via codemod Closes FOO-1717 flag = none This was the result of the InstUI codemod per the v7 upgrade guide instructions Test plan: * build still passes * no clue how we'd manually QA all this. Any ideas? Change-Id: I6ca72bfabca0628761be00d8bed27dda103e0711 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/260817 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Ahmad Amireh <ahmad@instructure.com> QA-Review: August Thornton <august@instructure.com> Product-Review: August Thornton <august@instructure.com>
2021-03-17 01:56:54 +08:00
"@instructure/ui-pill": "6",
fix audio player and video player sizing closes LA-729 flag=rce_enhancements The original intent for the audio player was to size it so the buttons just fit. This ignored the fact that it's rendered w/in an iframe, so popup menus are clipped. This change sizes the player to leave room for those popups. While the ticket was written against the audio player, the same issues may occur in the video player, either for portrait videos or videos < 400px wide when closed captions are present. The original code for sizing the video player shrank the width to fit thea video's size, which clipped the buttons. This change sets a minimum width for the player and letter-boxes the video. test plan: - in the new rce - add an audio file > expect it to be wide enough to show all the buttons and tall enough for the speed and volume popups - add a vertical video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - Submit to upload > expect the player to be wide enough to show all the buttons - click the fullscreen button > expect the video to be the height of the screen and letterboxed - restore to windowed size > expect the video to return to its letterboxed size - click the video, then the Options button - change the video's size > expect the video to remain letterboxed - add a horizontal video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - submit to upload > expect the player to be sized to the size of the video - fullscreen > expect the video to be letterboxed in the fullscreen player (if the aspect ration of the video !== that of your monitor, or fill the screen if they match) - for the horizontal video, select Opitons and change the size to be "medium" or "custom" and < 400px wide and add subtitles > expect the video to be letterboxed in a 400px wide iframe. Change-Id: Ib5d08dbd7796985d00f656e38a642ab92939d614 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238432 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-26 23:37:35 +08:00
"@instructure/ui-portal": "6",
"@instructure/ui-progress": "6",
"@instructure/ui-radio-input": "6",
Update InstUI component source modules via codemod Closes FOO-1717 flag = none This was the result of the InstUI codemod per the v7 upgrade guide instructions Test plan: * build still passes * no clue how we'd manually QA all this. Any ideas? Change-Id: I6ca72bfabca0628761be00d8bed27dda103e0711 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/260817 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Ahmad Amireh <ahmad@instructure.com> QA-Review: August Thornton <august@instructure.com> Product-Review: August Thornton <august@instructure.com>
2021-03-17 01:56:54 +08:00
"@instructure/ui-rating": "6",
fix audio player and video player sizing closes LA-729 flag=rce_enhancements The original intent for the audio player was to size it so the buttons just fit. This ignored the fact that it's rendered w/in an iframe, so popup menus are clipped. This change sizes the player to leave room for those popups. While the ticket was written against the audio player, the same issues may occur in the video player, either for portrait videos or videos < 400px wide when closed captions are present. The original code for sizing the video player shrank the width to fit thea video's size, which clipped the buttons. This change sets a minimum width for the player and letter-boxes the video. test plan: - in the new rce - add an audio file > expect it to be wide enough to show all the buttons and tall enough for the speed and volume popups - add a vertical video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - Submit to upload > expect the player to be wide enough to show all the buttons - click the fullscreen button > expect the video to be the height of the screen and letterboxed - restore to windowed size > expect the video to return to its letterboxed size - click the video, then the Options button - change the video's size > expect the video to remain letterboxed - add a horizontal video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - submit to upload > expect the player to be sized to the size of the video - fullscreen > expect the video to be letterboxed in the fullscreen player (if the aspect ration of the video !== that of your monitor, or fill the screen if they match) - for the horizontal video, select Opitons and change the size to be "medium" or "custom" and < 400px wide and add subtitles > expect the video to be letterboxed in a 400px wide iframe. Change-Id: Ib5d08dbd7796985d00f656e38a642ab92939d614 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238432 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-26 23:37:35 +08:00
"@instructure/ui-react-utils": "6",
"@instructure/ui-responsive": "6",
"@instructure/ui-select": "6",
Fix kb nav in RCE tray's filter drop-downs closes LS-1621 flag=none Strictly speaking, the bug this fixes was addressed by updating the <Select> in the RCE's Filter component by changing it to <SimpleSelect>, but there was a bug in an earlier version that had me update instui v7 components in canvas to the latest versions. You need to run yarn (canvas:compile_assets does this for you), or maybe even nuke_node before moving forward. test plan: - in the RCE, open the content tray (e.g. Documents > Course Documents) - use the keyboard to navigate thru the filter area - use arrow keys to open the various dropdowns and make changes > expect it to work, and for the tray not to unexpectedly close Change-Id: Id48441ef51ca2053b2b4b4cae27b90fcab6f4308 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/252965 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jackson Howe <jackson.howe@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-11-17 23:47:36 +08:00
"@instructure/ui-simple-select": "7",
fix audio player and video player sizing closes LA-729 flag=rce_enhancements The original intent for the audio player was to size it so the buttons just fit. This ignored the fact that it's rendered w/in an iframe, so popup menus are clipped. This change sizes the player to leave room for those popups. While the ticket was written against the audio player, the same issues may occur in the video player, either for portrait videos or videos < 400px wide when closed captions are present. The original code for sizing the video player shrank the width to fit thea video's size, which clipped the buttons. This change sets a minimum width for the player and letter-boxes the video. test plan: - in the new rce - add an audio file > expect it to be wide enough to show all the buttons and tall enough for the speed and volume popups - add a vertical video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - Submit to upload > expect the player to be wide enough to show all the buttons - click the fullscreen button > expect the video to be the height of the screen and letterboxed - restore to windowed size > expect the video to return to its letterboxed size - click the video, then the Options button - change the video's size > expect the video to remain letterboxed - add a horizontal video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - submit to upload > expect the player to be sized to the size of the video - fullscreen > expect the video to be letterboxed in the fullscreen player (if the aspect ration of the video !== that of your monitor, or fill the screen if they match) - for the horizontal video, select Opitons and change the size to be "medium" or "custom" and < 400px wide and add subtitles > expect the video to be letterboxed in a 400px wide iframe. Change-Id: Ib5d08dbd7796985d00f656e38a642ab92939d614 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238432 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-26 23:37:35 +08:00
"@instructure/ui-spinner": "6",
"@instructure/ui-svg-images": "6",
"@instructure/ui-table": "6",
"@instructure/ui-tabs": "6",
"@instructure/ui-tag": "6",
"@instructure/ui-text": "6",
"@instructure/ui-text-area": "6",
"@instructure/ui-text-input": "6",
"@instructure/ui-themeable": "6",
"@instructure/ui-themes": "6",
Add shared DateTimeInput component Closes FOO-1857 flag = none InstUI 6 had a combo DateTimeInput component which went away as of version 7. It's used in a couple of places in Canvas, so we recreate that functionality in a shared component. Tricky stuff to work in all time zones and all DST systems. Test plan: * tests pass (nothing uses this yet) * not sure if the included Storybook will work or not Change-Id: I053a936e5cb505100a0e44571d29584094bad4f2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262459 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Jacob Burroughs <jburroughs@instructure.com> Product-Review: Charley Kline <ckline@instructure.com>
2021-04-08 11:58:58 +08:00
"@instructure/ui-time-select": "6",
fix audio player and video player sizing closes LA-729 flag=rce_enhancements The original intent for the audio player was to size it so the buttons just fit. This ignored the fact that it's rendered w/in an iframe, so popup menus are clipped. This change sizes the player to leave room for those popups. While the ticket was written against the audio player, the same issues may occur in the video player, either for portrait videos or videos < 400px wide when closed captions are present. The original code for sizing the video player shrank the width to fit thea video's size, which clipped the buttons. This change sets a minimum width for the player and letter-boxes the video. test plan: - in the new rce - add an audio file > expect it to be wide enough to show all the buttons and tall enough for the speed and volume popups - add a vertical video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - Submit to upload > expect the player to be wide enough to show all the buttons - click the fullscreen button > expect the video to be the height of the screen and letterboxed - restore to windowed size > expect the video to return to its letterboxed size - click the video, then the Options button - change the video's size > expect the video to remain letterboxed - add a horizontal video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - submit to upload > expect the player to be sized to the size of the video - fullscreen > expect the video to be letterboxed in the fullscreen player (if the aspect ration of the video !== that of your monitor, or fill the screen if they match) - for the horizontal video, select Opitons and change the size to be "medium" or "custom" and < 400px wide and add subtitles > expect the video to be letterboxed in a 400px wide iframe. Change-Id: Ib5d08dbd7796985d00f656e38a642ab92939d614 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238432 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-26 23:37:35 +08:00
"@instructure/ui-toggle-details": "6",
"@instructure/ui-tree-browser": "6",
"@instructure/ui-view": "6",
"@instructure/uid": "6",
update Microsoft Immersive Reader SDK closes LS-1377 flag = immersive_reader_wiki_pages Test Plan: - Enable immersive reader. - Because there doesn't seem to be a way to run this locally (without consul), I had to temporarily modify the immersive_reader_controller.rb and added prod creds to get this to test. see me for more details Change-Id: Ifaa7edfa94ff29856ae6b474548e0f450b9d4c6c Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245869 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Ed Schiebel <eschiebel@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Clint Furse <cfurse@instructure.com>
2020-08-25 00:57:49 +08:00
"@microsoft/immersive-reader-sdk": "^1.1.0",
silence some yarn warnings caused by Apollo stuff Test plan: * run `yarn` * you should not see these warnings: warning " > react-apollo@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning "react-apollo > @apollo/react-common@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning "react-apollo > @apollo/react-common@3.0.1" has unmet peer dependency "apollo-utilities@^1.3.2". warning "react-apollo > @apollo/react-components@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning "react-apollo > @apollo/react-components@3.0.1" has unmet peer dependency "apollo-cache@^1.3.2". warning "react-apollo > @apollo/react-components@3.0.1" has unmet peer dependency "apollo-utilities@^1.3.2". warning "react-apollo > @apollo/react-hoc@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning "react-apollo > @apollo/react-hooks@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning " > @apollo/react-testing@3.0.1" has unmet peer dependency "apollo-utilities@^1.3.2". Change-Id: Icd38c4e742b00d3f31fe187b1bc915fd01169880 Reviewed-on: https://gerrit.instructure.com/207064 Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Reviewed-by: Cameron Matheson <cameron@instructure.com>
2019-08-28 04:10:29 +08:00
"apollo-cache": "^1.3.2",
use apollo client instead of apollo boost This prepares us for using apollo's instrospection fragment matcher (which isn't supported with -boost). Test plan: pages that use graphql still work refs GQL-17 Change-Id: Ib6af304855e6c0e23b598344ac1d30f4d4aa03a5 Reviewed-on: https://gerrit.instructure.com/172936 Tested-by: Jenkins Reviewed-by: Carl Kibler <ckibler@instructure.com> QA-Review: Cameron Matheson <cameron@instructure.com> Product-Review: Cameron Matheson <cameron@instructure.com>
2018-11-20 04:17:17 +08:00
"apollo-cache-inmemory": "^1.3.10",
upgrade react-apollo to 3.x.x closes COMMS-2316 TEST PLAN ------------------------------- all tests pass Change-Id: I0c270bb7a8d5dfa166641648841e619a1a21c0f4 Reviewed-on: https://gerrit.instructure.com/206348 Reviewed-by: Matthew Lemon <mlemon@instructure.com> Tested-by: Jenkins QA-Review: Ben Nelson <bnelson@instructure.com> Product-Review: Ben Nelson <bnelson@instructure.com>
2019-08-22 00:54:59 +08:00
"apollo-client": "^2.6.4",
use apollo client instead of apollo boost This prepares us for using apollo's instrospection fragment matcher (which isn't supported with -boost). Test plan: pages that use graphql still work refs GQL-17 Change-Id: Ib6af304855e6c0e23b598344ac1d30f4d4aa03a5 Reviewed-on: https://gerrit.instructure.com/172936 Tested-by: Jenkins Reviewed-by: Carl Kibler <ckibler@instructure.com> QA-Review: Cameron Matheson <cameron@instructure.com> Product-Review: Cameron Matheson <cameron@instructure.com>
2018-11-20 04:17:17 +08:00
"apollo-link": "^1.2.3",
"apollo-link-error": "^1.1.1",
"apollo-link-http": "^1.5.5",
Display multiple modules in A2 student view This also adds support for apollo-link-state. We are using this to move data from the `ENV` into our apollo query results, to keep a single source of truth and easier unit tests. If there are more then two modules that an assignment belongs to (which is abnormal) we are only rendering the first two modules with an additional link to the modules page, indicating that there are more modules this assignment belongs to. Fixes COMMS-1800 Test Plan: - Create an assignment, and add it to four modules - Navigate to the assignment as a student - Notice that 2 of the four modules are displayed in the header Change-Id: I9b797486ba56c8b827e5f76114c5a08d2f969f41 Reviewed-on: https://gerrit.instructure.com/174837 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Landon Gilbert-Bland <lbland@instructure.com> Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
2018-12-11 03:56:24 +08:00
"apollo-link-state": "^0.4.2",
silence some yarn warnings caused by Apollo stuff Test plan: * run `yarn` * you should not see these warnings: warning " > react-apollo@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning "react-apollo > @apollo/react-common@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning "react-apollo > @apollo/react-common@3.0.1" has unmet peer dependency "apollo-utilities@^1.3.2". warning "react-apollo > @apollo/react-components@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning "react-apollo > @apollo/react-components@3.0.1" has unmet peer dependency "apollo-cache@^1.3.2". warning "react-apollo > @apollo/react-components@3.0.1" has unmet peer dependency "apollo-utilities@^1.3.2". warning "react-apollo > @apollo/react-hoc@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning "react-apollo > @apollo/react-hooks@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning " > @apollo/react-testing@3.0.1" has unmet peer dependency "apollo-utilities@^1.3.2". Change-Id: Icd38c4e742b00d3f31fe187b1bc915fd01169880 Reviewed-on: https://gerrit.instructure.com/207064 Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Reviewed-by: Cameron Matheson <cameron@instructure.com>
2019-08-28 04:10:29 +08:00
"apollo-utilities": "^1.3.2",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"axios": "^0.19.0 || ^0.18.0",
Don’t include regenerator-runtime on account settings `axios-cache-adapter`’s “browser” field in package.json says to use A “dist” file that is prebuilt with webpack to handle old browsers (github.com/RasCarlito/axios-cache-adapter/blob/master/dist/cache.js) That means it has a copy of `regenerator-runtime` in it for the async functions it uses. That is wasteful and is bytes that our users shouldn’t need to download. Test plan: * the CSP stuff on the account settings page should work the same * but the webpack js bundle should be smaller Change-Id: I671f2eb60b57c43e002b9a62fd92feb5c96cd00b Reviewed-on: https://gerrit.instructure.com/204252 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-08 03:16:55 +08:00
"axios-cache-adapter": "^2.4.0",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"backbone": "1.1.1",
maintain precision of grades in grade input fixes GRADE-1098 test plan: 1. Create an Assignment a. with Display Grade as Percentage b. worth 9.5 points 2. Open New Gradebook 3. Grade a student on this assignment twice a. once with 55 (interpreted as percentage) b. again with 55% (explicit percentage) 4. Verify grade is 55% 5. Verify score is 5.225 Change-Id: Ie48ec7d5b787e864bfd3379e8dc6a4dbebebc2e5 Reviewed-on: https://gerrit.instructure.com/148848 Tested-by: Jenkins Reviewed-by: Derek Bender <djbender@instructure.com> Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com> QA-Review: Shahbaz Javeed <sjaveed@instructure.com> Product-Review: Matt Goodwin <mattg@instructure.com>
2018-05-02 04:54:56 +08:00
"big.js": "^5.0.3",
Remove remaining dynamic brand css code closes: CNVS-39103 CNVS-39104 CNVS-38650 test plan: * do a general css styling regression pass * make sure that the urls to css files look like /dist/brandable_css/new_styles_normal_contrast/<bundle>-<fingerprint>.css and not: /dist/brandable_css/<big long md5>/new_styles_normal_contrast/<bundle>-<fingerprint>.css * make sure that stylesheets loaded by handlebars templates work eg: go to the calendar page and make sure it is styled correctly * verify that the theme editor works. especially the process when you hit "preivew" and "apply" * set up config/canvas_cdn.yml to use the dev cdn * run `bundle exec canvas:compile_assets && bundle exec rake canvas:cdn:upload_to_s3` * load a page, all the css should load from the cdn * verify the theme editor works when using the cdn too. * also review the changes in the brandable_css npm package: https://github.com/ryankshaw/brandable_css/compare/c6bef...b159d5 Change-Id: I55db41e90f6bc54183a661128f1050445a086d6b Reviewed-on: https://gerrit.instructure.com/120912 Tested-by: Jenkins Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2017-09-26 07:19:15 +08:00
"brandable_css": "0.1.0",
Update canvas_offline_course_viewer for new translations Test plan - Smoke test to ensure dependency pinning hasn't caused any issues Change-Id: I98f2feec9c56f98f530685fa9c94c106d9881c4c Reviewed-on: https://gerrit.instructure.com/122023 Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com> Product-Review: Jon Willesen <jonw+gerrit@instructure.com> Tested-by: Jenkins QA-Review: Nathan Rogowski <nathan@instructure.com>
2017-08-09 03:40:06 +08:00
"canvas_offline_course_viewer": "https://github.com/instructure/canvas_offline_course_viewer.git#1.2.0",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"classnames": "^2.2.5",
"color-slicer": "0.8.0",
add confetti when assignment is submitted refs KNO-265 flag=confetti_for_assignments Moving Steven's POC (https://gerrit.instructure.com/c/canvas-lms/+/224811) to the original assignments implementation. A followup commit will introduce the screenreader text as this commit is already getting large, and there has been a few difficulties on adding that behavior already. test plan: - with confetti_for_assignments flag disabled - turn in a submission for an assignment before the due date - you should be redirected to /courses/:id/assignments/:id - no confetti should display - visit /courses/:id/assignments/:id?confetti=true - no confetti should display - with confetti_for_assignments flag enabled - turn in a submission for an assignment before the due date - you should be redirected to /courses/:id/assignments/:id?confetti=true - confetti should display - turn in a submission for an assignment after the due date - you should be redirected to /courses/:id/assignments/:id - no confetti should display - while confetti is displayed - you should be able to clear by pressing either `space` or `esc` - confetti should clear itself after 3 seconds qa risk: low Change-Id: Ie7743af9e2341eab26fbc3055e90bb0658463018 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/225929 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Johnny Le <jle@instructure.com> Product-Review: Johnny Le <jle@instructure.com> QA-Review: Johnny Le <jle@instructure.com>
2020-02-08 02:22:56 +08:00
"confetti-js": "^0.0.17",
react 16: use createReactClass for things that can’t be es6 classes these components can’t be converted to the react es6 class syntax because they use Mixins which aren’t supported by es6 classes. Change-Id: I8541b08518cd335c7a711bab117efcda65ac6b2c Reviewed-on: https://gerrit.instructure.com/164135 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-09-12 13:29:44 +08:00
"create-react-class": "^15.6.3",
upgrade d3 to latest 3.x version the previous version caused an error when building native dependencies during the yarn install when using node 8. refs CORE-704 test plan: - ensure d3 charts in gradezilla/OutcomeColumnView render correctly - ensure d3 charts in gradebook/OutcomeColumnView render correctly - ensure d3 charts in grade_summary/OutcomeLineGraphView render correctly - ensure d3 charts in client_apps/canvas_quizzes render correctly - yarn install runs without errors using latest node 8 lts Change-Id: Ib2f8d4acab6060795b50e545eb64f324587b6300 Reviewed-on: https://gerrit.instructure.com/134476 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Leo Abner <rabner@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2017-12-04 23:24:41 +08:00
"d3": "3.5.17",
Handle dependent variables in the theme editor After the theme editor refactor dependant variables were not working. This fixes it. This also makes it so that override files are handled properly. closes CORE-1085 Test Plan: - Go to the theme editor with a new theme - Change the "Primary Brand Color" - "Primary Button" should change as well - Preview the changes - Change should be reflected after the preview loads - Repeat that again, the same behavior should occur. - Change the "Primary Button" color and preview - The two items should now be "unlinked" and they change independent of one another - Upload a js override - Preview changes - Upload a css override - Preview changes - Both the js and the css fields should be populated Change-Id: I61572a3c5bdf4f63c82078dff492dc504d0af7bf Reviewed-on: https://gerrit.instructure.com/142395 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-03-02 07:12:40 +08:00
"formdata-polyfill": "^3.0.9",
Fix calendar event cutoff for specific time ranges The actual fix was applied to the fullcalendar package we are using. This just bumps our local version to apply the fix in canvas-lms. The fix in fullcalendar can be seen here: https://github.com/instructure/fullcalendar/pull/1/files fixes COMMS-268 Test Plan: - Navigate to the calendar - Create a new 50 minute even (ie, from 8:00 to 8:50) with a title - Switch the calendar to week view - Notice that the bottom half of the title is not cut off Change-Id: I084e085d7a97039df7729870271a8691e010e4ba Reviewed-on: https://gerrit.instructure.com/137608 Reviewed-by: Ryan Shaw <ryan@instructure.com> Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Venk Natarajan <vnatarajan@instructure.com> Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
2018-01-12 00:59:21 +08:00
"fullcalendar": "https://github.com/instructure/fullcalendar.git#1108dd1c991a029ec6fd7de3337737ec5295ba97",
upgrade graphiql Test plan: graphiql works flag = none Change-Id: Ia8bd7100024cab45746a27f370d5423e6c5fa9e6 Reviewed-on: https://gerrit.instructure.com/206853 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-27 06:36:31 +08:00
"graphiql": "^0.14.2",
upgrade graphiql-explorer Change-Id: Ie853ea9bbf0dbdbf58b0f0e572ff129ec6922577 Reviewed-on: https://gerrit.instructure.com/196594 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> QA-Review: Rob Orton <rob@instructure.com> Product-Review: Rob Orton <rob@instructure.com>
2019-06-05 05:11:11 +08:00
"graphiql-explorer": "^0.4.2",
Add graphiql-explorer to canvas' graphiql instance The graphiql-explorer makes it easy to explore the schema and build queries simply by checking the boxes next to fields from the schema test plan: - /graphiql still works as expected, but includes the explorer panel - canvas features that leverage graphql still work as expected (since the version of the graphql js client was updated) Change-Id: Ief625c6fb59e4e32e23a177f3b566aae271ab108 Reviewed-on: https://gerrit.instructure.com/181586 Tested-by: Jenkins Reviewed-by: Carl Kibler <ckibler@instructure.com> QA-Review: Carl Kibler <ckibler@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2019-02-13 23:29:15 +08:00
"graphql": "^14",
upgrade to apollo 2.1 closes RECNVS-377 Test plan: make sure student context cards work Change-Id: Ib306e0be5d51f68afad0ff112bf745d9e0ad1d5b Reviewed-on: https://gerrit.instructure.com/145501 Tested-by: Jenkins Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com> QA-Review: Collin Parrish <cparrish@instructure.com> Product-Review: Cameron Matheson <cameron@instructure.com>
2018-03-27 01:32:21 +08:00
"graphql-tag": "^2.8.0",
Get i18n-js and i18nliner from npm, not vendor closes: CORE-1201 test plan: * the qunit & selenium tests that we have around this should still pass (except for that one that had to be changed because the spec was actually expecting the wrong thing and the old code was erroneous) * load the app in fully production build and make sure translations still work Change-Id: Id06c38f60c1670fb93e85d5479ec747035c1158b Reviewed-on: https://gerrit.instructure.com/143456 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-03-14 04:10:14 +08:00
"i18n-js": "^3",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"ic-ajax": "~2.0.1",
"ic-tabs": "0.1.3",
upgrade immer and immutability-helper npm deps here are 2->3 changes from immutability-helper Huge thanks to @jedmao for converting the library to typescript! New: TypeScript definitions are now generated from TypeScript source. meaning they will always be 100% in sync w/ the source code. New: exported Context class. Deprecated: stop using const myUpdate = newContext().update and start using const myContext = new Context(); myContext.update(...). Deprecated: stop using update.extend and start using import { extend } from 'immutability-helper' or const { extend } = new Context(). test plan: * the only thing that uses immer is the assignments_2 teacher stuff, that should still work * discussions, gradingPeriods, and the CreateOrUpdateUserModal use immutability-helper, those should still all work Change-Id: If6b62788be5d3929b5a0ddd64e1b63aa09916b84 Reviewed-on: https://gerrit.instructure.com/205773 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-20 08:55:20 +08:00
"immer": "^3",
"immutability-helper": "^3",
Configurable proficiency ratings page closes OUT-1856, OUT-1858, OUT-2239, OUT-2148 This adds configurable proficiency ratings on the account rubrics page. Persisting these changes will occur in a future patchset (2252). Validating order will be in a separate patchset (2240). test plan: - with the "non-scoring rubrics" feature flag off, the account rubrics page should appear without the proficiency ratings tab - with the "non-scoring rubrics" feature flag on, the accounts rubrics page should appear with the proficiency tab, if visiting with an account with "manage_outcomes" permission (e.g. account admin) - create an account role that has "Create and edit assessing rubrics" permission enabled but "Manage learning outcomes" disabled by going to the account page, click on the "Permissions" link in the left menu, then select the "Account Roles" tab to then be able create the role and enable the permission above. - create an account user by going to the account page and then click on the "People" link in the left menu to then be able to click on "+ New User". you'll use the email address entered in the next step. - make that user an account admin by going to the account page, click on the "Settings" link in the left menu, then select the "Admins" tab, then click on "+ Account Admins". select the new role from the drop down menu and enter the email address you used in the preivous step - confirm with the feature flag enabled, that visiting the account rubrics page does not appear with the proficiency tab, if visiting with an account without "manage_outcomes" permission (e.g. masquerade as the user created above) - on the proficiency tab, test error handling: * description is required * points is required, should be a valid number * when saving changes, all fields with errors should be labelled with an error text, with the first field receiving focus Change-Id: Ic52ef9fe9c58cfb215216b3a505ef1fb4b851c68 Reviewed-on: https://gerrit.instructure.com/150841 Reviewed-by: Michael Brewer-Davis <mbd@instructure.com> Reviewed-by: Frank Murphy <fmurphy@instructure.com> Tested-by: Jenkins QA-Review: Dariusz Dzien <ddzien@instructure.com> Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-04-10 09:20:00 +08:00
"immutable": "^3.8.2",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"is-valid-domain": "^0.0.11",
Point to instructure forks Closes: CCI-351 flag = none Test Plan: - no behavioral changes - build passes Change-Id: I2e6bfa46b56ee2b59b8289fc90ef9c319757fc34 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/235566 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: James Butters <jbutters@instructure.com> Reviewed-by: Jacob Powell <spowell@instructure.com> QA-Review: James Butters <jbutters@instructure.com> QA-Review: Jacob Powell <spowell@instructure.com> Product-Review: James Butters <jbutters@instructure.com>
2020-04-29 05:19:29 +08:00
"jquery": "https://github.com/instructure/jquery.git#1.7.2-with-AMD-and-CommonJS",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"jquery-getscrollbarwidth": "^1.0.0",
"jquery-ui-touch-punch": "^0.2.3",
"jquery.cookie": "^1.4.1",
Update yarn/npm dependencies this will make it so we can use karma with the latest node. once the commit to upgrade d3 is merged, that was the only other thing we needed to do to have everything working on node 8. Change-Id: I820b27ee3da38818b69554c6e409a2177370ca34 Reviewed-on: https://gerrit.instructure.com/136752 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-01-03 06:24:44 +08:00
"jquery.elastic": "1.0.0",
get window.location.orgin polyfill from npm …instead of the copy-pasta’ed one in our repo Test plan: Make sure the files search results page works in ie11 Change-Id: I61433363eda53d44b897bf1f88837cef7c239f87 Reviewed-on: https://gerrit.instructure.com/135141 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-09 08:32:58 +08:00
"location-origin": "^1.1.4",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"lodash": "^4.16.4",
"md5": "^2.2.1",
Upgrade mediaelement to latest master of our fork Fixes: CORE-1091 show controls when they receive focus (#39) if controls are visibly hidden, they should still be tabbable for accessibility, and when they get keyboard-focused, they should become visible again. See: https://github.com/instructure/mediaelement/commit/0402b2b76 Change-Id: Ic655d43a64d111662f8d7368f21032664a8aee74 Reviewed-on: https://gerrit.instructure.com/142693 Tested-by: Jenkins Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-03-07 00:03:37 +08:00
"mediaelement": "https://github.com/instructure/mediaelement.git#master",
Pass correct locale to Planner Sometimes ENV.LOCALE and ENV.MOMENT_LOCALE are different (zh-Hans v zh-cn or mi v mi-nz). We were passing the former to planner, but moment needs the full locale, including language and region identifiers, and formatMessage copes with the full locale just fine, so we really need to pass in the latter or moment eventually blows up. So mi-nz month names would successfully parse, had to both bump our version of moment and tweak the canvas customized mi-nz locale data. to test, you'll have to run yarn to update moment, then build with RAILS_LOAD_ALL_LOCALES=1 yarn build Note on the changes to timezoneSpec.js: - some of the specs were parsing dates like "Mon, Aug 3", which are being interpreted in the current year, when Aut 3 is not a Monday. Resolved this by using MockDate to pretend today is 2/1/2015 - moment does not always interpret the Chinese characters for evening as implying PM. I'm assuming canvas will never need that particular construct and commented out the failing string. - there's one date-time that's getting the date totally wrong. - Fixed grammatically incorrect instances of '8月 3, 2015' to ''8月 3日, 2015' - fix cases where the year is coming after the month and day, which would never really happen fixes ADMIN-1331 test plan: - have a student in course so planner is enabled. - go to /profile/settings and Edit - change the Language to Reo Māori (Aotearoa) and "Update Settings" - go to the planner dashboard - click on + to create a new todo > expect you can create a todo. If you want, you can repeat with any of the languages listed in the ticket just to prove ^that wasn't a fluke. Change-Id: I9ba069ef61529088ab92271d7857998df6bbc409 Reviewed-on: https://gerrit.instructure.com/161206 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> Reviewed-by: Mysti Sadler <mysti@instructure.com> Reviewed-by: Jeremy Stanley <jeremy@instructure.com> QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2018-08-18 03:21:04 +08:00
"moment": "^2.10.6",
Change inbox avatar to use inst-ui Test Plan: -inspect avatar on inbox message is rendered from inst-ui fixes VICE-17 flag=none Change-Id: I92941e079b63a3a60468e1e894059c20e15b1251 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/241435 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com> QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com> Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
2020-06-30 02:23:26 +08:00
"nanoid": "^3.1.10",
Backport instUI fix to allow themeable w/ `class`es We made this change in @instructure/ui-themeable in g/203714 but that is for the current master on instUI 6, we need it now even though we are still on instUI 5 so this will back port it in so we can use it now. Test plan: * Things that use `themeable` should work both with and without the “Drop ie11” commit applied. Specifically: bin/rspec ./spec/selenium/dashboard/planner/student_planner_assignments_spec.rb:88 Should not fail with TypeError: Class constructor Yr cannot be invoked without 'new' Change-Id: I7ef8ef9eda1057badabbb08fcdd6875ad8064e89 Reviewed-on: https://gerrit.instructure.com/203950 Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-06 06:43:39 +08:00
"newless": "^0.3.0",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"normalize-scroll-left": "^0.2",
files: turn off page.js click handler because it prevents preventDefault on file links (sometimes) then use it explicitly where we need it, on the left/right preview buttons test plan: - go to user files (/files) - have multiple image files in a folder - reload the page, then click an image file - it should preview, not download - clicking the left/right arrows at the side of the preview window should go to the previous/next image without reloading the page fixes ADMIN-2923 Change-Id: Ib97d25d51e7c94fb962e5d24d3c763554e7fcdd4 Reviewed-on: https://gerrit.instructure.com/212876 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Carl Kibler <ckibler@instructure.com> Product-Review: Jeremy Stanley <jeremy@instructure.com>
2019-10-11 22:32:01 +08:00
"page": "^1.11",
update parse-decimal-number to 1.0.0 A hack can be removed for parsing numbers now that 1.0.0 incorporates the needed behavior. test plan: * verify Jenkins passes Change-Id: Ifaea8fd348f4f804e9a6042fb392c699badeea6e Reviewed-on: https://gerrit.instructure.com/138046 Tested-by: Jenkins Reviewed-by: Derek Bender <djbender@instructure.com> Reviewed-by: Ryan Shaw <ryan@instructure.com> Product-Review: Jeremy Neander <jneander@instructure.com> QA-Review: Jeremy Neander <jneander@instructure.com>
2018-01-17 00:52:42 +08:00
"parse-decimal-number": "1.0.0",
Put parse-link-header back in package.json …since we use it in our code It used to be there, but somehow someone deleted it on accident Change-Id: Id516fdb8507887ffed9450869654fc42a4afc415 Reviewed-on: https://gerrit.instructure.com/151898 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-31 02:03:31 +08:00
"parse-link-header": "^1",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"prop-types": "^15",
update qs dependency test plan: * Verify Jenkins passes? Change-Id: If472d2f898e4241d0d10dfd7f1ca5094ecf9d811 Reviewed-on: https://gerrit.instructure.com/184039 Tested-by: Jenkins Reviewed-by: KC Naegle <knaegle@instructure.com> Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Jeremy Neander <jneander@instructure.com>
2019-03-07 00:43:35 +08:00
"qs": "^6.6.0",
upgrade React to 16.9.0 note: this will start logging a lot of deprecation warnings from React about stuff like componentWillMount and componentWillReceiveProps. Teams should update their code to not use those things so those Deprecations go away Test plan: * automated builds should pass Change-Id: I42a340dacdb43d410c7246945c025e0eb83220fa Reviewed-on: https://gerrit.instructure.com/205772 Reviewed-by: Ryan Norton <rnorton@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-20 08:53:24 +08:00
"react": "^16.9.0",
upgrade react-apollo to 3.x.x closes COMMS-2316 TEST PLAN ------------------------------- all tests pass Change-Id: I0c270bb7a8d5dfa166641648841e619a1a21c0f4 Reviewed-on: https://gerrit.instructure.com/206348 Reviewed-by: Matthew Lemon <mlemon@instructure.com> Tested-by: Jenkins QA-Review: Ben Nelson <bnelson@instructure.com> Product-Review: Ben Nelson <bnelson@instructure.com>
2019-08-22 00:54:59 +08:00
"react-apollo": "^3.0.1",
Upgrade react-dnd so it works w/ react 16 Closes: CORE-1871 The react-dnd commit that first added react 16 to its peerDeps (https://github.com/react-dnd/react-dnd/commit/c6123fad317) First appeared in v2.5.2 so we need at least that version If we are going to use react 16 Test plan: * dashboard card and discussion reordering should still work like they always have Change-Id: I74b47949f3d0f7084c350d24a8de41139f535732 Reviewed-on: https://gerrit.instructure.com/164071 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-09-12 05:22:47 +08:00
"react-dnd": "^2.5.2",
"react-dnd-html5-backend": "^2.5.2",
upgrade React to 16.9.0 note: this will start logging a lot of deprecation warnings from React about stuff like componentWillMount and componentWillReceiveProps. Teams should update their code to not use those things so those Deprecations go away Test plan: * automated builds should pass Change-Id: I42a340dacdb43d410c7246945c025e0eb83220fa Reviewed-on: https://gerrit.instructure.com/205772 Reviewed-by: Ryan Norton <rnorton@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-20 08:53:24 +08:00
"react-dom": "^16.9.0",
fix expand/contract all buttons in new sLMGB closes OUT-2232 Test plan: - enable non-scoring rubrics - load student LMGB with multiple outcome groups, outcomes, and outcome results - verify that expanding and contracting the groups and outcomes works as expected - verify that after contracting a group and then re-expanding, the outcomes within the group are contracted - verify that the expand all and contract all buttons at the top of the page are enabled and disabled at the appropriate times - expand all: should be enabled when any element is contracted - contract all: should be enabled when any element is expanded - verify that the expand all/contract all buttons work as expected Change-Id: Ifbe02e900459faed8d411afb2bb9410a885a2237 Reviewed-on: https://gerrit.instructure.com/152103 Tested-by: Jenkins Reviewed-by: Matt Berns <mberns@instructure.com> Reviewed-by: Frank Murphy <fmurphy@instructure.com> QA-Review: Dariusz Dzien <ddzien@instructure.com> Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-06-01 05:13:10 +08:00
"react-immutable-proptypes": "^2.1.0",
Developer key scopes UI (functioning skeleton) Closes PLAT-3314 Test Plan - Enable new developer key FFs - Navigate to the developer keys page of an account - Verify all scope groups are rendered in the new scopes list component. - Verify the filter allows filtering by scope group name. - Verify the "Read Only GET" checkbox causes all scopes that use GET to be checked. - Go crazy testing checkboxes and make sure they all work logically (i.e. selecting the group level checkbox checks all scopes in the group). - Verify that each group shows a list of methods for all selected scopes. - Verify you can still create developer keys in root accounts and site admin. Change-Id: I5df402ca06740e8a1ff37c21b63d2d6d58720182 Reviewed-on: https://gerrit.instructure.com/149242 Reviewed-by: Marc Alan Phillips <mphillips@instructure.com> Tested-by: Jenkins QA-Review: August Thornton <august@instructure.com> Product-Review: Jesse Poulos <jpoulos@instructure.com>
2018-04-27 04:24:36 +08:00
"react-lazy-load": "^3.0.13",
Upgrade react-modal so it works with react 16 I know I said that the way forward was to just not use react-modal and use instUI modal instead but there are a bunch of things that _are_ Using it and I don’t want changing all those to be blockers for react16 if this will work. I still want us to get rid of react-modal, just don’t want it to be a blocker for react 16 Test plan: Things that use react-modal should still work the same as before. Check: * the color picker used on the calendar sidebar * the external apps stuff that has modals * the file preview modal in files * the “find appointment” modal in scheduler Change-Id: I606eda110782cd3300fcbb2f8052681fa5048050 Reviewed-on: https://gerrit.instructure.com/164232 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-09-13 03:05:43 +08:00
"react-modal": "^3",
Update react-redux to 5.1.1 test plan: - automated tests pass Change-Id: I6c1034ec8f443d10d39b5b551c1b7207e5191411 Reviewed-on: https://gerrit.instructure.com/173814 Tested-by: Jenkins Product-Review: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com>
2018-11-30 08:54:31 +08:00
"react-redux": "^5.1.1",
modernize canvas_quizzes fixes FOO-1409 flag = none no more client_apps, canvas_quizzes now lives as part of canvas-lms proper inside app/jsx/, which makes the build leaner and leaves us with one less thing to reason about logical changes: - converted from AMD to ES modules - upgraded to recent react + react-router - dropped RSVP in favor of native Promises - used CanvasModal instead of home-grown Dialog - removed dead code; notifications in particular were fishy as there had no dependents at all and did not even show up in the graph - ported tests to Jest, added more unit ones and two integration ones - removed "config.onError" and now throws errors where appropriate - disabled console statements in non-dev :: test plan :: - create a (old-school) quiz containing all types of questions - as 3 distinct students, take the quiz and try to randomize your answers at this point it's helpful to have a reference to compare the screens; I replicated the quiz on my production sandbox for this - go to /courses/:id/quizzes/:id/submissions/:id/log - verify it looks OK - click on a specific question in the stream and verify the question inspector widget works OK - go back to stream and push "View table" - verify the table and its controls are OK - go to /courses/:id/quizzes/:id/statistics - verify it looks OK - click on ? in the discrimination index chart and verify it displays a dialog with help content - click on "X respondents" in one of the charts and verify it displays a dialog with the respondent names - verify the interactive charts do interact as expected (no logic changed here so just a quick glance) - link to "View in SpeedGrader" for essay-like questions works Change-Id: I79af5ff4f1479503b5e2528b613255dde5bc45d3 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256118 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com> Product-Review: Simon Williams <simon@instructure.com>
2021-01-02 07:58:12 +08:00
"react-router-dom": "^5.2.0",
upgrade react-token-input so it supports react 16 closes: CORE-1885 Test plan: * make sure the token input that appears when you edit assignment due date Overrides on the assignment overrides page still works Like it did before. Here’s it’s original test plan: new due dates selection UI - on assignments, quizzes & discussions pages - with DA on and off - assign various due dates/(un)lock dates to source sections, individuals, and everybody - these should create overrides that properly take students/sections and dates - validations should work for all dates as normal and not let empty overrides get created (with no students or sections) - the names of overrides should properly update as students change - as more overrides get created, saving assignments should not slow down significantly - the student/section selector should be intuitive * the “new grading period set” form should work as it did before. Here’s it’s original test plan: A new button "+ Add Grading Period Set" is on the Grading Period Sets page. This allows a new set to be named and associated with as many terms as needed. To begin, visit the Grading page for an account (e.g. /accounts/1/grading_standards) and click "+ Set of Grading Period" and within this form ensure the following: 1. Given no name in the "Set name" field, when clicking the "Create" button a flash message is displayed and the set is not saved 2. Given no enrollment terms in the "Attach terms", when clicking the "Create" button a flash message is displayed and the set is not saved 3. Given a name and at least one attached enrollment term, when clicking the "Create" button an AJAX call successfully persists to the database and the new set is displayed on the page along with a successful flash message 4. When the form is open, the "+ Set of Grading Periods" button is disabled 5. When the form is in the process of creating a new set, the "Create" and "Cancel" button is disabled 6. Clicking close at any other time closes the form and re-enables the "+ Set of Grading Periods" button and all data in the form is cleared Change-Id: Ibb0290202b5dcf00ec42a4bb6d1c3d2e3d7a3b2b Reviewed-on: https://gerrit.instructure.com/164492 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-09-14 23:20:08 +08:00
"react-tokeninput": "^2.5.0",
bump npm-run-all version Change-Id: Ieae7ac480124e52050c79ca83c99a7fe698c48d5 Reviewed-on: https://gerrit.instructure.com/173262 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Gary Mei <gmei@instructure.com> Product-Review: Gary Mei <gmei@instructure.com>
2018-11-27 02:20:33 +08:00
"react-transition-group": "^1",
Update redux to 4.0.1 test plan: - automated tests pass Change-Id: I00260366f32e0407eaf4277b5b2d26d9896915ac Reviewed-on: https://gerrit.instructure.com/173813 Tested-by: Jenkins Product-Review: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com>
2018-11-30 08:52:22 +08:00
"redux": "^4.0.1",
Update redux-actions to 2.6.4 test plan: - automated tests pass Change-Id: I82969f661e78370c8a2f9035c2bca7d2397fb377 Reviewed-on: https://gerrit.instructure.com/173815 Tested-by: Jenkins Product-Review: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com>
2018-11-30 08:57:55 +08:00
"redux-actions": "^2.6.4",
Update redux-thunk to 2.3.0 test plan: - automated tests pass Change-Id: I3417cc46a9581dd4fe72fc96f8c8e995b90303fd Reviewed-on: https://gerrit.instructure.com/173816 Tested-by: Jenkins Product-Review: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com>
2018-11-30 09:00:13 +08:00
"redux-thunk": "^2.3.0",
direct share user selection modal closes ADMIN-2839 flag=direct_share test plan: - as a user with course management permissions (such as a teacher) go to the discussions index page and select "Send To..." from a discussion's kabob menu. - this should open a modal where you can search for and select other course users who have course management permissions. - clicking on the "Send" button only does a console log at the moment. Change-Id: I67f823d0820283fd90e2aa6e3ae3ea5fe54d9b3d Reviewed-on: https://gerrit.instructure.com/205967 Tested-by: Jenkins Reviewed-by: Carl Kibler <ckibler@instructure.com> QA-Review: Carl Kibler <ckibler@instructure.com> Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
2019-08-21 07:12:19 +08:00
"shallow-equal": "^1.2.0",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"spin.js": "2.3.2",
"swfobject": "^2.2.1",
"tablesorter": "^2.28.5",
update timezone library for brazil dst change temporarily using a fork of bigeasy/timezone since it does not build with the latest releases of eggert/tz fixes COREFE-308 test plan: - set user timezone to brazilia - create an assignment with a due date after 2019-11-03 - save the assignment - the time should not be off by an hour on the details page Change-Id: I7a15e92def90a5d83f8be079657a58894bd13822 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/215065 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-10-29 23:36:16 +08:00
"timezone": "https://registry.npmjs.org/@brentburgoyne/timezone/-/timezone-1.0.24.tgz",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"tinycolor2": "1.4.1",
Use native es modules for tinymce-a11y-checker Change-Id: Ia17a47e50711abca1b6ca154995bfa2f6e5b1eb8 Reviewed-on: https://gerrit.instructure.com/208604 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-09-07 12:35:49 +08:00
"tinymce-a11y-checker": "3.0.0-rc2",
basic direct share course selection tray Note: There appears to be an issue with VoiceOver not announcing the aria live updates. Going to ignore this for now and see if it is still a problem when InstUI 6 lands. Another ticket will be created to check and fix. refs ADMIN-2811 flag=direct_share test plan: - should be able to search by name for courses you manage in the direct share course selection tray. - copy button disabled until you select a course - after selecting a course, the copy button just logs to the console - cancel button closes the tray - generally accessible, except for VO reading alerts. - could check the flash_screenreader_holder div in the inspector if you want to watch the DOM changes that should trigger the alert. Change-Id: I5c102b25d277204a9929f780adbe94b9d3e46bcb Reviewed-on: https://gerrit.instructure.com/205371 Tested-by: Jenkins QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Jon Willesen <jonw+gerrit@instructure.com> Reviewed-by: Carl Kibler <ckibler@instructure.com>
2019-08-16 04:39:59 +08:00
"use-debounce": "^3",
Add use-media-set responsive React hook to package.json Refs USERS-549 flag=none This will be used in places where responsive components may have performance issues due to complexity. Test plan: * build passes Change-Id: Icce432352b5eb5118fc258b7c2f0e3c730eaae86 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/236255 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Pat Renner <prenner@instructure.com> Reviewed-by: Augusto Callejas <acallejas@instructure.com> QA-Review: Charley Kline <ckline@instructure.com> Product-Review: Charley Kline <ckline@instructure.com>
2020-04-30 23:40:56 +08:00
"use-media-set": "^1.1",
Configurable proficiency ratings page closes OUT-1856, OUT-1858, OUT-2239, OUT-2148 This adds configurable proficiency ratings on the account rubrics page. Persisting these changes will occur in a future patchset (2252). Validating order will be in a separate patchset (2240). test plan: - with the "non-scoring rubrics" feature flag off, the account rubrics page should appear without the proficiency ratings tab - with the "non-scoring rubrics" feature flag on, the accounts rubrics page should appear with the proficiency tab, if visiting with an account with "manage_outcomes" permission (e.g. account admin) - create an account role that has "Create and edit assessing rubrics" permission enabled but "Manage learning outcomes" disabled by going to the account page, click on the "Permissions" link in the left menu, then select the "Account Roles" tab to then be able create the role and enable the permission above. - create an account user by going to the account page and then click on the "People" link in the left menu to then be able to click on "+ New User". you'll use the email address entered in the next step. - make that user an account admin by going to the account page, click on the "Settings" link in the left menu, then select the "Admins" tab, then click on "+ Account Admins". select the new role from the drop down menu and enter the email address you used in the preivous step - confirm with the feature flag enabled, that visiting the account rubrics page does not appear with the proficiency tab, if visiting with an account without "manage_outcomes" permission (e.g. masquerade as the user created above) - on the proficiency tab, test error handling: * description is required * points is required, should be a valid number * when saving changes, all fields with errors should be labelled with an error text, with the first field receiving focus Change-Id: Ic52ef9fe9c58cfb215216b3a505ef1fb4b851c68 Reviewed-on: https://gerrit.instructure.com/150841 Reviewed-by: Michael Brewer-Davis <mbd@instructure.com> Reviewed-by: Frank Murphy <fmurphy@instructure.com> Tested-by: Jenkins QA-Review: Dariusz Dzien <ddzien@instructure.com> Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-04-10 09:20:00 +08:00
"uuid": "^3.2.1"
move napa from "devDependencies" to "dependencies" Change-Id: I4dde9458868cd5c1c41b921414dff4b3dc9371de Reviewed-on: https://gerrit.instructure.com/29878 Reviewed-by: Simon Williams <simon@instructure.com> Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> Tested-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
2014-02-11 02:29:11 +08:00
},
AMD Conversion "Trivial" JavaScript / CoffeeScript changes -------------------------------------------------- For the most part, all javascript was simply wrapped in `require` or `define`. The dependencies were found with a script that matched regexes in the files, it errs on the side of listing too many dependencies, so its worth double checking each file's dependencies (over time, anyway). i18n API changes -------------------------------------------------- No longer have to do I18n.scoped calls, just list i18n as a dependency with the scope and it's imported already scoped require ['i18n!some_scope'], (I18n) -> I18n.t 'im_scoped', 'I'm scoped!' JS bundling now done with r.js, not Jammit -------------------------------------------------- We don't use jammit to bundle JS anymore. Simply list dependencies for your JS modules in the file and RequireJS handles the rest. To optimize the JavaScript, first make sure you have node.js 0.4.12+ installed and then run: $ rake js:build The app defaults to the optimized build in production. You can use non-optimized in production by putting ?debug_assets=true in the url just like before. You can also test the optimized JavaScript in development with ?optimized_js=true. Significant changes -------------------------------------------------- These files have "real" changes to them (unlike the JavaScript that is simply wrapped in require and define). Worth taking a really close look at: - app/helpers/application_helper.rb - app/views/layouts/application.html.erb - config/assets.yml - config/build.js - lib/handlebars/handlebars.rb - lib/i18n_extraction/js_extractor.rb - lib/tasks/canvas.rake - lib/tasks/i18n.rake - lib/tasks/js.rake Change-Id: I4bc5ecb1231f331aaded0fef2bcc1f3a9fe482a7 Reviewed-on: https://gerrit.instructure.com/6986 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Ryan Florence <ryanf@instructure.com>
2011-11-11 00:31:45 +08:00
"devDependencies": {
upgrade react-apollo to 3.x.x closes COMMS-2316 TEST PLAN ------------------------------- all tests pass Change-Id: I0c270bb7a8d5dfa166641648841e619a1a21c0f4 Reviewed-on: https://gerrit.instructure.com/206348 Reviewed-by: Matthew Lemon <mlemon@instructure.com> Tested-by: Jenkins QA-Review: Ben Nelson <bnelson@instructure.com> Product-Review: Ben Nelson <bnelson@instructure.com>
2019-08-22 00:54:59 +08:00
"@apollo/react-testing": "^3.0.1",
Upgrade to babel 7 & allow any js file to be themeable closes: CORE-2699 CORE-2700 UIDEV-99 This commit gets canvas-lms itself upgraded to babel 7. To do that we also had to upgrade jest to v24. We had already got canvas-rce and canvas-planner on jest24/babel7 but now this gets everything to babel 7. so you will see a lot of things removed from yarn.lock since we don’t don’t have to have different versions of everything for babel and jest The other major thing this does is make it so any JS file in canvas can become an @instructure/ui-themeable themeable component. This means you no longer should have to put your css in app/stylesheets for any new react components that you are writing. Test plan: 1. Make sure that the perf of `yarn build:js` is on-par with what it was before. We pass everything through the themeable babel transform now so there is a chance it is slower. If it is majorly slower, we’ll have to figure something out. 2. run a production weback build. The common (or any bundle for that matter should get output exactly the same as it did before) things to manually qa check: * in a NODE_ENV=production enviornment, go to /accounts/site_admin/developer_keys * click the "+ Developer Key" button, it should open the modal. (there are selenium tests that do this, but it was one thing that had to be fixed to get jenkins to pass) * on a course that is set up as a master course, click on the thing that opens the blueprint courses tray. * verify that when you click "Associations" and "Sync History" links in that tray, that they dynamically load the webpack chunk for the modal contents for that thing and then the modal is shown (again, there are selenium specs that test that exact thing but it is always good to manually test it too) Change-Id: I802584228962b54480a500f8fe422f45c2dcac4c Reviewed-on: https://gerrit.instructure.com/183965 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 05:20:27 +08:00
"@babel/cli": "^7.0.0",
"@babel/core": "^7.0.0",
Now that i18nliner can understand it, turn back on fragments The previous commit makes it so i18nliner can understand <> instead of <React.Fragment>, so this turns back on the eslint rule we had to turn Off Test plan: * run bin/rake i18n:generate_js (or let the Jenkins builds run) * it should pass Change-Id: Ia3204cd6c3147eb52ca612adbb3b20b2df8c6921 Reviewed-on: https://gerrit.instructure.com/205378 Tested-by: Jenkins Reviewed-by: Ed Schiebel <eschiebel@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-16 05:46:07 +08:00
"@babel/parser": "^7",
Add support for javascript optional chaining Per https://github.com/tc39/proposal-optional-chaining Test Plan: - Jenkins passes flag = none Change-Id: I7b9fde7e91a9bd00a85397bcf791b8eccd528a5b Reviewed-on: https://gerrit.instructure.com/209826 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com> Product-Review: Steven Burnett <sburnett@instructure.com>
2019-09-17 23:38:44 +08:00
"@babel/plugin-proposal-optional-chaining": "^7",
Enable outcome alignment on Canvas pages closes OUT-3401 flag = none test plan: - check out/update canvas plugins needed for sharding: * multiple_root_accounts * demo_site * canvas_geoip - check out/update canvas plugin needed for provisioning: * uuid_provisioner - check out/update quiz repo: * quiz_api - check out/update outcomes service: * outcomes-service - add the following to the postgres container section of your docker-compose.override.yml in canvas: === ports: - "5432:5432" environment: VIRTUAL_HOST: db.canvas.docker === - update canvas configuration by adding example dynamic_settings to existing config/dynamic_settings.yml and by copying example uuid_provisioner.yml - in canvas rails console, enable the auto provision setting: > Setting.set('auto_provision_outcomes_service', 'true') - start up canvas, outcomes-service and quiz_api - create a new root account from canvas siteadmin http://canvas.docker/accounts/site_admin/root_accounts: * account name: outcomes * account domain: outcomes.canvas.docker - after a few minutes, verify in the outcomes rails console that a new shard has been created and registered for the second account, but not the first > ap AccountRegistry.all - create a course with outcomes in outcomes.canvas.docker - in the outcomes api docker container, dump canvas data and sync into the provisioned outcomes shard: > bundle exec rake canvas:dump_canvas_data[outcomes.outcomes.docker] > bundle exec rake canvas:sync[outcomes.outcomes.docker,true] - enable the outcome alignment feature flag: - http://canvas.docker/accounts/site_admin/settings - Feature Options tab - Find "Outcome alignment to non-scoring content" feature flag - Switch to "ON" - return to course created in new canvas account - create a canvas page in the course - load the newly created canvas page - confirm that an outcome alignment widget appears, and that it opens a side tray with course outcomes when attempting to align Change-Id: Ide6891493ea3c926d155d4aea9bc7aff5bdaa6fb Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/227463 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Michael Brewer-Davis <mbd@instructure.com> Reviewed-by: Pat Renner <prenner@instructure.com> QA-Review: Michael Brewer-Davis <mbd@instructure.com> Product-Review: Michael Brewer-Davis <mbd@instructure.com>
2020-02-21 07:38:23 +08:00
"@babel/plugin-transform-react-inline-elements": "^7.2.0",
rename canvas-supported-browsers to browserslist-config-canvas-lms this is to get it to work with how browserslist/autoprefixer/babel/ @instructure/ui-babel-preset expect things to work. We had to change the name because https://github.com/browserslist/browserslist#shareable-configs Says: For security reasons, external configuration only supports packages that have the browserslist-config- prefix. npm scoped packages are also supported, by naming or prefixing the module with @scope/browserslist-config, such as @scope/browserslist-config or @scope/browserslist-config-mycompany And we have to add: "browserslist": ["extends @instructure/browserslist-config-canvas-lms"], to all of our package.jsons that use @instructure/ui-babel-preset because that by default will use "extends @instructure/browserslist-config-instructure—ui" which would still do all the stuff for IE11 Test plan: * run `yarn` * all those errors about browserslist and postcss should not show uo * look at the code in public/dist for canvas-planner, * It should not include regenerator-runtime and you should see native `async` functions Change-Id: Ic84c13ac59d58963c12b8365b3068b5da3ee618d Reviewed-on: https://gerrit.instructure.com/204251 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-08 03:10:17 +08:00
"@instructure/browserslist-config-canvas-lms": ">=2",
fix audio player and video player sizing closes LA-729 flag=rce_enhancements The original intent for the audio player was to size it so the buttons just fit. This ignored the fact that it's rendered w/in an iframe, so popup menus are clipped. This change sizes the player to leave room for those popups. While the ticket was written against the audio player, the same issues may occur in the video player, either for portrait videos or videos < 400px wide when closed captions are present. The original code for sizing the video player shrank the width to fit thea video's size, which clipped the buttons. This change sets a minimum width for the player and letter-boxes the video. test plan: - in the new rce - add an audio file > expect it to be wide enough to show all the buttons and tall enough for the speed and volume popups - add a vertical video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - Submit to upload > expect the player to be wide enough to show all the buttons - click the fullscreen button > expect the video to be the height of the screen and letterboxed - restore to windowed size > expect the video to return to its letterboxed size - click the video, then the Options button - change the video's size > expect the video to remain letterboxed - add a horizontal video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - submit to upload > expect the player to be sized to the size of the video - fullscreen > expect the video to be letterboxed in the fullscreen player (if the aspect ration of the video !== that of your monitor, or fill the screen if they match) - for the horizontal video, select Opitons and change the size to be "medium" or "custom" and < 400px wide and add subtitles > expect the video to be letterboxed in a 400px wide iframe. Change-Id: Ib5d08dbd7796985d00f656e38a642ab92939d614 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238432 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-26 23:37:35 +08:00
"@instructure/ui-babel-preset": "6",
upgrade prettier test plan: specs pass Change-Id: I81883f8dc88f9ae96fc45fc0899d2f500abe56f2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258174 Reviewed-by: Ahmad Amireh <ahmad@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-02-05 02:32:55 +08:00
"@prettier/plugin-ruby": "^1.5.2",
Add release tracking and source map uploading to sentry This makes it so our sentry instance can be much more detailed in the data that it collects Change-Id: If44ea7bc54646988d681e6ad775951eb0e35436a Reviewed-on: https://gerrit.instructure.com/154010 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-06-16 01:28:53 +08:00
"@sentry/webpack-plugin": "^1.5.2",
A2: implement delete button closes ADMIN-2233 test plan: - click the delete button which will open a confirmation dialog that roughly matches the design - a11y for the dialog should make sense - the close button should dismiss the dialog with no effect - the cancel button should dismiss the dialog with no effect - the delete button should start a delete operation - when the delete operation completes, you should be redirected to the assignment index screen with a message indicating the assignment has been deleted - if your user does not have permission to delete the assignment, or some other error occurs, then the in-development error screen should be shown Change-Id: I0c3304360d3c389296bd0910d02d8215bdb0ac9e Reviewed-on: https://gerrit.instructure.com/177754 Reviewed-by: Carl Kibler <ckibler@instructure.com> Tested-by: Jenkins QA-Review: Carl Kibler <ckibler@instructure.com> Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
2019-01-15 01:33:05 +08:00
"@sheerun/mutationobserver-shim": "0.3.2",
convert group edit JQueryUI dialog to InstUI modal This commit covers the teacher/admin view of editing user groups. Need to look into removing the old code in a followup change. closes FOO-909 flag = none test plan: - Verify the test plan in the following gerrit still plays out: - https://gerrit.instructure.com/c/canvas-lms/+/247628 - You'll need a student created group set and an admin created group set to test all the angles - Student Group Set - Create a group and remember its state - Go to edit said group - Verify the Group Name field is populated - Verify the Joining select is populated with prior choice - Edit the Group Name and Joining select dropdown - Verify the group collection is refreshed with your newly updated group - Go to edit the group and verify your changes saved successfully - Admin Group Set - Create a group and remember its state - Go to edit said group - Verify the Group Name field is populated - Verify the Group Membership Limit is populated - Verify as you did with the Student Group Set - Ensure the group has a member count - Edit the group and set the Group Membership Limit lower than your member count - Verify you get a descriptive error - The updated group modal should behave as it did before and be accessible and keyboard navigable Change-Id: I6bd4c6983239c9ed779fa41d297dab81c364fcbe Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/250185 Reviewed-by: Ahmad Amireh <ahmad@instructure.com> QA-Review: Ahmad Amireh <ahmad@instructure.com> Product-Review: Ahmad Amireh <ahmad@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2020-10-15 06:41:17 +08:00
"@testing-library/dom": "^7",
Upgrade @testing-library dependencies to latest Most of the upgrades were backwards-compatible, but I made a few changes: * Replaced usages of wait, waitForElement, and waitForDomChange with waitFor as recommended here, since they are deprecated: https://testing-library.com/docs/dom-testing-library/api-async/#deprecated-methods * Replaced '@testing-library/react-hooks' imports with '@testing-library/react-hooks/dom' as recommended here: https://react-hooks-testing-library.com/installation#being-specific * Fixed some issues with @testing-library/jest-dom's toBeDisabled matcher not checking for the disabled attribute on parent elements-- e.g. changing this: `expect(getByText('Button Text')).toBeDisabled()` to this: `expect(getByRole('button', {name: 'Button Text'})).toBeDisabled()` closes LS-1831 flag = none Test plan: tests pass in Jenkins Change-Id: Ia549950dade5fd5b2597a3002b11f4f0a6f740f2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258923 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Charley Kline <ckline@instructure.com> QA-Review: Charley Kline <ckline@instructure.com> Product-Review: Charley Kline <ckline@instructure.com>
2021-02-18 02:07:07 +08:00
"@testing-library/jest-dom": "^5",
"@testing-library/react": "^11",
"@testing-library/react-hooks": "^5",
convert group edit JQueryUI dialog to InstUI modal This commit covers the teacher/admin view of editing user groups. Need to look into removing the old code in a followup change. closes FOO-909 flag = none test plan: - Verify the test plan in the following gerrit still plays out: - https://gerrit.instructure.com/c/canvas-lms/+/247628 - You'll need a student created group set and an admin created group set to test all the angles - Student Group Set - Create a group and remember its state - Go to edit said group - Verify the Group Name field is populated - Verify the Joining select is populated with prior choice - Edit the Group Name and Joining select dropdown - Verify the group collection is refreshed with your newly updated group - Go to edit the group and verify your changes saved successfully - Admin Group Set - Create a group and remember its state - Go to edit said group - Verify the Group Name field is populated - Verify the Group Membership Limit is populated - Verify as you did with the Student Group Set - Ensure the group has a member count - Edit the group and set the Group Membership Limit lower than your member count - Verify you get a descriptive error - The updated group modal should behave as it did before and be accessible and keyboard navigable Change-Id: I6bd4c6983239c9ed779fa41d297dab81c364fcbe Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/250185 Reviewed-by: Ahmad Amireh <ahmad@instructure.com> QA-Review: Ahmad Amireh <ahmad@instructure.com> Product-Review: Ahmad Amireh <ahmad@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2020-10-15 06:41:17 +08:00
"@testing-library/user-event": "^12",
silence some yarn warnings caused by Apollo stuff Test plan: * run `yarn` * you should not see these warnings: warning " > react-apollo@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning "react-apollo > @apollo/react-common@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning "react-apollo > @apollo/react-common@3.0.1" has unmet peer dependency "apollo-utilities@^1.3.2". warning "react-apollo > @apollo/react-components@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning "react-apollo > @apollo/react-components@3.0.1" has unmet peer dependency "apollo-cache@^1.3.2". warning "react-apollo > @apollo/react-components@3.0.1" has unmet peer dependency "apollo-utilities@^1.3.2". warning "react-apollo > @apollo/react-hoc@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning "react-apollo > @apollo/react-hooks@3.0.1" has unmet peer dependency "@types/react@^16.8.0". warning " > @apollo/react-testing@3.0.1" has unmet peer dependency "apollo-utilities@^1.3.2". Change-Id: Icd38c4e742b00d3f31fe187b1bc915fd01169880 Reviewed-on: https://gerrit.instructure.com/207064 Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Reviewed-by: Cameron Matheson <cameron@instructure.com>
2019-08-28 04:10:29 +08:00
"@types/react": ">=16.9.0",
A script to just update instUI Closes: CORE-1709 This is what our Jenkins job to pull in every instui RC commit will use Test plan: * run `yarn upgrade-instructure-ui` * it should make a commit that has new entries in yarn.lock for all the instUI packages that uses the latest rc version on the npm registry * it should not affect anything else besides yarn.lock Change-Id: I78cce6e801015819c4e4b27e26ede352deceebb9 Reviewed-on: https://gerrit.instructure.com/160435 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-08-11 00:22:49 +08:00
"@yarnpkg/lockfile": "^1.0.2",
add progress bar and errors to asmt bulk edit closes LA-898 flag=assignment_bulk_edit test plan: - Edit many dates and save - The job should start and a progress bar should be displayed next to the cancel button - The job progress should be polled and the progress bar updated - When the job completes, polling stops (see network tab), the progress bar should be at 100%, and a success message should be displayed. - There should be appropriate screen reader announcements. - If there are any errors during the job, polling should stop and the error messages should be displayed. Change-Id: Ifd9ec6224318a003317a66ce2460ccf3e9d45efa Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/233136 Reviewed-by: Jeremy Stanley <jeremy@instructure.com> QA-Review: Jeremy Stanley <jeremy@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
2020-04-07 06:07:18 +08:00
"array-flat-polyfill": "^1.0.1",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"axe-core": "~2.1.7",
Upgrade canvas-planner & rce to not use ui-presets This gets canvas planner and canvas-rce on babel 7, which is a prerequisite to canvas doing the same. Also, by not depending on the Kitchen sink of ui-presets, it cleans a ton of unused stuff from our node_modules/yarn.lock. It was originally 2 different commits but in order to get the yarn.lock right, we have to do them all as one. This also made it so we needed to have less “resolutions” in our package.json since the newer versions of those things work fine with the newer version of babel So there are 2 test plan areas: 1. Canvas-planner Closes: CORE-2575 Test plan: * smoke test to make sure everything in canvas-planner still works/looks like it used to in the canvas ui * make sure the translation task (yarn check-transifex) still works canvas-rce: upgrade to babel 7 & @instructure/ui-babel-preset 2. canvas-rce Closes: CORE-2576 Test plan: * smoke test the RCE editor * theming should still work/look exactly as before * make sure all the various build tasks (eg yarn test, test:coverage, debug, lint, extract, etc) all still work as before Change-Id: Id896687e3905f4df4627b181cad3f67ffe4417a5 Reviewed-on: https://gerrit.instructure.com/183877 Tested-by: Jenkins Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com> Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 02:30:44 +08:00
"babel-eslint": "^10",
Upgrade to babel 7 & allow any js file to be themeable closes: CORE-2699 CORE-2700 UIDEV-99 This commit gets canvas-lms itself upgraded to babel 7. To do that we also had to upgrade jest to v24. We had already got canvas-rce and canvas-planner on jest24/babel7 but now this gets everything to babel 7. so you will see a lot of things removed from yarn.lock since we don’t don’t have to have different versions of everything for babel and jest The other major thing this does is make it so any JS file in canvas can become an @instructure/ui-themeable themeable component. This means you no longer should have to put your css in app/stylesheets for any new react components that you are writing. Test plan: 1. Make sure that the perf of `yarn build:js` is on-par with what it was before. We pass everything through the themeable babel transform now so there is a chance it is slower. If it is majorly slower, we’ll have to figure something out. 2. run a production weback build. The common (or any bundle for that matter should get output exactly the same as it did before) things to manually qa check: * in a NODE_ENV=production enviornment, go to /accounts/site_admin/developer_keys * click the "+ Developer Key" button, it should open the modal. (there are selenium tests that do this, but it was one thing that had to be fixed to get jenkins to pass) * on a course that is set up as a master course, click on the thing that opens the blueprint courses tray. * verify that when you click "Associations" and "Sync History" links in that tray, that they dynamically load the webpack chunk for the modal contents for that thing and then the modal is shown (again, there are selenium specs that test that exact thing but it is always good to manually test it too) Change-Id: I802584228962b54480a500f8fe422f45c2dcac4c Reviewed-on: https://gerrit.instructure.com/183965 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 05:20:27 +08:00
"babel-jest": "^24",
"babel-loader": "^8",
dynamic import comments refs COMMS-1844 Test Plan: - Click on comments on an A2 student view - notice there is a loading indicator then the comments load Change-Id: I43ed778b826153b5cb4e58b9365a0016dec10897 Reviewed-on: https://gerrit.instructure.com/180618 Tested-by: Jenkins Reviewed-by: Aaron Hsu <ahsu@instructure.com> QA-Review: Landon Gilbert-Bland <lbland@instructure.com> Product-Review: Steven Burnett <sburnett@instructure.com>
2019-02-06 04:54:30 +08:00
"babel-plugin-dynamic-import-node": "^2.2.0",
support testing coffeescript with jest Change-Id: I540ad44c033e489ff49c251256263d547ca258cd Reviewed-on: https://gerrit.instructure.com/182600 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2019-02-23 14:41:33 +08:00
"babel-plugin-transform-amd-to-commonjs": "^1.4.0",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"babel-plugin-transform-react-remove-prop-types": "^0.4",
modernize canvas_quizzes fixes FOO-1409 flag = none no more client_apps, canvas_quizzes now lives as part of canvas-lms proper inside app/jsx/, which makes the build leaner and leaves us with one less thing to reason about logical changes: - converted from AMD to ES modules - upgraded to recent react + react-router - dropped RSVP in favor of native Promises - used CanvasModal instead of home-grown Dialog - removed dead code; notifications in particular were fishy as there had no dependents at all and did not even show up in the graph - ported tests to Jest, added more unit ones and two integration ones - removed "config.onError" and now throws errors where appropriate - disabled console statements in non-dev :: test plan :: - create a (old-school) quiz containing all types of questions - as 3 distinct students, take the quiz and try to randomize your answers at this point it's helpful to have a reference to compare the screens; I replicated the quiz on my production sandbox for this - go to /courses/:id/quizzes/:id/submissions/:id/log - verify it looks OK - click on a specific question in the stream and verify the question inspector widget works OK - go back to stream and push "View table" - verify the table and its controls are OK - go to /courses/:id/quizzes/:id/statistics - verify it looks OK - click on ? in the discrimination index chart and verify it displays a dialog with help content - click on "X respondents" in one of the charts and verify it displays a dialog with the respondent names - verify the interactive charts do interact as expected (no logic changed here so just a quick glance) - link to "View in SpeedGrader" for essay-like questions works Change-Id: I79af5ff4f1479503b5e2528b613255dde5bc45d3 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256118 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com> Product-Review: Simon Williams <simon@instructure.com>
2021-01-02 07:58:12 +08:00
"chai-assert-change": "^2.0.0",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"clean-webpack-plugin": "^3",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"coffee-loader": "~0.7.2",
"coffee-script": "^1",
Yarn.lock: update all our npm dependencies closes: CORE-1909 This is the result of running: `yarn upgrade-and-dedupe` and then fixing any specs/changes that needed to happen as a result of the new versions Test plan: * automated tests should pass Change-Id: I79ec63d8eb9d7bce4d48af0cff7cee369be58884 Reviewed-on: https://gerrit.instructure.com/164790 Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-09-18 07:08:57 +08:00
"concurrently": "^4",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"core-js-builder": "^3",
"css-loader": "^3",
use web pack closes CNVS-24124 makes working with web pack possible in canvas instead of require-js. See doc/working_with_webpack.md for instructions. TEST PLAN: Nothing should change in non-webpack'd behavior Things should mostly work when you use the USE_WEBPACK environment variable, but make sure to document and ticket things that don't Change-Id: I493a259a609e9e183950bc57aa5876df70108547 Reviewed-on: https://gerrit.instructure.com/64386 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-10-01 11:16:11 +08:00
"ember-template-compiler": "^1.8.0",
upgrade enzyme to 3.x Closes: CORE-1758 After this commit, if you or your team have any specs that import from old-enzyme-2.x-you-need-to-upgrade-this-spec-to-enzyme-3.x-by-importing-just-enzyme That means you need to upgrade those spec files to use the new enzyme by changing that to `import {mount, shallow, whatever} from ‘enzyme’`. Refer to http://airbnb.io/enzyme/docs/guides/migration-from-2-to-3.html for details Test plan: * all linters-and-js-specs should pass * since this only effects js specs, that is all that really matters. no app code to QA Change-Id: I46c5d815e9d95683832d70b64e31526b943d07e5 Reviewed-on: https://gerrit.instructure.com/135136 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-09 01:29:42 +08:00
"enzyme": "^3",
upgrade react from 15.x to 16.x closes: CORE-1874 test plan: Now that the automated selenium & javascript specs pass for this the last thing we need to do is to go manually click around and see if anything breaks. The best thing to do would be to open your browser console and look for errors. Deprecation warnings or propType errors or react warnings are fine but if any actual errors get thrown that is something we want to look into. specific things to look at: * all the gradezilla/gradebook/grading stuff (specifically things that have instUI <NumberInput>s and <Select>s) * look at the submission cell editor * the gb headers (especially make sure keyboard navigation works how it should) * moderated grading * grading perid edit page / enrollment terms * speedgrader * grading standards * gradebook history * theme editor * new discussions/announcements * the new permissions page * the dasboard * student planner * dashcards * global nav trays * help menu * assignment edit page * account user/course search Change-Id: I6a1fe7df9379d9c601eda932bd8cef9c06d10cd2 Reviewed-on: https://gerrit.instructure.com/163913 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-09-11 12:13:01 +08:00
"enzyme-adapter-react-16": "^1",
add enzyme snapshot serializer to jest converts all the existing `expect(component.debug()).toMatchSnapshot()` to: `expect(component).toMatchSnapshot()` which creates more detailed and more diff-able snapshots test plan: - specs pass -- this only affects js test code Change-Id: Ib6dbcc1e3f87e61a251e4635dc68353aca57aeac Reviewed-on: https://gerrit.instructure.com/167651 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-10 03:36:49 +08:00
"enzyme-to-json": "^3.3.4",
Upgrade to babel 7 & allow any js file to be themeable closes: CORE-2699 CORE-2700 UIDEV-99 This commit gets canvas-lms itself upgraded to babel 7. To do that we also had to upgrade jest to v24. We had already got canvas-rce and canvas-planner on jest24/babel7 but now this gets everything to babel 7. so you will see a lot of things removed from yarn.lock since we don’t don’t have to have different versions of everything for babel and jest The other major thing this does is make it so any JS file in canvas can become an @instructure/ui-themeable themeable component. This means you no longer should have to put your css in app/stylesheets for any new react components that you are writing. Test plan: 1. Make sure that the perf of `yarn build:js` is on-par with what it was before. We pass everything through the themeable babel transform now so there is a chance it is slower. If it is majorly slower, we’ll have to figure something out. 2. run a production weback build. The common (or any bundle for that matter should get output exactly the same as it did before) things to manually qa check: * in a NODE_ENV=production enviornment, go to /accounts/site_admin/developer_keys * click the "+ Developer Key" button, it should open the modal. (there are selenium tests that do this, but it was one thing that had to be fixed to get jenkins to pass) * on a course that is set up as a master course, click on the thing that opens the blueprint courses tray. * verify that when you click "Associations" and "Sync History" links in that tray, that they dynamically load the webpack chunk for the modal contents for that thing and then the modal is shown (again, there are selenium specs that test that exact thing but it is always good to manually test it too) Change-Id: I802584228962b54480a500f8fe422f45c2dcac4c Reviewed-on: https://gerrit.instructure.com/183965 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 05:20:27 +08:00
"es-check": "^5",
upgrade eslint & don’t use unique one in canvas-rce instead of having our own eslint in canvas-rce, and maintaining all future rules like react hooks and stuff we can just use the same one that the rest of the repo uses. test plan: * cd packages/canvas-rce * `yarn lint` should run Change-Id: Idbe8af533f7a19035d1998538d2d6fd1a711f164 Reviewed-on: https://gerrit.instructure.com/204998 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2019-08-14 09:31:44 +08:00
"eslint": "^6",
"eslint-config-airbnb": "^18",
"eslint-config-prettier": "^6",
Update eslint rules to allow optional chaining closes LA-973 flag=none test plan: - code with a?.b does not report no-unused-expressions eslint error Change-Id: If31b5545c31a9a095176cee74a2173ba0eeceab8 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/235941 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com> Reviewed-by: Augusto Callejas <acallejas@instructure.com>
2020-05-01 21:34:22 +08:00
"eslint-plugin-babel": "^5",
ESLint standardization This commit introduces a better more reasonable ESLint configuration. It removes all concerns with styling in favor of using prettier to handle those things. closes CORE-2096 Test Plan: - ESLint works Change-Id: I50b90b7191b576bce4817d885d14f18c4c72d208 Reviewed-on: https://gerrit.instructure.com/170874 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-11-03 01:48:59 +08:00
"eslint-plugin-eslint-comments": "^3.0.1",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"eslint-plugin-import": "^2",
Upgrade to babel 7 & allow any js file to be themeable closes: CORE-2699 CORE-2700 UIDEV-99 This commit gets canvas-lms itself upgraded to babel 7. To do that we also had to upgrade jest to v24. We had already got canvas-rce and canvas-planner on jest24/babel7 but now this gets everything to babel 7. so you will see a lot of things removed from yarn.lock since we don’t don’t have to have different versions of everything for babel and jest The other major thing this does is make it so any JS file in canvas can become an @instructure/ui-themeable themeable component. This means you no longer should have to put your css in app/stylesheets for any new react components that you are writing. Test plan: 1. Make sure that the perf of `yarn build:js` is on-par with what it was before. We pass everything through the themeable babel transform now so there is a chance it is slower. If it is majorly slower, we’ll have to figure something out. 2. run a production weback build. The common (or any bundle for that matter should get output exactly the same as it did before) things to manually qa check: * in a NODE_ENV=production enviornment, go to /accounts/site_admin/developer_keys * click the "+ Developer Key" button, it should open the modal. (there are selenium tests that do this, but it was one thing that had to be fixed to get jenkins to pass) * on a course that is set up as a master course, click on the thing that opens the blueprint courses tray. * verify that when you click "Associations" and "Sync History" links in that tray, that they dynamically load the webpack chunk for the modal contents for that thing and then the modal is shown (again, there are selenium specs that test that exact thing but it is always good to manually test it too) Change-Id: I802584228962b54480a500f8fe422f45c2dcac4c Reviewed-on: https://gerrit.instructure.com/183965 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 05:20:27 +08:00
"eslint-plugin-jest": "^22",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"eslint-plugin-jsx-a11y": "^6",
upgrade eslint & don’t use unique one in canvas-rce instead of having our own eslint in canvas-rce, and maintaining all future rules like react hooks and stuff we can just use the same one that the rest of the repo uses. test plan: * cd packages/canvas-rce * `yarn lint` should run Change-Id: Idbe8af533f7a19035d1998538d2d6fd1a711f164 Reviewed-on: https://gerrit.instructure.com/204998 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2019-08-14 09:31:44 +08:00
"eslint-plugin-lodash": "^6",
"eslint-plugin-notice": "^0.8",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"eslint-plugin-prettier": "^3",
"eslint-plugin-promise": "^4",
"eslint-plugin-qunit": "^4",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"eslint-plugin-react": "^7",
add react-hooks linting and update react dep Update the react dependency to 16.8 since we're starting to use react hooks, which requires that version at minimum. test plan: - linting still works - intentionally create a violation of rules-of-hooks. Linting should find and report the error. Change-Id: I0baccd64397b31118b96eb390462acf56daeca96 Reviewed-on: https://gerrit.instructure.com/199053 Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins
2019-06-26 05:24:47 +08:00
"eslint-plugin-react-hooks": "^1",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"exports-loader": "^0.7",
"expose-loader": "^0.7",
remove "exports" from all @instructure/ packages refs FOO-1331 refs LS-1657 flag = none test plan: canvas-rce mocha tests work after upgrading to inst-ui 7 Change-Id: Ibe8d94fdd5a994fda2c7b9703dccfb77a62415ca Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256766 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Ed Schiebel <eschiebel@instructure.com> QA-Review: Ed Schiebel <eschiebel@instructure.com> Product-Review: Simon Williams <simon@instructure.com>
2021-01-15 05:29:41 +08:00
"fast-glob": "^3.2.4",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"fetch-mock": "^7",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"file-loader": "^4",
update gglobby npm dep refs: CNVS-29725 test plan: * run `node script/xsslint.js` * it should work (this is ran by jenkins so reall if it passes, it is good) Change-Id: Ib9b68e486c32c91e3c430cea095a628daf51db2b Reviewed-on: https://gerrit.instructure.com/87181 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2016-08-09 07:39:19 +08:00
"gglobby": "0.0.3",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"glob": "^7",
New mocking foundation for A2 student view tests Utilizing https://www.apollographql.com/docs/graphql-tools/mocking/ Benefits of this new approach: - Query, propTypes, and mocked data all exist in the same location, so it becomes much easier to modify. - You can easily mock data nested deeply in data without needing to manually drill down into it. - The mocked data comes from a FRD graphql query, so you cannot accidently put invalid fields into the testing data (for example, null for a string that is marked as not null). - Can save complex overrides into reusable pieces (graded submission) Fixes COMMS-2224 Test Plan: - Jenkins passes Change-Id: Ib6c3c6f3b3c16b8829d89061b41d8a4d308eb0ed Reviewed-on: https://gerrit.instructure.com/201591 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Landon Gilbert-Bland <lbland@instructure.com> Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
2019-07-12 04:45:03 +08:00
"graphql-tools": "^4",
[node12] upgrade gulp refs FOO-1116 flag = none verified contents of public/dist/ are intact across versions with a cmd like this: find ./public/dist -type f -exec md5sum {} + | awk '{print $1}' | md5sum == TEST PLAN run "npx gulp rev" and verify it still works == BONUS TEST PLAN wipe out node_modules/, run "rake canvas compile:assets" and verify that still works. Change-Id: Ie072e415a89478e58a98b04b7826f974ba63f904 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/253041 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com> Product-Review: Simon Williams <simon@instructure.com>
2020-10-15 04:59:13 +08:00
"gulp": "^4",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"gulp-file": "^0.4",
[node12] upgrade gulp refs FOO-1116 flag = none verified contents of public/dist/ are intact across versions with a cmd like this: find ./public/dist -type f -exec md5sum {} + | awk '{print $1}' | md5sum == TEST PLAN run "npx gulp rev" and verify it still works == BONUS TEST PLAN wipe out node_modules/, run "rake canvas compile:assets" and verify that still works. Change-Id: Ie072e415a89478e58a98b04b7826f974ba63f904 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/253041 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com> Product-Review: Simon Williams <simon@instructure.com>
2020-10-15 04:59:13 +08:00
"gulp-filter": "^6",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"gulp-insert": "^0.5",
[node12] upgrade gulp refs FOO-1116 flag = none verified contents of public/dist/ are intact across versions with a cmd like this: find ./public/dist -type f -exec md5sum {} + | awk '{print $1}' | md5sum == TEST PLAN run "npx gulp rev" and verify it still works == BONUS TEST PLAN wipe out node_modules/, run "rake canvas compile:assets" and verify that still works. Change-Id: Ie072e415a89478e58a98b04b7826f974ba63f904 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/253041 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com> Product-Review: Simon Williams <simon@instructure.com>
2020-10-15 04:59:13 +08:00
"gulp-load-plugins": "^2",
"gulp-rename": "^2",
"gulp-rev": "^9",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"gulp-sourcemaps": "^2",
"gulp-uglify": "^3",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"handlebars": "1.3.0",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"imports-loader": "^0.8",
"istanbul-instrumenter-loader": "^3",
Add a way to generate better js coverage This should pick up coverage from both karma and jest in Canvas proper. It should also pick up coverage from anything under packages/* closes CORE-1265 Test Plan: - Run `COVERAGE=true yarn test` - Coverage reports (coverage-final.json) should generate in all packages such as (canvas-planner) as well as in coverage-karma and coverage-jest - Run `yarn run test:coverage` - coverage-js folder should be generated. Opening index.html should show the full coverage report - Remove coverage-{js, karma, jest} and packages/canvas-planner/coverage as well as .nyc_output to get back to a clean state - Run `RUN_TESTS_FIRST=true yarn run test:coverage` - All tests should run and generate the appropriate report just like the last time in coverage-js Change-Id: I50744b8977e0683e079af5bdd2865dbcd6ad9066 Reviewed-on: https://gerrit.instructure.com/146098 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-04-06 05:27:42 +08:00
"istanbul-merge": "^1.1.1",
Upgrade to babel 7 & allow any js file to be themeable closes: CORE-2699 CORE-2700 UIDEV-99 This commit gets canvas-lms itself upgraded to babel 7. To do that we also had to upgrade jest to v24. We had already got canvas-rce and canvas-planner on jest24/babel7 but now this gets everything to babel 7. so you will see a lot of things removed from yarn.lock since we don’t don’t have to have different versions of everything for babel and jest The other major thing this does is make it so any JS file in canvas can become an @instructure/ui-themeable themeable component. This means you no longer should have to put your css in app/stylesheets for any new react components that you are writing. Test plan: 1. Make sure that the perf of `yarn build:js` is on-par with what it was before. We pass everything through the themeable babel transform now so there is a chance it is slower. If it is majorly slower, we’ll have to figure something out. 2. run a production weback build. The common (or any bundle for that matter should get output exactly the same as it did before) things to manually qa check: * in a NODE_ENV=production enviornment, go to /accounts/site_admin/developer_keys * click the "+ Developer Key" button, it should open the modal. (there are selenium tests that do this, but it was one thing that had to be fixed to get jenkins to pass) * on a course that is set up as a master course, click on the thing that opens the blueprint courses tray. * verify that when you click "Associations" and "Sync History" links in that tray, that they dynamically load the webpack chunk for the modal contents for that thing and then the modal is shown (again, there are selenium specs that test that exact thing but it is always good to manually test it too) Change-Id: I802584228962b54480a500f8fe422f45c2dcac4c Reviewed-on: https://gerrit.instructure.com/183965 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 05:20:27 +08:00
"jest": "^24",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"jest-canvas-mock": "^2",
support testing coffeescript with jest Change-Id: I540ad44c033e489ff49c251256263d547ca258cd Reviewed-on: https://gerrit.instructure.com/182600 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2019-02-23 14:41:33 +08:00
"jest-config": "^24",
Use jsdom 14 instead of 11 in jest tests Test plan: * `yarn jest` should pass Change-Id: I157a55be009bae71e574ed0e9b9ff18f9e2c048b Reviewed-on: https://gerrit.instructure.com/203860 Reviewed-by: Cameron Matheson <cameron@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-06 01:45:01 +08:00
"jest-environment-jsdom-fourteen": "^0.1.0",
add overrides and editing to bulk assignment edit closes LA-847 flag=assignment_bulk_edit test plan: - Assignments and their overrides should be displayed with their dates - Each date input should function and work independently Change-Id: Ia2206bcae8b462535e3bcc99bf024bfaae39bc3e Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230953 QA-Review: Anju Reddy <areddy@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Product-Review: Jon Willesen <jonw+gerrit@instructure.com> Reviewed-by: Augusto Callejas <acallejas@instructure.com> Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
2020-03-23 11:42:21 +08:00
"jest-fetch-mock": "^3.0.3",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"jest-junit": "^7",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"jest-localstorage-mock": "^2",
Extract jest-moxios-utils to its own package closes CORE-2217 Test Plan: - Automated tests pass Change-Id: Icba5c61344e22e8a8e4929b9133c9a2b89a80ef9 Reviewed-on: https://gerrit.instructure.com/174135 Tested-by: Jenkins Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-12-04 23:19:46 +08:00
"jest-moxios-utils": "^1",
add apollo graphql query validation tools These tools allow unit tests to validate that the graphql queries being run using Apollo are valid according to the server's schema. This includes validating the variables. This commit includes a fix that the validator found with overrides where a Section requires a name (String!), but a Group does not (String). To fix the validation error, we have to have separate names for these fields and handle the possibility that the group might have a null name. closes ADMIN-2561 test plan: - specs pass - can still display the "Everyone" override (when there are no overrides) - can still display the "Everyone Else" override Change-Id: Ic19605e5ee12075e9abb5bb089e0285639957b69 Reviewed-on: https://gerrit.instructure.com/188602 Reviewed-by: Mysti Lilla <mysti@instructure.com> Reviewed-by: Cameron Matheson <cameron@instructure.com> Tested-by: Jenkins QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
2019-04-06 05:50:49 +08:00
"jest-raw-loader": "^1",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"json-loader": "^0.5.7",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"karma": "^3",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"karma-chrome-launcher": "^2",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"karma-coverage-istanbul-reporter": "^2",
Make changes for node 12/iojs. This makes a number of changes to get the compilation compatible with node 12 and iojs. - removes loom (no longer used) - updates karma dependencies to more recent versions - minor css change to make sass compilation work with node-sass (lib-sass) test plan: - should be able to compile assets with node 12 and iojs - JS specs still pass Change-Id: Id4a0628ff0c6dd09e622d02329a4400d60459ec2 Reviewed-on: https://gerrit.instructure.com/49493 Tested-by: Jenkins Reviewed-by: Nick Houle <nhoule@instructure.com> Product-Review: Cameron Matheson <cameron@instructure.com> QA-Review: Cameron Matheson <cameron@instructure.com>
2015-02-26 06:28:11 +08:00
"karma-firework-reporter": "~0.2.4",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"karma-junit-reporter": "^1",
Update yarn.lock with newest versions of deps closes: CNVS-38384 This is just to keep our tooling up to date Test plan: * automated tests should pass * build tooling should work (meaning webpack builds In prod & dev) Change-Id: I11fbda35827487e59712c762a71540a51258d1db Reviewed-on: https://gerrit.instructure.com/120434 Tested-by: Jenkins Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-07-26 01:29:52 +08:00
"karma-qunit": "~1.2.1",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"karma-sourcemap-loader": "^0.3",
publish jUnit test result file from karma tests Test plan: * run `yarn test` * there should be xml file in coverage-js/karma-test-results.xml With the spec results that we will use for Jenkins builds Change-Id: Ic68de197d2b52dbccdf58dc2d148aef1f2ca2646 Reviewed-on: https://gerrit.instructure.com/135949 Tested-by: Jenkins Reviewed-by: Robert Lamb <rlamb@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-18 23:21:42 +08:00
"karma-spec-reporter": "^0.0.32",
Update yarn.lock with newest versions of deps closes: CNVS-38384 This is just to keep our tooling up to date Test plan: * automated tests should pass * build tooling should work (meaning webpack builds In prod & dev) Change-Id: I11fbda35827487e59712c762a71540a51258d1db Reviewed-on: https://gerrit.instructure.com/120434 Tested-by: Jenkins Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-07-26 01:29:52 +08:00
"karma-verbose-reporter": "^0.0.6",
deduplicate yarn.lock refs DE-397 De-duplicating yarn.lock is necessary for some future InstUI upgrade work. In order to do this, we need to patch karma-webpack to avoid watching too many files within our JS job. We also need to pin babel-plugin-dynamic-import-node to the latest to work around a breaking change that causes “request of a dependency is an expression”. Both of these version pins are work arounds and will be addressed by our efforts to upgrade webpack to v5. Test Plan: 1. Ensure that “yarn dedupe-yarn” does not produce any file changes. 2. Ensure that the “JS (Karma)” job does not produce any warnings like “request of a dependency is an expression” 3. Ensure that the “JS (Karma)” job does not produce any warnings like “System limit for number of file watchers reached” 4. Ensure that Canvas front-end builds & behaves properly Change-Id: I94d77bd775bc12f9f96ac44640c862ff3e3dee79 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256674 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Ahmad Amireh <ahmad@instructure.com> QA-Review: Ahmad Amireh <ahmad@instructure.com> Product-Review: Ahmad Amireh <ahmad@instructure.com>
2021-01-14 05:14:23 +08:00
"karma-webpack": "necessary until https://github.com/ryanclark/karma-webpack/pull/449 is merged",
"karma-webpack": "instructure/karma-webpack#patch1",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"lint-staged": "^9",
Enables adding alt text to image uploads It also allows editing other a11y features, like making the image presentational or embedding it as a link. It splits out the Image Options form from the editor tray to avoid copy/pasting too much. The logic and state are still separated between the upload and edit forms, since they don't overlap super well. It also edits the logic around uploading and embedding images to support the extra attributes. A few Jest tests were added to check for appropriate attributes being added. Test Plan: With RCE Enhancements enabled, visit an RCE page Open the image upload modal and choose an image Notice the image attributes form underneath. Add alt text. Adjust the other attributes as desired. Upload the image Open the Raw HTML Editor. Notice that the alt text is added to your image, along with whatever other attributes you changed. Decoration Images are given the `role="presentation"` attribute; Display As "Link" embeds the image as a link. Fixes LS-445 flag = rce_enhancements Change-Id: I462e2c322a3b39fc4fa9f47b675426c581c3a398 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/242736 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jeremy Stanley <jeremy@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Peyton Craighill <pcraighill@instructure.com>
2020-07-16 05:11:24 +08:00
"merge-stream": "^2",
extend JS source files without relying on filepath fixes FOO-1435 flag = none instead of the bundler inferring the source file that an extension is meant for based on filepath, a plugin is now expected to explicitly map each source file to the extension file in its package.json manifest { "canvas": { "source-file-extensions": { "path/to/a.js": "path/to/extension-to-a.js" } } } this allows extensions to continue working even when the path of the source file no longer matches that of the extension inside the plugin == test plan - visit a page that contains an extended module and verify the extension is still applied Change-Id: Ida7d75b87aedc519502c969e6912a335af69abc0 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256222 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com> Product-Review: Simon Williams <simon@instructure.com>
2021-01-07 01:40:57 +08:00
"mkdirp": "^1.0.4",
Pass correct locale to Planner Sometimes ENV.LOCALE and ENV.MOMENT_LOCALE are different (zh-Hans v zh-cn or mi v mi-nz). We were passing the former to planner, but moment needs the full locale, including language and region identifiers, and formatMessage copes with the full locale just fine, so we really need to pass in the latter or moment eventually blows up. So mi-nz month names would successfully parse, had to both bump our version of moment and tweak the canvas customized mi-nz locale data. to test, you'll have to run yarn to update moment, then build with RAILS_LOAD_ALL_LOCALES=1 yarn build Note on the changes to timezoneSpec.js: - some of the specs were parsing dates like "Mon, Aug 3", which are being interpreted in the current year, when Aut 3 is not a Monday. Resolved this by using MockDate to pretend today is 2/1/2015 - moment does not always interpret the Chinese characters for evening as implying PM. I'm assuming canvas will never need that particular construct and commented out the failing string. - there's one date-time that's getting the date totally wrong. - Fixed grammatically incorrect instances of '8月 3, 2015' to ''8月 3日, 2015' - fix cases where the year is coming after the month and day, which would never really happen fixes ADMIN-1331 test plan: - have a student in course so planner is enabled. - go to /profile/settings and Edit - change the Language to Reo Māori (Aotearoa) and "Update Settings" - go to the planner dashboard - click on + to create a new todo > expect you can create a todo. If you want, you can repeat with any of the languages listed in the ticket just to prove ^that wasn't a fluke. Change-Id: I9ba069ef61529088ab92271d7857998df6bbc409 Reviewed-on: https://gerrit.instructure.com/161206 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> Reviewed-by: Mysti Sadler <mysti@instructure.com> Reviewed-by: Jeremy Stanley <jeremy@instructure.com> QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2018-08-18 03:21:04 +08:00
"mockdate": "^2.0.2",
don’t include really old timezone data in JS bundle closes: CORE-2770 we don’t need timezone data from before canvas was created (pre 2011) or, realistically, 15 years from now. by using this moment-timezone-data-webpack-plugin we can strip them out of our webpack bundle and our common vendor JS file will be smaller. and smaller js bundles = faster page loads test plan: * try to think of a compelling reason why we would need to properly handle timezone weirdness that is either older than 2011 or more than 15 years from now * if you can think of something, then we can’t do this * run the prod webpack build, the vendor file should be smaller Change-Id: I1823fb48cc14bc0687f5222d7f4344118825698e Reviewed-on: https://gerrit.instructure.com/188810 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2019-04-09 13:47:34 +08:00
"moment-timezone-data-webpack-plugin": "^1.0.3",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"moxios": "^0.4",
add POC MessageListActionContainerMSW test flag=canvas_inbox fixes VICE-1240 TEST PLAN: - yarn - yarn jest app/jsx/canvas_inbox/containers/__tests__/CanvasInboxFullPage.test.js should pass Change-Id: Ibaf618e8abae4aad63d6e1dabf1a1ea20f5c9dd6 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/261392 Reviewed-by: Brian Watson <bwatson@instructure.com> Reviewed-by: Davis Hyer <dhyer@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Davis Hyer <dhyer@instructure.com> Product-Review: Davis Hyer <dhyer@instructure.com>
2021-03-24 01:39:02 +08:00
"msw": "^0.27.2",
[node12] upgrade node-sass refs FOO-1116 flag = none this has been a controversial upgrade since, on the one hand, node-sass is deprecated and we need to move to dart-sass, but then doing that will require some work as i've seen a few major visual regressions caused by the transition (see patch for dart-sass) we can get node-sass unto the latest (that does compile under node12+) by changing our use of :not() with a selector list: :not(.a, .b) to: :not(.a):not(.b) see this gist for a more thorough explanation and rationale: https://gist.github.com/amireh/867a00a36588fc6490c38813cf2558c3 :: test plan :: - we are able to install dependencies on BOTH node10 and node12 - we must make sure there are no regressions to SIS-3125 Change-Id: If8c396e6404cb6d868997b399007a06e8d1e9548 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/253764 Reviewed-by: August Thornton <august@instructure.com> QA-Review: August Thornton <august@instructure.com> Product-Review: August Thornton <august@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2020-11-26 04:32:09 +08:00
"node-sass": "~4.14.1",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"nyc": "^13",
upgrade prettier test plan: specs pass Change-Id: I81883f8dc88f9ae96fc45fc0899d2f500abe56f2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258174 Reviewed-by: Ahmad Amireh <ahmad@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-02-05 02:32:55 +08:00
"prettier": "^2.2.1",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"qunitjs": "^1.14.0",
Add raven to grab errors from test runs closes CORE-1532 Test Plan: - Run tests with SENTRY_URL environment variable set - It should attempt to send data to sentry - Build works otherwise Change-Id: Ib802851a7b3ac8626033436f60399f134a8425b3 Reviewed-on: https://gerrit.instructure.com/153878 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-06-15 03:55:22 +08:00
"raven-js": "^3.26.2",
upgrade react from 15.x to 16.x closes: CORE-1874 test plan: Now that the automated selenium & javascript specs pass for this the last thing we need to do is to go manually click around and see if anything breaks. The best thing to do would be to open your browser console and look for errors. Deprecation warnings or propType errors or react warnings are fine but if any actual errors get thrown that is something we want to look into. specific things to look at: * all the gradezilla/gradebook/grading stuff (specifically things that have instUI <NumberInput>s and <Select>s) * look at the submission cell editor * the gb headers (especially make sure keyboard navigation works how it should) * moderated grading * grading perid edit page / enrollment terms * speedgrader * grading standards * gradebook history * theme editor * new discussions/announcements * the new permissions page * the dasboard * student planner * dashcards * global nav trays * help menu * assignment edit page * account user/course search Change-Id: I6a1fe7df9379d9c601eda932bd8cef9c06d10cd2 Reviewed-on: https://gerrit.instructure.com/163913 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-09-11 12:13:01 +08:00
"react-test-renderer": "^16",
Update redux-logger to 3.0.6 test plan: - automated tests pass Change-Id: Iaf8b223e7c60a43f5b4e10561d5d66643a312992 Reviewed-on: https://gerrit.instructure.com/173817 Tested-by: Jenkins Product-Review: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com>
2018-11-30 09:03:38 +08:00
"redux-logger": "^3.0.6",
make feature flags for Right To Left layout Closes: CORE-1154 There are 2 feature flags here. One a specific user (internal employees, sales people, contractors, etc) can turn on to see where we are and what would still need to be done. And the other is for an account to be able to turn on to let the users in their account that have their language set to an RTL language (eg: Arabic, Farsi or Hebrew) see the interface in RTL This commit is part of a chain of commits. you'll need to apply the ones that follow-on after this to see most of the actual Right To Left features, this commit is mainly just to create the feature flag. Test plan: * go to your user settings page * you should see a feature option for Force RTL Layout” * it should show that it is “in development” * it should should be hidden: eg: only appears for site admins and not For normal users * turn it on (if you have this checked out along with the others that follow beind this commit) * navigate around canvas, most things on most pages should be RTL * you should be able to get an idea of how much more work and what Kind of changes we’d still need to make to get it 100% * now turn off that user feature flag, and go to your account's settings * turn on the "allow users from RTL languages to see RTL layout" account-level feature flag. * nothing should change for you, it should be LTR like normal * set your language to either Arabic, Farsi or Hebrew * now the interface should all be in right to left. (again, you'll need to have the follow-on commits to this to see all of the RTL changes) * without either of the feature flags turned on, absolutely nothing should be different at all anywhere in the interface. Change-Id: Ia78d86fa46d2d289b1913c5d1340546d7f6c3a1f Reviewed-on: https://gerrit.instructure.com/143891 Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins
2018-03-17 02:25:14 +08:00
"sass-direction": "^1",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"script-loader": "^0.7",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"sinon": "^7",
Add @instructure/uid dependency to canvas test plan: yarn test:karma builds w/o errors Change-Id: I631dabdf9214e2d44bedaa4f4ff1451fcc0e76b0 Reviewed-on: https://gerrit.instructure.com/206016 Reviewed-by: Carl Kibler <ckibler@instructure.com> Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Carl Kibler <ckibler@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins
2019-08-21 22:55:36 +08:00
"style-loader": "^0.23",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"stylelint": "^10",
"through2": "^3",
Update tinymce and @tinymce/tinymce-react closes LS-1609 flag=rce_enhancements Had to nohiost tinymce so it remains w/in canvas-rce where RCEWrapper.js can require tinymce's stylesheets, but it still needs to be a dev dep. of canvas-lms because there are specs that import tinuymce. Moved the matchMedia jsdon polyfill into jest-setup where it can be used by everyone. Need it there since the new tinymce calls it. test plan: - specs pass - the RCE still works and looks the same Sorry, I don't know what else to say Change-Id: I8c956664176b7c25995a55e0c6fea4dafad3970f Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/255604 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Nate Armstrong <narmstrong@instructure.com> QA-Review: Nate Armstrong <narmstrong@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-12-19 01:36:23 +08:00
"tinymce": "^5",
Upgrade canvas-planner & rce to not use ui-presets This gets canvas planner and canvas-rce on babel 7, which is a prerequisite to canvas doing the same. Also, by not depending on the Kitchen sink of ui-presets, it cleans a ton of unused stuff from our node_modules/yarn.lock. It was originally 2 different commits but in order to get the yarn.lock right, we have to do them all as one. This also made it so we needed to have less “resolutions” in our package.json since the newer versions of those things work fine with the newer version of babel So there are 2 test plan areas: 1. Canvas-planner Closes: CORE-2575 Test plan: * smoke test to make sure everything in canvas-planner still works/looks like it used to in the canvas ui * make sure the translation task (yarn check-transifex) still works canvas-rce: upgrade to babel 7 & @instructure/ui-babel-preset 2. canvas-rce Closes: CORE-2576 Test plan: * smoke test the RCE editor * theming should still work/look exactly as before * make sure all the various build tasks (eg yarn test, test:coverage, debug, lint, extract, etc) all still work as before Change-Id: Id896687e3905f4df4627b181cad3f67ffe4417a5 Reviewed-on: https://gerrit.instructure.com/183877 Tested-by: Jenkins Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com> Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 02:30:44 +08:00
"waait": "^1",
upgrade webpack to v4 Closes: CORE-1143 Test plan: * load canvas in prod mode in a non-English language. Click around And make sure everything works * in prod mode, do a test to compare load time to what’s on beta. * page load time and js bundle size should be smaller * click around in the quizzes client apps and the ember grade book And make sure those things work Change-Id: I93c28c4a6d22db95cd1c7e59cd3f5221d46fe1ed Reviewed-on: https://gerrit.instructure.com/143422 Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
2018-03-07 10:12:53 +08:00
"webpack": "^4",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"webpack-cleanup-plugin": "^0.5",
Update webpack-cli for webpack:analyze bugfix Fixes FOO-1674 flag = none Update webpack-cli dependency to pull in a bugfix which was preventing the webpack:analyze tool from working. Test plan: * yarn webpack:analyze works again * nothing else broke (major version number changed!) Change-Id: I5f6ee48ea7b24bda9e13e73f44cee8cf23abfc22 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/260189 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jeff Largent <jeff.largent@instructure.com> QA-Review: Jeff Largent <jeff.largent@instructure.com> Product-Review: Charley Kline <ckline@instructure.com>
2021-03-09 03:33:46 +08:00
"webpack-cli": "^4",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"webpack-manifest-plugin": "^2",
upgrade webpack to v4 Closes: CORE-1143 Test plan: * load canvas in prod mode in a non-English language. Click around And make sure everything works * in prod mode, do a test to compare load time to what’s on beta. * page load time and js bundle size should be smaller * click around in the quizzes client apps and the ember grade book And make sure those things work Change-Id: I93c28c4a6d22db95cd1c7e59cd3f5221d46fe1ed Reviewed-on: https://gerrit.instructure.com/143422 Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
2018-03-07 10:12:53 +08:00
"webpack-stats-plugin": "^0.2.1",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"wsrun": "^5",
Point to instructure forks Closes: CCI-351 flag = none Test Plan: - no behavioral changes - build passes Change-Id: I2e6bfa46b56ee2b59b8289fc90ef9c319757fc34 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/235566 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: James Butters <jbutters@instructure.com> Reviewed-by: Jacob Powell <spowell@instructure.com> QA-Review: James Butters <jbutters@instructure.com> QA-Review: Jacob Powell <spowell@instructure.com> Product-Review: James Butters <jbutters@instructure.com>
2020-04-29 05:19:29 +08:00
"xsslint": "instructure/xsslint#babel7",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"yaml-loader": "^0.5"
clean up JS tests and integrate karma - js:generate_runner now generates common files to be used by different test runners - js spec file order now shuffled to better expose dependencies - fakeENV now returns two methods: setup and teardown - stock tinymce 3 files are now wrapped for AMD test plan: - tinymce should work the same - js:test rake task should run tests - js:build task should work as normal (using new location of r.js) - test results should successfully send to firework Change-Id: Ic09647f55dae57130fa0fe3d6a9168d2b67b89a2 Reviewed-on: https://gerrit.instructure.com/29297 QA-Review: Shawn Meredith <shawn@instructure.com> Tested-by: Shawn Meredith <shawn@instructure.com> Tested-by: Aaron Shafovaloff <ashafovaloff@instructure.com> Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
2014-01-24 23:58:37 +08:00
},
make inspect-process an optional dependency Change-Id: If62f0601df401e2407a0a606a75c230d1225b205 Reviewed-on: https://gerrit.instructure.com/183822 Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com> Tested-by: Jenkins Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2019-03-05 23:51:37 +08:00
"optionalDependencies": {
Add storyshots to storybook refs OUT-4237 flag=none Test-plan: > yarn install > yarn storybook - Look through outcomes stories in storybook quickly, verify everything loads > yarn test-storybook - Verify everything passes, if something doesn't pass, verify that that corresponding story is also broken in storybook > echo $? # should return 0 and jest results should say 0 failures - Change one of the stories so that it doesn't render, For example: undo the changes made to ManagementHeader.stories.js in tis PS > yarn test-storybook - Verify that it fails > echo $? # should return 1 and jest results should say 1+ failure(s) Change-Id: I492f50d861dccdfdf4a958fd007da44041f9dd49 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258297 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com> Reviewed-by: Michael Brewer-Davis <mbd@instructure.com> QA-Review: Pablo Gomez <pablo.gomez@instructure.com> Product-Review: Brian Watson <bwatson@instructure.com>
2021-02-06 07:39:54 +08:00
"@storybook/addon-actions": "^6.1.17",
"@storybook/addon-essentials": "^6.1.17",
"@storybook/addon-links": "^6.1.17",
"@storybook/addon-storyshots": "^6.1.17",
"@storybook/react": "^6.1.17",
make inspect-process an optional dependency Change-Id: If62f0601df401e2407a0a606a75c230d1225b205 Reviewed-on: https://gerrit.instructure.com/183822 Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com> Tested-by: Jenkins Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2019-03-05 23:51:37 +08:00
"inspect-process": "^0.5"
},
return focus to the status bar buttons when the kb shortcut dialog or the a11y checker tray close, return focus to the button that opened it. closes COREFE-108 test plan: - in rce, click on the kb short cutton in the status bar - close the kb shortcut dialog > expect focus to return to the button - repeat for the a11y checker - tab until the show-on-focus kb shortcut button above the RCE appears, click it, then close the dialog > expect focus to return to the button Change-Id: I27ea79930e643d9908a784fbcb89900918d3be01 Reviewed-on: https://gerrit.instructure.com/204283 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2019-08-08 04:19:35 +08:00
"browserslist": [
"extends @instructure/browserslist-config-canvas-lms"
],
speed up JS tests by running them concurrently closes: CORE-865 In order to get accurate coverage reports (ie: so the coverage numbers don’t only reflect a fraction of the total tests), when the COVERAGE environment variable is set, it does not split them out into groups to run concurrently. That way our linters-and-js-master build (which sets that environment variable) will run the same as it always has and our patch-set builds (which run the linters-and-js) will be faster. Test plan: * run ‘yarn test’ * it should be a lot faster than it used to be * look at the linters-and-js build in jenkins for this commit * it should have test reports for all both groups (coffee, js) Of karma tests as well as for the jest tests. * look at the coverage report after this gets merged. It should be the same as it was before Change-Id: I35147cc84df4afae92c1a73c201667d4d44b5518 Reviewed-on: https://gerrit.instructure.com/136373 Reviewed-by: Simon Williams <simon@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Jeremy Neander <jneander@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-22 04:09:17 +08:00
"jest-junit": {
"output": "./coverage-js/junit-reports/jest.xml"
},
upgrade karma everyone was getting build errors when they were npm install'ing. it was because karma 0.10 depended on an out-of-date version of chokiadr that does not compile against node 0.12 I also indicated that canvas is licenced agpl 3 so that you wouldn't always see an npm warning about not having one. also, let karma serve our css files so if any javascript references them in our quit tests, we don't see 404 warnings Change-Id: Iaa0377bc87b8f7ec8726d6cb82c0f8a103134b56 Reviewed-on: https://gerrit.instructure.com/58584 Tested-by: Jenkins Reviewed-by: Mike Nomitch <mnomitch@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2015-07-16 12:24:49 +08:00
"repository": "instructure/canvas-lms",
clean up JS tests and integrate karma - js:generate_runner now generates common files to be used by different test runners - js spec file order now shuffled to better expose dependencies - fakeENV now returns two methods: setup and teardown - stock tinymce 3 files are now wrapped for AMD test plan: - tinymce should work the same - js:test rake task should run tests - js:build task should work as normal (using new location of r.js) - test results should successfully send to firework Change-Id: Ic09647f55dae57130fa0fe3d6a9168d2b67b89a2 Reviewed-on: https://gerrit.instructure.com/29297 QA-Review: Shawn Meredith <shawn@instructure.com> Tested-by: Shawn Meredith <shawn@instructure.com> Tested-by: Aaron Shafovaloff <ashafovaloff@instructure.com> Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
2014-01-24 23:58:37 +08:00
"scripts": {
fix JS job sanity around COVERAGE var refs DE-462 Change-Id: Ie5bce0bdf0e7a16eb9424813abd49000d5d819d2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/257532 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com>
2021-01-27 23:25:50 +08:00
"test": "yarn test:packages && if [ \"$COVERAGE\" = \"1\" ]; then yarn test:jest:coverage --runInBand; else yarn test:jest --runInBand; fi && if [ \"$COVERAGE\" = \"1\" ]; then yarn test:karma; else yarn test:karma:concurrently; fi",
Add a way to generate better js coverage This should pick up coverage from both karma and jest in Canvas proper. It should also pick up coverage from anything under packages/* closes CORE-1265 Test Plan: - Run `COVERAGE=true yarn test` - Coverage reports (coverage-final.json) should generate in all packages such as (canvas-planner) as well as in coverage-karma and coverage-jest - Run `yarn run test:coverage` - coverage-js folder should be generated. Opening index.html should show the full coverage report - Remove coverage-{js, karma, jest} and packages/canvas-planner/coverage as well as .nyc_output to get back to a clean state - Run `RUN_TESTS_FIRST=true yarn run test:coverage` - All tests should run and generate the appropriate report just like the last time in coverage-js Change-Id: I50744b8977e0683e079af5bdd2865dbcd6ad9066 Reviewed-on: https://gerrit.instructure.com/146098 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-04-06 05:27:42 +08:00
"test:coverage": "script/generate_js_coverage",
speed up JS tests by running them concurrently closes: CORE-865 In order to get accurate coverage reports (ie: so the coverage numbers don’t only reflect a fraction of the total tests), when the COVERAGE environment variable is set, it does not split them out into groups to run concurrently. That way our linters-and-js-master build (which sets that environment variable) will run the same as it always has and our patch-set builds (which run the linters-and-js) will be faster. Test plan: * run ‘yarn test’ * it should be a lot faster than it used to be * look at the linters-and-js build in jenkins for this commit * it should have test reports for all both groups (coffee, js) Of karma tests as well as for the jest tests. * look at the coverage report after this gets merged. It should be the same as it was before Change-Id: I35147cc84df4afae92c1a73c201667d4d44b5518 Reviewed-on: https://gerrit.instructure.com/136373 Reviewed-by: Simon Williams <simon@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Jeremy Neander <jneander@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-22 04:09:17 +08:00
"test:watch": "concurrently --names \"jest,karma\" \"jest --watch .\" \"yarn test:karma:watch\"",
run jest tests concurrently closes USERS-376 fixes USERS-379 fixes USERS-385 test plan: - specs pass Change-Id: I30d4c27a2c628858a207d4c0236345bad49b7bcf Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/228278 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Charley Kline <ckline@instructure.com> QA-Review: Charley Kline <ckline@instructure.com> Product-Review: Charley Kline <ckline@instructure.com>
2020-02-28 05:49:45 +08:00
"test:jest": "jest --color",
attempt #2 to try to get master js build working my last thing fixed it in one spot but it fails in another now lets see if we just give it more memory if that will work Change-Id: Ia4a5aef21f3a07ac2d383682de1cfc4fe2d71f73 Reviewed-on: https://gerrit.instructure.com/206869 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-27 08:14:19 +08:00
"test:jest:coverage": "NODE_OPTIONS=\"--max_old_space_size=8192\" jest --color --coverage",
fix audio player and video player sizing closes LA-729 flag=rce_enhancements The original intent for the audio player was to size it so the buttons just fit. This ignored the fact that it's rendered w/in an iframe, so popup menus are clipped. This change sizes the player to leave room for those popups. While the ticket was written against the audio player, the same issues may occur in the video player, either for portrait videos or videos < 400px wide when closed captions are present. The original code for sizing the video player shrank the width to fit thea video's size, which clipped the buttons. This change sets a minimum width for the player and letter-boxes the video. test plan: - in the new rce - add an audio file > expect it to be wide enough to show all the buttons and tall enough for the speed and volume popups - add a vertical video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - Submit to upload > expect the player to be wide enough to show all the buttons - click the fullscreen button > expect the video to be the height of the screen and letterboxed - restore to windowed size > expect the video to return to its letterboxed size - click the video, then the Options button - change the video's size > expect the video to remain letterboxed - add a horizontal video > expect the video sized to fit in the available space in the Computer tab of the Upload Media modal - submit to upload > expect the player to be sized to the size of the video - fullscreen > expect the video to be letterboxed in the fullscreen player (if the aspect ration of the video !== that of your monitor, or fill the screen if they match) - for the horizontal video, select Opitons and change the size to be "medium" or "custom" and < 400px wide and add subtitles > expect the video to be letterboxed in a 400px wide iframe. Change-Id: Ib5d08dbd7796985d00f656e38a642ab92939d614 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238432 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-26 23:37:35 +08:00
"test:jest:debug": "node --inspect-brk node_modules/.bin/jest --runInBand",
update JS testing docs flag=none this commit also removes the phantomjs docker-compose service which has been broken for years, ever since PhantomJS was removed from karma.conf.js in https://gerrit.instructure.com/c/canvas-lms/+/102169 test plan: - follow the docs to ensure you can run a targeted JS test in docker Change-Id: Ifa1647897a7a9605e097aeaf89e718c167d379fc Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256179 Reviewed-by: Nate Armstrong <narmstrong@instructure.com> QA-Review: Nate Armstrong <narmstrong@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Product-Review: Michael Ziwisky <mziwisky@instructure.com>
2021-01-06 16:57:21 +08:00
"test:jest:watch": "jest --color --watch",
Give more memory to karma when it's running This should make it so our post-merge build starts working again and reporting new coverage information. closes CORE-1435 Test Plan: - Run `COVERAGE=true yarn run test:karma` - It should not fail because of memory issues Change-Id: I6e103352fa25e130d0ba8072a77c9d81ac11bb85 Reviewed-on: https://gerrit.instructure.com/150666 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-05-18 06:02:10 +08:00
"test:karma": "yarn run test:karma:watch --single-run",
Add linters to new Jenkins This moves eslint, stylelint, and xsslint to be part of our JS build pipeline. It does not account for other linters that are more general like tatl_tael linters and commit messages or non-frontend language specific linters like rubocop. Test Plan: - The linters-and-js build on New Jenkins should run and actually run the linters specified above. closes COREFE-220 flag = none Change-Id: I8f633caf9af025c83bbe68fbd1536276a838c159 Reviewed-on: https://gerrit.instructure.com/206106 Tested-by: Jenkins Reviewed-by: Ed Schiebel <eschiebel@instructure.com> Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-22 03:12:19 +08:00
"test:karma:concurrently": "concurrently --names \"coffee,jsa,jsg,jsh\" \"JSPEC_GROUP=coffee yarn test:karma:headless\" \"JSPEC_GROUP=jsa yarn test:karma:headless\" \"JSPEC_GROUP=jsg yarn test:karma:headless\" \"JSPEC_GROUP=jsh yarn test:karma:headless\"",
Give more memory to karma when it's running This should make it so our post-merge build starts working again and reporting new coverage information. closes CORE-1435 Test Plan: - Run `COVERAGE=true yarn run test:karma` - It should not fail because of memory issues Change-Id: I6e103352fa25e130d0ba8072a77c9d81ac11bb85 Reviewed-on: https://gerrit.instructure.com/150666 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-05-18 06:02:10 +08:00
"test:karma:headless": "yarn run test:karma --browsers ChromeHeadlessNoSandbox",
"test:karma:watch": "node --max-old-space-size=4096 ./node_modules/.bin/karma start",
"test:karma:watch:headless": "yarn run test:karma:watch --browsers ChromeHeadlessNoSandbox",
fix JS job sanity around COVERAGE var refs DE-462 Change-Id: Ie5bce0bdf0e7a16eb9424813abd49000d5d819d2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/257532 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com>
2021-01-27 23:25:50 +08:00
"test:packages": "if [ \"$COVERAGE\" = \"1\" ]; then yarn workspace-run-serial test:coverage; else yarn workspace-run-serial test; fi",
make npm build scripts more user friendly :) test plan: - run the following commands and assess that they run as expected: - yarn run build - yarn run build:css - yarn run build:css:watch - yarn run build:js - yarn run build:jss:watch Change-Id: I4c0a2a68ce62896364bc2da5e7956002c15f5847 Reviewed-on: https://gerrit.instructure.com/110497 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com> Product-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
2017-05-03 00:44:54 +08:00
"build": "yarn run build:css && yarn run build:js",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"build:watch": "concurrently --raw \"yarn build:css:watch\" \"yarn build:js:watch\"",
make npm build scripts more user friendly :) test plan: - run the following commands and assess that they run as expected: - yarn run build - yarn run build:css - yarn run build:css:watch - yarn run build:js - yarn run build:jss:watch Change-Id: I4c0a2a68ce62896364bc2da5e7956002c15f5847 Reviewed-on: https://gerrit.instructure.com/110497 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com> Product-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
2017-05-03 00:44:54 +08:00
"build:css": "brandable_css",
"build:css:watch": "brandable_css --watch",
"build:js": "yarn run webpack-development",
"build:js:watch": "yarn run webpack",
move packages into dependencies layer for caching refs DE-216 [change-merged] [build-registry-path=jenkins/canvas-lms/de-216] Test Plan: 1. Ensure that docker-compose build works locally 2. Ensure that packages building is cached when files aren’t changed 3. Packages build correctly when modified Change-Id: I3e775e5d7eb51ba06078314b50bf2f8efb6d7d0b Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245423 Reviewed-by: James Butters <jbutters@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com>
2020-08-19 05:43:49 +08:00
"build:packages": "yarn workspace-run build:canvas",
Drop IE 11 support closes: CORE-3175 based on our browser support documentation (https://community.canvaslms.com/docs/doc-10720) "On August 3, 2019, Internet Explorer 11 will no longer be supported as a Canvas browser." and since any code being merged to master now won't hit prod until after august 3rd, we can safely drop IE11 support now test plan: * look at the code generated by webpack * you should see things like "class" and arrow functions "() => {}" * if you go to canvas in IE 11, it should not work * if you go to canvas in the next oldest browsers we support (which would probably be Edge 42 or Safari 11) it should still work the same as it did before Change-Id: Ifc7f64902a333fd0f662ff6a68eb8f4353f01130 Reviewed-on: https://gerrit.instructure.com/197827 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-06-17 09:44:52 +08:00
"lint:browser-code": "es-check es8 ./public/dist/**/*.js",
fix pre-commit hook with unfixable eslint error test plan: - have a local yarn install - add an unfixable lint error (unused var) to a file in the prettier whitelist - try to commit the file - it should not try to run in docker after the lint error Change-Id: If1fcfc6693be26c6f6fdddb8cfa4c54a73512ebe Reviewed-on: https://gerrit.instructure.com/173469 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins
2018-11-28 06:40:21 +08:00
"lint:staged": "lint-staged",
rename some things fixes FOO-1265 [skip-eslint=true] [pin-commit-analytics=7e49eefd7f59cbf43fd03bf8957bbbfa76f8d9d5] [pin-commit-demo_site=adade2e38e46a358a4643cd3db2fe5ccffe39ec5] [pin-commit-instructure_misc_plugin=47a3161102b0611af56d134fbd0c828ddc1b8abf] [pin-commit-migration_tool=0dbac2f5b421d894395605ce4b583ef0f7d60b22] [pin-commit-multiple_root_accounts=cc96d28c0d59bbe47acc64de4fdd8e1d2b029805] Change-Id: I14c07f20bd260cf0de1f48ceb70b3c2313edf2d2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258807 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Michael Ziwisky <mziwisky@instructure.com> QA-Review: Michael Ziwisky <mziwisky@instructure.com> Product-Review: Michael Ziwisky <mziwisky@instructure.com>
2021-04-06 07:44:00 +08:00
"lint:js:coffeescripts": "echo 'STOP CALLING ME IM NO LONGER NEEDED'",
"lint:js:jsx": "eslint './ui/**/*.js'",
Add linters to new Jenkins This moves eslint, stylelint, and xsslint to be part of our JS build pipeline. It does not account for other linters that are more general like tatl_tael linters and commit messages or non-frontend language specific linters like rubocop. Test Plan: - The linters-and-js build on New Jenkins should run and actually run the linters specified above. closes COREFE-220 flag = none Change-Id: I8f633caf9af025c83bbe68fbd1536276a838c159 Reviewed-on: https://gerrit.instructure.com/206106 Tested-by: Jenkins Reviewed-by: Ed Schiebel <eschiebel@instructure.com> Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-22 03:12:19 +08:00
"lint:js:packages": "eslint ./packages/**/*.js",
"lint:style": "stylelint './app/**/*.{css,scss}' './packages/**/*.{css,scss}'",
"lint:xss": "node ./script/xsslint.js",
automatically dedupe yarn on postinstall Change-Id: Idaf1b07f9609f4948006f6be9aac357ab0816e86 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256887 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: James Butters <jbutters@instructure.com> Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com> Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com>
2021-01-16 02:24:10 +08:00
"postinstall": "yarn dedupe-yarn; test -n \"$DISABLE_POSTINSTALL\" || (yarn build:packages && ./script/install_hooks && ./script/fix_inst_esm.js)",
Print a helpful message in yarn webpack:analyze Change-Id: I7d73e8d482dc025d478597393c261b9807dae544 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/220599 Reviewed-by: KC Naegle <knaegle@instructure.com> Tested-by: Jenkins Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-12-13 04:32:11 +08:00
"webpack:analyze": "echo 'if you get any errors here, make sure you have ran `rake canvas:compile_assets` first' && NODE_ENV=production SKIP_SOURCEMAPS=1 node --max_old_space_size=8096 $(yarn bin)/webpack --json > stats-prod.json && NODE_OPTIONS=\"--max_old_space_size=8192\" npx webpack-bundle-analyzer stats-prod.json public/dist/webpack-production",
Support i18n numbers on quizzes edit page Test Plan: - Given a quiz in a locale with different number formatting - Change the points of a question to '1234.5' in that locale - See it accept and format points correctly on the question and the header Closes QO-442 Change-Id: I75c353716718377bb26c1088a4db58aaa7c8f721 Reviewed-on: https://gerrit.instructure.com/198543 Tested-by: Jenkins Reviewed-by: Jonathan Holt <jholt@instructure.com> QA-Review: David Tan <dtan@instructure.com> Product-Review: Kevin Dougherty III <jdougherty@instructure.com>
2019-06-21 06:11:28 +08:00
"webpack": "gulp rev 1> /dev/null & NODE_OPTIONS=\"--max_old_space_size=8192\" webpack --progress --color --watch",
improve lint:browser-code debugging refs DE-465 Change-Id: I560c445ee7bd4b501686bb10bc4ffb64b4b910ad Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256692 Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com>
2021-01-14 07:49:14 +08:00
"webpack-development": "gulp rev 1> /dev/null & NODE_OPTIONS=\"--max_old_space_size=8192\" webpack --color",
"webpack-production": "NODE_ENV=production gulp rev && NODE_ENV=production NODE_OPTIONS=\"--max_old_space_size=8192\" webpack --color",
don't swallow stderr during build:packages flag = none stderr output of the individual processes fed to "wsrun" are being swallowed if it's running in --parallel and asked to --collect-logs see: https://github.com/hfour/wsrun/issues/107 see: https://github.com/hfour/wsrun/issues/92 == test plan grab the following image from starlord and verify you see the actual error output from the canvas-rce package: export IMAGE="starlord.inscloudgate.net/jenkins/canvas-lms:63.262363.4-postgres-12-ruby-2.6-failed" && docker pull "$IMAGE" && docker run \ -v "$PWD"/package.json:/usr/src/app/package.json:ro \ --rm -it \ "$IMAGE" \ yarn build:packages Change-Id: I7650e6b9b83bb22faea569eba05a9f73f5e72b4f Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262410 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Aaron Ogata <aogata@instructure.com> QA-Review: Ahmad Amireh <ahmad@instructure.com> Product-Review: Ahmad Amireh <ahmad@instructure.com>
2021-04-07 23:59:07 +08:00
"workspace-run": "r() { wsrun --fast-exit --exclude-missing --report -c $@; exit $?; } && r",
Bump wsrun to the latest version Test Plan: - All workspaces run their tests on jenkins Change-Id: I66fa941a11cdd6306a27b5a374af88755d593472 Reviewed-on: https://gerrit.instructure.com/188718 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2019-04-09 02:36:08 +08:00
"workspace-run-serial": "r() { wsrun --fast-exit --exclude-missing --collect-logs --report --serial -c $@; exit $?; } && r",
add npm script that can run specific js specs example usage: `npm run jspec spec/javascripts/jsx/files` refs CNVS-33223 test plan: - current webpack test build should work exactly the same - `npm run jspec` should build + run all specs - `npm run jspec path/to/stuff` should build + run only specified specs - should work with both directories and individual files - `jspec-watch` should watch + build a path, but not run specs Change-Id: I788dd38a6c69a4c36a1300fcecf43678bc7f5327 Reviewed-on: https://gerrit.instructure.com/94625 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Product-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> QA-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
2016-11-08 05:13:53 +08:00
"jspec": "./spec/jspec.sh",
spec: add aXe unit testing capability this patch updates the a11y helper, adds a new spec script to run, and adds aXe testing to discussion views test plan: - run the spec files edited in this patch normally with yarn run jspec-watch path/to/spec - tests should all pass as expected - run the spec files edited in this patch with the new command yarn run a11y-report path/to/spec - you should get aXe errors on existing a11y violations Change-Id: Ib3db892046e115bedb363752d1e56226eef893af Reviewed-on: https://gerrit.instructure.com/87962 Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com> Reviewed-by: Steven Burnett <sburnett@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Matt Berns <mberns@instructure.com> QA-Review: Matt Berns <mberns@instructure.com>
2016-08-17 05:30:29 +08:00
"jspec-watch": "./spec/jspec.sh --watch",
script to upgrade without adding dupes to yarn.lock because yarn is silly and frequently adds duplicate entries for things into yarn.lock when it could satisfy everything the app needs with one version; when you make any changes to package.json, run this script: `yarn upgrade-and-dedupe` to make sure that yarn.lock doesn't add needless duplicates of things. if yarn ever fixes this issue: https://github.com/yarnpkg/yarn/issues/579 then this can go away. test plan: 1. check this out 2. run `yarn upgrade-and-dedupe` 3. push the change that commit makes 4. it should pass jenkins and not introduce any errors Change-Id: I8c268cc4c7c6ac4474221ce65129a6ef8b261813 Reviewed-on: https://gerrit.instructure.com/142447 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-03-03 02:20:00 +08:00
"a11y-report": "./spec/jspec.sh --a11y",
A script to just update instUI Closes: CORE-1709 This is what our Jenkins job to pull in every instui RC commit will use Test plan: * run `yarn upgrade-instructure-ui` * it should make a commit that has new entries in yarn.lock for all the instUI packages that uses the latest rc version on the npm registry * it should not affect anything else besides yarn.lock Change-Id: I78cce6e801015819c4e4b27e26ede352deceebb9 Reviewed-on: https://gerrit.instructure.com/160435 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-08-11 00:22:49 +08:00
"upgrade-and-dedupe": "rm -rf yarn.lock node_modules && yes 1 | yarn install --flat --production --ignore-scripts && git checkout package.json && yarn install && git add yarn.lock",
update build to load es modules from subpackages closes LA-995 flag=none 1. unify the instui ui-babel-preset options across sub-packages 2. include "@instructure" as part of each sub-package name 3. unify the commonjs and es module directory structure 4. use index.js to export anything needed to be imported from outside the package. This removes any dependency on the package's internal directory structure and makes importing independent of commonjs vs es module simple 5. move canvas-rce's main entry from async.js to index.js (I'm 98% sure index.js was an artifact of the old rce) test plan: - canvas-lms builds locally and in docker. (Jenkins builds the docker image, so I presume if it passes jenkins, the docker build wasn't broken) - sniff test the result, esp. student planner and the new rce. - yarn build:watch from canvas-rce, canvas-planner, and canvas-media packages should work, and yarn build:watch from canvas-lms should pick-up any changes. (I've verified this by finding a console.log statement and changing the message then use devtools to see it's in the new source after refreshing the browser) Change-Id: I5f242d06ad655597cd416057d4b740d4bd86003b Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/238603 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Alex Anderson <raanderson@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2020-05-28 06:04:02 +08:00
"upgrade-instructure-ui": "script/upgrade-instructure-ui",
say PLEASE to npx when running yarn-deduplicate because simply asking it to run yarn-deduplicate is no longer good enough, you must now be polite when doing it[1]: To prevent security and user-experience problems from mistyping package names, npx prompts before installing anything. Suppress this prompt with the -y or --yes option. we will also be updating npm to the latest to catch such issues in the future == test plan running "rake canvas:compile_assets" using npm > 7 completes without hanging indefinitely at the "install dependencies" stage [1]: https://docs.npmjs.com/cli/v7/commands/npx#compatibility-with-older-npx-versions Change-Id: I81e044d20143991cf6103084f44ce8d4c9011f5b Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/259662 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Aaron Ogata <aogata@instructure.com> QA-Review: Ahmad Amireh <ahmad@instructure.com> Product-Review: Ahmad Amireh <ahmad@instructure.com>
2021-03-02 02:42:47 +08:00
"dedupe-yarn": "npx --yes yarn-deduplicate",
Introduce Storybook to Canvas + i18N Canvas Inbox fixes VICE-947 This story contains work to move Canvas Inbox and Storybook to `app/jsx` inside our Monolith. Storybook should now be enabled for all of `app/jsx` and works with our existing I18n code after updating webpack to load translations correctly. Test Plan 1. Install node modules with `yarn` 2. At Canvas-LMS root, run `yarn storybook` 3. Storybook should open, test that Canvas Inbox components work as expected Change-Id: Iccd2b103164a2da4e37b5746f4d9d2b5faf5f29d Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/253024 QA-Review: Davis Hyer <dhyer@instructure.com> Product-Review: Davis Hyer <dhyer@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Davis Hyer <dhyer@instructure.com>
2020-11-18 03:27:40 +08:00
"clean": "yarn workspace-run-serial clean",
Storybook config fixes closes MAT-65 flag=none - The update to package.json corrects a typo in the command line, line, plus adds a directory needed to load brandable_css - The instui babel presets in the new .babelrc.json file are needed if you want an RCE in storybook - The change to ENV in preview.js is needed if you want an RCE in storybook test plan: - storybook builds and everything still works - components are rendered using the Lato font family Change-Id: I04c45e4dc6bd853c3513ff689d63f6388d874ec1 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/263291 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com> QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com> Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
2021-04-21 05:46:42 +08:00
"storybook": "start-storybook -p 6006 --no-dll --static-dir ./public/javascripts,./public",
Add storyshots to storybook refs OUT-4237 flag=none Test-plan: > yarn install > yarn storybook - Look through outcomes stories in storybook quickly, verify everything loads > yarn test-storybook - Verify everything passes, if something doesn't pass, verify that that corresponding story is also broken in storybook > echo $? # should return 0 and jest results should say 0 failures - Change one of the stories so that it doesn't render, For example: undo the changes made to ManagementHeader.stories.js in tis PS > yarn test-storybook - Verify that it fails > echo $? # should return 1 and jest results should say 1+ failure(s) Change-Id: I492f50d861dccdfdf4a958fd007da44041f9dd49 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258297 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com> Reviewed-by: Michael Brewer-Davis <mbd@instructure.com> QA-Review: Pablo Gomez <pablo.gomez@instructure.com> Product-Review: Brian Watson <bwatson@instructure.com>
2021-02-06 07:39:54 +08:00
"test-storybook": "yarn jest --roots .storybook --testMatch **/storybook.test.js"
make it so it works with yarn 1.3.2 (frd) closes: CORE-675 test plan: * while running yarn 0.27, * run `yarn` * it should work and there should only be one jquery in node_modules * brew upgrade yarn (or whatever else you do to upgrade yarn to 1.3.2) * run `yarn` * it should not log any warning about unpacking jquery to the same location as something else * it should work and not make any changes to yarn.lock or node_modules * load the calendar page, there should not be any errors Change-Id: I08a1b8ceddf31cae59720270f870516ad213b87d Reviewed-on: https://gerrit.instructure.com/133548 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-11-22 07:09:15 +08:00
},
"resolutions": {
Point to instructure forks Closes: CCI-351 flag = none Test Plan: - no behavioral changes - build passes Change-Id: I2e6bfa46b56ee2b59b8289fc90ef9c319757fc34 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/235566 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: James Butters <jbutters@instructure.com> Reviewed-by: Jacob Powell <spowell@instructure.com> QA-Review: James Butters <jbutters@instructure.com> QA-Review: Jacob Powell <spowell@instructure.com> Product-Review: James Butters <jbutters@instructure.com>
2020-04-29 05:19:29 +08:00
"jquery": "https://github.com/instructure/jquery.git#1.7.2-with-AMD-and-CommonJS",
put accidentally deleted comments back in package.json Change-Id: I6b00f817afbf46c6cfa48ed0f389aede78c9c3f3 Reviewed-on: https://gerrit.instructure.com/163733 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-09-09 13:17:24 +08:00
"graphael": "this is just here so yarn.lock looks the same whether the analytics plugin is checked out or not",
deduplicate yarn.lock refs DE-397 De-duplicating yarn.lock is necessary for some future InstUI upgrade work. In order to do this, we need to patch karma-webpack to avoid watching too many files within our JS job. We also need to pin babel-plugin-dynamic-import-node to the latest to work around a breaking change that causes “request of a dependency is an expression”. Both of these version pins are work arounds and will be addressed by our efforts to upgrade webpack to v5. Test Plan: 1. Ensure that “yarn dedupe-yarn” does not produce any file changes. 2. Ensure that the “JS (Karma)” job does not produce any warnings like “request of a dependency is an expression” 3. Ensure that the “JS (Karma)” job does not produce any warnings like “System limit for number of file watchers reached” 4. Ensure that Canvas front-end builds & behaves properly Change-Id: I94d77bd775bc12f9f96ac44640c862ff3e3dee79 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256674 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Ahmad Amireh <ahmad@instructure.com> QA-Review: Ahmad Amireh <ahmad@instructure.com> Product-Review: Ahmad Amireh <ahmad@instructure.com>
2021-01-14 05:14:23 +08:00
"graphael": "https://github.com/instructure/graphael.git",
"babel-plugin-dynamic-import-node": "if we let this upgrade to recent versions, we hit https://github.com/babel/babel/issues/11607",
"babel-plugin-dynamic-import-node": "2.3.0"
AMD Conversion "Trivial" JavaScript / CoffeeScript changes -------------------------------------------------- For the most part, all javascript was simply wrapped in `require` or `define`. The dependencies were found with a script that matched regexes in the files, it errs on the side of listing too many dependencies, so its worth double checking each file's dependencies (over time, anyway). i18n API changes -------------------------------------------------- No longer have to do I18n.scoped calls, just list i18n as a dependency with the scope and it's imported already scoped require ['i18n!some_scope'], (I18n) -> I18n.t 'im_scoped', 'I'm scoped!' JS bundling now done with r.js, not Jammit -------------------------------------------------- We don't use jammit to bundle JS anymore. Simply list dependencies for your JS modules in the file and RequireJS handles the rest. To optimize the JavaScript, first make sure you have node.js 0.4.12+ installed and then run: $ rake js:build The app defaults to the optimized build in production. You can use non-optimized in production by putting ?debug_assets=true in the url just like before. You can also test the optimized JavaScript in development with ?optimized_js=true. Significant changes -------------------------------------------------- These files have "real" changes to them (unlike the JavaScript that is simply wrapped in require and define). Worth taking a really close look at: - app/helpers/application_helper.rb - app/views/layouts/application.html.erb - config/assets.yml - config/build.js - lib/handlebars/handlebars.rb - lib/i18n_extraction/js_extractor.rb - lib/tasks/canvas.rake - lib/tasks/i18n.rake - lib/tasks/js.rake Change-Id: I4bc5ecb1231f331aaded0fef2bcc1f3a9fe482a7 Reviewed-on: https://gerrit.instructure.com/6986 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Ryan Florence <ryanf@instructure.com>
2011-11-11 00:31:45 +08:00
}
maintain precision of grades in grade input fixes GRADE-1098 test plan: 1. Create an Assignment a. with Display Grade as Percentage b. worth 9.5 points 2. Open New Gradebook 3. Grade a student on this assignment twice a. once with 55 (interpreted as percentage) b. again with 55% (explicit percentage) 4. Verify grade is 55% 5. Verify score is 5.225 Change-Id: Ie48ec7d5b787e864bfd3379e8dc6a4dbebebc2e5 Reviewed-on: https://gerrit.instructure.com/148848 Tested-by: Jenkins Reviewed-by: Derek Bender <djbender@instructure.com> Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com> QA-Review: Shahbaz Javeed <sjaveed@instructure.com> Product-Review: Matt Goodwin <mattg@instructure.com>
2018-05-02 04:54:56 +08:00
}