ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/.i18nrc

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

10 lines
108 B
Plaintext
Raw Normal View History

upgrade to node 6 closes: CNVS-29725 this gets everything working on node 6. As far as our build process goes, it cannot support running on both node 6 at the same time as 0.12 since our i18nliner handlebars stuff uses jsdom and one version of it only works on node <4 and the next only works on 4+. But the stuff in the production dependencies in package.json, aka the stuff that runs on the job servers (brandable_css), can work on both. we just need to run npm rebuild on the job servers if the stuff that was npm installed into ./node_modules was compiled against a different version of node. that is done here: https://gerrit.instructure.com/81254 that commit needs to be committed to caturday before we commit and deploy this to beta as far as managing node, there are 2 "official" ways that will make you life easier, you can either just use docker or use nvm (https://github.com/creationix/nvm) if you use nvm and if you use ZSH: Put this into your $HOME/.zshrc to call nvm use automatically whenever you enter a directory that contains an .nvmrc file with a string telling nvm which node to use: # place this after nvm initialization! autoload -U add-zsh-hook load-nvmrc() { if [[ -f .nvmrc && -r .nvmrc ]]; then nvm use elif [[ $(nvm version) != $(nvm version default) ]]; then echo "Reverting to nvm default version" nvm use default fi } add-zsh-hook chpwd load-nvmrc load-nvmrc but however you do it, as long as you have node 6.2 installed it should work test plan: * install nvm * check this patchset out * run bundle exec rake canvas:compile_assets * it should work * use theme editor to preview a change to a theme * it should work Change-Id: I1cc9faed361938afc713c4b921042386b956db70 Reviewed-on: https://gerrit.instructure.com/80839 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2016-05-27 07:39:09 +08:00
{
"plugins": [
(i18n-js:4) use i18nliner-canvas from npm refs FOO-2801 flag = none [change-merged][build-registry-path=jenkins/canvas-lms/foo-2801] gems/canvas_i18nliner is now a package @instructure/i18nliner-canvas and lives in the same repo on github along with the 3 other i18nliner libraries.. this was done to make it easier for maintainers to deal with this code, since changing one part may break the other due to how they're architected the source on github: https://github.com/instructure/i18nliner-js ~ test plan ~ build is still OK, this only affects the generation of files, and those i manually verified to be identical before and after Change-Id: I78afa8a808f1699c10aced8466cfade066848bc9 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/294209 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Charley Kline <ckline@instructure.com> QA-Review: Charley Kline <ckline@instructure.com> Product-Review: Charley Kline <ckline@instructure.com>
2022-06-19 18:52:13 +08:00
"@instructure/i18nliner-canvas"
(re) decentralize i18nliner configuration refs FOO-1408 flag = none This reverts commit c904d83673e20d4018ba5e784486e67fee99791a. Original commit 9af1badd2fe0cd9de81cb8fed32a22558390c39a. I've also made an adjustment where you may only include a directory and not a specific file so that we don't make it possible to configure outside of an ".i18nrc" file (a measure to eliminate surprises that's all) before: { "include": [ "path/to/dir/.i18nrc" ] } now: { "include": [ "path/to/dir" ] } :: test plan run "rake canvas:compile_assets" and visit any page with JavaScript text, that text should display correctly Change-Id: I320ec4056270647835035f45501d310b18d9cb25 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258178 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Michael Ziwisky <mziwisky@instructure.com> QA-Review: Michael Ziwisky <mziwisky@instructure.com> Product-Review: Michael Ziwisky <mziwisky@instructure.com>
2021-02-02 03:59:28 +08:00
],
"include": [
"gems/plugins",
rename some things fixes FOO-1265 [skip-eslint=true] [pin-commit-analytics=7e49eefd7f59cbf43fd03bf8957bbbfa76f8d9d5] [pin-commit-demo_site=adade2e38e46a358a4643cd3db2fe5ccffe39ec5] [pin-commit-instructure_misc_plugin=47a3161102b0611af56d134fbd0c828ddc1b8abf] [pin-commit-migration_tool=0dbac2f5b421d894395605ce4b583ef0f7d60b22] [pin-commit-multiple_root_accounts=cc96d28c0d59bbe47acc64de4fdd8e1d2b029805] Change-Id: I14c07f20bd260cf0de1f48ceb70b3c2313edf2d2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258807 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Michael Ziwisky <mziwisky@instructure.com> QA-Review: Michael Ziwisky <mziwisky@instructure.com> Product-Review: Michael Ziwisky <mziwisky@instructure.com>
2021-04-06 07:44:00 +08:00
"ui"
upgrade to node 6 closes: CNVS-29725 this gets everything working on node 6. As far as our build process goes, it cannot support running on both node 6 at the same time as 0.12 since our i18nliner handlebars stuff uses jsdom and one version of it only works on node <4 and the next only works on 4+. But the stuff in the production dependencies in package.json, aka the stuff that runs on the job servers (brandable_css), can work on both. we just need to run npm rebuild on the job servers if the stuff that was npm installed into ./node_modules was compiled against a different version of node. that is done here: https://gerrit.instructure.com/81254 that commit needs to be committed to caturday before we commit and deploy this to beta as far as managing node, there are 2 "official" ways that will make you life easier, you can either just use docker or use nvm (https://github.com/creationix/nvm) if you use nvm and if you use ZSH: Put this into your $HOME/.zshrc to call nvm use automatically whenever you enter a directory that contains an .nvmrc file with a string telling nvm which node to use: # place this after nvm initialization! autoload -U add-zsh-hook load-nvmrc() { if [[ -f .nvmrc && -r .nvmrc ]]; then nvm use elif [[ $(nvm version) != $(nvm version default) ]]; then echo "Reverting to nvm default version" nvm use default fi } add-zsh-hook chpwd load-nvmrc load-nvmrc but however you do it, as long as you have node 6.2 installed it should work test plan: * install nvm * check this patchset out * run bundle exec rake canvas:compile_assets * it should work * use theme editor to preview a change to a theme * it should work Change-Id: I1cc9faed361938afc713c4b921042386b956db70 Reviewed-on: https://gerrit.instructure.com/80839 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2016-05-27 07:39:09 +08:00
]
}