ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/package.json

127 lines
4.2 KiB
JSON
Raw Normal View History

AMD Conversion "Trivial" JavaScript / CoffeeScript changes -------------------------------------------------- For the most part, all javascript was simply wrapped in `require` or `define`. The dependencies were found with a script that matched regexes in the files, it errs on the side of listing too many dependencies, so its worth double checking each file's dependencies (over time, anyway). i18n API changes -------------------------------------------------- No longer have to do I18n.scoped calls, just list i18n as a dependency with the scope and it's imported already scoped require ['i18n!some_scope'], (I18n) -> I18n.t 'im_scoped', 'I'm scoped!' JS bundling now done with r.js, not Jammit -------------------------------------------------- We don't use jammit to bundle JS anymore. Simply list dependencies for your JS modules in the file and RequireJS handles the rest. To optimize the JavaScript, first make sure you have node.js 0.4.12+ installed and then run: $ rake js:build The app defaults to the optimized build in production. You can use non-optimized in production by putting ?debug_assets=true in the url just like before. You can also test the optimized JavaScript in development with ?optimized_js=true. Significant changes -------------------------------------------------- These files have "real" changes to them (unlike the JavaScript that is simply wrapped in require and define). Worth taking a really close look at: - app/helpers/application_helper.rb - app/views/layouts/application.html.erb - config/assets.yml - config/build.js - lib/handlebars/handlebars.rb - lib/i18n_extraction/js_extractor.rb - lib/tasks/canvas.rake - lib/tasks/i18n.rake - lib/tasks/js.rake Change-Id: I4bc5ecb1231f331aaded0fef2bcc1f3a9fe482a7 Reviewed-on: https://gerrit.instructure.com/6986 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Ryan Florence <ryanf@instructure.com>
2011-11-11 00:31:45 +08:00
{
"name": "canvas-lms",
upgrade karma everyone was getting build errors when they were npm install'ing. it was because karma 0.10 depended on an out-of-date version of chokiadr that does not compile against node 0.12 I also indicated that canvas is licenced agpl 3 so that you wouldn't always see an npm warning about not having one. also, let karma serve our css files so if any javascript references them in our quit tests, we don't see 404 warnings Change-Id: Iaa0377bc87b8f7ec8726d6cb82c0f8a103134b56 Reviewed-on: https://gerrit.instructure.com/58584 Tested-by: Jenkins Reviewed-by: Mike Nomitch <mnomitch@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2015-07-16 12:24:49 +08:00
"license": "AGPL-3.0",
AMD Conversion "Trivial" JavaScript / CoffeeScript changes -------------------------------------------------- For the most part, all javascript was simply wrapped in `require` or `define`. The dependencies were found with a script that matched regexes in the files, it errs on the side of listing too many dependencies, so its worth double checking each file's dependencies (over time, anyway). i18n API changes -------------------------------------------------- No longer have to do I18n.scoped calls, just list i18n as a dependency with the scope and it's imported already scoped require ['i18n!some_scope'], (I18n) -> I18n.t 'im_scoped', 'I'm scoped!' JS bundling now done with r.js, not Jammit -------------------------------------------------- We don't use jammit to bundle JS anymore. Simply list dependencies for your JS modules in the file and RequireJS handles the rest. To optimize the JavaScript, first make sure you have node.js 0.4.12+ installed and then run: $ rake js:build The app defaults to the optimized build in production. You can use non-optimized in production by putting ?debug_assets=true in the url just like before. You can also test the optimized JavaScript in development with ?optimized_js=true. Significant changes -------------------------------------------------- These files have "real" changes to them (unlike the JavaScript that is simply wrapped in require and define). Worth taking a really close look at: - app/helpers/application_helper.rb - app/views/layouts/application.html.erb - config/assets.yml - config/build.js - lib/handlebars/handlebars.rb - lib/i18n_extraction/js_extractor.rb - lib/tasks/canvas.rake - lib/tasks/i18n.rake - lib/tasks/js.rake Change-Id: I4bc5ecb1231f331aaded0fef2bcc1f3a9fe482a7 Reviewed-on: https://gerrit.instructure.com/6986 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Ryan Florence <ryanf@instructure.com>
2011-11-11 00:31:45 +08:00
"version": "0.0.0",
upgrade karma everyone was getting build errors when they were npm install'ing. it was because karma 0.10 depended on an out-of-date version of chokiadr that does not compile against node 0.12 I also indicated that canvas is licenced agpl 3 so that you wouldn't always see an npm warning about not having one. also, let karma serve our css files so if any javascript references them in our quit tests, we don't see 404 warnings Change-Id: Iaa0377bc87b8f7ec8726d6cb82c0f8a103134b56 Reviewed-on: https://gerrit.instructure.com/58584 Tested-by: Jenkins Reviewed-by: Mike Nomitch <mnomitch@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2015-07-16 12:24:49 +08:00
"engines": {
Remove RequireJS support closes: CNVS-31785 test plan: all builds should pass Change-Id: I2925934692a3d2f115f1289d7b50cb72d8cb907f Reviewed-on: https://gerrit.instructure.com/104492 Reviewed-by: Jon Jensen <jon@instructure.com> Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2017-03-09 04:58:38 +08:00
"node": ">=6.9.5"
upgrade karma everyone was getting build errors when they were npm install'ing. it was because karma 0.10 depended on an out-of-date version of chokiadr that does not compile against node 0.12 I also indicated that canvas is licenced agpl 3 so that you wouldn't always see an npm warning about not having one. also, let karma serve our css files so if any javascript references them in our quit tests, we don't see 404 warnings Change-Id: Iaa0377bc87b8f7ec8726d6cb82c0f8a103134b56 Reviewed-on: https://gerrit.instructure.com/58584 Tested-by: Jenkins Reviewed-by: Mike Nomitch <mnomitch@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2015-07-16 12:24:49 +08:00
},
move napa from "devDependencies" to "dependencies" Change-Id: I4dde9458868cd5c1c41b921414dff4b3dc9371de Reviewed-on: https://gerrit.instructure.com/29878 Reviewed-by: Simon Williams <simon@instructure.com> Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> Tested-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
2014-02-11 02:29:11 +08:00
"dependencies": {
Upgrade brandable_css fixes: CNVS-35414 the actual changes are here: https://github.com/ryankshaw/brandable_css/commit/1fa1c2bc10c Test plan: Before checking this out, run: rm -rf public/dist/brandable_css RAILS_ENV=production node_modules/.bin/brandable_css rm public/dist/brandable_css/brandable_css_* cd public/dist/brandable_css/ git init . git add . git commit -am “original” cd ../../.. Check this out, then run: yarn install RAILS_ENV=production node_modules/.bin/brandable_css rm public/dist/brandable_css/brandable_css_* cd public/dist/brandable_css git diff There should be no difference to test the S3 stuff still works: * set up your config/cavnas_cdn.yml file with a valid s3 bucket * run `brandable_css` * pull up a canvas page. * the css should show up right and should be coming from your cloudfront url Change-Id: Iee1a7a916c3f17341adf513c2981b018420f7c16 Reviewed-on: https://gerrit.instructure.com/104016 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-03-04 08:20:36 +08:00
"brandable_css": "0.0.68",
Update webzip export version to 1.0 closes OFFW-179 Change-Id: I30ade8c7931b3ae49fbbb01b2ef3fa199cd8d065 Reviewed-on: https://gerrit.instructure.com/106770 Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com> Tested-by: Jenkins Product-Review: Mysti Sadler <mysti@instructure.com> QA-Review: Mysti Sadler <mysti@instructure.com>
2017-03-29 23:54:28 +08:00
"canvas_offline_course_viewer": "https://github.com/instructure/canvas_offline_course_viewer.git#1.0.0",
use node_modules wherever possible closes: CNVS-31787 the only things left in bower are things that are just not avalable on npm because they are so old. we'll have to continue using the bower versions of them, but it's ok since they are mostly old ember stuff that will be ripped out when we finish our react screenreader gradebook also: remove some ember stuff that wasn't being used anymore. nothing was using this stuff test plan: this really does touch a lot of stuff. some things to check out specifically in the prod/optimized requireJS build: (load the page, click around to make sure things work) the screenreader gradebook client_apps: quiz statistics quiz event logging creating a new student group calendar, try all the views (month/agenda/etc) gradebook 2 turn on the new course/user search feature for your account and go to accounts/x and search for a user/course the new react gradebook use tinymce on a page, make sure that both the service and local version of it work Change-Id: I4322a154d289760ab51b92e34dd7fac808b41ba8 Reviewed-on: https://gerrit.instructure.com/93102 Tested-by: Jenkins QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2016-10-19 01:11:26 +08:00
"fullcalendar": "https://github.com/ryankshaw/fullcalendar.git#aa686b36d10cee1e1e3ec7c7784145e46667d47d",
Put proper icons in new user tutorials This upgrades inst-icons to 1.2.1 closes FALCOR-107 Test Plan: - Enable new user tutorials - Go to a course - The expand icon in the top right should be a |<- - When you open it, the collapse icon should be a ->| Change-Id: Ice6faf1d0762e495d923fd8305ef56be2f268355 Reviewed-on: https://gerrit.instructure.com/102735 Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins
2017-02-21 23:49:14 +08:00
"instructure-icons": "1.2.1",
upgrade instructure-ui to 1.3.1 test plan * Specs should pass * Load up gradebook and everything should work Change-Id: I5734e9262244154c495725f89d92841547aba473 Reviewed-on: https://gerrit.instructure.com/106662 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Jennifer Stern <jstern@instructure.com> Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Product-Review: Shahbaz Javeed <sjaveed@instructure.com> QA-Review: Shahbaz Javeed <sjaveed@instructure.com>
2017-03-29 05:04:06 +08:00
"instructure-ui": "1.3.1",
use node_modules wherever possible closes: CNVS-31787 the only things left in bower are things that are just not avalable on npm because they are so old. we'll have to continue using the bower versions of them, but it's ok since they are mostly old ember stuff that will be ripped out when we finish our react screenreader gradebook also: remove some ember stuff that wasn't being used anymore. nothing was using this stuff test plan: this really does touch a lot of stuff. some things to check out specifically in the prod/optimized requireJS build: (load the page, click around to make sure things work) the screenreader gradebook client_apps: quiz statistics quiz event logging creating a new student group calendar, try all the views (month/agenda/etc) gradebook 2 turn on the new course/user search feature for your account and go to accounts/x and search for a user/course the new react gradebook use tinymce on a page, make sure that both the service and local version of it work Change-Id: I4322a154d289760ab51b92e34dd7fac808b41ba8 Reviewed-on: https://gerrit.instructure.com/93102 Tested-by: Jenkins QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2016-10-19 01:11:26 +08:00
"tinymce": "4.1.9"
move napa from "devDependencies" to "dependencies" Change-Id: I4dde9458868cd5c1c41b921414dff4b3dc9371de Reviewed-on: https://gerrit.instructure.com/29878 Reviewed-by: Simon Williams <simon@instructure.com> Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> Tested-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
2014-02-11 02:29:11 +08:00
},
AMD Conversion "Trivial" JavaScript / CoffeeScript changes -------------------------------------------------- For the most part, all javascript was simply wrapped in `require` or `define`. The dependencies were found with a script that matched regexes in the files, it errs on the side of listing too many dependencies, so its worth double checking each file's dependencies (over time, anyway). i18n API changes -------------------------------------------------- No longer have to do I18n.scoped calls, just list i18n as a dependency with the scope and it's imported already scoped require ['i18n!some_scope'], (I18n) -> I18n.t 'im_scoped', 'I'm scoped!' JS bundling now done with r.js, not Jammit -------------------------------------------------- We don't use jammit to bundle JS anymore. Simply list dependencies for your JS modules in the file and RequireJS handles the rest. To optimize the JavaScript, first make sure you have node.js 0.4.12+ installed and then run: $ rake js:build The app defaults to the optimized build in production. You can use non-optimized in production by putting ?debug_assets=true in the url just like before. You can also test the optimized JavaScript in development with ?optimized_js=true. Significant changes -------------------------------------------------- These files have "real" changes to them (unlike the JavaScript that is simply wrapped in require and define). Worth taking a really close look at: - app/helpers/application_helper.rb - app/views/layouts/application.html.erb - config/assets.yml - config/build.js - lib/handlebars/handlebars.rb - lib/i18n_extraction/js_extractor.rb - lib/tasks/canvas.rake - lib/tasks/i18n.rake - lib/tasks/js.rake Change-Id: I4bc5ecb1231f331aaded0fef2bcc1f3a9fe482a7 Reviewed-on: https://gerrit.instructure.com/6986 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Ryan Florence <ryanf@instructure.com>
2011-11-11 00:31:45 +08:00
"devDependencies": {
‘require’ axe from node_modules Change-Id: I472dda47c01502785a4988aa8c6198e030832d36 Reviewed-on: https://gerrit.instructure.com/102168 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-02-14 07:54:30 +08:00
"axe-core": "2.1.7",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"axios": "0.15.2",
Bump Babel to version 6 closes CNVS-29019 closes gh-817 Test Plan: - bundle exec rake canvas:compile_assets should compile /app/jsx and /specs/javascripts/jsx properly - Automated tests should pass - Areas of Canvas that use JSX/ES6 should work properly such as Moderated Grading, Files, and the new Admin search page Change-Id: Ic2aefbe98dd65a9b38407a68dc569e19a9e300e2 Reviewed-on: https://gerrit.instructure.com/78232 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Heath Hales <hhales@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2016-07-09 00:16:46 +08:00
"babel-cli": "^6.10.1",
"babel-core": "^6.10.4",
Add eslint to Canvas Rollout plan for this: 1. Add necessary files and plugins to Canvas (this commit) - This will do nothing for many people, but those with eslint plugins in their editors will now start seeing linting stuff show up properly - These users can gradually add/remove rules as they see fit or where it makes sense. The default rule set is from Airbnb with a few minor modifications to make things less difficult with the current codebase. 2. Turn on warnings in the CI system (this commit + 1-2 months) - This would only apply to the diffs of new code - This will allow additional feedback from developers that don't already lint locally. Rules can be adjusted as seen fit. 3. Turn on failures in the CI system (this commit + 3-4 months) - Again this will be only for changed code, but at this point will start failing builds that don't follow the standards. - Changes to the rules can still be made here, but should be less frequent than those made in the previous 2 steps. closes CNVS-32987 Test Plan: - Running eslint locally works - Editors pick up linting errors when configured properly Change-Id: I93b7da735b96b472857120418c3c271a9ed6d429 Reviewed-on: https://gerrit.instructure.com/93969 Reviewed-by: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins Product-Review: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2016-10-29 05:58:10 +08:00
"babel-eslint": "^7.1.0",
Bump Babel to version 6 closes CNVS-29019 closes gh-817 Test Plan: - bundle exec rake canvas:compile_assets should compile /app/jsx and /specs/javascripts/jsx properly - Automated tests should pass - Areas of Canvas that use JSX/ES6 should work properly such as Moderated Grading, Files, and the new Admin search page Change-Id: Ic2aefbe98dd65a9b38407a68dc569e19a9e300e2 Reviewed-on: https://gerrit.instructure.com/78232 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Heath Hales <hhales@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2016-07-09 00:16:46 +08:00
"babel-loader": "^6.2.4",
"babel-plugin-add-module-exports": "0.2.1",
Strip out react propTypes in prod webpack build closes: CNVS-34774 I did this before with https://github.com/thejameskyle/babel-react-optimize but it had a few other transforms that were more complex that introduced an error in the compiled result. This enables just the propType transform from that test plan: * using webpack in prod mode * look at the javascript sources for some components, there shouldn’t be anything in there about PropTypes * the generated code should be smaller & run faster Change-Id: Idffd020c99e34fcd6fe29f916d0a8482e0d4e90d Reviewed-on: https://gerrit.instructure.com/104202 Tested-by: Jenkins Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-03-07 10:06:26 +08:00
"babel-plugin-transform-react-remove-prop-types": "0.3.2",
update some NPM packages test plan: * these are just spec things, if jenkins passes they should be fine Change-Id: I1628ee92f9ccad372692df5b5c599e093c561ca0 Reviewed-on: https://gerrit.instructure.com/101682 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins
2017-02-10 13:57:31 +08:00
"babel-polyfill": "6.22.0",
Bump Babel to version 6 closes CNVS-29019 closes gh-817 Test Plan: - bundle exec rake canvas:compile_assets should compile /app/jsx and /specs/javascripts/jsx properly - Automated tests should pass - Areas of Canvas that use JSX/ES6 should work properly such as Moderated Grading, Files, and the new Admin search page Change-Id: Ic2aefbe98dd65a9b38407a68dc569e19a9e300e2 Reviewed-on: https://gerrit.instructure.com/78232 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Heath Hales <hhales@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2016-07-09 00:16:46 +08:00
"babel-preset-es2015": "^6.9.0",
"babel-preset-react": "^6.11.1",
"babel-preset-stage-1": "^6.5.0",
Add babel-register plugin This prevents our gulpfile from printing out an error trying to require babel-register before falling back to babel-core/register. This is now possible because we are on Babel 6. closes gh-867 Test Plan: - Run compile assets - At the end during the 'rev' step, you should not see: ``` Failed to load external module babel-register Requiring external module babel-core/register ``` - Instead you should just see: ``` Requiring external module babel-register ``` Change-Id: I3168dbdfb733979e762537f40fdb96effbefa328 Reviewed-on: https://gerrit.instructure.com/85571 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2016-07-18 06:21:51 +08:00
"babel-register": "^6.9.0",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"backbone": "1.1.1",
"classnames": "~2.2.5",
use web pack closes CNVS-24124 makes working with web pack possible in canvas instead of require-js. See doc/working_with_webpack.md for instructions. TEST PLAN: Nothing should change in non-webpack'd behavior Things should mostly work when you use the USE_WEBPACK environment variable, but make sure to document and ticket things that don't Change-Id: I493a259a609e9e183950bc57aa5876df70108547 Reviewed-on: https://gerrit.instructure.com/64386 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-10-01 11:16:11 +08:00
"coffee-loader": "^0.7.2",
upgrade coffescript so we can use import/export Fixes: CNVS-35540 test plan: Since this upgrades the coffeescript compiler version, it changes the format of the code that it generates so it has the possibility to break things in a strange way if someone was doing something in a way that was not actually supposed to be supported as part of the coffeescript language spec or if we run into a weird edge case of the compiler doing one thing before but doing it in a way where our code breaks now. Having said that, since there is no specific place where we intended things to change: * automated specs should pass Change-Id: I0630c25db7f97e69675992bba2ebccfdaf918ed3 Reviewed-on: https://gerrit.instructure.com/104677 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-03-10 10:21:24 +08:00
"coffee-script": "1.12.2",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"color-slicer": "0.8.0",
polyfill Promise & a few other methods for ie11 closes: CNVS-31621 every other browser supports these features. this will just make it so we can count on things like Promise, Object.assign, [].includes etc (see FEATURES_TO_POLYFILL at the top of script/make-ie11-shim.js for full list) what do people think of this? what do you think of the approach, I don't want to include a polyfill in the common bundle and force every other browser to download this stuff they aren't going to need. but I still want it to be performant as possible for those using ie11 Is there anything else people think we should polyfill? the one I thought of is window.fetch, what do others think about that? test plan: * in ie11, load a page in canvas * open the IE developer console * type: Promise.resolve().then(function(){console.log('it works')}) * it should log 'it works' to the console * (that already works in other browsers, but you can check to make sure that it still does there too) Change-Id: Ie9c99a59631a13535903174a5e575427dbfeac4f Reviewed-on: https://gerrit.instructure.com/89626 Reviewed-by: Jennifer Stern <jstern@instructure.com> Tested-by: Jenkins QA-Review: August Thornton <august@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2016-09-03 07:12:39 +08:00
"core-js-builder": "^2.4.1",
Replace avatar image cropper with keyboard accessible one Fixes: CNVS-28306 Test Plan: - ensure Admin > <your account> > Settings > Enable Profiles and User Avatars are checked - navigate to Account > Profile - using keyboard: - TAB (displays "skip to main content") - ENTER (focuses on the main content of the profile page - TAB (focuses avatar image) - ENTER (displayes Select Profile Picture dialog) - TAB 4 times (focuses "choose a picture") - ENTER (displays system file open dialog) - Select a photo - The selected photo and crop-box are displayed and have focus - Use arrow keys to move the crop box around - Use shift-arrow keys to size the crop box - TAB twice to focus Save button - ENTER closes dialog - cropped image should be displayed on the profile page change history - added js spec for the cropper - fix require_js config for react-crop 2016-12-13 - changes needed after react-crop distribution changed - break CanvasCropper and CanvasCropperMaker into 2 files in response to code review 2016-12-16 - update the react-crop version - set a min size on the cropper (so it can't go negative) - update css so image won't overflow its box - address eslint warnings 2016-12-21 - fix merge conflict note: the .rb file change supports the build. there is no need for a corresponding spec Change-Id: I2b6dc165ed5dc2865f282c35018686dd820fea30 Reviewed-on: https://gerrit.instructure.com/97197 Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: David Tan <dtan@instructure.com> Product-Review: Chris Ward <cward@instructure.com> Tested-by: Jenkins
2016-12-10 00:05:18 +08:00
"css-loader": "0.26.1",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"d3": "3.4.1",
use web pack closes CNVS-24124 makes working with web pack possible in canvas instead of require-js. See doc/working_with_webpack.md for instructions. TEST PLAN: Nothing should change in non-webpack'd behavior Things should mostly work when you use the USE_WEBPACK environment variable, but make sure to document and ticket things that don't Change-Id: I493a259a609e9e183950bc57aa5876df70108547 Reviewed-on: https://gerrit.instructure.com/64386 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-10-01 11:16:11 +08:00
"ember-template-compiler": "^1.8.0",
update some NPM packages test plan: * these are just spec things, if jenkins passes they should be fine Change-Id: I1628ee92f9ccad372692df5b5c599e093c561ca0 Reviewed-on: https://gerrit.instructure.com/101682 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins
2017-02-10 13:57:31 +08:00
"enzyme": "2.7.1",
Update eslint/airbnb-eslint-config This also ignores the doc/ directory and should fix errors on Code Climate Test Plan: - Things work Change-Id: I5b970daf19a1cfbd4ff61bed07c4f85d6db31f8f Reviewed-on: https://gerrit.instructure.com/99888 Tested-by: Jenkins Reviewed-by: Cody Cutrer <cody@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2017-01-19 01:47:04 +08:00
"eslint": "^3.13.0",
"eslint-config-airbnb": "^14.0.0",
[eslint] Improve setup for different JS levels This makes it so eslint handles situations where we don't have ES2015+ available, while still allowing us to have our own common rules. Change-Id: I86b49a32433970afbcc48ef0f6fcdd7301795b63 Reviewed-on: https://gerrit.instructure.com/97872 Tested-by: Jenkins Reviewed-by: Dan Minkevitch <dan@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2016-12-17 07:08:07 +08:00
"eslint-config-airbnb-base": "^11.0.0",
update eslint deps in package.json test plan: * run node_modules/.bin/eslint app/jsx/*.jsx * it should work and have the same errors as before Change-Id: Id8dc82f975808c5a5ac1703f3e9e494e4b453d58 Reviewed-on: https://gerrit.instructure.com/98145 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2016-12-21 00:22:09 +08:00
"eslint-plugin-import": "^2.2.0",
Update eslint/airbnb-eslint-config This also ignores the doc/ directory and should fix errors on Code Climate Test Plan: - Things work Change-Id: I5b970daf19a1cfbd4ff61bed07c4f85d6db31f8f Reviewed-on: https://gerrit.instructure.com/99888 Tested-by: Jenkins Reviewed-by: Cody Cutrer <cody@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2017-01-19 01:47:04 +08:00
"eslint-plugin-jsx-a11y": "^3.0.2",
[eslint] add eslint-plugin-promise closes: CNVS-34124 These are it’s default rules: "rules": { "promise/always-return": "error", "promise/no-return-wrap": "error", "promise/param-names": "error", "promise/catch-or-return": "error", "promise/no-native": "off", "promise/no-nesting": "warn", "promise/no-promise-in-callback": "warn", "promise/no-callback-in-promise": "warn", "promise/avoid-new": "warn" } the only one I changed was set avoid-new to ignore because I have noticed that there was a few times where I really did need/want to make my own promise. I am open to debate on what others think though Test Plan: * the eslint errors on your code that uses promises should have the warnings you expect Change-Id: I46e5f2d1d2ded2dba1e5aeb2ebcf303bcd4c5981 Reviewed-on: https://gerrit.instructure.com/98201 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2016-12-21 05:29:07 +08:00
"eslint-plugin-promise": "^3.4.0",
Update eslint/airbnb-eslint-config This also ignores the doc/ directory and should fix errors on Code Climate Test Plan: - Things work Change-Id: I5b970daf19a1cfbd4ff61bed07c4f85d6db31f8f Reviewed-on: https://gerrit.instructure.com/99888 Tested-by: Jenkins Reviewed-by: Cody Cutrer <cody@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2017-01-19 01:47:04 +08:00
"eslint-plugin-react": "^6.9.0",
use web pack closes CNVS-24124 makes working with web pack possible in canvas instead of require-js. See doc/working_with_webpack.md for instructions. TEST PLAN: Nothing should change in non-webpack'd behavior Things should mostly work when you use the USE_WEBPACK environment variable, but make sure to document and ticket things that don't Change-Id: I493a259a609e9e183950bc57aa5876df70108547 Reviewed-on: https://gerrit.instructure.com/64386 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-10-01 11:16:11 +08:00
"exports-loader": "^0.6.2",
"expose-loader": "^0.7.0",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"fontfaceobserver": "^2.0.8",
update gglobby npm dep refs: CNVS-29725 test plan: * run `node script/xsslint.js` * it should work (this is ran by jenkins so reall if it passes, it is good) Change-Id: Ib9b68e486c32c91e3c430cea095a628daf51db2b Reviewed-on: https://gerrit.instructure.com/87181 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2016-08-09 07:39:19 +08:00
"gglobby": "0.0.3",
upgrade some npm deps to get ready for node 6 fixes: CNVS-30802 these are the npm deps I upgraded as part of my node 6 commit that should work fine on both node 0.12 and node 6. I am making this change as a separate commit so you can see exactly which ones only work on node 6 (or 0.12, or vise-versa) by looking at the package.json changes in the node 6 commit test plan: run npm install it should work Change-Id: I7fca4738ad3593caa7512ebb6be55866ea614af3 Reviewed-on: https://gerrit.instructure.com/87028 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ian Hoerner <ian@instructure.com>
2016-08-06 04:32:56 +08:00
"glob": "^7.0.3",
A new way of doing css/sass & New Canvas Theme Editor what this does: * Changes the way we generate css so we are able to generate custom css for people that use the theme editor. * Sets everything up so we can push all of our static assets (js, fonts, css, images, etc) to s3 pre-deploy and serve them from cloudfront. Yay! faster canvas for everyone! * as part of that, this enables the rails asset pipeline just so we can use it to put md5s in our urls. we don't use it for any of the coffeescript/sass/sprockets transformer stuff. * adds a new "Theme editor" functionality (only for people that have have the use-new-styles feature flag turned on) where an admin for an account can pick their own colors/images for all the users at their account/school. * when the user is done saving things in theme editor, it will, in a delayed job, generate all the css with against the variables that user specified and push it to s3 so it will be available to anyone else that requests it. (the delayed job will shell out to a node.js executable called `brandable_css`). * ability to pick an existing shared theme and to reset to blank theme. closes: CNVS-19685 * gets rid of jammit. test plan: (this is exaustive, so not every person has to do every step but we should make sure at least someone does each of these things. maybe as part of the review add a comment if you have done one of these bulletpoints) * before you check this out, compile all css and copy the public/stylsheets_compiled directory somewhere. after you check out this code and regenerate all the css. make sure there are no significant changes to the css output. (we updated the versions of node-sass and autoprefixer that we use so we want to make sure they don't change things in a way we weren't expecting) * make sure the way we load css for handlebars templates still works. eg: if there is a handlebars template at app/views/jst/some/template.handlebars if there is also a scss file at app/stylesheets/jst/some/template.scss then that stylesheet should get loaded when that template is rendered * check out the code and run migrations. browse around canvas, make sure css and js files load correctly as before. * cody, jacob, or someone on queso: look at the db migrations and make sure everything looks good and that I am handling sharding correctly. * verify that both rake canvas:compile_assets and guard, works as well as `node_modules/.bin/brandable_css` (note: if you have "node_modules/.bin" in your PATH (which you should), it will also work with just `brandable_css`) * verify that passing the --watch option to `.bin/node_modules/brandable_css` works and picks up changes to sass files, images, fonts, or any other resource that goes into a css file. and that it only recompiles the css files that actually depend on that file. * go to https://github.com/ryankshaw/brandable_css and check out the code there. that is what is actually doing the sass compiling * create a config/canvas_cdn.yml file and add aws access creds and an s3 bucket and cdn hostname (for testing, you can use the credentials for instructure_uploads_engineering from https://gollum.instructure.com/OtherServiceTestAccounts ). for a test cdn hostname you can use https://diu0rq5m1weh1.cloudfront.net. that is a cloudfront bucket I set up on my personal account that points to instructure_uploads_engineering * run rake canvas:compile_assets again, this time, at the end, you should see it run the assets:precompile task that puts md5s in filenames and, gzipps them, and copys them to public/assets. then you should see it run canvas:cdn:upload_to_s3 (look at log/development.log for progress), which pushes everything to s3. closes: CNVS-17333 CNVS-17430 CNVS-17337 * try out the theme editor: turn on new styles, go to accounts/x (where x is the @domain root acount you are testing from) and click the "theme editor" button on the right side of the page. that should take you to a page that has the ability to pick colors/images on the left side and preview your changes in an iframe on the right closes: CNVS-19360 CNVS-20551 * test the "preview", "save", "reset", and "choose existing" functionality closes: CNVS-17339 CNVS-17338 CNVS-19685 * make sure that the themeeditor works both if you have config/canvas_cdn.yml set up and enabled as well as if you don't. if it is enabled, you should see it push the css for just that new brand config to s3 when you hit preview, and the css should be accessible from the cdn you configured. Change-Id: Ie0a812d04f5eeb40e7df7e71941ff63ea51a4d22 Reviewed-on: https://gerrit.instructure.com/53873 Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> Reviewed-by: Jacob Fugal <jacob@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2015-02-12 03:51:05 +08:00
"gulp": "^3.9",
update some NPM packages test plan: * these are just spec things, if jenkins passes they should be fine Change-Id: I1628ee92f9ccad372692df5b5c599e093c561ca0 Reviewed-on: https://gerrit.instructure.com/101682 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins
2017-02-10 13:57:31 +08:00
"gulp-load-plugins": "^1.5.0",
upgrade some npm deps to get ready for node 6 fixes: CNVS-30802 these are the npm deps I upgraded as part of my node 6 commit that should work fine on both node 0.12 and node 6. I am making this change as a separate commit so you can see exactly which ones only work on node 6 (or 0.12, or vise-versa) by looking at the package.json changes in the node 6 commit test plan: run npm install it should work Change-Id: I7fca4738ad3593caa7512ebb6be55866ea614af3 Reviewed-on: https://gerrit.instructure.com/87028 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ian Hoerner <ian@instructure.com>
2016-08-06 04:32:56 +08:00
"gulp-rev": "^7.0.0",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"handlebars": "1.3.0",
use web pack closes CNVS-24124 makes working with web pack possible in canvas instead of require-js. See doc/working_with_webpack.md for instructions. TEST PLAN: Nothing should change in non-webpack'd behavior Things should mostly work when you use the USE_WEBPACK environment variable, but make sure to document and ticket things that don't Change-Id: I493a259a609e9e183950bc57aa5876df70108547 Reviewed-on: https://gerrit.instructure.com/64386 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-10-01 11:16:11 +08:00
"handlebars-loader": "^1.1.4",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"happypack": "^3.0.2",
"ic-ajax": "~2.0.1",
"ic-tabs": "0.1.3",
update build/tooling npm deps in package.json test plan: all the builds should pass Change-Id: I4b35fa25741f0cc065a2580ebfae164037986ce3 Reviewed-on: https://gerrit.instructure.com/98148 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2016-12-21 00:30:52 +08:00
"imports-loader": "0.7.0",
JS code coverage Fixes CNVS-30301 Test Plan: - Running the js tests locally should generate a folder called coverage-js with an index.html file that has the coverage information Change-Id: Ib57b40c60791324d0a1eafab4c541957a2c2e7e7 Reviewed-on: https://gerrit.instructure.com/84839 Reviewed-by: Landon Wilkins <lwilkins@instructure.com> Tested-by: Jenkins Product-Review: Steven Burnett <sburnett@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com>
2016-07-12 03:03:13 +08:00
"istanbul-instrumenter-loader": "0.2.0",
use web pack closes CNVS-24124 makes working with web pack possible in canvas instead of require-js. See doc/working_with_webpack.md for instructions. TEST PLAN: Nothing should change in non-webpack'd behavior Things should mostly work when you use the USE_WEBPACK environment variable, but make sure to document and ticket things that don't Change-Id: I493a259a609e9e183950bc57aa5876df70108547 Reviewed-on: https://gerrit.instructure.com/64386 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-10-01 11:16:11 +08:00
"json-loader": "^0.5.3",
web pack port of quiz statistics refs CNVS-25916 remove dynamic requirements for env configs, use separate jsx loader for client apps, update client app plugin to use old react version, rewrite selenium spec to be an integration test rather than executing arbitrary javascript, and MAJORLY refactor loading patterns of client apps to avoid sharing code with differences delineated by opaque require re-writes. Also moved some code that was in "common" client app but only used by one actual client app down into the app that uses it (simplifies dependency tracing). TEST PLAN: 1) make sure quiz statistics still works ok under require js build, no behavior should have changed 2) also make sure quiz log auding works under require-js Change-Id: I0e5ee3eda9da16e0ad48cf858761735c71df801c Reviewed-on: https://gerrit.instructure.com/69804 Tested-by: Jenkins Reviewed-by: Ryan Taylor <rtaylor@instructure.com> QA-Review: Michael Hargiss <mhargiss@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com>
2016-01-07 06:31:33 +08:00
"jsx-loader": "0.11.2",
update build/tooling npm deps in package.json test plan: all the builds should pass Change-Id: I4b35fa25741f0cc065a2580ebfae164037986ce3 Reviewed-on: https://gerrit.instructure.com/98148 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2016-12-21 00:30:52 +08:00
"karma": "1.3.0",
"karma-chrome-launcher": "^2.0.0",
upgrade some npm deps to get ready for node 6 fixes: CNVS-30802 these are the npm deps I upgraded as part of my node 6 commit that should work fine on both node 0.12 and node 6. I am making this change as a separate commit so you can see exactly which ones only work on node 6 (or 0.12, or vise-versa) by looking at the package.json changes in the node 6 commit test plan: run npm install it should work Change-Id: I7fca4738ad3593caa7512ebb6be55866ea614af3 Reviewed-on: https://gerrit.instructure.com/87028 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ian Hoerner <ian@instructure.com>
2016-08-06 04:32:56 +08:00
"karma-coverage": "1.1.1",
Make changes for node 12/iojs. This makes a number of changes to get the compilation compatible with node 12 and iojs. - removes loom (no longer used) - updates karma dependencies to more recent versions - minor css change to make sass compilation work with node-sass (lib-sass) test plan: - should be able to compile assets with node 12 and iojs - JS specs still pass Change-Id: Id4a0628ff0c6dd09e622d02329a4400d60459ec2 Reviewed-on: https://gerrit.instructure.com/49493 Tested-by: Jenkins Reviewed-by: Nick Houle <nhoule@instructure.com> Product-Review: Cameron Matheson <cameron@instructure.com> QA-Review: Cameron Matheson <cameron@instructure.com>
2015-02-26 06:28:11 +08:00
"karma-firework-reporter": "~0.2.4",
add phantom js support as an avenue for js test runs keep it commented for now to be optional Change-Id: I2b64b11aac72b6da74401e9c8391a844a620c387 Reviewed-on: https://gerrit.instructure.com/72407 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2016-03-02 08:09:15 +08:00
"karma-phantomjs-launcher": "^1.0.0",
upgrade to karma 1.1.1 this was a blocker for upgrading to node 6 since karma 0.x has a strict node version requirement of <=4, so it would not work on node 6 (although, ironically, if you forced it it would still work) closes: CNVS-30308 test plan: * run `npm install && bundle exec rake js:test` * it should work * the jenkins builds should all work Change-Id: Ifd9ae12347d7901cf2bafee110230699987b2511 Reviewed-on: https://gerrit.instructure.com/84590 Tested-by: Jenkins Reviewed-by: Matthew Sessions <msessions@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2016-07-08 05:01:53 +08:00
"karma-qunit": "~1.1.0",
Make karma load source maps from non-karma generated sources When using webpack, we pack up everything outside of karma and assuming you've set webpack to generate source maps it doesn't actually use them. This makes it so that it does use them so output can be much better. Test Plan: - Have your environment set up to use webpack - Change webpack.test.config.babel.js:23 to be: testWebpackConfig.devtool = 'inline-source-map'; - Comment out lines 64-68 of the same file - Run npm run webpack-test-watch to bundle the tests - Run the specs (doc/testing_javascript.md) - Make a test fail... you should see a mapping from bundled test file to the actual file. Change-Id: I650fe995d6aa595d89da5ae614d5407a699e75ec Reviewed-on: https://gerrit.instructure.com/89822 Tested-by: Jenkins Reviewed-by: Joel Hough <joel@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2016-09-08 03:18:23 +08:00
"karma-sourcemap-loader": "^0.3.7",
eliminate the need to run karma & webpack separately TL;DR: running JS tests in canvas will be a lot faster & simpler What you need to know as a developer writing JS in canvas: Lets say you are working on the “dashboard_cards” feature, just run: `npm run jspec-watch spec/javascripts/jsx/dashboard_card` While you write code and it will have a watcher that catches any changes and re-runs just the dashboar_card specs if you save any file that went into it. It should run & reload in less than a few seconds. You can give it the path to a specific spec file or have it run an entire directory. Or, if you are working on something that might touch a lot of stuff, run: `npm run test-watch` and while you are changing stuff, it will run *all* the QUnit specs on any change. It should only take a couple seconds for webpack to process the file change and to reload the specs in the browser. Jenkins can now just run “npm test” for the webpack build. No need to bundle install then run rake tasks just to run js tests. This change also starts warning you when you have specs that take a long time to run (e.g.: https://cl.ly/2i1O3O0J1504). It turns out we have some *really* slow js specs (like selenium-level slow) so if you notice a slow spec that you our your team wrote, please fix it. Longer details: To test our JS in webpack, we used to 1. run webpack with an env var set so it only does our ember stuff 2. run karma against ember 3. run webpack again against all the rest of the specs canvas 4 run karma again against all the specs in canvas that took a long time. this change makes it so both the ember specs and the specs in the rest of canvas run all in the same karma. it also makes it so karma runs webpack itself. so you don’t need to run `npm run webpack-test && karma start` to run tests, just `npm run test` (which is just an alias to `karma start`). it also means there is now just one watcher (karma) instead of one for both webpack and karma. Closes: CNVS-34977 Test plan: * Jenkins builds should pass * Try running different variations of the commands up there in the description. They should work and be fast-ish. Change-Id: Ia97f9bfa3677763f218f5f02c9463344f180bc6c Reviewed-on: https://gerrit.instructure.com/102169 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-02-14 11:57:26 +08:00
"karma-verbose-reporter": "^0.0.5",
"karma-webpack": "^2.0.2",
use node_modules wherever possible closes: CNVS-31787 the only things left in bower are things that are just not avalable on npm because they are so old. we'll have to continue using the bower versions of them, but it's ok since they are mostly old ember stuff that will be ripped out when we finish our react screenreader gradebook also: remove some ember stuff that wasn't being used anymore. nothing was using this stuff test plan: this really does touch a lot of stuff. some things to check out specifically in the prod/optimized requireJS build: (load the page, click around to make sure things work) the screenreader gradebook client_apps: quiz statistics quiz event logging creating a new student group calendar, try all the views (month/agenda/etc) gradebook 2 turn on the new course/user search feature for your account and go to accounts/x and search for a user/course the new react gradebook use tinymce on a page, make sure that both the service and local version of it work Change-Id: I4322a154d289760ab51b92e34dd7fac808b41ba8 Reviewed-on: https://gerrit.instructure.com/93102 Tested-by: Jenkins QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2016-10-19 01:11:26 +08:00
"lodash": "4.16.4",
"moment": "~2.10.6",
Webpack: better handling of chunks and cdn stuff fixes: CNVS-31779 [webpack] bundle file size test plan: * using webpack, look at the network panel in the chrome developer console. * the total ammount of javascript loaded for any given page should be much less than before this commit and about on par with what requireJS loads for the same page. * use chrome network panel to throttle to "Regular 3G" * from both a clean cache and a primed cache: * make sure that the total time to render the page is about on par with requireJS first change: load webpack chunks from CDN fixes: CNVS-32261 test plan: * run `npm run webpack-production` * check your page, it should load js files and chunks from the same hostname the page is served from. * now set a host: in config/canvas_cdn.yml (for testing locally, I just set it to http://127.0.0.1:3000, * restart rails and reload the page, now the scripts and chucks should come from that new hostname second change:include fingerprints in webpack bundle and chunk filenames closes: CNVS-28628 with this change we don't need to run `gulp rev` after running webpack and we can load both the bundle and chunk files safely from the cdn, since they will have content-based fingerprints so we can tell browsers to cache them forever. (we set those http caching headers in lib/canvas/cdn/s3_uploader.rb:53) test plan: * for both dev and production * run `npm run webpack` (or `npm run wepack-production`) * with a cdn configured in canvas_cdn.yml, run: RAILS_ENV=<dev or prod> bundle exec rake canvas:cdn:upload_to_s3 * check to make sure that the page loads the webpack js, that there are no errors, and it all came from the cdn third change: properly handle moment locale & timezone in webpack test plan: (see application_helper_spec.rb) * set a non-default user timezone, context timezone and locale * dates should show up in your timezone and and the date helper strings should be in your language better handling of moment custom locales closes: CNVS-33811 since we now have hatian and maori, we need to do this in a way that is not just a one-off for maori test plan: * set your locale to maori * in webpack & requireJS make sure dates show up right Change-Id: I34dbff7d46a1047f9b459d5e1c0d141f435d42fb Reviewed-on: https://gerrit.instructure.com/95737 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2016-12-13 01:32:11 +08:00
"moxios": "^0.3.0",
use node_modules wherever possible closes: CNVS-31787 the only things left in bower are things that are just not avalable on npm because they are so old. we'll have to continue using the bower versions of them, but it's ok since they are mostly old ember stuff that will be ripped out when we finish our react screenreader gradebook also: remove some ember stuff that wasn't being used anymore. nothing was using this stuff test plan: this really does touch a lot of stuff. some things to check out specifically in the prod/optimized requireJS build: (load the page, click around to make sure things work) the screenreader gradebook client_apps: quiz statistics quiz event logging creating a new student group calendar, try all the views (month/agenda/etc) gradebook 2 turn on the new course/user search feature for your account and go to accounts/x and search for a user/course the new react gradebook use tinymce on a page, make sure that both the service and local version of it work Change-Id: I4322a154d289760ab51b92e34dd7fac808b41ba8 Reviewed-on: https://gerrit.instructure.com/93102 Tested-by: Jenkins QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2016-10-19 01:11:26 +08:00
"page": "visionmedia/page.js#1.6.4",
add js helper to parse number string for locale also includes a helper to validate number strings for current locale closes CNVS-33191 test plan: - NA (a future commit demonstrating the use of the helper with be qa-able) Change-Id: I1722aad263e611d127317b2f1a3832537742c3fb Reviewed-on: https://gerrit.instructure.com/96677 Reviewed-by: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2016-12-03 06:13:50 +08:00
"parse-decimal-number": "0.1.1",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"phantomjs-prebuilt": "^2.1.4",
use node_modules wherever possible closes: CNVS-31787 the only things left in bower are things that are just not avalable on npm because they are so old. we'll have to continue using the bower versions of them, but it's ok since they are mostly old ember stuff that will be ripped out when we finish our react screenreader gradebook also: remove some ember stuff that wasn't being used anymore. nothing was using this stuff test plan: this really does touch a lot of stuff. some things to check out specifically in the prod/optimized requireJS build: (load the page, click around to make sure things work) the screenreader gradebook client_apps: quiz statistics quiz event logging creating a new student group calendar, try all the views (month/agenda/etc) gradebook 2 turn on the new course/user search feature for your account and go to accounts/x and search for a user/course the new react gradebook use tinymce on a page, make sure that both the service and local version of it work Change-Id: I4322a154d289760ab51b92e34dd7fac808b41ba8 Reviewed-on: https://gerrit.instructure.com/93102 Tested-by: Jenkins QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2016-10-19 01:11:26 +08:00
"qs": "https://github.com/hapijs/qs.git#a341cdf2fadba5ede1ce6c95c7051f6f31f37b81",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"qunitjs": "^1.14.0",
use node_modules wherever possible closes: CNVS-31787 the only things left in bower are things that are just not avalable on npm because they are so old. we'll have to continue using the bower versions of them, but it's ok since they are mostly old ember stuff that will be ripped out when we finish our react screenreader gradebook also: remove some ember stuff that wasn't being used anymore. nothing was using this stuff test plan: this really does touch a lot of stuff. some things to check out specifically in the prod/optimized requireJS build: (load the page, click around to make sure things work) the screenreader gradebook client_apps: quiz statistics quiz event logging creating a new student group calendar, try all the views (month/agenda/etc) gradebook 2 turn on the new course/user search feature for your account and go to accounts/x and search for a user/course the new react gradebook use tinymce on a page, make sure that both the service and local version of it work Change-Id: I4322a154d289760ab51b92e34dd7fac808b41ba8 Reviewed-on: https://gerrit.instructure.com/93102 Tested-by: Jenkins QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2016-10-19 01:11:26 +08:00
"react": "0.14.8",
"react-addons-css-transition-group": "0.14.8",
"react-addons-pure-render-mixin": "0.14.8",
"react-addons-test-utils": "0.14.8",
"react-addons-update": "0.14.8",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"react-crop": "^4.0.2",
"react-dnd": "2.1.4",
"react-dnd-html5-backend": "2.1.2",
"react-dom": "0.14.8",
update fontfaceobserver & react-modal NPM packages closes: CNVS-34926 test plan: * go to a page that has a react modal (like theme editor), make sure it works * make sure the custom font that canvas uses loads correctly. Change-Id: I9c37ddfc6b3338e2ebaacb85cb8cdb81c7f9e21c Reviewed-on: https://gerrit.instructure.com/101681 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-02-10 13:56:58 +08:00
"react-modal": "1.6.5",
use node_modules wherever possible closes: CNVS-31787 the only things left in bower are things that are just not avalable on npm because they are so old. we'll have to continue using the bower versions of them, but it's ok since they are mostly old ember stuff that will be ripped out when we finish our react screenreader gradebook also: remove some ember stuff that wasn't being used anymore. nothing was using this stuff test plan: this really does touch a lot of stuff. some things to check out specifically in the prod/optimized requireJS build: (load the page, click around to make sure things work) the screenreader gradebook client_apps: quiz statistics quiz event logging creating a new student group calendar, try all the views (month/agenda/etc) gradebook 2 turn on the new course/user search feature for your account and go to accounts/x and search for a user/course the new react gradebook use tinymce on a page, make sure that both the service and local version of it work Change-Id: I4322a154d289760ab51b92e34dd7fac808b41ba8 Reviewed-on: https://gerrit.instructure.com/93102 Tested-by: Jenkins QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2016-10-19 01:11:26 +08:00
"react-redux": "4.4.5",
"react-select-box": "https://github.com/instructure-react/react-select-box.git#b1ddd39223d48793fbe3dc4e87aca00d57197b5f",
"react-tabs": "0.8.2",
fetch all pages of students for adhoc override fixes CNVS-28479 when a course has more than 200 students (so not all are prefetched) and an adhoc assignment override specifies more than a page size (default 10) of students, it's possible for some students in the override to be neither prefetched nor in the first page of results when fetched by ID. make sure to fetch all pages of results when fetched by ID. also make the 4 prefetch requests happen serially, and only once the user begins interacting with the component (hover or focus). this way we don't fetch more than we need to in small courses, and we don't fetch anything if the teacher isn't using this part of the UI (generally the case). this has the added benefit of speeding up selenium specs, as it has only one server thread and the `get` waits for all ajax requests to complete test-plan: part 1: - have a course with at least 201 students - have an assignment in that course with an override that specifies 11 students - have the 11th student specified for the override be the 201st student in the course - edit the assignment - confirm you see the name for the 201st student (11th in override) instead of "Loading..." part 2: - have a course with 51 students - go to edit a new assignment - confirm no /users ajax requests happen initially - focus the "Assign to" widget so you can manage overrides - confirm there are 2 ajax requests for /users - confirm you see 7 students in the dropdown (either immediately or with a very slight delay, depending on whether you clicked or tabbed into the widget) - confirm you can search for any of them without additional ajax requests Change-Id: I47ed202eb0d8ac1ad9e4ad21e50ceae930a6f3fe Reviewed-on: https://gerrit.instructure.com/106693 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Leo Abner <rabner@instructure.com> Product-Review: Jon Jensen <jon@instructure.com>
2017-03-29 05:25:49 +08:00
"react-tokeninput": "2.3.0",
use node_modules wherever possible closes: CNVS-31787 the only things left in bower are things that are just not avalable on npm because they are so old. we'll have to continue using the bower versions of them, but it's ok since they are mostly old ember stuff that will be ripped out when we finish our react screenreader gradebook also: remove some ember stuff that wasn't being used anymore. nothing was using this stuff test plan: this really does touch a lot of stuff. some things to check out specifically in the prod/optimized requireJS build: (load the page, click around to make sure things work) the screenreader gradebook client_apps: quiz statistics quiz event logging creating a new student group calendar, try all the views (month/agenda/etc) gradebook 2 turn on the new course/user search feature for your account and go to accounts/x and search for a user/course the new react gradebook use tinymce on a page, make sure that both the service and local version of it work Change-Id: I4322a154d289760ab51b92e34dd7fac808b41ba8 Reviewed-on: https://gerrit.instructure.com/93102 Tested-by: Jenkins QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2016-10-19 01:11:26 +08:00
"react-tray": "2.0.4",
"redux": "3.5.2",
"redux-actions": "0.11.0",
"redux-logger": "2.6.1",
"redux-thunk": "2.1.0",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"requirejs": "~2.2.0",
"script-loader": "^0.7.0",
upgrade sinon Change-Id: I4dfe355bbfe1f0de2fb5028b1d4b4b8443a69cc7 Reviewed-on: https://gerrit.instructure.com/108112 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Derek Bender <djbender@instructure.com> QA-Review: Derek Bender <djbender@instructure.com>
2017-04-11 05:43:40 +08:00
"sinon": "2.1.0",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"spin.js": "2.3.2",
"style-loader": "^0.13.1",
"stylelint": "7.8.0",
"timezone": "1.0.5",
"uglify-js": "~2.7.0",
"webpack": "2.2.1",
"webpack-manifest-plugin": "^1.0.1",
yarnify package.json Change-Id: I04b98d8911adcc7f391bdf9c904aee2650943bb9 Reviewed-on: https://gerrit.instructure.com/104966 Reviewed-by: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins
2017-03-14 06:48:24 +08:00
"webpack-parallel-uglify-plugin": "0.2.0",
"xsslint": "0.1.4"
clean up JS tests and integrate karma - js:generate_runner now generates common files to be used by different test runners - js spec file order now shuffled to better expose dependencies - fakeENV now returns two methods: setup and teardown - stock tinymce 3 files are now wrapped for AMD test plan: - tinymce should work the same - js:test rake task should run tests - js:build task should work as normal (using new location of r.js) - test results should successfully send to firework Change-Id: Ic09647f55dae57130fa0fe3d6a9168d2b67b89a2 Reviewed-on: https://gerrit.instructure.com/29297 QA-Review: Shawn Meredith <shawn@instructure.com> Tested-by: Shawn Meredith <shawn@instructure.com> Tested-by: Aaron Shafovaloff <ashafovaloff@instructure.com> Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
2014-01-24 23:58:37 +08:00
},
upgrade karma everyone was getting build errors when they were npm install'ing. it was because karma 0.10 depended on an out-of-date version of chokiadr that does not compile against node 0.12 I also indicated that canvas is licenced agpl 3 so that you wouldn't always see an npm warning about not having one. also, let karma serve our css files so if any javascript references them in our quit tests, we don't see 404 warnings Change-Id: Iaa0377bc87b8f7ec8726d6cb82c0f8a103134b56 Reviewed-on: https://gerrit.instructure.com/58584 Tested-by: Jenkins Reviewed-by: Mike Nomitch <mnomitch@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2015-07-16 12:24:49 +08:00
"repository": "instructure/canvas-lms",
clean up JS tests and integrate karma - js:generate_runner now generates common files to be used by different test runners - js spec file order now shuffled to better expose dependencies - fakeENV now returns two methods: setup and teardown - stock tinymce 3 files are now wrapped for AMD test plan: - tinymce should work the same - js:test rake task should run tests - js:build task should work as normal (using new location of r.js) - test results should successfully send to firework Change-Id: Ic09647f55dae57130fa0fe3d6a9168d2b67b89a2 Reviewed-on: https://gerrit.instructure.com/29297 QA-Review: Shawn Meredith <shawn@instructure.com> Tested-by: Shawn Meredith <shawn@instructure.com> Tested-by: Aaron Shafovaloff <ashafovaloff@instructure.com> Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
2014-01-24 23:58:37 +08:00
"scripts": {
spec: preserve stderr from the browser, refs SD-2148 test plan: 1. see previous patchset build where Xvfb was intentionally killed 2. note the `ERROR:browser_main_loop.cc(272)] Gtk: cannot open display: :20.0` Change-Id: Ia7bd7f82e85972c25fe7221cb2441473a3267936 Reviewed-on: https://gerrit.instructure.com/106517 Tested-by: Jenkins Reviewed-by: Landon Wilkins <lwilkins@instructure.com> Product-Review: Landon Wilkins <lwilkins@instructure.com> QA-Review: Landon Wilkins <lwilkins@instructure.com>
2017-03-28 05:49:39 +08:00
"test": "node -r ./karma.debugging.js node_modules/.bin/karma start --single-run",
eliminate the need to run karma & webpack separately TL;DR: running JS tests in canvas will be a lot faster & simpler What you need to know as a developer writing JS in canvas: Lets say you are working on the “dashboard_cards” feature, just run: `npm run jspec-watch spec/javascripts/jsx/dashboard_card` While you write code and it will have a watcher that catches any changes and re-runs just the dashboar_card specs if you save any file that went into it. It should run & reload in less than a few seconds. You can give it the path to a specific spec file or have it run an entire directory. Or, if you are working on something that might touch a lot of stuff, run: `npm run test-watch` and while you are changing stuff, it will run *all* the QUnit specs on any change. It should only take a couple seconds for webpack to process the file change and to reload the specs in the browser. Jenkins can now just run “npm test” for the webpack build. No need to bundle install then run rake tasks just to run js tests. This change also starts warning you when you have specs that take a long time to run (e.g.: https://cl.ly/2i1O3O0J1504). It turns out we have some *really* slow js specs (like selenium-level slow) so if you notice a slow spec that you our your team wrote, please fix it. Longer details: To test our JS in webpack, we used to 1. run webpack with an env var set so it only does our ember stuff 2. run karma against ember 3. run webpack again against all the rest of the specs canvas 4 run karma again against all the specs in canvas that took a long time. this change makes it so both the ember specs and the specs in the rest of canvas run all in the same karma. it also makes it so karma runs webpack itself. so you don’t need to run `npm run webpack-test && karma start` to run tests, just `npm run test` (which is just an alias to `karma start`). it also means there is now just one watcher (karma) instead of one for both webpack and karma. Closes: CNVS-34977 Test plan: * Jenkins builds should pass * Try running different variations of the commands up there in the description. They should work and be fast-ish. Change-Id: Ia97f9bfa3677763f218f5f02c9463344f180bc6c Reviewed-on: https://gerrit.instructure.com/102169 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-02-14 11:57:26 +08:00
"test-watch": "karma start",
i18nliner-js (part I) this swaps out our "parsing" with i18nliner-js also remove localization abilities of I18n.beforeLabel, since it's not worth the trouble to support. it can still be called to format a string. notable changes/fixes in generated yml: 1. client_apps are picked up by i18n:rake so they'll get translated... due to the old short-circuiting logic (`rc = rc && ...`), it would stop processing scripts within a particular file after the first one it found without an I18n.t 2. we no longer incorrectly double-escape special chars in our js strings (e.g. newlines are actually newlines, not a literal "\n") test plan: 1. verify string extraction: 1. `rake js:generate i18n:generate` before and after this commit 2. confirm `config/locales/generated/en.yml` is identical, except the notable changes/fixes listed above 2. verify js translation file generation: 1. `rake i18n:generate_js` before and after this commit 2. confirm the files in public/javascripts/translations are identical 3. verify client_app checker still works: 1. `cd client_apps/canvas_quiz_statistics/` 2. `grunt check_i18n` Change-Id: Ic8ad058bee1c9476f42916f10b612c1c08863fe3 Reviewed-on: https://gerrit.instructure.com/42809 Reviewed-by: Michael Ziwisky <mziwisky@instructure.com> Product-Review: Michael Ziwisky <mziwisky@instructure.com> QA-Review: Michael Ziwisky <mziwisky@instructure.com> Tested-by: Jenkins <jenkins@instructure.com>
2014-10-16 02:50:10 +08:00
"preinstall": "script/gem_npm install",
use web pack closes CNVS-24124 makes working with web pack possible in canvas instead of require-js. See doc/working_with_webpack.md for instructions. TEST PLAN: Nothing should change in non-webpack'd behavior Things should mostly work when you use the USE_WEBPACK environment variable, but make sure to document and ticket things that don't Change-Id: I493a259a609e9e183950bc57aa5876df70108547 Reviewed-on: https://gerrit.instructure.com/64386 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-10-01 11:16:11 +08:00
"preupdate": "script/gem_npm update",
eliminate the need to run karma & webpack separately TL;DR: running JS tests in canvas will be a lot faster & simpler What you need to know as a developer writing JS in canvas: Lets say you are working on the “dashboard_cards” feature, just run: `npm run jspec-watch spec/javascripts/jsx/dashboard_card` While you write code and it will have a watcher that catches any changes and re-runs just the dashboar_card specs if you save any file that went into it. It should run & reload in less than a few seconds. You can give it the path to a specific spec file or have it run an entire directory. Or, if you are working on something that might touch a lot of stuff, run: `npm run test-watch` and while you are changing stuff, it will run *all* the QUnit specs on any change. It should only take a couple seconds for webpack to process the file change and to reload the specs in the browser. Jenkins can now just run “npm test” for the webpack build. No need to bundle install then run rake tasks just to run js tests. This change also starts warning you when you have specs that take a long time to run (e.g.: https://cl.ly/2i1O3O0J1504). It turns out we have some *really* slow js specs (like selenium-level slow) so if you notice a slow spec that you our your team wrote, please fix it. Longer details: To test our JS in webpack, we used to 1. run webpack with an env var set so it only does our ember stuff 2. run karma against ember 3. run webpack again against all the rest of the specs canvas 4 run karma again against all the specs in canvas that took a long time. this change makes it so both the ember specs and the specs in the rest of canvas run all in the same karma. it also makes it so karma runs webpack itself. so you don’t need to run `npm run webpack-test && karma start` to run tests, just `npm run test` (which is just an alias to `karma start`). it also means there is now just one watcher (karma) instead of one for both webpack and karma. Closes: CNVS-34977 Test plan: * Jenkins builds should pass * Try running different variations of the commands up there in the description. They should work and be fast-ish. Change-Id: Ia97f9bfa3677763f218f5f02c9463344f180bc6c Reviewed-on: https://gerrit.instructure.com/102169 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-02-14 11:57:26 +08:00
"webpack": "gulp rev & webpack --progress --color --watch",
"webpack-development": "gulp rev & webpack --progress --color",
"webpack-stats": "webpack --profile --json",
"webpack-production": "gulp rev & webpack --progress --color --config webpack.production.config.js",
add npm script that can run specific js specs example usage: `npm run jspec spec/javascripts/jsx/files` refs CNVS-33223 test plan: - current webpack test build should work exactly the same - `npm run jspec` should build + run all specs - `npm run jspec path/to/stuff` should build + run only specified specs - should work with both directories and individual files - `jspec-watch` should watch + build a path, but not run specs Change-Id: I788dd38a6c69a4c36a1300fcecf43678bc7f5327 Reviewed-on: https://gerrit.instructure.com/94625 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Product-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> QA-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
2016-11-08 05:13:53 +08:00
"jspec": "./spec/jspec.sh",
"jspec-watch": "./spec/jspec.sh --watch"
AMD Conversion "Trivial" JavaScript / CoffeeScript changes -------------------------------------------------- For the most part, all javascript was simply wrapped in `require` or `define`. The dependencies were found with a script that matched regexes in the files, it errs on the side of listing too many dependencies, so its worth double checking each file's dependencies (over time, anyway). i18n API changes -------------------------------------------------- No longer have to do I18n.scoped calls, just list i18n as a dependency with the scope and it's imported already scoped require ['i18n!some_scope'], (I18n) -> I18n.t 'im_scoped', 'I'm scoped!' JS bundling now done with r.js, not Jammit -------------------------------------------------- We don't use jammit to bundle JS anymore. Simply list dependencies for your JS modules in the file and RequireJS handles the rest. To optimize the JavaScript, first make sure you have node.js 0.4.12+ installed and then run: $ rake js:build The app defaults to the optimized build in production. You can use non-optimized in production by putting ?debug_assets=true in the url just like before. You can also test the optimized JavaScript in development with ?optimized_js=true. Significant changes -------------------------------------------------- These files have "real" changes to them (unlike the JavaScript that is simply wrapped in require and define). Worth taking a really close look at: - app/helpers/application_helper.rb - app/views/layouts/application.html.erb - config/assets.yml - config/build.js - lib/handlebars/handlebars.rb - lib/i18n_extraction/js_extractor.rb - lib/tasks/canvas.rake - lib/tasks/i18n.rake - lib/tasks/js.rake Change-Id: I4bc5ecb1231f331aaded0fef2bcc1f3a9fe482a7 Reviewed-on: https://gerrit.instructure.com/6986 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Ryan Florence <ryanf@instructure.com>
2011-11-11 00:31:45 +08:00
}
}