ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/.eslintignore

14 lines
352 B
Plaintext
Raw Normal View History

modernize canvas_quizzes fixes FOO-1409 flag = none no more client_apps, canvas_quizzes now lives as part of canvas-lms proper inside app/jsx/, which makes the build leaner and leaves us with one less thing to reason about logical changes: - converted from AMD to ES modules - upgraded to recent react + react-router - dropped RSVP in favor of native Promises - used CanvasModal instead of home-grown Dialog - removed dead code; notifications in particular were fishy as there had no dependents at all and did not even show up in the graph - ported tests to Jest, added more unit ones and two integration ones - removed "config.onError" and now throws errors where appropriate - disabled console statements in non-dev :: test plan :: - create a (old-school) quiz containing all types of questions - as 3 distinct students, take the quiz and try to randomize your answers at this point it's helpful to have a reference to compare the screens; I replicated the quiz on my production sandbox for this - go to /courses/:id/quizzes/:id/submissions/:id/log - verify it looks OK - click on a specific question in the stream and verify the question inspector widget works OK - go back to stream and push "View table" - verify the table and its controls are OK - go to /courses/:id/quizzes/:id/statistics - verify it looks OK - click on ? in the discrimination index chart and verify it displays a dialog with help content - click on "X respondents" in one of the charts and verify it displays a dialog with the respondent names - verify the interactive charts do interact as expected (no logic changed here so just a quick glance) - link to "View in SpeedGrader" for essay-like questions works Change-Id: I79af5ff4f1479503b5e2528b613255dde5bc45d3 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256118 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com> Product-Review: Simon Williams <simon@instructure.com>
2021-01-02 07:58:12 +08:00
/app/jsx/canvas_quizzes/**/*.test.js
Run prettier and add in public/javascripts to prettier whitelist This also adds things in this directory to the whitelist to make sure nothing ugly gets introduced. Test Plan: - Automated tests pass - Make a non-pretty change in a js file within public/javascripts - Commit it - Notice it has been prettierfied refs COREFE-347 flag = none Change-Id: I554c5fd455ebc5690aa88b3b9858adbc11e2a966 Reviewed-on: https://gerrit.instructure.com/212575 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2019-10-09 22:04:45 +08:00
/gems/canvas_i18nliner/*
/doc/*
/public/javascripts/translations/*
/public/javascripts/vendor/*
/public/javascripts/bower/*
ESLint standardization This commit introduces a better more reasonable ESLint configuration. It removes all concerns with styling in favor of using prettier to handle those things. closes CORE-2096 Test Plan: - ESLint works Change-Id: I50b90b7191b576bce4817d885d14f18c4c72d208 Reviewed-on: https://gerrit.instructure.com/170874 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-11-03 01:48:59 +08:00
public/javascripts/react-dnd-test-backend.js
public/javascripts/mathquill.js
spec/selenium/helpers/jquery.simulate.js
spec/javascripts/support/jquery.mockjax.js
Run prettier on packages/ Test Plan: - Automated tests pass refs COREFE-347 flag = none Change-Id: I573a1dff4f90b0d68fee8d0f261b50a60c7a3fbb Reviewed-on: https://gerrit.instructure.com/212768 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2019-10-11 03:44:56 +08:00
packages/**/node_modules/**