ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/.rubocop.yml

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

472 lines
13 KiB
YAML
Raw Normal View History

rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
require:
- rubocop-rails
- rubocop-rake
- rubocop-rspec
- rubocop-performance
# this odd relative path is so that rubocop works when run without "bundle
# exec", such as from most editors/IDEs.
- ./gems/rubocop-canvas/lib/rubocop_canvas
- outrigger/cops/migration/tagged
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AllCops:
TargetRubyVersion: 2.7
NewCops: enable
deterministic described classes, refs SD-1969 This cop encourages explit require_dependency calls for ambiguous nested constants in specs. What does that mean? Consider: module Analytics describe Assignments do Depending on what has been required and/or autoloaded, `Assignments` could either resolve to `Analytics::Assignments`, or just the top-level `Assignments`. This is a cause of flickering failures and test-queue woes. This example should either have an explicit `require_dependency` call, or get rid of the module and just do `describe Analytics::Assignments`` Correct all existing ones in the codebase, except for a few ActiveRecord-related ones (the auto-correct isn't quite perfect, i.e. it assumes the file path will be `const_name.underscore`, which is no bueno for things like ActiveRecord::ConnectionAdapters::PostgreSQLAdapter) Test plan: n/a, specs Change-Id: Ic24bf3e0f547ca11c46887d4af92804da091912a Reviewed-on: https://gerrit.instructure.com/98752 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Jon Jensen <jon@instructure.com> QA-Review: Jon Jensen <jon@instructure.com>
2017-01-04 08:52:49 +08:00
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Bundler:
Severity: error
rubocop: split configuration * remove spurious .rubocop.yml override files * split the configuration into an enforced and optional * run both configurations in jenkins (may result in some duplicate comments at different levels) * auto-correct the enforced configuration in the pre-commit hook * fix comments for Gemfile.d and the root dir; enforced configuration is only applied to that directory for now Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 00:20:02 +08:00
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Gemspec:
Severity: error
Gemspec/RequiredRubyVersion:
# all the gemspecs in this repo are non-published gems
# the root Gemfile enforces the Ruby version, and we purposely
# don't specify required_ruby_version in the rest to reduce
# maintenance pain when updating ruby versions
Enabled: false
rubocop: split configuration * remove spurious .rubocop.yml override files * split the configuration into an enforced and optional * run both configurations in jenkins (may result in some duplicate comments at different levels) * auto-correct the enforced configuration in the pre-commit hook * fix comments for Gemfile.d and the root dir; enforced configuration is only applied to that directory for now Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 00:20:02 +08:00
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Layout:
Severity: error
rubocop: split configuration * remove spurious .rubocop.yml override files * split the configuration into an enforced and optional * run both configurations in jenkins (may result in some duplicate comments at different levels) * auto-correct the enforced configuration in the pre-commit hook * fix comments for Gemfile.d and the root dir; enforced configuration is only applied to that directory for now Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 00:20:02 +08:00
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Lint:
Severity: error
Lint/AmbiguousBlockAssociation:
IgnoredMethods:
- change
- not_change
- raise_error
Lint/NoFileUtilsRmRf:
Severity: warning # intended for specs; not enforced
Lint/NoSleep:
Severity: warning # intended for specs; not enforced
Lint/NonLocalExitFromIterator:
Enabled: false # SnR is too low because of how often this construct is used
rubocop: disable Lint/RedundantCopDisableDirective temporarily it's removing disable directives that need to be there Change-Id: Iecff7d5559742af834946a6d9223fd24634baa90 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279693 Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-30 00:01:47 +08:00
Lint/RedundantCopDisableDirective:
Enabled: false # can't have this enabled until https://github.com/rubocop/rubocop/issues/10263
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Lint/SafeNavigationConsistency:
Enabled: false # https://github.com/rubocop/rubocop/issues/9816
Lint/UnusedBlockArgument:
AutoCorrect: false # force the engineer to think about how come it's unused, instead of silently _ prefixing it
Lint/UnusedMethodArgument:
AllowUnusedKeywordArguments: true # there's no way to mark a kwarg as unused
AutoCorrect: false # force the engineer to think about how come it's unused, instead of silently _ prefixing it
rubocop: split configuration * remove spurious .rubocop.yml override files * split the configuration into an enforced and optional * run both configurations in jenkins (may result in some duplicate comments at different levels) * auto-correct the enforced configuration in the pre-commit hook * fix comments for Gemfile.d and the root dir; enforced configuration is only applied to that directory for now Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 00:20:02 +08:00
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Metrics:
Enabled: false # SnR is just too low to have this enabled
rubocop: go back to a single .rubocop.yml it was just too confusing on which one an editor is using, double comments in jenkins, etc. this is accomplished by several things: * required cops are just marked as severe, instead of using a separate config for them, and failing if anything shows up from that config * get rid of all the logic to only include certain directories for certain cops. turns out it's not _that_ ominous to correct errors across the entire repository before marking a cop as required. * but still auto-generate config to turn _off_ autocorrect for non-severe cops. this is important because auto-correct must run for entire files, and we don't want it auto-correcting optional things that you didn't touch. * update gergich to get more details from the parsed comments. this plus the prior point means we _don't_ have to have heavy mode when in autocorrecting, but we still display out-of-context lines that were autocorrected this also makes it so we can use per-dir .rubocop.yml files again, so take some of the exceptions out of the root and put them in their own directory Change-Id: Ie936d1a9920b68910acd250ba817c7b4a670b958 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274394 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-25 00:29:32 +08:00
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Migration/Tagged:
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AllowedTags:
- predeploy
- postdeploy
- cassandra
- dynamodb
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Naming:
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Severity: error
Naming/HeredocDelimiterNaming:
ForbiddenDelimiters:
# negative regex - these are the _allowed_ delimiters
# any you add should describe the format of the data, not describe
# what the data is for. this allows editors to syntax highlight
lint use of add_foreign_key test plan: - create a migration (locally) and add it to a commit (no need to actually commit, push, or even run the migration) that adds a foreign key to an existing table, e.g. add_foreign_key :users, :eportfolios - run script/rlint, and it should complain that you should use a non-transactional migration and add `delay_validation: true` to the arguments - do those things, run script/rlint again, and it should not complain - add a foreign key to a table created in the same migration, e.g. create_table :foo do |t| end add_foreign_key :foo, :bar - run script/rlint again, and it shouldn't complain flag=none closes DE-940 Change-Id: I3f235cbf1ff4011e20d74bdaa8953b857c7e330a Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/280514 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Isaac Moore <isaac.moore@instructure.com> QA-Review: Isaac Moore <isaac.moore@instructure.com> Product-Review: Jeremy Stanley <jeremy@instructure.com>
2021-12-07 08:13:15 +08:00
- ^(?!AST|BASE64|CSV|GQL|HTML|JS|MD|PEM|REGEX|RUBY|SQL|SRT|TEXT|XML|YAML|PATTERN).+$
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Performance:
Severity: error
Performance/Casecmp:
disable Performance/CaseCmp because it gives bad advice. `str.casecmp("foo").zero?` is not only less clear than `str.downcase == "foo"`, but it is not Unicode-aware (ironically, `str.casecmp?("foo")`, with the question mark, _is_ Unicode-aware) Change-Id: I1abd17f4a09b205073998c5cf9e89cb4bd85ad6b Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282294 Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Jeremy Stanley <jeremy@instructure.com> Product-Review: Jeremy Stanley <jeremy@instructure.com>
2022-01-07 06:24:29 +08:00
Enabled: false # casecmp(other).zero? is a bad suggestion because it's not Unicode-aware (also it's less clear)
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Performance/CollectionLiteralInLoop:
Severity: convention # not auto-correctable; can be a pain to fix and isn't necessarily performance critical
Performance/MethodObjectAsBlock:
Enabled: false # decreases expressiveness
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Rails:
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Severity: error
Rails/ApplicationRecord:
Enabled: false # we never bothered creating an ApplicationRecord
Rails/Blank:
UnlessPresent: false # allow `unless foo.present?`
Rails/ContentTag:
Exclude:
- "**/db/migrate/*" # this cop is for views, not migrations, where it gets confused with outrigger
- "doc/**/*"
Rails/DynamicFindBy:
AllowedMethods:
- find_by_confirmation_code # CommunicationChannel
- find_by_signature # AssetSignature
- find_by_domain # Account
- find_by_name # PluginSetting
- find_by_asset_string # ApplicationRecord
- find_by_pseudonym_credentials # SessionPersistenceToken
- find_by_quiz # Quizzes::OutstandingQuizSubmissionManager
Rails/HasManyOrHasOneDependent:
Enabled: false # legacy code + most things we soft delete anyway
Rails/HelperInstanceVariable:
Enabled: false # legacy code
Rails/NegateInclude:
Enabled: false # exclude? isn't as intuitive as !include?
Rails/Present:
UnlessBlank: false # allow `unless foo.blank?`
Rails/SkipsModelValidations:
Enabled: false # Canvas skips validations in many places for optimization reasons
Rails/WhereExists:
EnforcedStyle: where
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
RSpec:
Severity: error
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
RSpec/AnyInstance:
Enabled: false # while using an instance double would be preferable, it's a pain
RSpec/DescribedClass:
Enabled: false # we haven't used it, and it seems antithetical to RSpec/NamedSubject
RSpec/ExampleLength:
Enabled: false # this is a Metrics-style cop
RSpec/ExpectInHook:
Enabled: false # follows RSpec/MultipleExpectations
RSpec/InstanceVariable:
Enabled: false # legacy code
RSpec/MessageSpies:
Enabled: false # we don't use spies
RSpec/MultipleExpectations:
Enabled: false # we don't write specs in this style
RSpec/MultipleMemoizedHelpers:
Enabled: false # complicated setup is sometimes necessary
RSpec/NestedGroups:
Enabled: false # legacy code
RSpec/SubjectStub:
Enabled: false # yes, canvas is big and complicated sometimes
RSpec/StubbedMock:
Enabled: false # this style goes along with spies
RuboCop: RSpec/Rails/HttpStatus [skip-stages=Flakey] auto-corrected Change-Id: Ia1b3aabd3a12c3fe1fba7ccaf53e730791192626 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279436 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 06:15:50 +08:00
RSpec/Rails:
Severity: error
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Security:
Severity: error
Security/YAMLLoad:
# technically even YAML.load is fairly safe in Canvas because we override it and only allow certain types
# but still avoid it if you can.
Severity: warning
AutoCorrect: false
Specs/EnsureSpecExtension:
Exclude:
- spec/shared_examples/**/*
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Style:
Severity: error
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Style/Alias:
EnforcedStyle: prefer_alias_method # https://github.com/rubocop/ruby-style-guide/issues/821
Style/BlockDelimiters:
IgnoredMethods: []
Style/Documentation:
Enabled: false # most things don't need to be documented
Style/DoubleNegation:
Enabled: false # we use double negation, even outside of return context, to get an actual true/false for various API results
Style/EmptyElse:
EnforcedStyle: empty # explicit nil indicates programmer intent
Style/FloatDivision:
Enabled: false # inherently dangerous cop because the args may not even be integers, and only upside is maybe saving 4 characters
Style/FormatStringToken:
Enabled: false # I18n requires template style, but ohter code uses annotated style, and there are some trivial unannotted that don't really need to be annotated
rubocop: disable Style/HashLikeCase because this isn't even pointless pedantry. it's just pointless Change-Id: I7b8cd656a4adb8da3b5e30a59593297f91d9aa9a Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286846 Reviewed-by: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Jeremy Stanley <jeremy@instructure.com> Product-Review: Jeremy Stanley <jeremy@instructure.com>
2022-03-11 10:50:30 +08:00
Style/HashLikeCase:
Enabled: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Style/HashSyntax:
EnforcedStyle: ruby19_no_mixed_keys
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Style/IfUnlessModifier:
# see also https://github.com/rubocop/rubocop/discussions/10048
Enabled: false # can obscure important decisions or put too much code in a line
Style/MultilineBlockChain:
Enabled: false # this is common when building up a large API result
Style/NumericPredicate:
Enabled: false # `> 0` can be easier to read than `.positive?`
Style/ParallelAssignment:
Enabled: false # most uses are legitimate deconstruction or value swapping
Style/PercentQLiterals:
EnforcedStyle: upper_case_q
Style/PerlBackrefs:
Enabled: false # Regexp.last_match(1) is far worse than $1
Style/RescueStandardError:
EnforcedStyle: implicit
Style/ReturnNil:
Enabled: false # explicit nil is okay when a method is expected to have a return value
rubocop: reconfigure Style/SoleNestedConditional to allow the modifier form, e.g. this is okay if condition_a || condition_b do_something unless condition_c && condition_d end and is in fact preferable to if (condition_a || condition_b) && !(condition_c && condition_d) do_something end which is what rubocop would turn it into otherwise Change-Id: I1b917e3ea5149379f22e70294d263b713b3b9b35 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282475 Reviewed-by: Eric Saupe <eric.saupe@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Jeremy Stanley <jeremy@instructure.com> Product-Review: Jeremy Stanley <jeremy@instructure.com>
2022-01-11 06:31:48 +08:00
Style/SoleNestedConditional:
AllowModifier: true # it makes lines too long and complicated otherwise
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Style/SpecialGlobalVars:
Enabled: false # $! and $? are fine
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Style/StringLiterals:
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
EnforcedStyle: double_quotes
Style/StringLiteralsInInterpolation:
EnforcedStyle: double_quotes
Style/SymbolArray:
MinSize: 3
Style/TernaryParentheses:
EnforcedStyle: require_parentheses_when_complex
Style/WhileUntilModifier:
Enabled: false # nontrivial loops should look like loops
Style/WordArray:
MinSize: 3
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
# the following cops have offenses in the code base that have not been fixed.
# we should eventually either fix them, or turn them off completely (and move
# them to the section above)
# auto-correct needs to be disabled for any that support it in the meantime
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Layout/LineLength:
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Enabled: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
AutoCorrect: false
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Lint/UriEscapeUnescape:
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Severity: warning
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Naming/AccessorMethodName:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Naming/BinaryOperatorParameterName:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
AutoCorrect: false
Naming/BlockParameterName:
Severity: convention
Naming/ClassAndModuleCamelCase:
Severity: convention
Naming/ConstantName:
Severity: convention
Naming/FileName:
Severity: convention
Exclude:
- "**/Gemfile.d/~after.rb"
Naming/MemoizedInstanceVariableName:
Severity: convention
Naming/MethodName:
Severity: convention
Naming/MethodParameterName:
Severity: convention
Naming/PredicateName:
Severity: convention
Naming/VariableName:
Severity: convention
Naming/VariableNumber:
Enabled: false
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Rails/ActiveRecordCallbacksOrder:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Rails/ActiveRecordOverride:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Rails/ApplicationMailer:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
Rails/BelongsTo:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
AutoCorrect: false
Rails/BulkChangeTable:
Severity: convention
Rails/CreateTableWithTimestamps:
Severity: convention
Rails/Date:
Enabled: false
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
Rails/EagerEvaluationLogMessage:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
Rails/EnumHash:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
Rails/FindBy:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
Rails/FindById:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
Rails/FindEach:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
AutoCorrect: false
rubocop: add missing non-error cops Change-Id: I7691d98cb0f1a2d0452990c8e93968e950406c51 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279427 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 05:22:41 +08:00
Rails/I18nLocaleAssignment:
Severity: convention
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Rails/InverseOf:
Severity: convention
Rails/LexicallyScopedActionFilter:
Severity: convention
Rails/NotNullColumn:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Rails/Output:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Rails/OutputSafety:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Rails/Pick:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
Rails/PluckInWhere:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
Rails/RakeEnvironment:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
AutoCorrect: false
Rails/ReadWriteAttribute:
Enabled: false # accessors are often defined in terms of read_attribute
AutoCorrect: false
Rails/ReversibleMigration:
Severity: convention
Rails/TimeZone:
Enabled: false
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: add missing non-error cops Change-Id: I7691d98cb0f1a2d0452990c8e93968e950406c51 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279427 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 05:22:41 +08:00
Rails/TimeZoneAssignment:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Rake/Desc:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Rake/MethodDefinitionInTask:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
RSpec/Capybara/FeatureMethods:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
RSpec/AroundBlock:
Severity: convention
RSpec/Be:
Severity: convention
RSpec/BeEql:
Enabled: false
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
RSpec/BeforeAfterAll:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
RSpec/ContextMethod:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
RSpec/ContextWording:
Enabled: false
RSpec/DescribeClass:
Enabled: false
RSpec/DescribeMethod:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
RSpec/ExpectActual:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
RSpec/ExpectChange:
Enabled: false
AutoCorrect: false
RSpec/FilePath:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
RSpec/HooksBeforeExamples:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
RSpec/IdenticalEqualityAssertion:
Severity: convention
RSpec/ImplicitBlockExpectation:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
RSpec/ImplicitExpect:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
RSpec/IteratedExpectation:
Severity: convention
RSpec/LeakyConstantDeclaration:
Severity: convention
RSpec/LetSetup:
Severity: convention
RSpec/MessageChain:
Severity: convention
RSpec/MissingExampleGroupArgument:
Severity: convention
RSpec/MultipleDescribes:
Severity: convention
RSpec/NamedSubject:
Enabled: false
RSpec/NotToNot:
Enabled: false
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
RSpec/OverwritingSetup:
Severity: convention
RSpec/PredicateMatcher:
Enabled: false
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
RSpec/ReceiveCounts:
Severity: convention
AutoCorrect: false
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
RSpec/ReturnFromStub:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
RSpec/ScatteredLet:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
RSpec/ScatteredSetup:
Enabled: false
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
RSpec/SharedContext:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
RSpec/SubjectDeclaration:
Severity: convention
RSpec/VariableName:
Severity: convention
RSpec/VerifiedDoubles:
Enabled: false
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Style/AccessModifierDeclarations:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Style/AccessorGrouping:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: disable Style/CaseLikeIf seems overly pedantic Change-Id: Ibe3ccd76978650842dd09fd1232df5673e292d58 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287118 Reviewed-by: Jeremy Stanley <jeremy@instructure.com> QA-Review: Jeremy Stanley <jeremy@instructure.com> Product-Review: Jeremy Stanley <jeremy@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2022-03-15 23:02:48 +08:00
Style/CaseLikeIf:
Enabled: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Style/ClassAndModuleChildren:
Enabled: false
AutoCorrect: false
Style/ClassVars:
Severity: convention
Style/CombinableLoops:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Style/CommentedKeyword:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Style/DocumentDynamicEvalDefinition:
Severity: convention
Style/ExponentialNotation:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Style/FormatString:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Style/GlobalVars:
Severity: convention
Style/GuardClause:
Enabled: false
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Style/HashAsLastArrayItem:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
AutoCorrect: false
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Style/InfiniteLoop:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
Style/KeywordParametersOrder:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Style/MissingRespondToMissing:
Severity: convention
Style/MixinUsage:
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
Style/ModuleFunction:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
Style/MultipleComparison:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
AutoCorrect: false
Style/OptionalArguments:
Severity: convention
Style/OptionalBooleanParameter:
Severity: convention
Style/RescueModifier:
Severity: warning
AutoCorrect: false
Style/StringConcatenation:
Enabled: false
AutoCorrect: false
Style/TrailingCommaInArrayLiteral:
Enabled: false
AutoCorrect: false
Style/TrailingCommaInHashLiteral:
Enabled: false
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
Style/TrailingUnderscoreVariable:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false
Style/WhileUntilDo:
rubocop: default to error severity means we can remove a whole bunch of specific cop configurations that now inherit the proper settings. cops that still have violations need to be explicitly named to make them not error. this means that the list of remaining cops is explicitly in our config now. also combined the don't-auto-correct lists with the not-yet-fixed lists, so that it's only a "permanent" section and a "todo" section the final computed configuration is unchanged by this commit, with one exception - Bundler/OrderedGems was moved to the Gemfile.d/.rubocop.yml override, and some of the internal gems violated that so their gemfiles have been autocorrected Change-Id: I100884a96dbe9eb9d4bfc0692663c271daa9de16 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279413 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 01:10:12 +08:00
Severity: convention
rubocop: remove .rubocop.common.yml we're far enough along that the generated disablings are no longer useful Change-Id: Iec341384f7a5f6eeb42bad4ae1ea12f433d270a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279397 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Jacob Burroughs <jburroughs@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-24 00:16:53 +08:00
AutoCorrect: false