ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/spec/migrations/populate_conversation_root_...

85 lines
3.2 KiB
Ruby
Raw Normal View History

filter conversations while masquerading, fixes #7634 start tracking root_account_ids more consistently for messages, and aggregate them on the conversation. add a scope when masquerading such that conversations tied to other root accounts are hidden. a masquerader must have access to all root accounts a conversation belongs to in order to see it (unless the masquerader is a site admin) test plan: 1. enroll a user in courses under two different root accounts (let's call them accounts A and B) 2. as the user, log in under the account domain for A and send some messages 3. log in under the account domain for B and send some messages to the existing conversations, as well as to some new recipients 4. set up an account admin with access only to B 5. log in as the admin, and masquerade as the user 6. ensure you can only see conversations created under B (none of the ones that are solely A, or both A and B) 7. log in as a site admin, and masquerade as the user 8. ensure you can see conversations from both accounts Change-Id: I4a26b8b8914fd531103bb92c3d4442de843d9986 Reviewed-on: https://gerrit.instructure.com/9767 Reviewed-by: Jon Jensen <jon@instructure.com> Tested-by: Jon Jensen <jon@instructure.com>
2012-04-03 00:05:37 +08:00
#
# Copyright (C) 2011 Instructure, Inc.
#
# This file is part of Canvas.
#
# Canvas is free software: you can redistribute it and/or modify it under
# the terms of the GNU Affero General Public License as published by the Free
# Software Foundation, version 3 of the License.
#
# Canvas is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU Affero General Public License for more
# details.
#
# You should have received a copy of the GNU Affero General Public License along
# with this program. If not, see <http://www.gnu.org/licenses/>.
#
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb')
require 'db/migrate/20120402054921_populate_conversation_root_account_ids.rb'
1.9 spec fixes spec updates for 1.9 * fix a syntax error * update our html_escape backport so that rails 1.9 doesn't print constant warnings about using the "n" regex option with a utf-8 string (as a bonus this is also a lot more efficient) * fix using a migration class as a rspec describe context, because its method_missing prints the method name to console so we get a ton of "to_ary" etc printed * fix post header checks in spec/lib Change-Id: I634570e516252e9a2fbef9f13a55d1bae0a254cd Reviewed-on: https://gerrit.instructure.com/10856 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins <jenkins@instructure.com>
2012-05-18 10:51:27 +08:00
describe 'PopulateConversationRootAccountIds' do
filter conversations while masquerading, fixes #7634 start tracking root_account_ids more consistently for messages, and aggregate them on the conversation. add a scope when masquerading such that conversations tied to other root accounts are hidden. a masquerader must have access to all root accounts a conversation belongs to in order to see it (unless the masquerader is a site admin) test plan: 1. enroll a user in courses under two different root accounts (let's call them accounts A and B) 2. as the user, log in under the account domain for A and send some messages 3. log in under the account domain for B and send some messages to the existing conversations, as well as to some new recipients 4. set up an account admin with access only to B 5. log in as the admin, and masquerade as the user 6. ensure you can only see conversations created under B (none of the ones that are solely A, or both A and B) 7. log in as a site admin, and masquerade as the user 8. ensure you can see conversations from both accounts Change-Id: I4a26b8b8914fd531103bb92c3d4442de843d9986 Reviewed-on: https://gerrit.instructure.com/9767 Reviewed-by: Jon Jensen <jon@instructure.com> Tested-by: Jon Jensen <jon@instructure.com>
2012-04-03 00:05:37 +08:00
describe "up" do
it "should work" do
drop context_messages left over cruft from a very long time ago, in case we needed to revert stuff test plan: * smoke test conversations Change-Id: Ie222afc37dd17539e8e993857ed535c1bee4bade Reviewed-on: https://gerrit.instructure.com/17197 Tested-by: Jenkins <jenkins@instructure.com> Reviewed-by: Jon Jensen <jon@instructure.com> QA-Review: Clare Hetherington <clare@instructure.com>
2013-01-29 03:33:48 +08:00
pending "no longer possible since context_messages no longer exists"
filter conversations while masquerading, fixes #7634 start tracking root_account_ids more consistently for messages, and aggregate them on the conversation. add a scope when masquerading such that conversations tied to other root accounts are hidden. a masquerader must have access to all root accounts a conversation belongs to in order to see it (unless the masquerader is a site admin) test plan: 1. enroll a user in courses under two different root accounts (let's call them accounts A and B) 2. as the user, log in under the account domain for A and send some messages 3. log in under the account domain for B and send some messages to the existing conversations, as well as to some new recipients 4. set up an account admin with access only to B 5. log in as the admin, and masquerade as the user 6. ensure you can only see conversations created under B (none of the ones that are solely A, or both A and B) 7. log in as a site admin, and masquerade as the user 8. ensure you can see conversations from both accounts Change-Id: I4a26b8b8914fd531103bb92c3d4442de843d9986 Reviewed-on: https://gerrit.instructure.com/9767 Reviewed-by: Jon Jensen <jon@instructure.com> Tested-by: Jon Jensen <jon@instructure.com>
2012-04-03 00:05:37 +08:00
u = user
# messages w/ account contexts
u1 = user
a1a = Account.default
a1b = Account.create
Cross-shard conversations fixes CNVS-1171 test plan: * full conversations regression test * initiate a conversation with a user from another shard * reply to that conversation from both the sender and the receiver * repeat for a group conversation involving two or more shards * repeat for huge batch conversations with hundreds of users and two or more shards * known NOT working yet: * re-using the correct cross-shard private conversation * probably the tagging of messages with Course x, Group y, etc. Change-Id: I52549039875941cd518077cea4e28bfd2bc10dbf Reviewed-on: https://gerrit.instructure.com/16523 Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Clare Hetherington <clare@instructure.com> Tested-by: Jenkins <jenkins@instructure.com>
2012-11-29 06:53:00 +08:00
cn1 = Conversation.initiate([u, u1], true)
filter conversations while masquerading, fixes #7634 start tracking root_account_ids more consistently for messages, and aggregate them on the conversation. add a scope when masquerading such that conversations tied to other root accounts are hidden. a masquerader must have access to all root accounts a conversation belongs to in order to see it (unless the masquerader is a site admin) test plan: 1. enroll a user in courses under two different root accounts (let's call them accounts A and B) 2. as the user, log in under the account domain for A and send some messages 3. log in under the account domain for B and send some messages to the existing conversations, as well as to some new recipients 4. set up an account admin with access only to B 5. log in as the admin, and masquerade as the user 6. ensure you can only see conversations created under B (none of the ones that are solely A, or both A and B) 7. log in as a site admin, and masquerade as the user 8. ensure you can see conversations from both accounts Change-Id: I4a26b8b8914fd531103bb92c3d4442de843d9986 Reviewed-on: https://gerrit.instructure.com/9767 Reviewed-by: Jon Jensen <jon@instructure.com> Tested-by: Jon Jensen <jon@instructure.com>
2012-04-03 00:05:37 +08:00
cn1.add_message(u, "test1").update_attribute(:context, a1a)
cn1.add_message(u, "test2").update_attribute(:context, a1a)
cn1.add_message(u, "test3").update_attribute(:context, a1b)
cn1.root_account_ids.should eql []
# context message on course
u2 = user
a2 = Account.create
c2 = course(:account => a2)
Cross-shard conversations fixes CNVS-1171 test plan: * full conversations regression test * initiate a conversation with a user from another shard * reply to that conversation from both the sender and the receiver * repeat for a group conversation involving two or more shards * repeat for huge batch conversations with hundreds of users and two or more shards * known NOT working yet: * re-using the correct cross-shard private conversation * probably the tagging of messages with Course x, Group y, etc. Change-Id: I52549039875941cd518077cea4e28bfd2bc10dbf Reviewed-on: https://gerrit.instructure.com/16523 Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Clare Hetherington <clare@instructure.com> Tested-by: Jenkins <jenkins@instructure.com>
2012-11-29 06:53:00 +08:00
cn2 = Conversation.initiate([u, u2], true)
filter conversations while masquerading, fixes #7634 start tracking root_account_ids more consistently for messages, and aggregate them on the conversation. add a scope when masquerading such that conversations tied to other root accounts are hidden. a masquerader must have access to all root accounts a conversation belongs to in order to see it (unless the masquerader is a site admin) test plan: 1. enroll a user in courses under two different root accounts (let's call them accounts A and B) 2. as the user, log in under the account domain for A and send some messages 3. log in under the account domain for B and send some messages to the existing conversations, as well as to some new recipients 4. set up an account admin with access only to B 5. log in as the admin, and masquerade as the user 6. ensure you can only see conversations created under B (none of the ones that are solely A, or both A and B) 7. log in as a site admin, and masquerade as the user 8. ensure you can see conversations from both accounts Change-Id: I4a26b8b8914fd531103bb92c3d4442de843d9986 Reviewed-on: https://gerrit.instructure.com/9767 Reviewed-by: Jon Jensen <jon@instructure.com> Tested-by: Jon Jensen <jon@instructure.com>
2012-04-03 00:05:37 +08:00
cn2.add_message(u, "test")
Conversation.connection.execute "INSERT INTO context_messages(context_id, context_type) VALUES(#{c2.id}, 'Course')"
cn2.conversation_messages.update_all("context_message_id = (SELECT id FROM context_messages ORDER BY id DESC LIMIT 1)")
cn2.root_account_ids.should eql []
# context message on group
u3 = user
a3 = Account.create
g3 = group(:group_context => a3)
Cross-shard conversations fixes CNVS-1171 test plan: * full conversations regression test * initiate a conversation with a user from another shard * reply to that conversation from both the sender and the receiver * repeat for a group conversation involving two or more shards * repeat for huge batch conversations with hundreds of users and two or more shards * known NOT working yet: * re-using the correct cross-shard private conversation * probably the tagging of messages with Course x, Group y, etc. Change-Id: I52549039875941cd518077cea4e28bfd2bc10dbf Reviewed-on: https://gerrit.instructure.com/16523 Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Clare Hetherington <clare@instructure.com> Tested-by: Jenkins <jenkins@instructure.com>
2012-11-29 06:53:00 +08:00
cn3 = Conversation.initiate([u, u3], true)
filter conversations while masquerading, fixes #7634 start tracking root_account_ids more consistently for messages, and aggregate them on the conversation. add a scope when masquerading such that conversations tied to other root accounts are hidden. a masquerader must have access to all root accounts a conversation belongs to in order to see it (unless the masquerader is a site admin) test plan: 1. enroll a user in courses under two different root accounts (let's call them accounts A and B) 2. as the user, log in under the account domain for A and send some messages 3. log in under the account domain for B and send some messages to the existing conversations, as well as to some new recipients 4. set up an account admin with access only to B 5. log in as the admin, and masquerade as the user 6. ensure you can only see conversations created under B (none of the ones that are solely A, or both A and B) 7. log in as a site admin, and masquerade as the user 8. ensure you can see conversations from both accounts Change-Id: I4a26b8b8914fd531103bb92c3d4442de843d9986 Reviewed-on: https://gerrit.instructure.com/9767 Reviewed-by: Jon Jensen <jon@instructure.com> Tested-by: Jon Jensen <jon@instructure.com>
2012-04-03 00:05:37 +08:00
cn3.add_message(u, "test")
Conversation.connection.execute "INSERT INTO context_messages(context_id, context_type) VALUES(#{g3.id}, 'Group')"
cn3.conversation_messages.update_all("context_message_id = (SELECT id FROM context_messages ORDER BY id DESC LIMIT 1)")
cn3.root_account_ids.should eql []
# submission
u4 = user
a4 = Account.create
c4 = course(:account => a4, :active_all => true)
student_in_course(:user => u4, :course => c4, :active_all => true)
as4 = c4.assignments.create
s4 = as4.submit_homework(u4, :submission_type => "online_text_entry", :body => "")
Cross-shard conversations fixes CNVS-1171 test plan: * full conversations regression test * initiate a conversation with a user from another shard * reply to that conversation from both the sender and the receiver * repeat for a group conversation involving two or more shards * repeat for huge batch conversations with hundreds of users and two or more shards * known NOT working yet: * re-using the correct cross-shard private conversation * probably the tagging of messages with Course x, Group y, etc. Change-Id: I52549039875941cd518077cea4e28bfd2bc10dbf Reviewed-on: https://gerrit.instructure.com/16523 Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Clare Hetherington <clare@instructure.com> Tested-by: Jenkins <jenkins@instructure.com>
2012-11-29 06:53:00 +08:00
cn4 = Conversation.initiate([u, u4], true)
filter conversations while masquerading, fixes #7634 start tracking root_account_ids more consistently for messages, and aggregate them on the conversation. add a scope when masquerading such that conversations tied to other root accounts are hidden. a masquerader must have access to all root accounts a conversation belongs to in order to see it (unless the masquerader is a site admin) test plan: 1. enroll a user in courses under two different root accounts (let's call them accounts A and B) 2. as the user, log in under the account domain for A and send some messages 3. log in under the account domain for B and send some messages to the existing conversations, as well as to some new recipients 4. set up an account admin with access only to B 5. log in as the admin, and masquerade as the user 6. ensure you can only see conversations created under B (none of the ones that are solely A, or both A and B) 7. log in as a site admin, and masquerade as the user 8. ensure you can see conversations from both accounts Change-Id: I4a26b8b8914fd531103bb92c3d4442de843d9986 Reviewed-on: https://gerrit.instructure.com/9767 Reviewed-by: Jon Jensen <jon@instructure.com> Tested-by: Jon Jensen <jon@instructure.com>
2012-04-03 00:05:37 +08:00
cn4.add_message(u, '').update_attribute(:asset, s4)
cn4.root_account_ids.should eql []
# no root account info available
u5 = user
Cross-shard conversations fixes CNVS-1171 test plan: * full conversations regression test * initiate a conversation with a user from another shard * reply to that conversation from both the sender and the receiver * repeat for a group conversation involving two or more shards * repeat for huge batch conversations with hundreds of users and two or more shards * known NOT working yet: * re-using the correct cross-shard private conversation * probably the tagging of messages with Course x, Group y, etc. Change-Id: I52549039875941cd518077cea4e28bfd2bc10dbf Reviewed-on: https://gerrit.instructure.com/16523 Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Clare Hetherington <clare@instructure.com> Tested-by: Jenkins <jenkins@instructure.com>
2012-11-29 06:53:00 +08:00
cn5 = Conversation.initiate([u, u5], true)
filter conversations while masquerading, fixes #7634 start tracking root_account_ids more consistently for messages, and aggregate them on the conversation. add a scope when masquerading such that conversations tied to other root accounts are hidden. a masquerader must have access to all root accounts a conversation belongs to in order to see it (unless the masquerader is a site admin) test plan: 1. enroll a user in courses under two different root accounts (let's call them accounts A and B) 2. as the user, log in under the account domain for A and send some messages 3. log in under the account domain for B and send some messages to the existing conversations, as well as to some new recipients 4. set up an account admin with access only to B 5. log in as the admin, and masquerade as the user 6. ensure you can only see conversations created under B (none of the ones that are solely A, or both A and B) 7. log in as a site admin, and masquerade as the user 8. ensure you can see conversations from both accounts Change-Id: I4a26b8b8914fd531103bb92c3d4442de843d9986 Reviewed-on: https://gerrit.instructure.com/9767 Reviewed-by: Jon Jensen <jon@instructure.com> Tested-by: Jon Jensen <jon@instructure.com>
2012-04-03 00:05:37 +08:00
cn5.add_message(u, "test")
PopulateConversationRootAccountIds.up
cn1.reload.root_account_ids.should eql [a1a.id, a1b.id]
cn2.reload.root_account_ids.should eql [a2.id]
cn3.reload.root_account_ids.should eql [a3.id]
cn4.reload.root_account_ids.should eql [a4.id]
cn5.reload.root_account_ids.should eql []
end
end
end