ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/lib/data_fixup/fix_invalid_course_ids_on_e...

10 lines
316 B
Ruby
Raw Normal View History

move deleted enrollments when cross listing sections fixes CNVS-13828 test plan - prior to checking out patch set - enroll a user in a section - delete the enrollment - cross list the section - attempt to add user to sections new course - it should fail - checkout patch set and run migration - attempt to add user to sections new course - it should succeed - enroll a user in a section - delete the enrollment - cross list the section - attempt to add user to sections new course - it should work (it will restore the old enrollment) - enroll a user in a cross listed section - delete the enrollment - uncross list the section - attempt to add the user to the sections current course - it should work (it will restore the old enrollment) Change-Id: Ib397f96b0761d87bf6f9fb11ffc978012f0f5b39 Reviewed-on: https://gerrit.instructure.com/37036 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins <jenkins@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Rob Orton <rob@instructure.com>
2014-06-28 08:52:26 +08:00
module DataFixup::FixInvalidCourseIdsOnEnrollments
def self.run
don't try and eager load in a data fixup fixes CNVS-21318 eager load will try and select all the columns of the joined table by name. but due to race conditions, being in the middle of running migrations, it's possible the process will know of a column that hasn't been created yet. naming it in the select will break the query. Change-Id: I71ddd01c77f8f6157e36a01103dff52b7b967284 test-plan: N/A Reviewed-on: https://gerrit.instructure.com/63902 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Jacob Fugal <jacob@instructure.com> QA-Review: Jacob Fugal <jacob@instructure.com>
2015-09-24 06:35:40 +08:00
Enrollment.joins(:course_section).preload(:course_section).
move deleted enrollments when cross listing sections fixes CNVS-13828 test plan - prior to checking out patch set - enroll a user in a section - delete the enrollment - cross list the section - attempt to add user to sections new course - it should fail - checkout patch set and run migration - attempt to add user to sections new course - it should succeed - enroll a user in a section - delete the enrollment - cross list the section - attempt to add user to sections new course - it should work (it will restore the old enrollment) - enroll a user in a cross listed section - delete the enrollment - uncross list the section - attempt to add the user to the sections current course - it should work (it will restore the old enrollment) Change-Id: Ib397f96b0761d87bf6f9fb11ffc978012f0f5b39 Reviewed-on: https://gerrit.instructure.com/37036 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins <jenkins@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Rob Orton <rob@instructure.com>
2014-06-28 08:52:26 +08:00
where("course_sections.course_id<>enrollments.course_id").
use preload/eager_load instead of includes refs CNVS-21901 Change-Id: Ie9e1b2778b72f649392d8a1c47c0c86dae0ef19c Reviewed-on: https://gerrit.instructure.com/58660 Reviewed-by: Rob Orton <rob@instructure.com> Tested-by: Jenkins Product-Review: Cody Cutrer <cody@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com>
2015-07-17 05:53:07 +08:00
find_each do |e|
move deleted enrollments when cross listing sections fixes CNVS-13828 test plan - prior to checking out patch set - enroll a user in a section - delete the enrollment - cross list the section - attempt to add user to sections new course - it should fail - checkout patch set and run migration - attempt to add user to sections new course - it should succeed - enroll a user in a section - delete the enrollment - cross list the section - attempt to add user to sections new course - it should work (it will restore the old enrollment) - enroll a user in a cross listed section - delete the enrollment - uncross list the section - attempt to add the user to the sections current course - it should work (it will restore the old enrollment) Change-Id: Ib397f96b0761d87bf6f9fb11ffc978012f0f5b39 Reviewed-on: https://gerrit.instructure.com/37036 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins <jenkins@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Rob Orton <rob@instructure.com>
2014-06-28 08:52:26 +08:00
Enrollment.where(id: e).update_all(course_id: e.course_section.course_id)
end
end
end