ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/gems/dr_diff/dr_diff.gemspec

22 lines
706 B
Ruby
Raw Normal View History

add frozen_string_literal comment to engines and gems Change-Id: Ifb661509145c16937c9f1c28803687b7cec4b3a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/261815 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Rob Orton <rob@instructure.com> QA-Review: Rob Orton <rob@instructure.com> Product-Review: Rob Orton <rob@instructure.com>
2021-03-30 06:09:42 +08:00
# frozen_string_literal: true
incremental linting via dr diff, fixes SD-1521 test plan: * verify rubocop still comments on canvas-lms errors -- add "sleep 1" to a controller -- `./script/rlint` -- verify you see an error about sleeping * verify rubocop still comments on plugin errors -- add "sleep 1" to a plugin -- run rlint on the plugin `./script/rlint --plugin custom_reports` -- verify you see an error about sleeping Change-Id: Id0df56c3adfcb6b673a0400e9f714ae22b78242c Reviewed-on: https://gerrit.instructure.com/90657 Reviewed-by: Jon Jensen <jon@instructure.com> Product-Review: Jon Jensen <jon@instructure.com> QA-Review: Jon Jensen <jon@instructure.com> Tested-by: Jenkins
2016-09-19 05:23:32 +08:00
Gem::Specification.new do |spec|
spec.name = "dr_diff"
spec.version = "0.0.1"
spec.authors = ["Landon Wilkins"]
spec.email = ["lwilkins@instructure.com"]
spec.summary = "Run linters only on the git diff."
spec.files = Dir.glob("{lib,spec,bin}/**/*")
spec.test_files = spec.files.grep(%r{^spec/})
spec.require_paths = ["lib"]
rubocop: go back to a single .rubocop.yml it was just too confusing on which one an editor is using, double comments in jenkins, etc. this is accomplished by several things: * required cops are just marked as severe, instead of using a separate config for them, and failing if anything shows up from that config * get rid of all the logic to only include certain directories for certain cops. turns out it's not _that_ ominous to correct errors across the entire repository before marking a cop as required. * but still auto-generate config to turn _off_ autocorrect for non-severe cops. this is important because auto-correct must run for entire files, and we don't want it auto-correcting optional things that you didn't touch. * update gergich to get more details from the parsed comments. this plus the prior point means we _don't_ have to have heavy mode when in autocorrecting, but we still display out-of-context lines that were autocorrected this also makes it so we can use per-dir .rubocop.yml files again, so take some of the exceptions out of the root and put them in their own directory Change-Id: Ie936d1a9920b68910acd250ba817c7b4a670b958 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274394 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-25 00:29:32 +08:00
spec.add_dependency "gergich", "2.0.0"
spec.add_development_dependency "byebug", "~> 11.1"
incremental linting via dr diff, fixes SD-1521 test plan: * verify rubocop still comments on canvas-lms errors -- add "sleep 1" to a controller -- `./script/rlint` -- verify you see an error about sleeping * verify rubocop still comments on plugin errors -- add "sleep 1" to a plugin -- run rlint on the plugin `./script/rlint --plugin custom_reports` -- verify you see an error about sleeping Change-Id: Id0df56c3adfcb6b673a0400e9f714ae22b78242c Reviewed-on: https://gerrit.instructure.com/90657 Reviewed-by: Jon Jensen <jon@instructure.com> Product-Review: Jon Jensen <jon@instructure.com> QA-Review: Jon Jensen <jon@instructure.com> Tested-by: Jenkins
2016-09-19 05:23:32 +08:00
spec.add_development_dependency "pry"
spec.add_development_dependency "pry-nav"
RuboCop: Bundler and Gemspec Change-Id: I3077a90ba421f5996bb7ef2d4b7d85c2134b4c11 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274193 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-23 02:59:02 +08:00
spec.add_development_dependency "rspec", "~> 3.5.0"
spec.add_development_dependency "rspec-mocks"
incremental linting via dr diff, fixes SD-1521 test plan: * verify rubocop still comments on canvas-lms errors -- add "sleep 1" to a controller -- `./script/rlint` -- verify you see an error about sleeping * verify rubocop still comments on plugin errors -- add "sleep 1" to a plugin -- run rlint on the plugin `./script/rlint --plugin custom_reports` -- verify you see an error about sleeping Change-Id: Id0df56c3adfcb6b673a0400e9f714ae22b78242c Reviewed-on: https://gerrit.instructure.com/90657 Reviewed-by: Jon Jensen <jon@instructure.com> Product-Review: Jon Jensen <jon@instructure.com> QA-Review: Jon Jensen <jon@instructure.com> Tested-by: Jenkins
2016-09-19 05:23:32 +08:00
end