ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/.jshintrc

20 lines
1.7 KiB
Plaintext
Raw Normal View History

add a rake canvas:check_syntax task to check for js errors you can pass quick=true to to disable style guideline checks and only check for syntax errors. this will also spit out javascript style warnings using jshint and gjslint. I have not nailed down exactly which things we want to warn about, we can talk about it and come to a consensus on what we care about. I do not necessarily think that we should use both jshint and gjslint, I just put them both in to show what kind of things they can check for. in order to use gjslint, you need to install it from http://code.google.com/closure/utilities/ Make your .git/hooks/pre-commit look like: rake canvas:check_syntax:changed quick=true to not allow committing js with syntax errors Change-Id: Icfc21c2d30f60dc2fafef80d5c93432b6309afdb Reviewed-on: https://gerrit.instructure.com/2908 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Zach Wily <zach@instructure.com>
2011-03-31 05:06:00 +08:00
{
make jslint settings more sane we use jslint just as a last resort effort to make sure our javascript doesn't have syntax errors or something. these changes will make the jenkins output less verbose. Change-Id: I937ad1bc6f6b142c4ba424f65e72e9806468638f Reviewed-on: https://gerrit.instructure.com/12787 Tested-by: Jenkins <jenkins@instructure.com> Reviewed-by: Ryan Shaw <ryan@instructure.com>
2012-08-08 03:13:57 +08:00
"predef": [
"INST", "define", "require", "ENV"
],
add a rake canvas:check_syntax task to check for js errors you can pass quick=true to to disable style guideline checks and only check for syntax errors. this will also spit out javascript style warnings using jshint and gjslint. I have not nailed down exactly which things we want to warn about, we can talk about it and come to a consensus on what we care about. I do not necessarily think that we should use both jshint and gjslint, I just put them both in to show what kind of things they can check for. in order to use gjslint, you need to install it from http://code.google.com/closure/utilities/ Make your .git/hooks/pre-commit look like: rake canvas:check_syntax:changed quick=true to not allow committing js with syntax errors Change-Id: Icfc21c2d30f60dc2fafef80d5c93432b6309afdb Reviewed-on: https://gerrit.instructure.com/2908 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Zach Wily <zach@instructure.com>
2011-03-31 05:06:00 +08:00
"browser": true,
make jslint settings more sane we use jslint just as a last resort effort to make sure our javascript doesn't have syntax errors or something. these changes will make the jenkins output less verbose. Change-Id: I937ad1bc6f6b142c4ba424f65e72e9806468638f Reviewed-on: https://gerrit.instructure.com/12787 Tested-by: Jenkins <jenkins@instructure.com> Reviewed-by: Ryan Shaw <ryan@instructure.com>
2012-08-08 03:13:57 +08:00
"devel": true,
add a rake canvas:check_syntax task to check for js errors you can pass quick=true to to disable style guideline checks and only check for syntax errors. this will also spit out javascript style warnings using jshint and gjslint. I have not nailed down exactly which things we want to warn about, we can talk about it and come to a consensus on what we care about. I do not necessarily think that we should use both jshint and gjslint, I just put them both in to show what kind of things they can check for. in order to use gjslint, you need to install it from http://code.google.com/closure/utilities/ Make your .git/hooks/pre-commit look like: rake canvas:check_syntax:changed quick=true to not allow committing js with syntax errors Change-Id: Icfc21c2d30f60dc2fafef80d5c93432b6309afdb Reviewed-on: https://gerrit.instructure.com/2908 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Zach Wily <zach@instructure.com>
2011-03-31 05:06:00 +08:00
"jquery": true,
make jslint settings more sane we use jslint just as a last resort effort to make sure our javascript doesn't have syntax errors or something. these changes will make the jenkins output less verbose. Change-Id: I937ad1bc6f6b142c4ba424f65e72e9806468638f Reviewed-on: https://gerrit.instructure.com/12787 Tested-by: Jenkins <jenkins@instructure.com> Reviewed-by: Ryan Shaw <ryan@instructure.com>
2012-08-08 03:13:57 +08:00
"asi": true, // This option suppresses warnings about missing semicolons.
"plusplus": false, // This option prohibits the use of unary increment and decrement operators
"curly": false, // This option requires you to always put curly braces around blocks in loops and conditionals
"forin": false, // This option requires all for in loops to filter object's items.
"undef": true, // This option prohibits the use of explicitly undeclared variables. This option is very useful for spotting leaking and mistyped variables.
"unused": true, // This option warns when you define and never use your variables. It is very useful for general code cleanup, especially when used in addition to undef.
"camelcase": true, //This option allows you to force all variable names to use either camelCase style or UPPER_CASE with underscores.
"eqeqeq":true, // This options prohibits the use of == and != in favor of === and !==. The former try to coerce values before comparing them which can lead to some unexpected results
"indent": 2, // This option enforces specific tab width for your code.
"latedef": true, // This option prohibits the use of a variable before it was defined
"immed": true, // This option prohibits the use of immediate function invocations without wrapping them in parentheses. Wrapping parentheses assists readers of your code in understanding that the expression is the result of a function, and not the function itself.
"boss": true // This option suppresses warnings about the use of assignments in cases where comparisons are expected. More often than not, code like if (a = 10) {} is a typo.
add a rake canvas:check_syntax task to check for js errors you can pass quick=true to to disable style guideline checks and only check for syntax errors. this will also spit out javascript style warnings using jshint and gjslint. I have not nailed down exactly which things we want to warn about, we can talk about it and come to a consensus on what we care about. I do not necessarily think that we should use both jshint and gjslint, I just put them both in to show what kind of things they can check for. in order to use gjslint, you need to install it from http://code.google.com/closure/utilities/ Make your .git/hooks/pre-commit look like: rake canvas:check_syntax:changed quick=true to not allow committing js with syntax errors Change-Id: Icfc21c2d30f60dc2fafef80d5c93432b6309afdb Reviewed-on: https://gerrit.instructure.com/2908 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Zach Wily <zach@instructure.com>
2011-03-31 05:06:00 +08:00
}