ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/package.json

290 lines
11 KiB
JSON
Raw Normal View History

AMD Conversion "Trivial" JavaScript / CoffeeScript changes -------------------------------------------------- For the most part, all javascript was simply wrapped in `require` or `define`. The dependencies were found with a script that matched regexes in the files, it errs on the side of listing too many dependencies, so its worth double checking each file's dependencies (over time, anyway). i18n API changes -------------------------------------------------- No longer have to do I18n.scoped calls, just list i18n as a dependency with the scope and it's imported already scoped require ['i18n!some_scope'], (I18n) -> I18n.t 'im_scoped', 'I'm scoped!' JS bundling now done with r.js, not Jammit -------------------------------------------------- We don't use jammit to bundle JS anymore. Simply list dependencies for your JS modules in the file and RequireJS handles the rest. To optimize the JavaScript, first make sure you have node.js 0.4.12+ installed and then run: $ rake js:build The app defaults to the optimized build in production. You can use non-optimized in production by putting ?debug_assets=true in the url just like before. You can also test the optimized JavaScript in development with ?optimized_js=true. Significant changes -------------------------------------------------- These files have "real" changes to them (unlike the JavaScript that is simply wrapped in require and define). Worth taking a really close look at: - app/helpers/application_helper.rb - app/views/layouts/application.html.erb - config/assets.yml - config/build.js - lib/handlebars/handlebars.rb - lib/i18n_extraction/js_extractor.rb - lib/tasks/canvas.rake - lib/tasks/i18n.rake - lib/tasks/js.rake Change-Id: I4bc5ecb1231f331aaded0fef2bcc1f3a9fe482a7 Reviewed-on: https://gerrit.instructure.com/6986 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Ryan Florence <ryanf@instructure.com>
2011-11-11 00:31:45 +08:00
{
"name": "canvas-lms",
upgrade karma everyone was getting build errors when they were npm install'ing. it was because karma 0.10 depended on an out-of-date version of chokiadr that does not compile against node 0.12 I also indicated that canvas is licenced agpl 3 so that you wouldn't always see an npm warning about not having one. also, let karma serve our css files so if any javascript references them in our quit tests, we don't see 404 warnings Change-Id: Iaa0377bc87b8f7ec8726d6cb82c0f8a103134b56 Reviewed-on: https://gerrit.instructure.com/58584 Tested-by: Jenkins Reviewed-by: Mike Nomitch <mnomitch@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2015-07-16 12:24:49 +08:00
"license": "AGPL-3.0",
AMD Conversion "Trivial" JavaScript / CoffeeScript changes -------------------------------------------------- For the most part, all javascript was simply wrapped in `require` or `define`. The dependencies were found with a script that matched regexes in the files, it errs on the side of listing too many dependencies, so its worth double checking each file's dependencies (over time, anyway). i18n API changes -------------------------------------------------- No longer have to do I18n.scoped calls, just list i18n as a dependency with the scope and it's imported already scoped require ['i18n!some_scope'], (I18n) -> I18n.t 'im_scoped', 'I'm scoped!' JS bundling now done with r.js, not Jammit -------------------------------------------------- We don't use jammit to bundle JS anymore. Simply list dependencies for your JS modules in the file and RequireJS handles the rest. To optimize the JavaScript, first make sure you have node.js 0.4.12+ installed and then run: $ rake js:build The app defaults to the optimized build in production. You can use non-optimized in production by putting ?debug_assets=true in the url just like before. You can also test the optimized JavaScript in development with ?optimized_js=true. Significant changes -------------------------------------------------- These files have "real" changes to them (unlike the JavaScript that is simply wrapped in require and define). Worth taking a really close look at: - app/helpers/application_helper.rb - app/views/layouts/application.html.erb - config/assets.yml - config/build.js - lib/handlebars/handlebars.rb - lib/i18n_extraction/js_extractor.rb - lib/tasks/canvas.rake - lib/tasks/i18n.rake - lib/tasks/js.rake Change-Id: I4bc5ecb1231f331aaded0fef2bcc1f3a9fe482a7 Reviewed-on: https://gerrit.instructure.com/6986 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Ryan Florence <ryanf@instructure.com>
2011-11-11 00:31:45 +08:00
"version": "0.0.0",
upgrade karma everyone was getting build errors when they were npm install'ing. it was because karma 0.10 depended on an out-of-date version of chokiadr that does not compile against node 0.12 I also indicated that canvas is licenced agpl 3 so that you wouldn't always see an npm warning about not having one. also, let karma serve our css files so if any javascript references them in our quit tests, we don't see 404 warnings Change-Id: Iaa0377bc87b8f7ec8726d6cb82c0f8a103134b56 Reviewed-on: https://gerrit.instructure.com/58584 Tested-by: Jenkins Reviewed-by: Mike Nomitch <mnomitch@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2015-07-16 12:24:49 +08:00
"engines": {
relax node version req so it works w/ docker Test plan: * if you rebuild your docker image it shouldn’t complain about A node version that is not compatible with this module Change-Id: Ieef58139be7a913a9aa3b5156937e01752dd1537 Reviewed-on: https://gerrit.instructure.com/186683 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-25 22:45:33 +08:00
"node": ">=10.14.0",
Bump to Node 10 closes CORE-2329 There were some tests that were expecting a snapshot-like value where it expected `new Date().toLocaleDateString()` to give something Like “2016-7-11” but that was actually wrong. If you do `new Date().toLocaleDateString()` in a browser it will give you something like “7/11/2016”. And this new version of node matches what a real browser would have done, so I just updated the specs so they are looking for the correct format. This change does not actually reflect a change in what a real user would see. Just what jest/jsdom/node formats it as. Test Plan: - check to make sure that the assignments 2 availability dates component produces markup exactly as it did before - Automated tests pass - Build canvas locally, everything passes. - Build canvas with docker, everything passes. Change-Id: I74285cd6d9b251ca60ab79396e332cc3a419bcee Reviewed-on: https://gerrit.instructure.com/177198 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-01-09 04:25:49 +08:00
"yarn": "^1.6.0"
upgrade karma everyone was getting build errors when they were npm install'ing. it was because karma 0.10 depended on an out-of-date version of chokiadr that does not compile against node 0.12 I also indicated that canvas is licenced agpl 3 so that you wouldn't always see an npm warning about not having one. also, let karma serve our css files so if any javascript references them in our quit tests, we don't see 404 warnings Change-Id: Iaa0377bc87b8f7ec8726d6cb82c0f8a103134b56 Reviewed-on: https://gerrit.instructure.com/58584 Tested-by: Jenkins Reviewed-by: Mike Nomitch <mnomitch@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2015-07-16 12:24:49 +08:00
},
Use yarn workspaces Run `script/nuke_node.sh` to clean everything up Run `yarn install` it should install everything for everything Run `yarn build` and `yarn test` they should work exactly as before Change-Id: I11a27ff2d705c6cbb3b3f9029dd8b32138706146 Reviewed-on: https://gerrit.instructure.com/151356 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-25 00:09:03 +08:00
"private": true,
"workspaces": {
"packages": [
spec: increase the timeout of canvas-rce specs Also: * update mocha-jsdom to eliminate a spec issue * fix some specs test plan: * Verify Jenkins passes Change-Id: Ib486336306719b5ca4160e15843a0aac084c5c92 Reviewed-on: https://gerrit.instructure.com/153972 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-06-15 22:04:23 +08:00
"gems/canvas_i18nliner",
"gems/selinimum",
treat anything in gems/plugins/* as a workspace Fixes: https://github.com/instructure/canvas-lms/issues/1323 This lets open source users continue putting their own plugins with npm deps In gems/plugins. They will still have to have a forked version Of yarn.lock though since that will be different for them than a “Default” install. Also, this means that everyone will see a bunch of warnings like this Every time they yarn install: Warning: gems/plugins/academic_benchmark is a dir… no package.json Warning: gems/plugins/account_reports is a dir.. has no package.json Warning: gems/plugins/canvas_geoip is a …, but has no package.json Warning: gems/plugins/demo_site is a directory, but has no package.json Warning: gems/plugins/instructure_misc_plugin is … has no package.json Warning: gems/plugins/moodle_importer is a d.., but has no package.json Warning: gems/plugins/qti_exporter is a dir…, but has no package.json Warning: gems/plugins/respondus_soap_endpoint is … no package.json Warning: gems/plugins/simply_versioned is a …, but has no package.json Test plan: * yarn install should work Change-Id: Ie65c8faf8b1022210cfb7eda8c25107facfe83b5 Reviewed-on: https://gerrit.instructure.com/158043 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-07-20 03:42:35 +08:00
"gems/plugins/*",
Use yarn workspaces Run `script/nuke_node.sh` to clean everything up Run `yarn install` it should install everything for everything Run `yarn build` and `yarn test` they should work exactly as before Change-Id: I11a27ff2d705c6cbb3b3f9029dd8b32138706146 Reviewed-on: https://gerrit.instructure.com/151356 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-25 00:09:03 +08:00
"packages/*",
"client_apps/*"
],
"nohoist": [
"canvas_quizzes/grunt*",
"canvas_quizzes/jasmine*"
]
},
move napa from "devDependencies" to "dependencies" Change-Id: I4dde9458868cd5c1c41b921414dff4b3dc9371de Reviewed-on: https://gerrit.instructure.com/29878 Reviewed-by: Simon Williams <simon@instructure.com> Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> Tested-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
2014-02-11 02:29:11 +08:00
"dependencies": {
Give RCEWrapper onFocus/onBlur handlers closes ADMIN-2742 there are challanges - RCEWrapper keeps track of whether it has focus. This is true if anything w/in its outermost div is the activeElement - since the previously active element blurs before the new element becomes active. we need a timeout to wait and see where focus lands. this is true when: - focus moves to a tinymce popup, like a menu - focus moves to one of RCE's dialogs or trays - the user interacts with content in the CanvasContentTray. This is because a new instance of the CCT is created every time it renders as the user interacts with it. (An artifact of how it's wired into redux). This also addresses a bug where the html-view textarea was the wrong size when flipping between rich text and html views. NOTE: if you close any of the Trays or Modals by typing "esc", it will blur the RCE. This is a known bug that I'm hoping will be fixed via INSTUi-2201. If not, then via another CORE ticket test plan: - not necessary, but if you test in assignments2, you'll know it's working because the RCE will go away if it loses focus, so enable assignments2, create an assignment, then edit the assignment (you can't create an a2 assignment yet) - insert and edit an external link - insert and edit a course image - upload an image - insert and edit a course document - upload a document > in each case, expect focus to return to the RCE, and if applicable, the yellow indicator box is correctly positioned. - in any of the above cases, click on the yellow indicator while it's visible > expect focus to stay w/in the rce resizing: - click the "switch to html view" button > expect the textarea to fill the avaiable space - resize it and click the button to switch back > expect the rce to be the same (or really close) size Change-Id: If85c5644558fbce27530e43bb71c2bdb7e91eb12 Reviewed-on: https://gerrit.instructure.com/199273 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2019-06-27 06:07:22 +08:00
"@instructure/canvas-rce-old": "4.1.4",
Upgrade @instructure/media-capture and media-player Test plan: * use the media capture stuff from the new RCE * it should look the same but use instUI 6 components Change-Id: If5e41b75652898c0d2a4d51eedb4fc437d68f7d2 Reviewed-on: https://gerrit.instructure.com/205695 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-20 04:18:48 +08:00
"@instructure/media-capture": "^5.54.0",
bump npm-run-all version Change-Id: Ieae7ac480124e52050c79ca83c99a7fe698c48d5 Reviewed-on: https://gerrit.instructure.com/173262 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Gary Mei <gmei@instructure.com> Product-Review: Gary Mei <gmei@instructure.com>
2018-11-27 02:20:33 +08:00
"@instructure/react-crop": "^5.0.1",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"@instructure/ui-alerts": "^5",
"@instructure/ui-billboard": "^5",
"@instructure/ui-breadcrumb": "^5",
"@instructure/ui-buttons": "^5",
"@instructure/ui-core": "^5",
Make A2 header content editable waiting on an instui release. without it 1. the Points edit has the wrong font size 2. you cannot delete a module closes ADMIN-2303 test plan: - create an assignment, open it, click the assignments 2 button, then add #edit to the url and refresh (this forces the assignment into edit mode) > expect the assignment type to be "Assignment" and to be editable - on selecting any value other than "Assignment", expect to be sent to the corresponding page in canvas after confirmation > expect the correct module(s) to be selected, and to be editable - expect to be able to select > 1 module - when all modules are deleted, expect th "No Module Assigned" placeholder > expect the correct assignment group to be selected, and to be editable > expect the assignment name to be correct and editable - edit and delete the name > expect a "name is required" message > expect the points to be correct and editable - entering anything that's not a number should result in an error message Change-Id: Ief36b01d7f5380f16d3e76b7afeb7d7d8e38b3bc Reviewed-on: https://gerrit.instructure.com/176293 Tested-by: Jenkins Reviewed-by: Carl Kibler <ckibler@instructure.com> QA-Review: Carl Kibler <ckibler@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2018-12-21 05:30:07 +08:00
"@instructure/ui-editable": "^5",
Upgrade @instructure/media-capture and media-player Test plan: * use the media capture stuff from the new RCE * it should look the same but use instUI 6 components Change-Id: If5e41b75652898c0d2a4d51eedb4fc437d68f7d2 Reviewed-on: https://gerrit.instructure.com/205695 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-20 04:18:48 +08:00
"@instructure/ui-elements": "^5",
track anonymous grading in the audit trail ui closes GRADE-1668 test plan: A. Setup 1. Create an assignment * With moderated grading * With anonymous grading * Worth 10 points * Three graders (A, B, and C) * Teachers as final grader (not admin) * Assigned to only one or two students * just for less work in QA 2. As each student, submit to the assignment 3. As Grader A: a. Assign provisional grades b. Maybe leave a submission comment or two 4. As the teacher, disable anonymous grading * The related event will have a warning badge 5. As Grader B: a. Assign provisional grades b. Maybe leave a submission comment or two * The related events will have warning badges 6. As the teacher, re-enable anonymous grading 7. As Grader C: a. Assign provisional grades b. Maybe leave a submission comment or two 8. As the final grader: a. Visit the moderation page b. Select provisional grades c. Post grades d. Display grades to students B. Verify 1. Log in as a user with "view audit trail" permission (admin) 2. Open the assignment in SpeedGrader 3. Open the assessment audit trail 4. For Grader A a. Expand the user event group for Grader A b. Verify there is no non-anonymous warning icon to the side of the user name c. Verify there are no non-anonymous warning badges to the side of the user's grading actions 5. For Grader B a. Expand the user event group for Grader B b. Verify there is a non-anonymous warning icon to the side of the user name c. Verify the non-anonymous warning icon triggers a sensible tooltip d. Verify there are some non-anonymous warning badges to the side of the user's grading actions e. Verify the badged icons trigger sensible tooltips 6. For Grader C a. Expand the user event group for Grader C b. Verify there is no non-anonymous warning icon to the side of the user name c. Verify there are no non-anonymous warning badges to the side of the user's grading actions 7. For the teacher a. Expand the user event group for the teacher b. Verify there is a non-anonymous warning icon to the side of the user name c. Verify there is a non-anonymous warning badge to the side side of the user's action disabling anonymous grading d. Verify there are no non-anonymous warning badges to the side of the user's moderation actions (after enabling anonymous) Change-Id: I2e675b84dc3e6b59e3111ed39b7a814f38f19f5c Reviewed-on: https://gerrit.instructure.com/170684 Tested-by: Jenkins Reviewed-by: Gary Mei <gmei@instructure.com> Reviewed-by: Adrian Packel <apackel@instructure.com> QA-Review: Adrian Packel <apackel@instructure.com> Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-11-01 22:13:35 +08:00
"@instructure/ui-focusable": "^5",
Add override details to teacher view closes ADMIN-1510 This change includes some code to flip some of the elements into edit mode, but that's not part of this ticket (though if you want to see it, add #edit to the URL) test plan: - have an assignment with some submission types, specified allowed filename extensions, due, lock, unlock dates - load /courses/:course_id/assignments/:assignmen_id?assignments_2=true - click the ">" to expand the override summary to see the details > expect the data to match your assignment notes: - "score to keep" and submission requirements are hard-coded for now until we get the data - the attempts input only appears when attempts allowed is limited (e.g. non null) - Submission Requirement only appears when there are > 1 submission types - the UI mostly matches the mockup. Mary's design is changing, so it may not be 100% exact. Change-Id: Ia385ec7880e3d834658d412a4c7ac5afc9091fac Reviewed-on: https://gerrit.instructure.com/175098 Tested-by: Jenkins QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com> Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
2018-12-12 06:06:18 +08:00
"@instructure/ui-form-field": "^5",
dynamic import comments refs COMMS-1844 Test Plan: - Click on comments on an A2 student view - notice there is a loading indicator then the comments load Change-Id: I43ed778b826153b5cb4e58b9365a0016dec10897 Reviewed-on: https://gerrit.instructure.com/180618 Tested-by: Jenkins Reviewed-by: Aaron Hsu <ahsu@instructure.com> QA-Review: Landon Gilbert-Bland <lbland@instructure.com> Product-Review: Steven Burnett <sburnett@instructure.com>
2019-02-06 04:54:30 +08:00
"@instructure/ui-forms": "^5",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"@instructure/ui-icons": "^5",
"@instructure/ui-layout": "^5",
Upgrade @instructure/media-capture and media-player Test plan: * use the media capture stuff from the new RCE * it should look the same but use instUI 6 components Change-Id: If5e41b75652898c0d2a4d51eedb4fc437d68f7d2 Reviewed-on: https://gerrit.instructure.com/205695 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-20 04:18:48 +08:00
"@instructure/ui-media-player": "^5.54.0",
Give RCEWrapper onFocus/onBlur handlers closes ADMIN-2742 there are challanges - RCEWrapper keeps track of whether it has focus. This is true if anything w/in its outermost div is the activeElement - since the previously active element blurs before the new element becomes active. we need a timeout to wait and see where focus lands. this is true when: - focus moves to a tinymce popup, like a menu - focus moves to one of RCE's dialogs or trays - the user interacts with content in the CanvasContentTray. This is because a new instance of the CCT is created every time it renders as the user interacts with it. (An artifact of how it's wired into redux). This also addresses a bug where the html-view textarea was the wrong size when flipping between rich text and html views. NOTE: if you close any of the Trays or Modals by typing "esc", it will blur the RCE. This is a known bug that I'm hoping will be fixed via INSTUi-2201. If not, then via another CORE ticket test plan: - not necessary, but if you test in assignments2, you'll know it's working because the RCE will go away if it loses focus, so enable assignments2, create an assignment, then edit the assignment (you can't create an a2 assignment yet) - insert and edit an external link - insert and edit a course image - upload an image - insert and edit a course document - upload a document > in each case, expect focus to return to the RCE, and if applicable, the yellow indicator box is correctly positioned. - in any of the above cases, click on the yellow indicator while it's visible > expect focus to stay w/in the rce resizing: - click the "switch to html view" button > expect the textarea to fill the avaiable space - resize it and click the button to switch back > expect the rce to be the same (or really close) size Change-Id: If85c5644558fbce27530e43bb71c2bdb7e91eb12 Reviewed-on: https://gerrit.instructure.com/199273 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2019-06-27 06:07:22 +08:00
"@instructure/ui-menu": "^5",
Make A2 header content editable waiting on an instui release. without it 1. the Points edit has the wrong font size 2. you cannot delete a module closes ADMIN-2303 test plan: - create an assignment, open it, click the assignments 2 button, then add #edit to the url and refresh (this forces the assignment into edit mode) > expect the assignment type to be "Assignment" and to be editable - on selecting any value other than "Assignment", expect to be sent to the corresponding page in canvas after confirmation > expect the correct module(s) to be selected, and to be editable - expect to be able to select > 1 module - when all modules are deleted, expect th "No Module Assigned" placeholder > expect the correct assignment group to be selected, and to be editable > expect the assignment name to be correct and editable - edit and delete the name > expect a "name is required" message > expect the points to be correct and editable - entering anything that's not a number should result in an error message Change-Id: Ief36b01d7f5380f16d3e76b7afeb7d7d8e38b3bc Reviewed-on: https://gerrit.instructure.com/176293 Tested-by: Jenkins Reviewed-by: Carl Kibler <ckibler@instructure.com> QA-Review: Carl Kibler <ckibler@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2018-12-21 05:30:07 +08:00
"@instructure/ui-number-input": "^5",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"@instructure/ui-overlays": "^5",
"@instructure/ui-pagination": "^5",
Fix Select deprecations with CanvaSelect this commit add the new CanvasSelect which wraps the new controlled-only INSTUI Select (single select only) to provide a nearly drop-in replacement for the deprecated INSTUI Select used in canvas. This new CanvasSelect is then used in people_search.js and TimeZoneSelect/index.js to resolve the deprectation warnings. changes include an upgrade to ui-select 6.8 closes ADMIN-2775, COREFE-186 COREFE-184 test plan: - nav to a course's people page - click on the +People button > expect the Role and Section selects to work as expected - nav to the account's people page - click on the pencil icon to the right of a user > expect the Time Zone select to show a blank line, then 2 groups of time zones > expect the select to work as expected > expect screenreaders to tell you interesting things as you interact with the select Change-Id: I5dcfb2c1c8ca64071ce9dbf0a194777f10c711cf Reviewed-on: https://gerrit.instructure.com/202508 Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins Product-Review: Ed Schiebel <eschiebel@instructure.com>
2019-07-23 04:58:34 +08:00
"@instructure/ui-select": "^6.8.1",
upgrade canvas-rce to instUI 6 and consume it as esModules closes: CORE-2922 CORE-2951 CORE-2950 CORE-2952 Also, since we are using the new @instructure/ui-icons we can pull In the latest icons that design wants us to use for the toolbar buttons test plan: * canvas-rce build should pass and canvas webpack should consume it as a “harmony export” * check the “text color” button in the toolbar, it should Update it’s color to match the color you picked * the bulleted list icons in the toolbar should use instUI icons * run `yarn webpack:analyze`, the canvas-rce chunk should be a lot Smaller than it was. and everything from @instructure/ui-whatever Should be coming from the /es dir. Change-Id: I13c670bdd174a9bc10aca4a7f9c5bc9208883ac9 Reviewed-on: https://gerrit.instructure.com/192569 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-05-08 13:18:04 +08:00
"@instructure/ui-svg-images": "^5",
A2: search and sort on teacher view students tab closes ADMIN-2510 test plan: - on the students tab of teacher view: - type in the search field, at least 3 characters - the search should happen after a short delay and display results - the name, score, and submission date columns are sortable in ascending and descending order - sorting causes another load - enter less than 3 characters in the search field - after a short delay, a message should be displayed about needing 3 characters - clearing the search field should go back to original search of all students Change-Id: Ibaaeff175089003a4a5fcbb27db32c9510330e25 Reviewed-on: https://gerrit.instructure.com/186995 Tested-by: Jenkins Reviewed-by: Ed Schiebel <eschiebel@instructure.com> QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
2019-03-22 01:32:00 +08:00
"@instructure/ui-table": "^5",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"@instructure/ui-tabs": "^5",
fix <Select> deprecation in NewCourseModal Replace Select with CanvasSelect Replace legacy TextInput with the new TextInput fixes ADMIN-2771 test plan: - go to account courses page, /accounts/self - click the "+Course" button > expect the 2 TextInputs to accept input > expect the subaccount and term selects to work as expected > expect some nice screenreader messages as you interact with the selects > expect the course to be created with the right data when clicking on the "Add Course" button - try it again, but do something to make it fail (I set a breakpoint at courses_controller.rb line 791 and set @course=nil) > expect to get an error flash message - click on the "details" button > expect the details popup to be above the Modal's overlay and you can dismiss it. Change-Id: I8612b086a8812660c82c9d243746ed211deb5a59 Reviewed-on: https://gerrit.instructure.com/202575 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2019-07-25 06:15:52 +08:00
"@instructure/ui-text-input": "^6.8.1",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"@instructure/ui-themeable": "^5",
"@instructure/ui-themes": "^5",
"@instructure/ui-toggle-details": "^5",
Add @instructure/uid dependency to canvas test plan: yarn test:karma builds w/o errors Change-Id: I631dabdf9214e2d44bedaa4f4ff1451fcc0e76b0 Reviewed-on: https://gerrit.instructure.com/206016 Reviewed-by: Carl Kibler <ckibler@instructure.com> Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Carl Kibler <ckibler@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins
2019-08-21 22:55:36 +08:00
"@instructure/uid": "^5",
use apollo client instead of apollo boost This prepares us for using apollo's instrospection fragment matcher (which isn't supported with -boost). Test plan: pages that use graphql still work refs GQL-17 Change-Id: Ib6af304855e6c0e23b598344ac1d30f4d4aa03a5 Reviewed-on: https://gerrit.instructure.com/172936 Tested-by: Jenkins Reviewed-by: Carl Kibler <ckibler@instructure.com> QA-Review: Cameron Matheson <cameron@instructure.com> Product-Review: Cameron Matheson <cameron@instructure.com>
2018-11-20 04:17:17 +08:00
"apollo-cache-inmemory": "^1.3.10",
upgrade react-apollo to 3.x.x closes COMMS-2316 TEST PLAN ------------------------------- all tests pass Change-Id: I0c270bb7a8d5dfa166641648841e619a1a21c0f4 Reviewed-on: https://gerrit.instructure.com/206348 Reviewed-by: Matthew Lemon <mlemon@instructure.com> Tested-by: Jenkins QA-Review: Ben Nelson <bnelson@instructure.com> Product-Review: Ben Nelson <bnelson@instructure.com>
2019-08-22 00:54:59 +08:00
"apollo-client": "^2.6.4",
use apollo client instead of apollo boost This prepares us for using apollo's instrospection fragment matcher (which isn't supported with -boost). Test plan: pages that use graphql still work refs GQL-17 Change-Id: Ib6af304855e6c0e23b598344ac1d30f4d4aa03a5 Reviewed-on: https://gerrit.instructure.com/172936 Tested-by: Jenkins Reviewed-by: Carl Kibler <ckibler@instructure.com> QA-Review: Cameron Matheson <cameron@instructure.com> Product-Review: Cameron Matheson <cameron@instructure.com>
2018-11-20 04:17:17 +08:00
"apollo-link": "^1.2.3",
"apollo-link-error": "^1.1.1",
"apollo-link-http": "^1.5.5",
Display multiple modules in A2 student view This also adds support for apollo-link-state. We are using this to move data from the `ENV` into our apollo query results, to keep a single source of truth and easier unit tests. If there are more then two modules that an assignment belongs to (which is abnormal) we are only rendering the first two modules with an additional link to the modules page, indicating that there are more modules this assignment belongs to. Fixes COMMS-1800 Test Plan: - Create an assignment, and add it to four modules - Navigate to the assignment as a student - Notice that 2 of the four modules are displayed in the header Change-Id: I9b797486ba56c8b827e5f76114c5a08d2f969f41 Reviewed-on: https://gerrit.instructure.com/174837 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Landon Gilbert-Bland <lbland@instructure.com> Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
2018-12-11 03:56:24 +08:00
"apollo-link-state": "^0.4.2",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"axios": "^0.19.0 || ^0.18.0",
Don’t include regenerator-runtime on account settings `axios-cache-adapter`’s “browser” field in package.json says to use A “dist” file that is prebuilt with webpack to handle old browsers (github.com/RasCarlito/axios-cache-adapter/blob/master/dist/cache.js) That means it has a copy of `regenerator-runtime` in it for the async functions it uses. That is wasteful and is bytes that our users shouldn’t need to download. Test plan: * the CSP stuff on the account settings page should work the same * but the webpack js bundle should be smaller Change-Id: I671f2eb60b57c43e002b9a62fd92feb5c96cd00b Reviewed-on: https://gerrit.instructure.com/204252 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-08 03:16:55 +08:00
"axios-cache-adapter": "^2.4.0",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"backbone": "1.1.1",
maintain precision of grades in grade input fixes GRADE-1098 test plan: 1. Create an Assignment a. with Display Grade as Percentage b. worth 9.5 points 2. Open New Gradebook 3. Grade a student on this assignment twice a. once with 55 (interpreted as percentage) b. again with 55% (explicit percentage) 4. Verify grade is 55% 5. Verify score is 5.225 Change-Id: Ie48ec7d5b787e864bfd3379e8dc6a4dbebebc2e5 Reviewed-on: https://gerrit.instructure.com/148848 Tested-by: Jenkins Reviewed-by: Derek Bender <djbender@instructure.com> Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com> QA-Review: Shahbaz Javeed <sjaveed@instructure.com> Product-Review: Matt Goodwin <mattg@instructure.com>
2018-05-02 04:54:56 +08:00
"big.js": "^5.0.3",
Remove remaining dynamic brand css code closes: CNVS-39103 CNVS-39104 CNVS-38650 test plan: * do a general css styling regression pass * make sure that the urls to css files look like /dist/brandable_css/new_styles_normal_contrast/<bundle>-<fingerprint>.css and not: /dist/brandable_css/<big long md5>/new_styles_normal_contrast/<bundle>-<fingerprint>.css * make sure that stylesheets loaded by handlebars templates work eg: go to the calendar page and make sure it is styled correctly * verify that the theme editor works. especially the process when you hit "preivew" and "apply" * set up config/canvas_cdn.yml to use the dev cdn * run `bundle exec canvas:compile_assets && bundle exec rake canvas:cdn:upload_to_s3` * load a page, all the css should load from the cdn * verify the theme editor works when using the cdn too. * also review the changes in the brandable_css npm package: https://github.com/ryankshaw/brandable_css/compare/c6bef...b159d5 Change-Id: I55db41e90f6bc54183a661128f1050445a086d6b Reviewed-on: https://gerrit.instructure.com/120912 Tested-by: Jenkins Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2017-09-26 07:19:15 +08:00
"brandable_css": "0.1.0",
Use yarn workspaces Run `script/nuke_node.sh` to clean everything up Run `yarn install` it should install everything for everything Run `yarn build` and `yarn test` they should work exactly as before Change-Id: I11a27ff2d705c6cbb3b3f9029dd8b32138706146 Reviewed-on: https://gerrit.instructure.com/151356 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-25 00:09:03 +08:00
"canvas-planner": ">=1.0.16",
Update canvas_offline_course_viewer for new translations Test plan - Smoke test to ensure dependency pinning hasn't caused any issues Change-Id: I98f2feec9c56f98f530685fa9c94c106d9881c4c Reviewed-on: https://gerrit.instructure.com/122023 Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com> Product-Review: Jon Willesen <jonw+gerrit@instructure.com> Tested-by: Jenkins QA-Review: Nathan Rogowski <nathan@instructure.com>
2017-08-09 03:40:06 +08:00
"canvas_offline_course_viewer": "https://github.com/instructure/canvas_offline_course_viewer.git#1.2.0",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"classnames": "^2.2.5",
"color-slicer": "0.8.0",
react 16: use createReactClass for things that can’t be es6 classes these components can’t be converted to the react es6 class syntax because they use Mixins which aren’t supported by es6 classes. Change-Id: I8541b08518cd335c7a711bab117efcda65ac6b2c Reviewed-on: https://gerrit.instructure.com/164135 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-09-12 13:29:44 +08:00
"create-react-class": "^15.6.3",
upgrade d3 to latest 3.x version the previous version caused an error when building native dependencies during the yarn install when using node 8. refs CORE-704 test plan: - ensure d3 charts in gradezilla/OutcomeColumnView render correctly - ensure d3 charts in gradebook/OutcomeColumnView render correctly - ensure d3 charts in grade_summary/OutcomeLineGraphView render correctly - ensure d3 charts in client_apps/canvas_quizzes render correctly - yarn install runs without errors using latest node 8 lts Change-Id: Ib2f8d4acab6060795b50e545eb64f324587b6300 Reviewed-on: https://gerrit.instructure.com/134476 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Leo Abner <rabner@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2017-12-04 23:24:41 +08:00
"d3": "3.5.17",
Handle dependent variables in the theme editor After the theme editor refactor dependant variables were not working. This fixes it. This also makes it so that override files are handled properly. closes CORE-1085 Test Plan: - Go to the theme editor with a new theme - Change the "Primary Brand Color" - "Primary Button" should change as well - Preview the changes - Change should be reflected after the preview loads - Repeat that again, the same behavior should occur. - Change the "Primary Button" color and preview - The two items should now be "unlinked" and they change independent of one another - Upload a js override - Preview changes - Upload a css override - Preview changes - Both the js and the css fields should be populated Change-Id: I61572a3c5bdf4f63c82078dff492dc504d0af7bf Reviewed-on: https://gerrit.instructure.com/142395 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-03-02 07:12:40 +08:00
"formdata-polyfill": "^3.0.9",
Fix calendar event cutoff for specific time ranges The actual fix was applied to the fullcalendar package we are using. This just bumps our local version to apply the fix in canvas-lms. The fix in fullcalendar can be seen here: https://github.com/instructure/fullcalendar/pull/1/files fixes COMMS-268 Test Plan: - Navigate to the calendar - Create a new 50 minute even (ie, from 8:00 to 8:50) with a title - Switch the calendar to week view - Notice that the bottom half of the title is not cut off Change-Id: I084e085d7a97039df7729870271a8691e010e4ba Reviewed-on: https://gerrit.instructure.com/137608 Reviewed-by: Ryan Shaw <ryan@instructure.com> Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Venk Natarajan <vnatarajan@instructure.com> Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
2018-01-12 00:59:21 +08:00
"fullcalendar": "https://github.com/instructure/fullcalendar.git#1108dd1c991a029ec6fd7de3337737ec5295ba97",
upgrade graphiql Test plan: graphiql works flag = none Change-Id: Ia8bd7100024cab45746a27f370d5423e6c5fa9e6 Reviewed-on: https://gerrit.instructure.com/206853 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-27 06:36:31 +08:00
"graphiql": "^0.14.2",
upgrade graphiql-explorer Change-Id: Ie853ea9bbf0dbdbf58b0f0e572ff129ec6922577 Reviewed-on: https://gerrit.instructure.com/196594 Tested-by: Jenkins Reviewed-by: Rob Orton <rob@instructure.com> QA-Review: Rob Orton <rob@instructure.com> Product-Review: Rob Orton <rob@instructure.com>
2019-06-05 05:11:11 +08:00
"graphiql-explorer": "^0.4.2",
Add graphiql-explorer to canvas' graphiql instance The graphiql-explorer makes it easy to explore the schema and build queries simply by checking the boxes next to fields from the schema test plan: - /graphiql still works as expected, but includes the explorer panel - canvas features that leverage graphql still work as expected (since the version of the graphql js client was updated) Change-Id: Ief625c6fb59e4e32e23a177f3b566aae271ab108 Reviewed-on: https://gerrit.instructure.com/181586 Tested-by: Jenkins Reviewed-by: Carl Kibler <ckibler@instructure.com> QA-Review: Carl Kibler <ckibler@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2019-02-13 23:29:15 +08:00
"graphql": "^14",
upgrade to apollo 2.1 closes RECNVS-377 Test plan: make sure student context cards work Change-Id: Ib306e0be5d51f68afad0ff112bf745d9e0ad1d5b Reviewed-on: https://gerrit.instructure.com/145501 Tested-by: Jenkins Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com> QA-Review: Collin Parrish <cparrish@instructure.com> Product-Review: Cameron Matheson <cameron@instructure.com>
2018-03-27 01:32:21 +08:00
"graphql-tag": "^2.8.0",
Get i18n-js and i18nliner from npm, not vendor closes: CORE-1201 test plan: * the qunit & selenium tests that we have around this should still pass (except for that one that had to be changed because the spec was actually expecting the wrong thing and the old code was erroneous) * load the app in fully production build and make sure translations still work Change-Id: Id06c38f60c1670fb93e85d5479ec747035c1158b Reviewed-on: https://gerrit.instructure.com/143456 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-03-14 04:10:14 +08:00
"i18n-js": "^3",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"ic-ajax": "~2.0.1",
"ic-tabs": "0.1.3",
upgrade immer and immutability-helper npm deps here are 2->3 changes from immutability-helper Huge thanks to @jedmao for converting the library to typescript! New: TypeScript definitions are now generated from TypeScript source. meaning they will always be 100% in sync w/ the source code. New: exported Context class. Deprecated: stop using const myUpdate = newContext().update and start using const myContext = new Context(); myContext.update(...). Deprecated: stop using update.extend and start using import { extend } from 'immutability-helper' or const { extend } = new Context(). test plan: * the only thing that uses immer is the assignments_2 teacher stuff, that should still work * discussions, gradingPeriods, and the CreateOrUpdateUserModal use immutability-helper, those should still all work Change-Id: If6b62788be5d3929b5a0ddd64e1b63aa09916b84 Reviewed-on: https://gerrit.instructure.com/205773 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-20 08:55:20 +08:00
"immer": "^3",
"immutability-helper": "^3",
Configurable proficiency ratings page closes OUT-1856, OUT-1858, OUT-2239, OUT-2148 This adds configurable proficiency ratings on the account rubrics page. Persisting these changes will occur in a future patchset (2252). Validating order will be in a separate patchset (2240). test plan: - with the "non-scoring rubrics" feature flag off, the account rubrics page should appear without the proficiency ratings tab - with the "non-scoring rubrics" feature flag on, the accounts rubrics page should appear with the proficiency tab, if visiting with an account with "manage_outcomes" permission (e.g. account admin) - create an account role that has "Create and edit assessing rubrics" permission enabled but "Manage learning outcomes" disabled by going to the account page, click on the "Permissions" link in the left menu, then select the "Account Roles" tab to then be able create the role and enable the permission above. - create an account user by going to the account page and then click on the "People" link in the left menu to then be able to click on "+ New User". you'll use the email address entered in the next step. - make that user an account admin by going to the account page, click on the "Settings" link in the left menu, then select the "Admins" tab, then click on "+ Account Admins". select the new role from the drop down menu and enter the email address you used in the preivous step - confirm with the feature flag enabled, that visiting the account rubrics page does not appear with the proficiency tab, if visiting with an account without "manage_outcomes" permission (e.g. masquerade as the user created above) - on the proficiency tab, test error handling: * description is required * points is required, should be a valid number * when saving changes, all fields with errors should be labelled with an error text, with the first field receiving focus Change-Id: Ic52ef9fe9c58cfb215216b3a505ef1fb4b851c68 Reviewed-on: https://gerrit.instructure.com/150841 Reviewed-by: Michael Brewer-Davis <mbd@instructure.com> Reviewed-by: Frank Murphy <fmurphy@instructure.com> Tested-by: Jenkins QA-Review: Dariusz Dzien <ddzien@instructure.com> Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-04-10 09:20:00 +08:00
"immutable": "^3.8.2",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"is-valid-domain": "^0.0.11",
Speed up $.support checks that were for old IE versions closes: CORE-3020 Doing these feature detections takes my chrome browser on a fast MacBookPro 21ms. See: https://cl.ly/868790d66a8f I hate to actually make any changes here but these are all things That no browser that we support doesn’t support. And getting a flat 21ms boost on every pageload I think might be worth it. To see the actual changes, look at this commit on GitHub: https://github.com/ryankshaw/jquery/commit/dadf794ebc4c4dcf94c344dab7d9 Change-Id: I836f0ac19ae234fc789423d833a20b760fd42dc7 Reviewed-on: https://gerrit.instructure.com/195704 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-05-30 05:29:19 +08:00
"jquery": "https://github.com/ryankshaw/jquery.git#dadf794ebc4c4dcf94c344dab7d9341d46bc17cc",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"jquery-getscrollbarwidth": "^1.0.0",
"jquery-ui-touch-punch": "^0.2.3",
"jquery.cookie": "^1.4.1",
Update yarn/npm dependencies this will make it so we can use karma with the latest node. once the commit to upgrade d3 is merged, that was the only other thing we needed to do to have everything working on node 8. Change-Id: I820b27ee3da38818b69554c6e409a2177370ca34 Reviewed-on: https://gerrit.instructure.com/136752 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-01-03 06:24:44 +08:00
"jquery.elastic": "1.0.0",
get window.location.orgin polyfill from npm …instead of the copy-pasta’ed one in our repo Test plan: Make sure the files search results page works in ie11 Change-Id: I61433363eda53d44b897bf1f88837cef7c239f87 Reviewed-on: https://gerrit.instructure.com/135141 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-09 08:32:58 +08:00
"location-origin": "^1.1.4",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"lodash": "^4.16.4",
"md5": "^2.2.1",
Upgrade mediaelement to latest master of our fork Fixes: CORE-1091 show controls when they receive focus (#39) if controls are visibly hidden, they should still be tabbable for accessibility, and when they get keyboard-focused, they should become visible again. See: https://github.com/instructure/mediaelement/commit/0402b2b76 Change-Id: Ic655d43a64d111662f8d7368f21032664a8aee74 Reviewed-on: https://gerrit.instructure.com/142693 Tested-by: Jenkins Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-03-07 00:03:37 +08:00
"mediaelement": "https://github.com/instructure/mediaelement.git#master",
Pass correct locale to Planner Sometimes ENV.LOCALE and ENV.MOMENT_LOCALE are different (zh-Hans v zh-cn or mi v mi-nz). We were passing the former to planner, but moment needs the full locale, including language and region identifiers, and formatMessage copes with the full locale just fine, so we really need to pass in the latter or moment eventually blows up. So mi-nz month names would successfully parse, had to both bump our version of moment and tweak the canvas customized mi-nz locale data. to test, you'll have to run yarn to update moment, then build with RAILS_LOAD_ALL_LOCALES=1 yarn build Note on the changes to timezoneSpec.js: - some of the specs were parsing dates like "Mon, Aug 3", which are being interpreted in the current year, when Aut 3 is not a Monday. Resolved this by using MockDate to pretend today is 2/1/2015 - moment does not always interpret the Chinese characters for evening as implying PM. I'm assuming canvas will never need that particular construct and commented out the failing string. - there's one date-time that's getting the date totally wrong. - Fixed grammatically incorrect instances of '8月 3, 2015' to ''8月 3日, 2015' - fix cases where the year is coming after the month and day, which would never really happen fixes ADMIN-1331 test plan: - have a student in course so planner is enabled. - go to /profile/settings and Edit - change the Language to Reo Māori (Aotearoa) and "Update Settings" - go to the planner dashboard - click on + to create a new todo > expect you can create a todo. If you want, you can repeat with any of the languages listed in the ticket just to prove ^that wasn't a fluke. Change-Id: I9ba069ef61529088ab92271d7857998df6bbc409 Reviewed-on: https://gerrit.instructure.com/161206 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> Reviewed-by: Mysti Sadler <mysti@instructure.com> Reviewed-by: Jeremy Stanley <jeremy@instructure.com> QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2018-08-18 03:21:04 +08:00
"moment": "^2.10.6",
Backport instUI fix to allow themeable w/ `class`es We made this change in @instructure/ui-themeable in g/203714 but that is for the current master on instUI 6, we need it now even though we are still on instUI 5 so this will back port it in so we can use it now. Test plan: * Things that use `themeable` should work both with and without the “Drop ie11” commit applied. Specifically: bin/rspec ./spec/selenium/dashboard/planner/student_planner_assignments_spec.rb:88 Should not fail with TypeError: Class constructor Yr cannot be invoked without 'new' Change-Id: I7ef8ef9eda1057badabbb08fcdd6875ad8064e89 Reviewed-on: https://gerrit.instructure.com/203950 Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-06 06:43:39 +08:00
"newless": "^0.3.0",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"normalize-scroll-left": "^0.2",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"page": "visionmedia/page.js#1.6.4",
update parse-decimal-number to 1.0.0 A hack can be removed for parsing numbers now that 1.0.0 incorporates the needed behavior. test plan: * verify Jenkins passes Change-Id: Ifaea8fd348f4f804e9a6042fb392c699badeea6e Reviewed-on: https://gerrit.instructure.com/138046 Tested-by: Jenkins Reviewed-by: Derek Bender <djbender@instructure.com> Reviewed-by: Ryan Shaw <ryan@instructure.com> Product-Review: Jeremy Neander <jneander@instructure.com> QA-Review: Jeremy Neander <jneander@instructure.com>
2018-01-17 00:52:42 +08:00
"parse-decimal-number": "1.0.0",
Put parse-link-header back in package.json …since we use it in our code It used to be there, but somehow someone deleted it on accident Change-Id: Id516fdb8507887ffed9450869654fc42a4afc415 Reviewed-on: https://gerrit.instructure.com/151898 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-31 02:03:31 +08:00
"parse-link-header": "^1",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"prop-types": "^15",
update qs dependency test plan: * Verify Jenkins passes? Change-Id: If472d2f898e4241d0d10dfd7f1ca5094ecf9d811 Reviewed-on: https://gerrit.instructure.com/184039 Tested-by: Jenkins Reviewed-by: KC Naegle <knaegle@instructure.com> Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Jeremy Neander <jneander@instructure.com>
2019-03-07 00:43:35 +08:00
"qs": "^6.6.0",
upgrade React to 16.9.0 note: this will start logging a lot of deprecation warnings from React about stuff like componentWillMount and componentWillReceiveProps. Teams should update their code to not use those things so those Deprecations go away Test plan: * automated builds should pass Change-Id: I42a340dacdb43d410c7246945c025e0eb83220fa Reviewed-on: https://gerrit.instructure.com/205772 Reviewed-by: Ryan Norton <rnorton@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-20 08:53:24 +08:00
"react": "^16.9.0",
upgrade react-apollo to 3.x.x closes COMMS-2316 TEST PLAN ------------------------------- all tests pass Change-Id: I0c270bb7a8d5dfa166641648841e619a1a21c0f4 Reviewed-on: https://gerrit.instructure.com/206348 Reviewed-by: Matthew Lemon <mlemon@instructure.com> Tested-by: Jenkins QA-Review: Ben Nelson <bnelson@instructure.com> Product-Review: Ben Nelson <bnelson@instructure.com>
2019-08-22 00:54:59 +08:00
"react-apollo": "^3.0.1",
Upgrade react-dnd so it works w/ react 16 Closes: CORE-1871 The react-dnd commit that first added react 16 to its peerDeps (https://github.com/react-dnd/react-dnd/commit/c6123fad317) First appeared in v2.5.2 so we need at least that version If we are going to use react 16 Test plan: * dashboard card and discussion reordering should still work like they always have Change-Id: I74b47949f3d0f7084c350d24a8de41139f535732 Reviewed-on: https://gerrit.instructure.com/164071 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-09-12 05:22:47 +08:00
"react-dnd": "^2.5.2",
"react-dnd-html5-backend": "^2.5.2",
upgrade React to 16.9.0 note: this will start logging a lot of deprecation warnings from React about stuff like componentWillMount and componentWillReceiveProps. Teams should update their code to not use those things so those Deprecations go away Test plan: * automated builds should pass Change-Id: I42a340dacdb43d410c7246945c025e0eb83220fa Reviewed-on: https://gerrit.instructure.com/205772 Reviewed-by: Ryan Norton <rnorton@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-20 08:53:24 +08:00
"react-dom": "^16.9.0",
fix expand/contract all buttons in new sLMGB closes OUT-2232 Test plan: - enable non-scoring rubrics - load student LMGB with multiple outcome groups, outcomes, and outcome results - verify that expanding and contracting the groups and outcomes works as expected - verify that after contracting a group and then re-expanding, the outcomes within the group are contracted - verify that the expand all and contract all buttons at the top of the page are enabled and disabled at the appropriate times - expand all: should be enabled when any element is contracted - contract all: should be enabled when any element is expanded - verify that the expand all/contract all buttons work as expected Change-Id: Ifbe02e900459faed8d411afb2bb9410a885a2237 Reviewed-on: https://gerrit.instructure.com/152103 Tested-by: Jenkins Reviewed-by: Matt Berns <mberns@instructure.com> Reviewed-by: Frank Murphy <fmurphy@instructure.com> QA-Review: Dariusz Dzien <ddzien@instructure.com> Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-06-01 05:13:10 +08:00
"react-immutable-proptypes": "^2.1.0",
Developer key scopes UI (functioning skeleton) Closes PLAT-3314 Test Plan - Enable new developer key FFs - Navigate to the developer keys page of an account - Verify all scope groups are rendered in the new scopes list component. - Verify the filter allows filtering by scope group name. - Verify the "Read Only GET" checkbox causes all scopes that use GET to be checked. - Go crazy testing checkboxes and make sure they all work logically (i.e. selecting the group level checkbox checks all scopes in the group). - Verify that each group shows a list of methods for all selected scopes. - Verify you can still create developer keys in root accounts and site admin. Change-Id: I5df402ca06740e8a1ff37c21b63d2d6d58720182 Reviewed-on: https://gerrit.instructure.com/149242 Reviewed-by: Marc Alan Phillips <mphillips@instructure.com> Tested-by: Jenkins QA-Review: August Thornton <august@instructure.com> Product-Review: Jesse Poulos <jpoulos@instructure.com>
2018-04-27 04:24:36 +08:00
"react-lazy-load": "^3.0.13",
Upgrade react-modal so it works with react 16 I know I said that the way forward was to just not use react-modal and use instUI modal instead but there are a bunch of things that _are_ Using it and I don’t want changing all those to be blockers for react16 if this will work. I still want us to get rid of react-modal, just don’t want it to be a blocker for react 16 Test plan: Things that use react-modal should still work the same as before. Check: * the color picker used on the calendar sidebar * the external apps stuff that has modals * the file preview modal in files * the “find appointment” modal in scheduler Change-Id: I606eda110782cd3300fcbb2f8052681fa5048050 Reviewed-on: https://gerrit.instructure.com/164232 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-09-13 03:05:43 +08:00
"react-modal": "^3",
Update react-redux to 5.1.1 test plan: - automated tests pass Change-Id: I6c1034ec8f443d10d39b5b551c1b7207e5191411 Reviewed-on: https://gerrit.instructure.com/173814 Tested-by: Jenkins Product-Review: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com>
2018-11-30 08:54:31 +08:00
"react-redux": "^5.1.1",
upgrade react-token-input so it supports react 16 closes: CORE-1885 Test plan: * make sure the token input that appears when you edit assignment due date Overrides on the assignment overrides page still works Like it did before. Here’s it’s original test plan: new due dates selection UI - on assignments, quizzes & discussions pages - with DA on and off - assign various due dates/(un)lock dates to source sections, individuals, and everybody - these should create overrides that properly take students/sections and dates - validations should work for all dates as normal and not let empty overrides get created (with no students or sections) - the names of overrides should properly update as students change - as more overrides get created, saving assignments should not slow down significantly - the student/section selector should be intuitive * the “new grading period set” form should work as it did before. Here’s it’s original test plan: A new button "+ Add Grading Period Set" is on the Grading Period Sets page. This allows a new set to be named and associated with as many terms as needed. To begin, visit the Grading page for an account (e.g. /accounts/1/grading_standards) and click "+ Set of Grading Period" and within this form ensure the following: 1. Given no name in the "Set name" field, when clicking the "Create" button a flash message is displayed and the set is not saved 2. Given no enrollment terms in the "Attach terms", when clicking the "Create" button a flash message is displayed and the set is not saved 3. Given a name and at least one attached enrollment term, when clicking the "Create" button an AJAX call successfully persists to the database and the new set is displayed on the page along with a successful flash message 4. When the form is open, the "+ Set of Grading Periods" button is disabled 5. When the form is in the process of creating a new set, the "Create" and "Cancel" button is disabled 6. Clicking close at any other time closes the form and re-enables the "+ Set of Grading Periods" button and all data in the form is cleared Change-Id: Ibb0290202b5dcf00ec42a4bb6d1c3d2e3d7a3b2b Reviewed-on: https://gerrit.instructure.com/164492 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-09-14 23:20:08 +08:00
"react-tokeninput": "^2.5.0",
bump npm-run-all version Change-Id: Ieae7ac480124e52050c79ca83c99a7fe698c48d5 Reviewed-on: https://gerrit.instructure.com/173262 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Gary Mei <gmei@instructure.com> Product-Review: Gary Mei <gmei@instructure.com>
2018-11-27 02:20:33 +08:00
"react-transition-group": "^1",
Update redux to 4.0.1 test plan: - automated tests pass Change-Id: I00260366f32e0407eaf4277b5b2d26d9896915ac Reviewed-on: https://gerrit.instructure.com/173813 Tested-by: Jenkins Product-Review: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com>
2018-11-30 08:52:22 +08:00
"redux": "^4.0.1",
Update redux-actions to 2.6.4 test plan: - automated tests pass Change-Id: I82969f661e78370c8a2f9035c2bca7d2397fb377 Reviewed-on: https://gerrit.instructure.com/173815 Tested-by: Jenkins Product-Review: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com>
2018-11-30 08:57:55 +08:00
"redux-actions": "^2.6.4",
Update redux-thunk to 2.3.0 test plan: - automated tests pass Change-Id: I3417cc46a9581dd4fe72fc96f8c8e995b90303fd Reviewed-on: https://gerrit.instructure.com/173816 Tested-by: Jenkins Product-Review: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com>
2018-11-30 09:00:13 +08:00
"redux-thunk": "^2.3.0",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"spin.js": "2.3.2",
"swfobject": "^2.2.1",
"tablesorter": "^2.28.5",
bump bigeasy/timezone to 1.0.18 (2018e) fixes CORE-1985 Change-Id: Ia9d5eddf1462de2226e43012f4756fc1f9b93c25 Reviewed-on: https://gerrit.instructure.com/168277 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2018-10-16 01:36:11 +08:00
"timezone": "^1.0.18",
move things from “devDeps” to “dependencies” Closes CNVS-39744 we used to only have the things needed to compile brandable_css in “Dependencies”. This was because, when we used to have to run brandable_css on a job server when someone pressed “preview” in the theme editor, we only wanted to have the minimum amount of node_modules installed there to do that. But now that we no longer have to do any brand-specific css compiling we can just do what is considered normal and put anything that actually goes on the page in “dependencies” and leave all the build tooling, linting, etc stuff in devDependencies. This also makes it so it is really easy to see the cases that we might be loading 2 versions of something in our webpack bundles by running `yarn install --prod --flat`. Whatever that prompts you about is something that will be included more than once in our webpack bundles. Test plan: * run `yarn install` * it should not generate a new yarn.lock because everything is the same versions as before. Change-Id: I87b88f50d2cdbe494f928e5418e8540da9cc084c Reviewed-on: https://gerrit.instructure.com/128244 Tested-by: Jenkins Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-10-04 01:05:04 +08:00
"tinycolor2": "1.4.1",
upgrade tinymce-a11y-cheker to work with tinyMCE 5 Closes: CORE-2727 CORE-2728 CORE-2729 This version works with both 5.x and 4.x of tinymce, so it will be fine To use for both the old code and the new code Test plan: * smoke test to make sure that the a11y checker works just like it used to * in my following commit that upgrades to tinymce 5, you should not see Errors about the a11y_checker plugin not working with tinymce 5 Change-Id: I220e79a5c5e04fc589d906adde83ab4c7ebb5794 Reviewed-on: https://gerrit.instructure.com/188187 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2019-04-04 01:31:39 +08:00
"tinymce-a11y-checker": "^2",
Configurable proficiency ratings page closes OUT-1856, OUT-1858, OUT-2239, OUT-2148 This adds configurable proficiency ratings on the account rubrics page. Persisting these changes will occur in a future patchset (2252). Validating order will be in a separate patchset (2240). test plan: - with the "non-scoring rubrics" feature flag off, the account rubrics page should appear without the proficiency ratings tab - with the "non-scoring rubrics" feature flag on, the accounts rubrics page should appear with the proficiency tab, if visiting with an account with "manage_outcomes" permission (e.g. account admin) - create an account role that has "Create and edit assessing rubrics" permission enabled but "Manage learning outcomes" disabled by going to the account page, click on the "Permissions" link in the left menu, then select the "Account Roles" tab to then be able create the role and enable the permission above. - create an account user by going to the account page and then click on the "People" link in the left menu to then be able to click on "+ New User". you'll use the email address entered in the next step. - make that user an account admin by going to the account page, click on the "Settings" link in the left menu, then select the "Admins" tab, then click on "+ Account Admins". select the new role from the drop down menu and enter the email address you used in the preivous step - confirm with the feature flag enabled, that visiting the account rubrics page does not appear with the proficiency tab, if visiting with an account without "manage_outcomes" permission (e.g. masquerade as the user created above) - on the proficiency tab, test error handling: * description is required * points is required, should be a valid number * when saving changes, all fields with errors should be labelled with an error text, with the first field receiving focus Change-Id: Ic52ef9fe9c58cfb215216b3a505ef1fb4b851c68 Reviewed-on: https://gerrit.instructure.com/150841 Reviewed-by: Michael Brewer-Davis <mbd@instructure.com> Reviewed-by: Frank Murphy <fmurphy@instructure.com> Tested-by: Jenkins QA-Review: Dariusz Dzien <ddzien@instructure.com> Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-04-10 09:20:00 +08:00
"uuid": "^3.2.1"
move napa from "devDependencies" to "dependencies" Change-Id: I4dde9458868cd5c1c41b921414dff4b3dc9371de Reviewed-on: https://gerrit.instructure.com/29878 Reviewed-by: Simon Williams <simon@instructure.com> Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> Tested-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
2014-02-11 02:29:11 +08:00
},
AMD Conversion "Trivial" JavaScript / CoffeeScript changes -------------------------------------------------- For the most part, all javascript was simply wrapped in `require` or `define`. The dependencies were found with a script that matched regexes in the files, it errs on the side of listing too many dependencies, so its worth double checking each file's dependencies (over time, anyway). i18n API changes -------------------------------------------------- No longer have to do I18n.scoped calls, just list i18n as a dependency with the scope and it's imported already scoped require ['i18n!some_scope'], (I18n) -> I18n.t 'im_scoped', 'I'm scoped!' JS bundling now done with r.js, not Jammit -------------------------------------------------- We don't use jammit to bundle JS anymore. Simply list dependencies for your JS modules in the file and RequireJS handles the rest. To optimize the JavaScript, first make sure you have node.js 0.4.12+ installed and then run: $ rake js:build The app defaults to the optimized build in production. You can use non-optimized in production by putting ?debug_assets=true in the url just like before. You can also test the optimized JavaScript in development with ?optimized_js=true. Significant changes -------------------------------------------------- These files have "real" changes to them (unlike the JavaScript that is simply wrapped in require and define). Worth taking a really close look at: - app/helpers/application_helper.rb - app/views/layouts/application.html.erb - config/assets.yml - config/build.js - lib/handlebars/handlebars.rb - lib/i18n_extraction/js_extractor.rb - lib/tasks/canvas.rake - lib/tasks/i18n.rake - lib/tasks/js.rake Change-Id: I4bc5ecb1231f331aaded0fef2bcc1f3a9fe482a7 Reviewed-on: https://gerrit.instructure.com/6986 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Ryan Florence <ryanf@instructure.com>
2011-11-11 00:31:45 +08:00
"devDependencies": {
upgrade react-apollo to 3.x.x closes COMMS-2316 TEST PLAN ------------------------------- all tests pass Change-Id: I0c270bb7a8d5dfa166641648841e619a1a21c0f4 Reviewed-on: https://gerrit.instructure.com/206348 Reviewed-by: Matthew Lemon <mlemon@instructure.com> Tested-by: Jenkins QA-Review: Ben Nelson <bnelson@instructure.com> Product-Review: Ben Nelson <bnelson@instructure.com>
2019-08-22 00:54:59 +08:00
"@apollo/react-testing": "^3.0.1",
Upgrade to babel 7 & allow any js file to be themeable closes: CORE-2699 CORE-2700 UIDEV-99 This commit gets canvas-lms itself upgraded to babel 7. To do that we also had to upgrade jest to v24. We had already got canvas-rce and canvas-planner on jest24/babel7 but now this gets everything to babel 7. so you will see a lot of things removed from yarn.lock since we don’t don’t have to have different versions of everything for babel and jest The other major thing this does is make it so any JS file in canvas can become an @instructure/ui-themeable themeable component. This means you no longer should have to put your css in app/stylesheets for any new react components that you are writing. Test plan: 1. Make sure that the perf of `yarn build:js` is on-par with what it was before. We pass everything through the themeable babel transform now so there is a chance it is slower. If it is majorly slower, we’ll have to figure something out. 2. run a production weback build. The common (or any bundle for that matter should get output exactly the same as it did before) things to manually qa check: * in a NODE_ENV=production enviornment, go to /accounts/site_admin/developer_keys * click the "+ Developer Key" button, it should open the modal. (there are selenium tests that do this, but it was one thing that had to be fixed to get jenkins to pass) * on a course that is set up as a master course, click on the thing that opens the blueprint courses tray. * verify that when you click "Associations" and "Sync History" links in that tray, that they dynamically load the webpack chunk for the modal contents for that thing and then the modal is shown (again, there are selenium specs that test that exact thing but it is always good to manually test it too) Change-Id: I802584228962b54480a500f8fe422f45c2dcac4c Reviewed-on: https://gerrit.instructure.com/183965 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 05:20:27 +08:00
"@babel/cli": "^7.0.0",
"@babel/core": "^7.0.0",
Now that i18nliner can understand it, turn back on fragments The previous commit makes it so i18nliner can understand <> instead of <React.Fragment>, so this turns back on the eslint rule we had to turn Off Test plan: * run bin/rake i18n:generate_js (or let the Jenkins builds run) * it should pass Change-Id: Ia3204cd6c3147eb52ca612adbb3b20b2df8c6921 Reviewed-on: https://gerrit.instructure.com/205378 Tested-by: Jenkins Reviewed-by: Ed Schiebel <eschiebel@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-16 05:46:07 +08:00
"@babel/parser": "^7",
add @babel/plugin-transform-react-inline-elements closes: CORE-2749 Now that we use babel-transform-runtime, we can also do this to improve performance over the existing React.createElement calls by inlining the result of what it would have returned. see https://github.com/facebook/react/issues/3228 for why this improves runtime perf so for an example, say you have: const foo = <div className="bar" style={{color: 'red'}}>The Text</div> normally babel would transform that to: var foo = React.createElement("div", { className: "bar", style: { color: 'red' } }, "The Text"); but this will transform it to: var foo = _jsx("div", { className: "bar", style: { color: 'red' } }, void 0, "The Text"); That React.createElement is a lot more complex and slower at runtime, This should make things faster at runtime TEST PLAN: * bundle sizes should stay the same but js runtime for react “render”ing Should be faster in production mode Change-Id: I075d249b9effd0af1b16b9e35c1ddd27696c6955 Reviewed-on: https://gerrit.instructure.com/188865 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-04-10 00:46:49 +08:00
"@babel/plugin-transform-react-inline-elements": "^7.2.0",
rename canvas-supported-browsers to browserslist-config-canvas-lms this is to get it to work with how browserslist/autoprefixer/babel/ @instructure/ui-babel-preset expect things to work. We had to change the name because https://github.com/browserslist/browserslist#shareable-configs Says: For security reasons, external configuration only supports packages that have the browserslist-config- prefix. npm scoped packages are also supported, by naming or prefixing the module with @scope/browserslist-config, such as @scope/browserslist-config or @scope/browserslist-config-mycompany And we have to add: "browserslist": ["extends @instructure/browserslist-config-canvas-lms"], to all of our package.jsons that use @instructure/ui-babel-preset because that by default will use "extends @instructure/browserslist-config-instructure—ui" which would still do all the stuff for IE11 Test plan: * run `yarn` * all those errors about browserslist and postcss should not show uo * look at the code in public/dist for canvas-planner, * It should not include regenerator-runtime and you should see native `async` functions Change-Id: Ic84c13ac59d58963c12b8365b3068b5da3ee618d Reviewed-on: https://gerrit.instructure.com/204251 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-08 03:10:17 +08:00
"@instructure/browserslist-config-canvas-lms": ">=2",
"@instructure/ui-babel-preset": "^6",
Add release tracking and source map uploading to sentry This makes it so our sentry instance can be much more detailed in the data that it collects Change-Id: If44ea7bc54646988d681e6ad775951eb0e35436a Reviewed-on: https://gerrit.instructure.com/154010 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-06-16 01:28:53 +08:00
"@sentry/webpack-plugin": "^1.5.2",
A2: implement delete button closes ADMIN-2233 test plan: - click the delete button which will open a confirmation dialog that roughly matches the design - a11y for the dialog should make sense - the close button should dismiss the dialog with no effect - the cancel button should dismiss the dialog with no effect - the delete button should start a delete operation - when the delete operation completes, you should be redirected to the assignment index screen with a message indicating the assignment has been deleted - if your user does not have permission to delete the assignment, or some other error occurs, then the in-development error screen should be shown Change-Id: I0c3304360d3c389296bd0910d02d8215bdb0ac9e Reviewed-on: https://gerrit.instructure.com/177754 Reviewed-by: Carl Kibler <ckibler@instructure.com> Tested-by: Jenkins QA-Review: Carl Kibler <ckibler@instructure.com> Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
2019-01-15 01:33:05 +08:00
"@sheerun/mutationobserver-shim": "0.3.2",
upgrade @testing-library npm deps Change-Id: I5438f3895173d4b2b417835c6ac937dc65d160d3 Reviewed-on: https://gerrit.instructure.com/205774 Reviewed-by: Ed Schiebel <eschiebel@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-20 08:57:20 +08:00
"@testing-library/dom": "^6",
Fix Select deprecations with CanvaSelect this commit add the new CanvasSelect which wraps the new controlled-only INSTUI Select (single select only) to provide a nearly drop-in replacement for the deprecated INSTUI Select used in canvas. This new CanvasSelect is then used in people_search.js and TimeZoneSelect/index.js to resolve the deprectation warnings. changes include an upgrade to ui-select 6.8 closes ADMIN-2775, COREFE-186 COREFE-184 test plan: - nav to a course's people page - click on the +People button > expect the Role and Section selects to work as expected - nav to the account's people page - click on the pencil icon to the right of a user > expect the Time Zone select to show a blank line, then 2 groups of time zones > expect the select to work as expected > expect screenreaders to tell you interesting things as you interact with the select Change-Id: I5dcfb2c1c8ca64071ce9dbf0a194777f10c711cf Reviewed-on: https://gerrit.instructure.com/202508 Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins Product-Review: Ed Schiebel <eschiebel@instructure.com>
2019-07-23 04:58:34 +08:00
"@testing-library/jest-dom": "^4",
upgrade @testing-library npm deps Change-Id: I5438f3895173d4b2b417835c6ac937dc65d160d3 Reviewed-on: https://gerrit.instructure.com/205774 Reviewed-by: Ed Schiebel <eschiebel@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-20 08:57:20 +08:00
"@testing-library/react": "^9",
start of direct share course selection tray This includes some general utilities Note: There is a bug in the instui Tray that mounts the contents of the Tray twice, which results in multiple fetches for the managed courses. We're going to ignore this for now since the right fix is to fix Tray and not work around it. flag=direct_share refs ADMIN-2811 test plan: - On the discussions index page, click on the kabob menu for a discussion and choose "Copy To...". - A tray should open and load a list of the courses you are allowed to manage. There is no other functionality in the tray yet. Change-Id: Ic0f5e841f61cd3cdaef7b681db2907089c561665 Reviewed-on: https://gerrit.instructure.com/204331 Tested-by: Jenkins QA-Review: Carl Kibler <ckibler@instructure.com> Product-Review: Jon Willesen <jonw+gerrit@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
2019-08-08 07:23:48 +08:00
"@testing-library/react-hooks": "^2.0.1",
A script to just update instUI Closes: CORE-1709 This is what our Jenkins job to pull in every instui RC commit will use Test plan: * run `yarn upgrade-instructure-ui` * it should make a commit that has new entries in yarn.lock for all the instUI packages that uses the latest rc version on the npm registry * it should not affect anything else besides yarn.lock Change-Id: I78cce6e801015819c4e4b27e26ede352deceebb9 Reviewed-on: https://gerrit.instructure.com/160435 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-08-11 00:22:49 +08:00
"@yarnpkg/lockfile": "^1.0.2",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"axe-core": "~2.1.7",
Upgrade canvas-planner & rce to not use ui-presets This gets canvas planner and canvas-rce on babel 7, which is a prerequisite to canvas doing the same. Also, by not depending on the Kitchen sink of ui-presets, it cleans a ton of unused stuff from our node_modules/yarn.lock. It was originally 2 different commits but in order to get the yarn.lock right, we have to do them all as one. This also made it so we needed to have less “resolutions” in our package.json since the newer versions of those things work fine with the newer version of babel So there are 2 test plan areas: 1. Canvas-planner Closes: CORE-2575 Test plan: * smoke test to make sure everything in canvas-planner still works/looks like it used to in the canvas ui * make sure the translation task (yarn check-transifex) still works canvas-rce: upgrade to babel 7 & @instructure/ui-babel-preset 2. canvas-rce Closes: CORE-2576 Test plan: * smoke test the RCE editor * theming should still work/look exactly as before * make sure all the various build tasks (eg yarn test, test:coverage, debug, lint, extract, etc) all still work as before Change-Id: Id896687e3905f4df4627b181cad3f67ffe4417a5 Reviewed-on: https://gerrit.instructure.com/183877 Tested-by: Jenkins Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com> Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 02:30:44 +08:00
"babel-eslint": "^10",
Upgrade to babel 7 & allow any js file to be themeable closes: CORE-2699 CORE-2700 UIDEV-99 This commit gets canvas-lms itself upgraded to babel 7. To do that we also had to upgrade jest to v24. We had already got canvas-rce and canvas-planner on jest24/babel7 but now this gets everything to babel 7. so you will see a lot of things removed from yarn.lock since we don’t don’t have to have different versions of everything for babel and jest The other major thing this does is make it so any JS file in canvas can become an @instructure/ui-themeable themeable component. This means you no longer should have to put your css in app/stylesheets for any new react components that you are writing. Test plan: 1. Make sure that the perf of `yarn build:js` is on-par with what it was before. We pass everything through the themeable babel transform now so there is a chance it is slower. If it is majorly slower, we’ll have to figure something out. 2. run a production weback build. The common (or any bundle for that matter should get output exactly the same as it did before) things to manually qa check: * in a NODE_ENV=production enviornment, go to /accounts/site_admin/developer_keys * click the "+ Developer Key" button, it should open the modal. (there are selenium tests that do this, but it was one thing that had to be fixed to get jenkins to pass) * on a course that is set up as a master course, click on the thing that opens the blueprint courses tray. * verify that when you click "Associations" and "Sync History" links in that tray, that they dynamically load the webpack chunk for the modal contents for that thing and then the modal is shown (again, there are selenium specs that test that exact thing but it is always good to manually test it too) Change-Id: I802584228962b54480a500f8fe422f45c2dcac4c Reviewed-on: https://gerrit.instructure.com/183965 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 05:20:27 +08:00
"babel-jest": "^24",
"babel-loader": "^8",
dynamic import comments refs COMMS-1844 Test Plan: - Click on comments on an A2 student view - notice there is a loading indicator then the comments load Change-Id: I43ed778b826153b5cb4e58b9365a0016dec10897 Reviewed-on: https://gerrit.instructure.com/180618 Tested-by: Jenkins Reviewed-by: Aaron Hsu <ahsu@instructure.com> QA-Review: Landon Gilbert-Bland <lbland@instructure.com> Product-Review: Steven Burnett <sburnett@instructure.com>
2019-02-06 04:54:30 +08:00
"babel-plugin-dynamic-import-node": "^2.2.0",
support testing coffeescript with jest Change-Id: I540ad44c033e489ff49c251256263d547ca258cd Reviewed-on: https://gerrit.instructure.com/182600 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2019-02-23 14:41:33 +08:00
"babel-plugin-transform-amd-to-commonjs": "^1.4.0",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"babel-plugin-transform-react-remove-prop-types": "^0.4",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"clean-webpack-plugin": "^3",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"coffee-loader": "~0.7.2",
"coffee-script": "^1",
Yarn.lock: update all our npm dependencies closes: CORE-1909 This is the result of running: `yarn upgrade-and-dedupe` and then fixing any specs/changes that needed to happen as a result of the new versions Test plan: * automated tests should pass Change-Id: I79ec63d8eb9d7bce4d48af0cff7cee369be58884 Reviewed-on: https://gerrit.instructure.com/164790 Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-09-18 07:08:57 +08:00
"concurrently": "^4",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"core-js-builder": "^3",
"css-loader": "^3",
use web pack closes CNVS-24124 makes working with web pack possible in canvas instead of require-js. See doc/working_with_webpack.md for instructions. TEST PLAN: Nothing should change in non-webpack'd behavior Things should mostly work when you use the USE_WEBPACK environment variable, but make sure to document and ticket things that don't Change-Id: I493a259a609e9e183950bc57aa5876df70108547 Reviewed-on: https://gerrit.instructure.com/64386 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-10-01 11:16:11 +08:00
"ember-template-compiler": "^1.8.0",
upgrade enzyme to 3.x Closes: CORE-1758 After this commit, if you or your team have any specs that import from old-enzyme-2.x-you-need-to-upgrade-this-spec-to-enzyme-3.x-by-importing-just-enzyme That means you need to upgrade those spec files to use the new enzyme by changing that to `import {mount, shallow, whatever} from ‘enzyme’`. Refer to http://airbnb.io/enzyme/docs/guides/migration-from-2-to-3.html for details Test plan: * all linters-and-js-specs should pass * since this only effects js specs, that is all that really matters. no app code to QA Change-Id: I46c5d815e9d95683832d70b64e31526b943d07e5 Reviewed-on: https://gerrit.instructure.com/135136 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-09 01:29:42 +08:00
"enzyme": "^3",
upgrade react from 15.x to 16.x closes: CORE-1874 test plan: Now that the automated selenium & javascript specs pass for this the last thing we need to do is to go manually click around and see if anything breaks. The best thing to do would be to open your browser console and look for errors. Deprecation warnings or propType errors or react warnings are fine but if any actual errors get thrown that is something we want to look into. specific things to look at: * all the gradezilla/gradebook/grading stuff (specifically things that have instUI <NumberInput>s and <Select>s) * look at the submission cell editor * the gb headers (especially make sure keyboard navigation works how it should) * moderated grading * grading perid edit page / enrollment terms * speedgrader * grading standards * gradebook history * theme editor * new discussions/announcements * the new permissions page * the dasboard * student planner * dashcards * global nav trays * help menu * assignment edit page * account user/course search Change-Id: I6a1fe7df9379d9c601eda932bd8cef9c06d10cd2 Reviewed-on: https://gerrit.instructure.com/163913 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-09-11 12:13:01 +08:00
"enzyme-adapter-react-16": "^1",
add enzyme snapshot serializer to jest converts all the existing `expect(component.debug()).toMatchSnapshot()` to: `expect(component).toMatchSnapshot()` which creates more detailed and more diff-able snapshots test plan: - specs pass -- this only affects js test code Change-Id: Ib6dbcc1e3f87e61a251e4635dc68353aca57aeac Reviewed-on: https://gerrit.instructure.com/167651 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-10 03:36:49 +08:00
"enzyme-to-json": "^3.3.4",
Upgrade to babel 7 & allow any js file to be themeable closes: CORE-2699 CORE-2700 UIDEV-99 This commit gets canvas-lms itself upgraded to babel 7. To do that we also had to upgrade jest to v24. We had already got canvas-rce and canvas-planner on jest24/babel7 but now this gets everything to babel 7. so you will see a lot of things removed from yarn.lock since we don’t don’t have to have different versions of everything for babel and jest The other major thing this does is make it so any JS file in canvas can become an @instructure/ui-themeable themeable component. This means you no longer should have to put your css in app/stylesheets for any new react components that you are writing. Test plan: 1. Make sure that the perf of `yarn build:js` is on-par with what it was before. We pass everything through the themeable babel transform now so there is a chance it is slower. If it is majorly slower, we’ll have to figure something out. 2. run a production weback build. The common (or any bundle for that matter should get output exactly the same as it did before) things to manually qa check: * in a NODE_ENV=production enviornment, go to /accounts/site_admin/developer_keys * click the "+ Developer Key" button, it should open the modal. (there are selenium tests that do this, but it was one thing that had to be fixed to get jenkins to pass) * on a course that is set up as a master course, click on the thing that opens the blueprint courses tray. * verify that when you click "Associations" and "Sync History" links in that tray, that they dynamically load the webpack chunk for the modal contents for that thing and then the modal is shown (again, there are selenium specs that test that exact thing but it is always good to manually test it too) Change-Id: I802584228962b54480a500f8fe422f45c2dcac4c Reviewed-on: https://gerrit.instructure.com/183965 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 05:20:27 +08:00
"es-check": "^5",
upgrade eslint & don’t use unique one in canvas-rce instead of having our own eslint in canvas-rce, and maintaining all future rules like react hooks and stuff we can just use the same one that the rest of the repo uses. test plan: * cd packages/canvas-rce * `yarn lint` should run Change-Id: Idbe8af533f7a19035d1998538d2d6fd1a711f164 Reviewed-on: https://gerrit.instructure.com/204998 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2019-08-14 09:31:44 +08:00
"eslint": "^6",
"eslint-config-airbnb": "^18",
"eslint-config-prettier": "^6",
ESLint standardization This commit introduces a better more reasonable ESLint configuration. It removes all concerns with styling in favor of using prettier to handle those things. closes CORE-2096 Test Plan: - ESLint works Change-Id: I50b90b7191b576bce4817d885d14f18c4c72d208 Reviewed-on: https://gerrit.instructure.com/170874 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-11-03 01:48:59 +08:00
"eslint-plugin-eslint-comments": "^3.0.1",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"eslint-plugin-import": "^2",
Upgrade to babel 7 & allow any js file to be themeable closes: CORE-2699 CORE-2700 UIDEV-99 This commit gets canvas-lms itself upgraded to babel 7. To do that we also had to upgrade jest to v24. We had already got canvas-rce and canvas-planner on jest24/babel7 but now this gets everything to babel 7. so you will see a lot of things removed from yarn.lock since we don’t don’t have to have different versions of everything for babel and jest The other major thing this does is make it so any JS file in canvas can become an @instructure/ui-themeable themeable component. This means you no longer should have to put your css in app/stylesheets for any new react components that you are writing. Test plan: 1. Make sure that the perf of `yarn build:js` is on-par with what it was before. We pass everything through the themeable babel transform now so there is a chance it is slower. If it is majorly slower, we’ll have to figure something out. 2. run a production weback build. The common (or any bundle for that matter should get output exactly the same as it did before) things to manually qa check: * in a NODE_ENV=production enviornment, go to /accounts/site_admin/developer_keys * click the "+ Developer Key" button, it should open the modal. (there are selenium tests that do this, but it was one thing that had to be fixed to get jenkins to pass) * on a course that is set up as a master course, click on the thing that opens the blueprint courses tray. * verify that when you click "Associations" and "Sync History" links in that tray, that they dynamically load the webpack chunk for the modal contents for that thing and then the modal is shown (again, there are selenium specs that test that exact thing but it is always good to manually test it too) Change-Id: I802584228962b54480a500f8fe422f45c2dcac4c Reviewed-on: https://gerrit.instructure.com/183965 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 05:20:27 +08:00
"eslint-plugin-jest": "^22",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"eslint-plugin-jsx-a11y": "^6",
upgrade eslint & don’t use unique one in canvas-rce instead of having our own eslint in canvas-rce, and maintaining all future rules like react hooks and stuff we can just use the same one that the rest of the repo uses. test plan: * cd packages/canvas-rce * `yarn lint` should run Change-Id: Idbe8af533f7a19035d1998538d2d6fd1a711f164 Reviewed-on: https://gerrit.instructure.com/204998 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2019-08-14 09:31:44 +08:00
"eslint-plugin-lodash": "^6",
"eslint-plugin-notice": "^0.8",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"eslint-plugin-prettier": "^3",
"eslint-plugin-promise": "^4",
"eslint-plugin-qunit": "^4",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"eslint-plugin-react": "^7",
add react-hooks linting and update react dep Update the react dependency to 16.8 since we're starting to use react hooks, which requires that version at minimum. test plan: - linting still works - intentionally create a violation of rules-of-hooks. Linting should find and report the error. Change-Id: I0baccd64397b31118b96eb390462acf56daeca96 Reviewed-on: https://gerrit.instructure.com/199053 Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins
2019-06-26 05:24:47 +08:00
"eslint-plugin-react-hooks": "^1",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"exports-loader": "^0.7",
"expose-loader": "^0.7",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"fetch-mock": "^7",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"file-loader": "^4",
update gglobby npm dep refs: CNVS-29725 test plan: * run `node script/xsslint.js` * it should work (this is ran by jenkins so reall if it passes, it is good) Change-Id: Ib9b68e486c32c91e3c430cea095a628daf51db2b Reviewed-on: https://gerrit.instructure.com/87181 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2016-08-09 07:39:19 +08:00
"gglobby": "0.0.3",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"glob": "^7",
New mocking foundation for A2 student view tests Utilizing https://www.apollographql.com/docs/graphql-tools/mocking/ Benefits of this new approach: - Query, propTypes, and mocked data all exist in the same location, so it becomes much easier to modify. - You can easily mock data nested deeply in data without needing to manually drill down into it. - The mocked data comes from a FRD graphql query, so you cannot accidently put invalid fields into the testing data (for example, null for a string that is marked as not null). - Can save complex overrides into reusable pieces (graded submission) Fixes COMMS-2224 Test Plan: - Jenkins passes Change-Id: Ib6c3c6f3b3c16b8829d89061b41d8a4d308eb0ed Reviewed-on: https://gerrit.instructure.com/201591 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Landon Gilbert-Bland <lbland@instructure.com> Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
2019-07-12 04:45:03 +08:00
"graphql-tools": "^4",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"gulp": "^3",
"gulp-file": "^0.4",
"gulp-filter": "^5",
"gulp-insert": "^0.5",
"gulp-load-plugins": "^1",
"gulp-rename": "^1",
"gulp-rev": "^8",
"gulp-sourcemaps": "^2",
"gulp-uglify": "^3",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"handlebars": "1.3.0",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"imports-loader": "^0.8",
"istanbul-instrumenter-loader": "^3",
Add a way to generate better js coverage This should pick up coverage from both karma and jest in Canvas proper. It should also pick up coverage from anything under packages/* closes CORE-1265 Test Plan: - Run `COVERAGE=true yarn test` - Coverage reports (coverage-final.json) should generate in all packages such as (canvas-planner) as well as in coverage-karma and coverage-jest - Run `yarn run test:coverage` - coverage-js folder should be generated. Opening index.html should show the full coverage report - Remove coverage-{js, karma, jest} and packages/canvas-planner/coverage as well as .nyc_output to get back to a clean state - Run `RUN_TESTS_FIRST=true yarn run test:coverage` - All tests should run and generate the appropriate report just like the last time in coverage-js Change-Id: I50744b8977e0683e079af5bdd2865dbcd6ad9066 Reviewed-on: https://gerrit.instructure.com/146098 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-04-06 05:27:42 +08:00
"istanbul-merge": "^1.1.1",
Upgrade to babel 7 & allow any js file to be themeable closes: CORE-2699 CORE-2700 UIDEV-99 This commit gets canvas-lms itself upgraded to babel 7. To do that we also had to upgrade jest to v24. We had already got canvas-rce and canvas-planner on jest24/babel7 but now this gets everything to babel 7. so you will see a lot of things removed from yarn.lock since we don’t don’t have to have different versions of everything for babel and jest The other major thing this does is make it so any JS file in canvas can become an @instructure/ui-themeable themeable component. This means you no longer should have to put your css in app/stylesheets for any new react components that you are writing. Test plan: 1. Make sure that the perf of `yarn build:js` is on-par with what it was before. We pass everything through the themeable babel transform now so there is a chance it is slower. If it is majorly slower, we’ll have to figure something out. 2. run a production weback build. The common (or any bundle for that matter should get output exactly the same as it did before) things to manually qa check: * in a NODE_ENV=production enviornment, go to /accounts/site_admin/developer_keys * click the "+ Developer Key" button, it should open the modal. (there are selenium tests that do this, but it was one thing that had to be fixed to get jenkins to pass) * on a course that is set up as a master course, click on the thing that opens the blueprint courses tray. * verify that when you click "Associations" and "Sync History" links in that tray, that they dynamically load the webpack chunk for the modal contents for that thing and then the modal is shown (again, there are selenium specs that test that exact thing but it is always good to manually test it too) Change-Id: I802584228962b54480a500f8fe422f45c2dcac4c Reviewed-on: https://gerrit.instructure.com/183965 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 05:20:27 +08:00
"jest": "^24",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"jest-canvas-mock": "^2",
support testing coffeescript with jest Change-Id: I540ad44c033e489ff49c251256263d547ca258cd Reviewed-on: https://gerrit.instructure.com/182600 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2019-02-23 14:41:33 +08:00
"jest-config": "^24",
Use jsdom 14 instead of 11 in jest tests Test plan: * `yarn jest` should pass Change-Id: I157a55be009bae71e574ed0e9b9ff18f9e2c048b Reviewed-on: https://gerrit.instructure.com/203860 Reviewed-by: Cameron Matheson <cameron@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-06 01:45:01 +08:00
"jest-environment-jsdom-fourteen": "^0.1.0",
don’t count unread_count or dashcard indicators against newRelic load time closes: CORE-3187 AKA: Revert "Revert "don’t count unread_count or dashcard indicators against newRelic load time"" This reverts commit d754ff5ed159f8ca0a922b39be4a784f24d88f63. Test plan: * the little badges that show unread discussion counts and stuff on each dashcard should work the same as before * the badge on the global nav that shows how many unread inbox messages You have should work the same as before * if you have newRelic set up, neither should count against page load metrics Change-Id: I3b869e7fb650f40f16f514db9d8b9f558443db5b Reviewed-on: https://gerrit.instructure.com/201202 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-07-15 23:10:51 +08:00
"jest-fetch-mock": "^2.1.2",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"jest-junit": "^7",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"jest-localstorage-mock": "^2",
Extract jest-moxios-utils to its own package closes CORE-2217 Test Plan: - Automated tests pass Change-Id: Icba5c61344e22e8a8e4929b9133c9a2b89a80ef9 Reviewed-on: https://gerrit.instructure.com/174135 Tested-by: Jenkins Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-12-04 23:19:46 +08:00
"jest-moxios-utils": "^1",
add apollo graphql query validation tools These tools allow unit tests to validate that the graphql queries being run using Apollo are valid according to the server's schema. This includes validating the variables. This commit includes a fix that the validator found with overrides where a Section requires a name (String!), but a Group does not (String). To fix the validation error, we have to have separate names for these fields and handle the possibility that the group might have a null name. closes ADMIN-2561 test plan: - specs pass - can still display the "Everyone" override (when there are no overrides) - can still display the "Everyone Else" override Change-Id: Ic19605e5ee12075e9abb5bb089e0285639957b69 Reviewed-on: https://gerrit.instructure.com/188602 Reviewed-by: Mysti Lilla <mysti@instructure.com> Reviewed-by: Cameron Matheson <cameron@instructure.com> Tested-by: Jenkins QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
2019-04-06 05:50:49 +08:00
"jest-raw-loader": "^1",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"json-loader": "^0.5.7",
web pack port of quiz statistics refs CNVS-25916 remove dynamic requirements for env configs, use separate jsx loader for client apps, update client app plugin to use old react version, rewrite selenium spec to be an integration test rather than executing arbitrary javascript, and MAJORLY refactor loading patterns of client apps to avoid sharing code with differences delineated by opaque require re-writes. Also moved some code that was in "common" client app but only used by one actual client app down into the app that uses it (simplifies dependency tracing). TEST PLAN: 1) make sure quiz statistics still works ok under require js build, no behavior should have changed 2) also make sure quiz log auding works under require-js Change-Id: I0e5ee3eda9da16e0ad48cf858761735c71df801c Reviewed-on: https://gerrit.instructure.com/69804 Tested-by: Jenkins Reviewed-by: Ryan Taylor <rtaylor@instructure.com> QA-Review: Michael Hargiss <mhargiss@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com>
2016-01-07 06:31:33 +08:00
"jsx-loader": "0.11.2",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"karma": "^3",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"karma-chrome-launcher": "^2",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"karma-coverage-istanbul-reporter": "^2",
Make changes for node 12/iojs. This makes a number of changes to get the compilation compatible with node 12 and iojs. - removes loom (no longer used) - updates karma dependencies to more recent versions - minor css change to make sass compilation work with node-sass (lib-sass) test plan: - should be able to compile assets with node 12 and iojs - JS specs still pass Change-Id: Id4a0628ff0c6dd09e622d02329a4400d60459ec2 Reviewed-on: https://gerrit.instructure.com/49493 Tested-by: Jenkins Reviewed-by: Nick Houle <nhoule@instructure.com> Product-Review: Cameron Matheson <cameron@instructure.com> QA-Review: Cameron Matheson <cameron@instructure.com>
2015-02-26 06:28:11 +08:00
"karma-firework-reporter": "~0.2.4",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"karma-junit-reporter": "^1",
Update yarn.lock with newest versions of deps closes: CNVS-38384 This is just to keep our tooling up to date Test plan: * automated tests should pass * build tooling should work (meaning webpack builds In prod & dev) Change-Id: I11fbda35827487e59712c762a71540a51258d1db Reviewed-on: https://gerrit.instructure.com/120434 Tested-by: Jenkins Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-07-26 01:29:52 +08:00
"karma-qunit": "~1.2.1",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"karma-sourcemap-loader": "^0.3",
publish jUnit test result file from karma tests Test plan: * run `yarn test` * there should be xml file in coverage-js/karma-test-results.xml With the spec results that we will use for Jenkins builds Change-Id: Ic68de197d2b52dbccdf58dc2d148aef1f2ca2646 Reviewed-on: https://gerrit.instructure.com/135949 Tested-by: Jenkins Reviewed-by: Robert Lamb <rlamb@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-18 23:21:42 +08:00
"karma-spec-reporter": "^0.0.32",
Update yarn.lock with newest versions of deps closes: CNVS-38384 This is just to keep our tooling up to date Test plan: * automated tests should pass * build tooling should work (meaning webpack builds In prod & dev) Change-Id: I11fbda35827487e59712c762a71540a51258d1db Reviewed-on: https://gerrit.instructure.com/120434 Tested-by: Jenkins Reviewed-by: Simon Williams <simon@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-07-26 01:29:52 +08:00
"karma-verbose-reporter": "^0.0.6",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"karma-webpack": "^3",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"lint-staged": "^9",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"merge-stream": "^1",
Pass correct locale to Planner Sometimes ENV.LOCALE and ENV.MOMENT_LOCALE are different (zh-Hans v zh-cn or mi v mi-nz). We were passing the former to planner, but moment needs the full locale, including language and region identifiers, and formatMessage copes with the full locale just fine, so we really need to pass in the latter or moment eventually blows up. So mi-nz month names would successfully parse, had to both bump our version of moment and tweak the canvas customized mi-nz locale data. to test, you'll have to run yarn to update moment, then build with RAILS_LOAD_ALL_LOCALES=1 yarn build Note on the changes to timezoneSpec.js: - some of the specs were parsing dates like "Mon, Aug 3", which are being interpreted in the current year, when Aut 3 is not a Monday. Resolved this by using MockDate to pretend today is 2/1/2015 - moment does not always interpret the Chinese characters for evening as implying PM. I'm assuming canvas will never need that particular construct and commented out the failing string. - there's one date-time that's getting the date totally wrong. - Fixed grammatically incorrect instances of '8月 3, 2015' to ''8月 3日, 2015' - fix cases where the year is coming after the month and day, which would never really happen fixes ADMIN-1331 test plan: - have a student in course so planner is enabled. - go to /profile/settings and Edit - change the Language to Reo Māori (Aotearoa) and "Update Settings" - go to the planner dashboard - click on + to create a new todo > expect you can create a todo. If you want, you can repeat with any of the languages listed in the ticket just to prove ^that wasn't a fluke. Change-Id: I9ba069ef61529088ab92271d7857998df6bbc409 Reviewed-on: https://gerrit.instructure.com/161206 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> Reviewed-by: Mysti Sadler <mysti@instructure.com> Reviewed-by: Jeremy Stanley <jeremy@instructure.com> QA-Review: Anju Reddy <areddy@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2018-08-18 03:21:04 +08:00
"mockdate": "^2.0.2",
don’t include really old timezone data in JS bundle closes: CORE-2770 we don’t need timezone data from before canvas was created (pre 2011) or, realistically, 15 years from now. by using this moment-timezone-data-webpack-plugin we can strip them out of our webpack bundle and our common vendor JS file will be smaller. and smaller js bundles = faster page loads test plan: * try to think of a compelling reason why we would need to properly handle timezone weirdness that is either older than 2011 or more than 15 years from now * if you can think of something, then we can’t do this * run the prod webpack build, the vendor file should be smaller Change-Id: I1823fb48cc14bc0687f5222d7f4344118825698e Reviewed-on: https://gerrit.instructure.com/188810 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2019-04-09 13:47:34 +08:00
"moment-timezone-data-webpack-plugin": "^1.0.3",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"moxios": "^0.4",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"nyc": "^13",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"prettier": "^1",
Upgrade instructure-ui to 1.0 fixes CNVS-34969 test plan: - go /profile/settings and turn on high contrast - go to the course people page (/courses/#/users) - click on the +People button > expected result: the modal honors high contrast - enter some text in he text area > expected result: nothing bad happens, as the event handler for TextArea has changed. - there's a TextArea in MessageStudents also, but I don't know where to find it in the UI. You should probalby test it doesn't blow up either. Change-Id: Ia8102dacfa2b01ee043002ee0f5c27943abe5743 Reviewed-on: https://gerrit.instructure.com/102133 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Dan Sasaki Product-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2017-02-15 05:54:51 +08:00
"qunitjs": "^1.14.0",
Add raven to grab errors from test runs closes CORE-1532 Test Plan: - Run tests with SENTRY_URL environment variable set - It should attempt to send data to sentry - Build works otherwise Change-Id: Ib802851a7b3ac8626033436f60399f134a8425b3 Reviewed-on: https://gerrit.instructure.com/153878 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-06-15 03:55:22 +08:00
"raven-js": "^3.26.2",
upgrade react from 15.x to 16.x closes: CORE-1874 test plan: Now that the automated selenium & javascript specs pass for this the last thing we need to do is to go manually click around and see if anything breaks. The best thing to do would be to open your browser console and look for errors. Deprecation warnings or propType errors or react warnings are fine but if any actual errors get thrown that is something we want to look into. specific things to look at: * all the gradezilla/gradebook/grading stuff (specifically things that have instUI <NumberInput>s and <Select>s) * look at the submission cell editor * the gb headers (especially make sure keyboard navigation works how it should) * moderated grading * grading perid edit page / enrollment terms * speedgrader * grading standards * gradebook history * theme editor * new discussions/announcements * the new permissions page * the dasboard * student planner * dashcards * global nav trays * help menu * assignment edit page * account user/course search Change-Id: I6a1fe7df9379d9c601eda932bd8cef9c06d10cd2 Reviewed-on: https://gerrit.instructure.com/163913 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> QA-Review: Tucker McKnight <tmcknight@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-09-11 12:13:01 +08:00
"react-test-renderer": "^16",
Update redux-logger to 3.0.6 test plan: - automated tests pass Change-Id: Iaf8b223e7c60a43f5b4e10561d5d66643a312992 Reviewed-on: https://gerrit.instructure.com/173817 Tested-by: Jenkins Product-Review: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com>
2018-11-30 09:03:38 +08:00
"redux-logger": "^3.0.6",
make feature flags for Right To Left layout Closes: CORE-1154 There are 2 feature flags here. One a specific user (internal employees, sales people, contractors, etc) can turn on to see where we are and what would still need to be done. And the other is for an account to be able to turn on to let the users in their account that have their language set to an RTL language (eg: Arabic, Farsi or Hebrew) see the interface in RTL This commit is part of a chain of commits. you'll need to apply the ones that follow-on after this to see most of the actual Right To Left features, this commit is mainly just to create the feature flag. Test plan: * go to your user settings page * you should see a feature option for Force RTL Layout” * it should show that it is “in development” * it should should be hidden: eg: only appears for site admins and not For normal users * turn it on (if you have this checked out along with the others that follow beind this commit) * navigate around canvas, most things on most pages should be RTL * you should be able to get an idea of how much more work and what Kind of changes we’d still need to make to get it 100% * now turn off that user feature flag, and go to your account's settings * turn on the "allow users from RTL languages to see RTL layout" account-level feature flag. * nothing should change for you, it should be LTR like normal * set your language to either Arabic, Farsi or Hebrew * now the interface should all be in right to left. (again, you'll need to have the follow-on commits to this to see all of the RTL changes) * without either of the feature flags turned on, absolutely nothing should be different at all anywhere in the interface. Change-Id: Ia78d86fa46d2d289b1913c5d1340546d7f6c3a1f Reviewed-on: https://gerrit.instructure.com/143891 Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins
2018-03-17 02:25:14 +08:00
"sass-direction": "^1",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"script-loader": "^0.7",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"sinon": "^7",
Add @instructure/uid dependency to canvas test plan: yarn test:karma builds w/o errors Change-Id: I631dabdf9214e2d44bedaa4f4ff1451fcc0e76b0 Reviewed-on: https://gerrit.instructure.com/206016 Reviewed-by: Carl Kibler <ckibler@instructure.com> Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Carl Kibler <ckibler@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Tested-by: Jenkins
2019-08-21 22:55:36 +08:00
"style-loader": "^0.23",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"stylelint": "^10",
"through2": "^3",
Upgrade canvas-planner & rce to not use ui-presets This gets canvas planner and canvas-rce on babel 7, which is a prerequisite to canvas doing the same. Also, by not depending on the Kitchen sink of ui-presets, it cleans a ton of unused stuff from our node_modules/yarn.lock. It was originally 2 different commits but in order to get the yarn.lock right, we have to do them all as one. This also made it so we needed to have less “resolutions” in our package.json since the newer versions of those things work fine with the newer version of babel So there are 2 test plan areas: 1. Canvas-planner Closes: CORE-2575 Test plan: * smoke test to make sure everything in canvas-planner still works/looks like it used to in the canvas ui * make sure the translation task (yarn check-transifex) still works canvas-rce: upgrade to babel 7 & @instructure/ui-babel-preset 2. canvas-rce Closes: CORE-2576 Test plan: * smoke test the RCE editor * theming should still work/look exactly as before * make sure all the various build tasks (eg yarn test, test:coverage, debug, lint, extract, etc) all still work as before Change-Id: Id896687e3905f4df4627b181cad3f67ffe4417a5 Reviewed-on: https://gerrit.instructure.com/183877 Tested-by: Jenkins Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com> Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-06 02:30:44 +08:00
"waait": "^1",
upgrade webpack to v4 Closes: CORE-1143 Test plan: * load canvas in prod mode in a non-English language. Click around And make sure everything works * in prod mode, do a test to compare load time to what’s on beta. * page load time and js bundle size should be smaller * click around in the quizzes client apps and the ember grade book And make sure those things work Change-Id: I93c28c4a6d22db95cd1c7e59cd3f5221d46fe1ed Reviewed-on: https://gerrit.instructure.com/143422 Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
2018-03-07 10:12:53 +08:00
"webpack": "^4",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"webpack-cleanup-plugin": "^0.5",
upgrade webpack to v4 Closes: CORE-1143 Test plan: * load canvas in prod mode in a non-English language. Click around And make sure everything works * in prod mode, do a test to compare load time to what’s on beta. * page load time and js bundle size should be smaller * click around in the quizzes client apps and the ember grade book And make sure those things work Change-Id: I93c28c4a6d22db95cd1c7e59cd3f5221d46fe1ed Reviewed-on: https://gerrit.instructure.com/143422 Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
2018-03-07 10:12:53 +08:00
"webpack-cli": "^3",
the regular “update all the npm things” commit this updates all the stuff we get from npm that we _can_ upgrade to the newest versions available. test plan: * all the builds should pass Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881 Reviewed-on: https://gerrit.instructure.com/167282 Reviewed-by: Steven Burnett <sburnett@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2018-10-04 07:01:30 +08:00
"webpack-manifest-plugin": "^2",
upgrade webpack to v4 Closes: CORE-1143 Test plan: * load canvas in prod mode in a non-English language. Click around And make sure everything works * in prod mode, do a test to compare load time to what’s on beta. * page load time and js bundle size should be smaller * click around in the quizzes client apps and the ember grade book And make sure those things work Change-Id: I93c28c4a6d22db95cd1c7e59cd3f5221d46fe1ed Reviewed-on: https://gerrit.instructure.com/143422 Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
2018-03-07 10:12:53 +08:00
"webpack-stats-plugin": "^0.2.1",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"wsrun": "^5",
Now that i18nliner can understand it, turn back on fragments The previous commit makes it so i18nliner can understand <> instead of <React.Fragment>, so this turns back on the eslint rule we had to turn Off Test plan: * run bin/rake i18n:generate_js (or let the Jenkins builds run) * it should pass Change-Id: Ia3204cd6c3147eb52ca612adbb3b20b2df8c6921 Reviewed-on: https://gerrit.instructure.com/205378 Tested-by: Jenkins Reviewed-by: Ed Schiebel <eschiebel@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-16 05:46:07 +08:00
"xsslint": "ryankshaw/xsslint#babel7",
[npm dependencies] update all our npm dependencies This is just the regular “update all the things” commit. For things in package.json that we just want the latest version of, I changed them to a simple major with a carat. (Eg: “8^” or “4^”), that way you can see easier which things are specifically locked down To a specific version (or range of versions) for a reason. Test plan: * automated specs & build tasks should work Change-Id: Id7a3f853bd0f7537cc0f08d7dba8d6726b836c44 Reviewed-on: https://gerrit.instructure.com/141653 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-02-23 03:58:38 +08:00
"yaml-loader": "^0.5"
clean up JS tests and integrate karma - js:generate_runner now generates common files to be used by different test runners - js spec file order now shuffled to better expose dependencies - fakeENV now returns two methods: setup and teardown - stock tinymce 3 files are now wrapped for AMD test plan: - tinymce should work the same - js:test rake task should run tests - js:build task should work as normal (using new location of r.js) - test results should successfully send to firework Change-Id: Ic09647f55dae57130fa0fe3d6a9168d2b67b89a2 Reviewed-on: https://gerrit.instructure.com/29297 QA-Review: Shawn Meredith <shawn@instructure.com> Tested-by: Shawn Meredith <shawn@instructure.com> Tested-by: Aaron Shafovaloff <ashafovaloff@instructure.com> Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
2014-01-24 23:58:37 +08:00
},
make inspect-process an optional dependency Change-Id: If62f0601df401e2407a0a606a75c230d1225b205 Reviewed-on: https://gerrit.instructure.com/183822 Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com> Tested-by: Jenkins Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2019-03-05 23:51:37 +08:00
"optionalDependencies": {
"inspect-process": "^0.5"
},
return focus to the status bar buttons when the kb shortcut dialog or the a11y checker tray close, return focus to the button that opened it. closes COREFE-108 test plan: - in rce, click on the kb short cutton in the status bar - close the kb shortcut dialog > expect focus to return to the button - repeat for the a11y checker - tab until the show-on-focus kb shortcut button above the RCE appears, click it, then close the dialog > expect focus to return to the button Change-Id: I27ea79930e643d9908a784fbcb89900918d3be01 Reviewed-on: https://gerrit.instructure.com/204283 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com>
2019-08-08 04:19:35 +08:00
"browserslist": [
"extends @instructure/browserslist-config-canvas-lms"
],
speed up JS tests by running them concurrently closes: CORE-865 In order to get accurate coverage reports (ie: so the coverage numbers don’t only reflect a fraction of the total tests), when the COVERAGE environment variable is set, it does not split them out into groups to run concurrently. That way our linters-and-js-master build (which sets that environment variable) will run the same as it always has and our patch-set builds (which run the linters-and-js) will be faster. Test plan: * run ‘yarn test’ * it should be a lot faster than it used to be * look at the linters-and-js build in jenkins for this commit * it should have test reports for all both groups (coffee, js) Of karma tests as well as for the jest tests. * look at the coverage report after this gets merged. It should be the same as it was before Change-Id: I35147cc84df4afae92c1a73c201667d4d44b5518 Reviewed-on: https://gerrit.instructure.com/136373 Reviewed-by: Simon Williams <simon@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Jeremy Neander <jneander@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-22 04:09:17 +08:00
"jest-junit": {
"output": "./coverage-js/junit-reports/jest.xml"
},
upgrade karma everyone was getting build errors when they were npm install'ing. it was because karma 0.10 depended on an out-of-date version of chokiadr that does not compile against node 0.12 I also indicated that canvas is licenced agpl 3 so that you wouldn't always see an npm warning about not having one. also, let karma serve our css files so if any javascript references them in our quit tests, we don't see 404 warnings Change-Id: Iaa0377bc87b8f7ec8726d6cb82c0f8a103134b56 Reviewed-on: https://gerrit.instructure.com/58584 Tested-by: Jenkins Reviewed-by: Mike Nomitch <mnomitch@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2015-07-16 12:24:49 +08:00
"repository": "instructure/canvas-lms",
clean up JS tests and integrate karma - js:generate_runner now generates common files to be used by different test runners - js spec file order now shuffled to better expose dependencies - fakeENV now returns two methods: setup and teardown - stock tinymce 3 files are now wrapped for AMD test plan: - tinymce should work the same - js:test rake task should run tests - js:build task should work as normal (using new location of r.js) - test results should successfully send to firework Change-Id: Ic09647f55dae57130fa0fe3d6a9168d2b67b89a2 Reviewed-on: https://gerrit.instructure.com/29297 QA-Review: Shawn Meredith <shawn@instructure.com> Tested-by: Shawn Meredith <shawn@instructure.com> Tested-by: Aaron Shafovaloff <ashafovaloff@instructure.com> Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com> Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
2014-01-24 23:58:37 +08:00
"scripts": {
fix jest tests timing out in jenkins Change-Id: I594d05c5375b20d9eff78487c1a84023ad65e438 Reviewed-on: https://gerrit.instructure.com/184792 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-03-12 01:06:37 +08:00
"test": "concurrently --names \"packages,jest,karma\" \"yarn test:packages\" \"if [ \"$COVERAGE\" ]; then yarn test:jest:coverage --maxWorkers 1; else yarn test:jest --maxWorkers 1; fi\" \"if [ \"$COVERAGE\" ]; then yarn test:karma; else yarn test:karma:concurrently; fi\"",
Add a way to generate better js coverage This should pick up coverage from both karma and jest in Canvas proper. It should also pick up coverage from anything under packages/* closes CORE-1265 Test Plan: - Run `COVERAGE=true yarn test` - Coverage reports (coverage-final.json) should generate in all packages such as (canvas-planner) as well as in coverage-karma and coverage-jest - Run `yarn run test:coverage` - coverage-js folder should be generated. Opening index.html should show the full coverage report - Remove coverage-{js, karma, jest} and packages/canvas-planner/coverage as well as .nyc_output to get back to a clean state - Run `RUN_TESTS_FIRST=true yarn run test:coverage` - All tests should run and generate the appropriate report just like the last time in coverage-js Change-Id: I50744b8977e0683e079af5bdd2865dbcd6ad9066 Reviewed-on: https://gerrit.instructure.com/146098 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-04-06 05:27:42 +08:00
"test:coverage": "script/generate_js_coverage",
speed up JS tests by running them concurrently closes: CORE-865 In order to get accurate coverage reports (ie: so the coverage numbers don’t only reflect a fraction of the total tests), when the COVERAGE environment variable is set, it does not split them out into groups to run concurrently. That way our linters-and-js-master build (which sets that environment variable) will run the same as it always has and our patch-set builds (which run the linters-and-js) will be faster. Test plan: * run ‘yarn test’ * it should be a lot faster than it used to be * look at the linters-and-js build in jenkins for this commit * it should have test reports for all both groups (coffee, js) Of karma tests as well as for the jest tests. * look at the coverage report after this gets merged. It should be the same as it was before Change-Id: I35147cc84df4afae92c1a73c201667d4d44b5518 Reviewed-on: https://gerrit.instructure.com/136373 Reviewed-by: Simon Williams <simon@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Reviewed-by: Jeremy Neander <jneander@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-22 04:09:17 +08:00
"test:watch": "concurrently --names \"jest,karma\" \"jest --watch .\" \"yarn test:karma:watch\"",
Add a way to generate better js coverage This should pick up coverage from both karma and jest in Canvas proper. It should also pick up coverage from anything under packages/* closes CORE-1265 Test Plan: - Run `COVERAGE=true yarn test` - Coverage reports (coverage-final.json) should generate in all packages such as (canvas-planner) as well as in coverage-karma and coverage-jest - Run `yarn run test:coverage` - coverage-js folder should be generated. Opening index.html should show the full coverage report - Remove coverage-{js, karma, jest} and packages/canvas-planner/coverage as well as .nyc_output to get back to a clean state - Run `RUN_TESTS_FIRST=true yarn run test:coverage` - All tests should run and generate the appropriate report just like the last time in coverage-js Change-Id: I50744b8977e0683e079af5bdd2865dbcd6ad9066 Reviewed-on: https://gerrit.instructure.com/146098 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-04-06 05:27:42 +08:00
"test:jest": "jest --color",
attempt #2 to try to get master js build working my last thing fixed it in one spot but it fails in another now lets see if we just give it more memory if that will work Change-Id: Ia4a5aef21f3a07ac2d383682de1cfc4fe2d71f73 Reviewed-on: https://gerrit.instructure.com/206869 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-27 08:14:19 +08:00
"test:jest:coverage": "NODE_OPTIONS=\"--max_old_space_size=8192\" jest --color --coverage",
make test:jest:debug open dev tools automatically Change-Id: Ie98f6055f848a4605b4f3276a403f05d345ae2a7 Reviewed-on: https://gerrit.instructure.com/182603 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2019-02-24 05:35:33 +08:00
"test:jest:debug": "inspect node_modules/.bin/jest --runInBand",
Give more memory to karma when it's running This should make it so our post-merge build starts working again and reporting new coverage information. closes CORE-1435 Test Plan: - Run `COVERAGE=true yarn run test:karma` - It should not fail because of memory issues Change-Id: I6e103352fa25e130d0ba8072a77c9d81ac11bb85 Reviewed-on: https://gerrit.instructure.com/150666 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-05-18 06:02:10 +08:00
"test:karma": "yarn run test:karma:watch --single-run",
Disable happypack for concurrent karma runs If we are splitting up our specs and running different groups across different cores, we don’t need to also use happypack to distribute that work to multiple cores. In fact, if we do, it’ll be slower because of cpu thrashing Change-Id: If000c59d73d46961bffebacab9f7b0291a01bda6 Reviewed-on: https://gerrit.instructure.com/164889 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-09-19 03:44:28 +08:00
"test:karma:concurrently": "DISABLE_HAPPYPACK=1 concurrently --names \"coffee,js1,js2\" \"JSPEC_GROUP=coffee yarn test:karma:headless\" \"JSPEC_GROUP=js1 yarn test:karma:headless\" \"JSPEC_GROUP=js2 yarn test:karma:headless\"",
Give more memory to karma when it's running This should make it so our post-merge build starts working again and reporting new coverage information. closes CORE-1435 Test Plan: - Run `COVERAGE=true yarn run test:karma` - It should not fail because of memory issues Change-Id: I6e103352fa25e130d0ba8072a77c9d81ac11bb85 Reviewed-on: https://gerrit.instructure.com/150666 Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-05-18 06:02:10 +08:00
"test:karma:headless": "yarn run test:karma --browsers ChromeHeadlessNoSandbox",
"test:karma:watch": "node --max-old-space-size=4096 ./node_modules/.bin/karma start",
"test:karma:watch:headless": "yarn run test:karma:watch --browsers ChromeHeadlessNoSandbox",
Bump to Node 10 closes CORE-2329 There were some tests that were expecting a snapshot-like value where it expected `new Date().toLocaleDateString()` to give something Like “2016-7-11” but that was actually wrong. If you do `new Date().toLocaleDateString()` in a browser it will give you something like “7/11/2016”. And this new version of node matches what a real browser would have done, so I just updated the specs so they are looking for the correct format. This change does not actually reflect a change in what a real user would see. Just what jest/jsdom/node formats it as. Test Plan: - check to make sure that the assignments 2 availability dates component produces markup exactly as it did before - Automated tests pass - Build canvas locally, everything passes. - Build canvas with docker, everything passes. Change-Id: I74285cd6d9b251ca60ab79396e332cc3a419bcee Reviewed-on: https://gerrit.instructure.com/177198 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-01-09 04:25:49 +08:00
"test:packages": "if [ \"$COVERAGE\" ]; then yarn workspace-run-serial test:coverage; else yarn workspace-run-serial test; fi",
make npm build scripts more user friendly :) test plan: - run the following commands and assess that they run as expected: - yarn run build - yarn run build:css - yarn run build:css:watch - yarn run build:js - yarn run build:jss:watch Change-Id: I4c0a2a68ce62896364bc2da5e7956002c15f5847 Reviewed-on: https://gerrit.instructure.com/110497 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com> Product-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
2017-05-03 00:44:54 +08:00
"build": "yarn run build:css && yarn run build:js",
upgrade some NPM dependencies Change-Id: If2a90959713e292a46c9d5e9c75c89a37f7316b6 Reviewed-on: https://gerrit.instructure.com/205007 Tested-by: Jenkins Reviewed-by: Cameron Matheson <cameron@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-14 13:36:39 +08:00
"build:watch": "concurrently --raw \"yarn build:css:watch\" \"yarn build:js:watch\"",
make npm build scripts more user friendly :) test plan: - run the following commands and assess that they run as expected: - yarn run build - yarn run build:css - yarn run build:css:watch - yarn run build:js - yarn run build:jss:watch Change-Id: I4c0a2a68ce62896364bc2da5e7956002c15f5847 Reviewed-on: https://gerrit.instructure.com/110497 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com> Product-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
2017-05-03 00:44:54 +08:00
"build:css": "brandable_css",
"build:css:watch": "brandable_css --watch",
"build:js": "yarn run webpack-development",
"build:js:watch": "yarn run webpack",
Use yarn workspaces Run `script/nuke_node.sh` to clean everything up Run `yarn install` it should install everything for everything Run `yarn build` and `yarn test` they should work exactly as before Change-Id: I11a27ff2d705c6cbb3b3f9029dd8b32138706146 Reviewed-on: https://gerrit.instructure.com/151356 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-25 00:09:03 +08:00
"build:packages": "yarn workspace-run build:canvas",
Drop IE 11 support closes: CORE-3175 based on our browser support documentation (https://community.canvaslms.com/docs/doc-10720) "On August 3, 2019, Internet Explorer 11 will no longer be supported as a Canvas browser." and since any code being merged to master now won't hit prod until after august 3rd, we can safely drop IE11 support now test plan: * look at the code generated by webpack * you should see things like "class" and arrow functions "() => {}" * if you go to canvas in IE 11, it should not work * if you go to canvas in the next oldest browsers we support (which would probably be Edge 42 or Safari 11) it should still work the same as it did before Change-Id: Ifc7f64902a333fd0f662ff6a68eb8f4353f01130 Reviewed-on: https://gerrit.instructure.com/197827 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-06-17 09:44:52 +08:00
"lint:browser-code": "es-check es8 ./public/dist/**/*.js",
fix pre-commit hook with unfixable eslint error test plan: - have a local yarn install - add an unfixable lint error (unused var) to a file in the prettier whitelist - try to commit the file - it should not try to run in docker after the lint error Change-Id: If1fcfc6693be26c6f6fdddb8cfa4c54a73512ebe Reviewed-on: https://gerrit.instructure.com/173469 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins
2018-11-28 06:40:21 +08:00
"lint:staged": "lint-staged",
Add precommit hook for auto fixing files This only affects javascript files and only affects things from the prettier whitelist This will run slowly if you don't have node_modules installed locally (e.g., in Docker), but it will gladly attempt to run things in Docker for you. This adds a new githook_installer image that will install the githook whenever a docker-compose up happens in the repo. It will also install the hook whenever a `yarn` occurs locally (as a postinstall hook). This commit should also not fail things. For example having unused variables is an ESLint error, but it isn't autofixable. It will log the error, but will otherwise continue. However, it will make this pretty with prettier as well as fix any other autofixable ESLint errors. closes CORE-2118 Test Plan: - Run `yarn` - Add some semicolons to something from the whitelist - git add that file - git commit and it will strip semicolons - In a dockerized Canvas: - docker-compose up - Add semicolons to a file - git add that file - git commit, it will take forever (~60s) - It should have stripped out semicolons Change-Id: Id9198aa008808e898f29acb9ed64dd14ff843222 Reviewed-on: https://gerrit.instructure.com/171510 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-11-08 07:04:08 +08:00
"postinstall": "yarn build:packages && ./script/install_hooks",
add a “webpack:analyze” command to package.json This is so other people can generate that webpack chunk webpage that shows how big all the chunks are and what is in them Test plan: * either run script/nuke_node.sh or compile_assets or in some other way, make sure your public/javscripts/translations files are up to date * then run `yarn webpack:analyze` * it should work for a few minutes then open a page that shows cool webpack chunk stats in your browser Change-Id: Ia070e373d81aaeec2131e8e299f82515cff57fa4 Reviewed-on: https://gerrit.instructure.com/193087 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-05-11 04:13:45 +08:00
"webpack:analyze": "NODE_ENV=production SKIP_SOURCEMAPS=1 node --max_old_space_size=8096 $(yarn bin)/webpack --json > stats-prod.json && NODE_OPTIONS=\"--max_old_space_size=8192\" npx webpack-bundle-analyzer stats-prod.json public/dist/webpack-production",
Support i18n numbers on quizzes edit page Test Plan: - Given a quiz in a locale with different number formatting - Change the points of a question to '1234.5' in that locale - See it accept and format points correctly on the question and the header Closes QO-442 Change-Id: I75c353716718377bb26c1088a4db58aaa7c8f721 Reviewed-on: https://gerrit.instructure.com/198543 Tested-by: Jenkins Reviewed-by: Jonathan Holt <jholt@instructure.com> QA-Review: David Tan <dtan@instructure.com> Product-Review: Kevin Dougherty III <jdougherty@instructure.com>
2019-06-21 06:11:28 +08:00
"webpack": "gulp rev 1> /dev/null & NODE_OPTIONS=\"--max_old_space_size=8192\" webpack --progress --color --watch",
Fix docker build running out of js heap memory Test plan: * the docker image should pass * if you want to test locally, run: `RAILS_ENV=production bundle exec rake canvas:compile_assets` * that should work Change-Id: I800a4ee035ec3f853c924a6f520ae061fccb4b56 Reviewed-on: https://gerrit.instructure.com/195856 Reviewed-by: Carl Kibler <ckibler@instructure.com> Tested-by: Jenkins QA-Review: Ryan Shaw <ryan@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-05-31 02:42:43 +08:00
"webpack-development": "gulp rev 1> /dev/null & NODE_OPTIONS=\"--max_old_space_size=8192\" webpack --color && yarn lint:browser-code",
upgrade webpack to v4 Closes: CORE-1143 Test plan: * load canvas in prod mode in a non-English language. Click around And make sure everything works * in prod mode, do a test to compare load time to what’s on beta. * page load time and js bundle size should be smaller * click around in the quizzes client apps and the ember grade book And make sure those things work Change-Id: I93c28c4a6d22db95cd1c7e59cd3f5221d46fe1ed Reviewed-on: https://gerrit.instructure.com/143422 Tested-by: Jenkins QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
2018-03-07 10:12:53 +08:00
"webpack-production": "NODE_ENV=production gulp rev && NODE_ENV=production NODE_OPTIONS=\"--max_old_space_size=8192\" webpack --color && yarn lint:browser-code",
Bump wsrun to the latest version Test Plan: - All workspaces run their tests on jenkins Change-Id: I66fa941a11cdd6306a27b5a374af88755d593472 Reviewed-on: https://gerrit.instructure.com/188718 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> QA-Review: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
2019-04-09 02:36:08 +08:00
"workspace-run": "r() { wsrun --fast-exit --exclude-missing --collect-logs --report -c $@; exit $?; } && r",
"workspace-run-serial": "r() { wsrun --fast-exit --exclude-missing --collect-logs --report --serial -c $@; exit $?; } && r",
add npm script that can run specific js specs example usage: `npm run jspec spec/javascripts/jsx/files` refs CNVS-33223 test plan: - current webpack test build should work exactly the same - `npm run jspec` should build + run all specs - `npm run jspec path/to/stuff` should build + run only specified specs - should work with both directories and individual files - `jspec-watch` should watch + build a path, but not run specs Change-Id: I788dd38a6c69a4c36a1300fcecf43678bc7f5327 Reviewed-on: https://gerrit.instructure.com/94625 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> Product-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com> QA-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
2016-11-08 05:13:53 +08:00
"jspec": "./spec/jspec.sh",
spec: add aXe unit testing capability this patch updates the a11y helper, adds a new spec script to run, and adds aXe testing to discussion views test plan: - run the spec files edited in this patch normally with yarn run jspec-watch path/to/spec - tests should all pass as expected - run the spec files edited in this patch with the new command yarn run a11y-report path/to/spec - you should get aXe errors on existing a11y violations Change-Id: Ib3db892046e115bedb363752d1e56226eef893af Reviewed-on: https://gerrit.instructure.com/87962 Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com> Reviewed-by: Steven Burnett <sburnett@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Matt Berns <mberns@instructure.com> QA-Review: Matt Berns <mberns@instructure.com>
2016-08-17 05:30:29 +08:00
"jspec-watch": "./spec/jspec.sh --watch",
script to upgrade without adding dupes to yarn.lock because yarn is silly and frequently adds duplicate entries for things into yarn.lock when it could satisfy everything the app needs with one version; when you make any changes to package.json, run this script: `yarn upgrade-and-dedupe` to make sure that yarn.lock doesn't add needless duplicates of things. if yarn ever fixes this issue: https://github.com/yarnpkg/yarn/issues/579 then this can go away. test plan: 1. check this out 2. run `yarn upgrade-and-dedupe` 3. push the change that commit makes 4. it should pass jenkins and not introduce any errors Change-Id: I8c268cc4c7c6ac4474221ce65129a6ef8b261813 Reviewed-on: https://gerrit.instructure.com/142447 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-03-03 02:20:00 +08:00
"a11y-report": "./spec/jspec.sh --a11y",
A script to just update instUI Closes: CORE-1709 This is what our Jenkins job to pull in every instui RC commit will use Test plan: * run `yarn upgrade-instructure-ui` * it should make a commit that has new entries in yarn.lock for all the instUI packages that uses the latest rc version on the npm registry * it should not affect anything else besides yarn.lock Change-Id: I78cce6e801015819c4e4b27e26ede352deceebb9 Reviewed-on: https://gerrit.instructure.com/160435 Tested-by: Jenkins Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-08-11 00:22:49 +08:00
"upgrade-and-dedupe": "rm -rf yarn.lock node_modules && yes 1 | yarn install --flat --production --ignore-scripts && git checkout package.json && yarn install && git add yarn.lock",
"upgrade-instructure-ui": "script/upgrade-instructure-ui"
make it so it works with yarn 1.3.2 (frd) closes: CORE-675 test plan: * while running yarn 0.27, * run `yarn` * it should work and there should only be one jquery in node_modules * brew upgrade yarn (or whatever else you do to upgrade yarn to 1.3.2) * run `yarn` * it should not log any warning about unpacking jquery to the same location as something else * it should work and not make any changes to yarn.lock or node_modules * load the calendar page, there should not be any errors Change-Id: I08a1b8ceddf31cae59720270f870516ad213b87d Reviewed-on: https://gerrit.instructure.com/133548 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-11-22 07:09:15 +08:00
},
"resolutions": {
Speed up $.support checks that were for old IE versions closes: CORE-3020 Doing these feature detections takes my chrome browser on a fast MacBookPro 21ms. See: https://cl.ly/868790d66a8f I hate to actually make any changes here but these are all things That no browser that we support doesn’t support. And getting a flat 21ms boost on every pageload I think might be worth it. To see the actual changes, look at this commit on GitHub: https://github.com/ryankshaw/jquery/commit/dadf794ebc4c4dcf94c344dab7d9 Change-Id: I836f0ac19ae234fc789423d833a20b760fd42dc7 Reviewed-on: https://gerrit.instructure.com/195704 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-05-30 05:29:19 +08:00
"jquery": "https://github.com/ryankshaw/jquery.git#dadf794ebc4c4dcf94c344dab7d9341d46bc17cc",
put accidentally deleted comments back in package.json Change-Id: I6b00f817afbf46c6cfa48ed0f389aede78c9c3f3 Reviewed-on: https://gerrit.instructure.com/163733 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2018-09-09 13:17:24 +08:00
"graphael": "this is just here so yarn.lock looks the same whether the analytics plugin is checked out or not",
Revert "Upgrade node-sass since it has fixed bug we needed" ...Because it has NOT fixed the bug we needed it to Closes: CORE-2817 This reverts commit e7c110f88a0af207b443de11b486177c92b23d1f. Test plan: * open any page in canvas * in the dev console, type $.flashError(“whatever”) * the error message that appears should be styled correctly Change-Id: I748b0f4607f671ba22ec0a38f9422e6179be24ab Reviewed-on: https://gerrit.instructure.com/191538 Tested-by: Jenkins Reviewed-by: Steven Burnett <sburnett@instructure.com> QA-Review: Steven Burnett <sburnett@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2019-05-01 03:31:39 +08:00
"graphael": "https://github.com/ryankshaw/graphael.git",
"node-sass": "if we let node-sass upgrade to recent versions, it causes: SIS-3125",
"node-sass": "4.7.2"
AMD Conversion "Trivial" JavaScript / CoffeeScript changes -------------------------------------------------- For the most part, all javascript was simply wrapped in `require` or `define`. The dependencies were found with a script that matched regexes in the files, it errs on the side of listing too many dependencies, so its worth double checking each file's dependencies (over time, anyway). i18n API changes -------------------------------------------------- No longer have to do I18n.scoped calls, just list i18n as a dependency with the scope and it's imported already scoped require ['i18n!some_scope'], (I18n) -> I18n.t 'im_scoped', 'I'm scoped!' JS bundling now done with r.js, not Jammit -------------------------------------------------- We don't use jammit to bundle JS anymore. Simply list dependencies for your JS modules in the file and RequireJS handles the rest. To optimize the JavaScript, first make sure you have node.js 0.4.12+ installed and then run: $ rake js:build The app defaults to the optimized build in production. You can use non-optimized in production by putting ?debug_assets=true in the url just like before. You can also test the optimized JavaScript in development with ?optimized_js=true. Significant changes -------------------------------------------------- These files have "real" changes to them (unlike the JavaScript that is simply wrapped in require and define). Worth taking a really close look at: - app/helpers/application_helper.rb - app/views/layouts/application.html.erb - config/assets.yml - config/build.js - lib/handlebars/handlebars.rb - lib/i18n_extraction/js_extractor.rb - lib/tasks/canvas.rake - lib/tasks/i18n.rake - lib/tasks/js.rake Change-Id: I4bc5ecb1231f331aaded0fef2bcc1f3a9fe482a7 Reviewed-on: https://gerrit.instructure.com/6986 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Ryan Florence <ryanf@instructure.com>
2011-11-11 00:31:45 +08:00
}
maintain precision of grades in grade input fixes GRADE-1098 test plan: 1. Create an Assignment a. with Display Grade as Percentage b. worth 9.5 points 2. Open New Gradebook 3. Grade a student on this assignment twice a. once with 55 (interpreted as percentage) b. again with 55% (explicit percentage) 4. Verify grade is 55% 5. Verify score is 5.225 Change-Id: Ie48ec7d5b787e864bfd3379e8dc6a4dbebebc2e5 Reviewed-on: https://gerrit.instructure.com/148848 Tested-by: Jenkins Reviewed-by: Derek Bender <djbender@instructure.com> Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com> QA-Review: Shahbaz Javeed <sjaveed@instructure.com> Product-Review: Matt Goodwin <mattg@instructure.com>
2018-05-02 04:54:56 +08:00
}