ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/.rubocop.yml

101 lines
2.9 KiB
YAML
Raw Normal View History

rubocop: split configuration * remove spurious .rubocop.yml override files * split the configuration into an enforced and optional * run both configurations in jenkins (may result in some duplicate comments at different levels) * auto-correct the enforced configuration in the pre-commit hook * fix comments for Gemfile.d and the root dir; enforced configuration is only applied to that directory for now Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 00:20:02 +08:00
inherit_from: .rubocop.common.yml
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
deterministic described classes, refs SD-1969 This cop encourages explit require_dependency calls for ambiguous nested constants in specs. What does that mean? Consider: module Analytics describe Assignments do Depending on what has been required and/or autoloaded, `Assignments` could either resolve to `Analytics::Assignments`, or just the top-level `Assignments`. This is a cause of flickering failures and test-queue woes. This example should either have an explicit `require_dependency` call, or get rid of the module and just do `describe Analytics::Assignments`` Correct all existing ones in the codebase, except for a few ActiveRecord-related ones (the auto-correct isn't quite perfect, i.e. it assumes the file path will be `const_name.underscore`, which is no bueno for things like ActiveRecord::ConnectionAdapters::PostgreSQLAdapter) Test plan: n/a, specs Change-Id: Ic24bf3e0f547ca11c46887d4af92804da091912a Reviewed-on: https://gerrit.instructure.com/98752 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Jon Jensen <jon@instructure.com> QA-Review: Jon Jensen <jon@instructure.com>
2017-01-04 08:52:49 +08:00
AllCops:
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
NewCops: enable # TODO
deterministic described classes, refs SD-1969 This cop encourages explit require_dependency calls for ambiguous nested constants in specs. What does that mean? Consider: module Analytics describe Assignments do Depending on what has been required and/or autoloaded, `Assignments` could either resolve to `Analytics::Assignments`, or just the top-level `Assignments`. This is a cause of flickering failures and test-queue woes. This example should either have an explicit `require_dependency` call, or get rid of the module and just do `describe Analytics::Assignments`` Correct all existing ones in the codebase, except for a few ActiveRecord-related ones (the auto-correct isn't quite perfect, i.e. it assumes the file path will be `const_name.underscore`, which is no bueno for things like ActiveRecord::ConnectionAdapters::PostgreSQLAdapter) Test plan: n/a, specs Change-Id: Ic24bf3e0f547ca11c46887d4af92804da091912a Reviewed-on: https://gerrit.instructure.com/98752 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Jon Jensen <jon@instructure.com> QA-Review: Jon Jensen <jon@instructure.com>
2017-01-04 08:52:49 +08:00
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Lint/AmbiguousBlockAssociation: # TODO
rubocop: split configuration * remove spurious .rubocop.yml override files * split the configuration into an enforced and optional * run both configurations in jenkins (may result in some duplicate comments at different levels) * auto-correct the enforced configuration in the pre-commit hook * fix comments for Gemfile.d and the root dir; enforced configuration is only applied to that directory for now Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 00:20:02 +08:00
Exclude:
- spec/**/*
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Naming/VariableNumber: # TODO
turn off rubocop rule for ElseAlignment Change-Id: I3278edf4da55ddb15586937a752e98674db468fa Reviewed-on: https://gerrit.instructure.com/140633 Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com> Product-Review: Derek Bender <djbender@instructure.com> QA-Review: Derek Bender <djbender@instructure.com> Tested-by: Jenkins
2018-02-13 02:55:16 +08:00
Enabled: false
rubocop: split configuration * remove spurious .rubocop.yml override files * split the configuration into an enforced and optional * run both configurations in jenkins (may result in some duplicate comments at different levels) * auto-correct the enforced configuration in the pre-commit hook * fix comments for Gemfile.d and the root dir; enforced configuration is only applied to that directory for now Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 00:20:02 +08:00
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Rails/HasManyOrHasOneDependent: # TODO
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Rails/ReadWriteAttribute: # TODO: autocorrect (unsafe)
rubocop: split configuration * remove spurious .rubocop.yml override files * split the configuration into an enforced and optional * run both configurations in jenkins (may result in some duplicate comments at different levels) * auto-correct the enforced configuration in the pre-commit hook * fix comments for Gemfile.d and the root dir; enforced configuration is only applied to that directory for now Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 00:20:02 +08:00
Enabled: false # accessors are often defined in terms of read_attribute
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Rails/TimeZone: # TODO: autocorrect (unsafe)
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
rubocop: split configuration * remove spurious .rubocop.yml override files * split the configuration into an enforced and optional * run both configurations in jenkins (may result in some duplicate comments at different levels) * auto-correct the enforced configuration in the pre-commit hook * fix comments for Gemfile.d and the root dir; enforced configuration is only applied to that directory for now Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 00:20:02 +08:00
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
RSpec/ContextWording: # TODO
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
RSpec/DescribeClass: # TODO
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
RSpec/DescribedClass: # TODO: autocorrect (unsafe)
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
RSpec/ExpectChange: # TODO: autocorrect (unsafe)
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
RSpec/HookArgument: # TODO: autocorrect
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
RSpec/NamedSubject: # TODO
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
RSpec/NotToNot: # TODO: autocorrect
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
RSpec/ScatteredSetup: # TODO: investigate if these are required
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
RSpec/VerifiedDoubles: # TODO
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
rubocop: split configuration * remove spurious .rubocop.yml override files * split the configuration into an enforced and optional * run both configurations in jenkins (may result in some duplicate comments at different levels) * auto-correct the enforced configuration in the pre-commit hook * fix comments for Gemfile.d and the root dir; enforced configuration is only applied to that directory for now Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 00:20:02 +08:00
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/BlockDelimiters: # TODO: autocorrect
rubocop: split configuration * remove spurious .rubocop.yml override files * split the configuration into an enforced and optional * run both configurations in jenkins (may result in some duplicate comments at different levels) * auto-correct the enforced configuration in the pre-commit hook * fix comments for Gemfile.d and the root dir; enforced configuration is only applied to that directory for now Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 00:20:02 +08:00
Enabled: true
Exclude:
- spec/**/*_spec.rb
- spec/shared_examples/**/*.rb
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/ClassAndModuleChildren: # TODO: autocorrect (unsafe)
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/DoubleNegation: # TODO: autocorrect (unsafe)
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/Dir: # TODO: autocorrect
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/FormatStringToken: # TODO: investigate if this complains about our i18n library
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/GuardClause: # TODO
make gergich a better coworker Change-Id: I9a04d12fc49f6e0095359e5dabbb5f5f18629692 Reviewed-on: https://gerrit.instructure.com/51939 Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com> Tested-by: Ethan Vizitei <evizitei@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-10 03:55:31 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/IfUnlessModifier: # TODO: autocorrect
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/Lambda: # TODO: autocorrect
bump rubocop Change-Id: Ic510fa4a6b34227cf8c6b01bdeea98d9325d1a0d Reviewed-on: https://gerrit.instructure.com/136139 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com>
2017-12-20 04:08:55 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/MethodCallWithArgsParentheses: # TODO: autocorrect
bump rubocop Change-Id: Ic510fa4a6b34227cf8c6b01bdeea98d9325d1a0d Reviewed-on: https://gerrit.instructure.com/136139 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com>
2017-12-20 04:08:55 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/MethodCallWithoutArgsParentheses: # TODO: autocorrect
bump rubocop Change-Id: Ic510fa4a6b34227cf8c6b01bdeea98d9325d1a0d Reviewed-on: https://gerrit.instructure.com/136139 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com>
2017-12-20 04:08:55 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/NumericLiterals: # TODO: autocorrect
bump rubocop Change-Id: Ic510fa4a6b34227cf8c6b01bdeea98d9325d1a0d Reviewed-on: https://gerrit.instructure.com/136139 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com>
2017-12-20 04:08:55 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/NumericPredicate: # TODO: autocorrect (unsafe)
disable Style/FormatStringToken rubocop test plan: * N/A Change-Id: I0c607f5c33742b824738dd423433c8111c54b3e2 Reviewed-on: https://gerrit.instructure.com/142460 Reviewed-by: Jacob Fugal <jacob@instructure.com> Tested-by: Jenkins Product-Review: Jeremy Neander <jneander@instructure.com> QA-Review: Jeremy Neander <jneander@instructure.com>
2018-03-03 03:36:50 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/ParallelAssignment: # TODO: autocorrect (with probable exceptions)
bump rubocop Change-Id: Ic510fa4a6b34227cf8c6b01bdeea98d9325d1a0d Reviewed-on: https://gerrit.instructure.com/136139 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com>
2017-12-20 04:08:55 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/PercentLiteralDelimiters: # TODO: autocorrect
bump rubocop Change-Id: Ic510fa4a6b34227cf8c6b01bdeea98d9325d1a0d Reviewed-on: https://gerrit.instructure.com/136139 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com>
2017-12-20 04:08:55 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/PercentQLiterals: # TODO: autocorrect
bump rubocop Change-Id: Ic510fa4a6b34227cf8c6b01bdeea98d9325d1a0d Reviewed-on: https://gerrit.instructure.com/136139 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com>
2017-12-20 04:08:55 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/RedundantSelf: # TODO: autocorrect
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/RegexpLiteral: # TODO: autocorrect
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/RescueModifier: # TODO
rubocop: split configuration * remove spurious .rubocop.yml override files * split the configuration into an enforced and optional * run both configurations in jenkins (may result in some duplicate comments at different levels) * auto-correct the enforced configuration in the pre-commit hook * fix comments for Gemfile.d and the root dir; enforced configuration is only applied to that directory for now Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 00:20:02 +08:00
Severity: warning
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/RescueStandardError: # TODO: autocorrect
rubocop: split configuration * remove spurious .rubocop.yml override files * split the configuration into an enforced and optional * run both configurations in jenkins (may result in some duplicate comments at different levels) * auto-correct the enforced configuration in the pre-commit hook * fix comments for Gemfile.d and the root dir; enforced configuration is only applied to that directory for now Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898 Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 00:20:02 +08:00
EnforcedStyle: implicit
bump rubocop Change-Id: Ic510fa4a6b34227cf8c6b01bdeea98d9325d1a0d Reviewed-on: https://gerrit.instructure.com/136139 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com>
2017-12-20 04:08:55 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/ReturnNil: # TODO: autocorrect (investigate violations)
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/SignalException: # TODO: autocorrect
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/StderrPuts: # TODO: autocorrect
add some ruby linting for jenkins to take advantage of add migration lint as rubocop cops create frozen constant linter find_ids datafixup lint send_later lint lint send_later in predeploys add freeze_constant cop to default config don't forget to include rubocop when running get the rubocop runner into the script lint for wrong algorithm name lint primary key lint remove_column in predeploys get rubocop output as parsed json diff munging for gergich disable a few style cops tweak rubocop setup to allow IDE plugins to work get gergich comment format right shell out to gergich if we're in jenkins-land Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd Reviewed-on: https://gerrit.instructure.com/51755 Tested-by: Jenkins Reviewed-by: Jason Madsen <jmadsen@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-05 08:49:25 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/SymbolArray: # TODO: autocorrect
make gergich a better coworker Change-Id: I9a04d12fc49f6e0095359e5dabbb5f5f18629692 Reviewed-on: https://gerrit.instructure.com/51939 Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com> Tested-by: Ethan Vizitei <evizitei@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-10 03:55:31 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/TrailingCommaInArguments: # TODO: autocorrect
upgrade rubocop to 0.46.0 and rubocop-rspec to 1.8.0 note: Astrolabe::Node is now just Rubocop::Node closes CNVS-34077 test plan: rubocop should still lint correctly Change-Id: Id5feb1700ad78cc0b34c6cb90d2a75320b210138 Reviewed-on: https://gerrit.instructure.com/98512 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com>
2016-12-28 14:17:05 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/TrailingCommaInArrayLiteral: # TODO: autocorrect
bump rubocop version to 0.68.0 to support ruby 2.6 this changes upgrades to the earliest version of rubocop supporting ruby 2.6 while also choosing a version that fixes a breaking 0.60.0 change to revert psych version change. namespace changes were made on multiple cops to support the new rubocop version requirements as well as the change to move performance cops out of the rubocop gem in to rubocop-performance. the Layout/IndentFirstParameter cop is currently broken but a rubocop version upgrade will fix that. the FreezeConstants cop also required a fix to handle nil types. refs DE-289 test plan: - ensure rubocop runs completely Change-Id: I0ca68f426e287b5a973b96a4ae0e975f1cbc0240 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/248786 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Kyle Rosenbaum <krosenbaum@instructure.com> Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com> Reviewed-by: Ryan Norton <rnorton@instructure.com>
2020-09-29 03:53:45 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/TrailingCommaInHashLiteral: # TODO: autocorrect
make gergich a better coworker Change-Id: I9a04d12fc49f6e0095359e5dabbb5f5f18629692 Reviewed-on: https://gerrit.instructure.com/51939 Reviewed-by: Cody Cutrer <cody@instructure.com> QA-Review: Ethan Vizitei <evizitei@instructure.com> Tested-by: Ethan Vizitei <evizitei@instructure.com> Product-Review: Ethan Vizitei <evizitei@instructure.com>
2015-04-10 03:55:31 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/WhileUntilModifier: # TODO: autocorrect
turn off Rubocop::Cop::Style::WhileUntilModifier The modifier while/until construction should not be preferred. The style guide has been updated to reflect this: https://gollum.instructure.com/Ruby-style-guidelines#While/Until Change-Id: Ib1b8b3cf29d52729ba9d3f9066554fc421d47111 Reviewed-on: https://gerrit.instructure.com/52997 Reviewed-by: Jeremy Stanley <jeremy@instructure.com> Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Strand McCutchen <smccutchen@instructure.com> QA-Review: Strand McCutchen <smccutchen@instructure.com>
2015-04-29 00:27:56 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/WordArray: # TODO: autocorrect
Moving ParallelAssignment back to style Change-Id: If7a864309fd97f673c81b1ef2a8a59dcb838fb49 Reviewed-on: https://gerrit.instructure.com/70363 Tested-by: Jenkins Reviewed-by: Jon Jensen <jon@instructure.com> Product-Review: Jon Jensen <jon@instructure.com> QA-Review: Jon Jensen <jon@instructure.com>
2016-01-15 23:44:38 +08:00
Enabled: false
RuboCop: tweak common config document why each cop is disabled, disable a few more globally, and document the intentions for each currently disabled cops in the optional config Change-Id: I7abaabd76142a61e1922f55da0c8abb6a665ec05 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274265 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Cody Cutrer <cody@instructure.com> Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-24 00:38:07 +08:00
Style/ZeroLengthPredicate: # TODO: autocorrect (unsafe)
upgrade rubocop to 0.46.0 and rubocop-rspec to 1.8.0 note: Astrolabe::Node is now just Rubocop::Node closes CNVS-34077 test plan: rubocop should still lint correctly Change-Id: Id5feb1700ad78cc0b34c6cb90d2a75320b210138 Reviewed-on: https://gerrit.instructure.com/98512 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins Product-Review: Simon Williams <simon@instructure.com> QA-Review: Simon Williams <simon@instructure.com>
2016-12-28 14:17:05 +08:00
Enabled: false