ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/spec/.eslintrc

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

32 lines
743 B
Plaintext
Raw Normal View History

add eslint rules to lint Qunit specs We just had a thing where a commit made it through that added an .only(…), which made it so Jenkins would only run that one test. This should help prevent that. And it should help us write more helpful tests too. Test plan: * change a test from “test(” to “Qunit.only(“, eslint should print an error. Change-Id: If43640a74cadbe88ed8d49a9c66232356a339104 Reviewed-on: https://gerrit.instructure.com/134893 Reviewed-by: Jeremy Neander <jneander@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-07 08:52:17 +08:00
{
combine spec/.eslintrc & spec/javscripts/.eslintrc I didn’t realize there was already one in spec/javascripts when I made spec/.eslintrc. by combining them into 1, we won’t get those gergich errors when we convert a file in spec/cofffeescripts to JS Test plan: * js files in spec/coffeescripts should not log eslint errors about “Undefined global: test” Change-Id: Iebee0ebef9d9903df964e331886ceaefc728431f Reviewed-on: https://gerrit.instructure.com/136642 Reviewed-by: Derek Bender <djbender@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-30 02:27:45 +08:00
"env": {
"qunit": true
},
"globals": {
"module": true,
"test": true,
"equal": true,
"ok": true,
spec: add global sandbox This is an updated form of the magic `this.stub` magic present in the legacy QUnit specs. Subsequent commits will replace those calls with the updated form, which is a global `sandbox` object with `stub`, `spy`, `mock`, and `clock` methods which are automatically verified and restored at the end of each spec. Replacing the older methods with the updated methods will allow these legacy specs to be updated for modern testing. Change-Id: Id409756ce5f5cb60c52a0735d385e5648fe9dd8f Reviewed-on: https://gerrit.instructure.com/157014 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Jeremy Neander <jneander@instructure.com> QA-Review: Jeremy Neander <jneander@instructure.com>
2018-07-12 04:31:13 +08:00
"sandbox": true,
combine spec/.eslintrc & spec/javscripts/.eslintrc I didn’t realize there was already one in spec/javascripts when I made spec/.eslintrc. by combining them into 1, we won’t get those gergich errors when we convert a file in spec/cofffeescripts to JS Test plan: * js files in spec/coffeescripts should not log eslint errors about “Undefined global: test” Change-Id: Iebee0ebef9d9903df964e331886ceaefc728431f Reviewed-on: https://gerrit.instructure.com/136642 Reviewed-by: Derek Bender <djbender@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-30 02:27:45 +08:00
"sinon": true,
"deepEqual": true
},
Update eslint to v7 so it stops complaining about the ?. operator, among other things closes MAT-45 flag=none test plan: - npx eslint ./path/to/a.js on a file with ?. in it doesn't complain Change-Id: I6056e25ce9c53a8e652d6e4eec1280057369cf26 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/265387 Reviewed-by: Guilherme Baron <gbaron@instructure.com> QA-Review: Guilherme Baron <gbaron@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-05-21 00:54:30 +08:00
"extends": ["plugin:qunit/recommended", "plugin:qunit/two"],
"plugins": ["qunit"],
add eslint rules to lint Qunit specs We just had a thing where a commit made it through that added an .only(…), which made it so Jenkins would only run that one test. This should help prevent that. And it should help us write more helpful tests too. Test plan: * change a test from “test(” to “Qunit.only(“, eslint should print an error. Change-Id: If43640a74cadbe88ed8d49a9c66232356a339104 Reviewed-on: https://gerrit.instructure.com/134893 Reviewed-by: Jeremy Neander <jneander@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-07 08:52:17 +08:00
"rules": {
combine spec/.eslintrc & spec/javscripts/.eslintrc I didn’t realize there was already one in spec/javascripts when I made spec/.eslintrc. by combining them into 1, we won’t get those gergich errors when we convert a file in spec/cofffeescripts to JS Test plan: * js files in spec/coffeescripts should not log eslint errors about “Undefined global: test” Change-Id: Iebee0ebef9d9903df964e331886ceaefc728431f Reviewed-on: https://gerrit.instructure.com/136642 Reviewed-by: Derek Bender <djbender@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-30 02:27:45 +08:00
"func-names": "off",
"prefer-arrow-callback": "off",
[spec] turn of jest eslint rule in /spec This was causing false-positives. Since we have no jest tests in spec/* we can safely ignore this here Change-Id: Ice9aca609cd5356191d3d71448886b4cb05da8f5 Reviewed-on: https://gerrit.instructure.com/136645 Reviewed-by: Derek Bender <djbender@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-30 02:46:33 +08:00
"jest/no-identical-title": "off",
[spec] eslint: turn off “qunit/no-setup-teardown” I notice a lot of commits get gergich warnings about this. I don’t know that it’s that helpful to bug people to change it. What do you guys think, keep it or commit this? Change-Id: Ida24383b45f84aca136d19b75fee322dab53d52e Reviewed-on: https://gerrit.instructure.com/136646 Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-30 02:48:18 +08:00
"qunit/no-setup-teardown": "off",
add eslint rules to lint Qunit specs We just had a thing where a commit made it through that added an .only(…), which made it so Jenkins would only run that one test. This should help prevent that. And it should help us write more helpful tests too. Test plan: * change a test from “test(” to “Qunit.only(“, eslint should print an error. Change-Id: If43640a74cadbe88ed8d49a9c66232356a339104 Reviewed-on: https://gerrit.instructure.com/134893 Reviewed-by: Jeremy Neander <jneander@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-07 08:52:17 +08:00
"qunit/no-global-assertions": "off",
"qunit/no-global-module-test": "off",
"qunit/require-expect": "off",
"qunit/no-assert-logical-expression": "error",
"qunit/no-commented-tests": "error",
"qunit/no-compare-relation-boolean": "error"
Update eslint to v7 so it stops complaining about the ?. operator, among other things closes MAT-45 flag=none test plan: - npx eslint ./path/to/a.js on a file with ?. in it doesn't complain Change-Id: I6056e25ce9c53a8e652d6e4eec1280057369cf26 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/265387 Reviewed-by: Guilherme Baron <gbaron@instructure.com> QA-Review: Guilherme Baron <gbaron@instructure.com> Product-Review: Ed Schiebel <eschiebel@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-05-21 00:54:30 +08:00
},
"parserOptions": {
"ecmaVersion": 2020
add eslint rules to lint Qunit specs We just had a thing where a commit made it through that added an .only(…), which made it so Jenkins would only run that one test. This should help prevent that. And it should help us write more helpful tests too. Test plan: * change a test from “test(” to “Qunit.only(“, eslint should print an error. Change-Id: If43640a74cadbe88ed8d49a9c66232356a339104 Reviewed-on: https://gerrit.instructure.com/134893 Reviewed-by: Jeremy Neander <jneander@instructure.com> Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2017-12-07 08:52:17 +08:00
}
}