canvas-lms/app/messages/submission_comment_for_teac...

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

30 lines
1.1 KiB
Plaintext
Raw Normal View History

anonymize submission comment for teacher notifications fixes GRADE-1988 When an assignment is anonymous and still muted, comments from students will not have their names exposed in notifications to the teacher. test plan: * Submission Comment Steps 1. Sign in or act as the first student 2. Submit to the anonymous assignment 3. Submit to the non-anonymous assignment 4. Sign in or act as either student 5. Comment on the anonymous submission 6. Comment on the non-anonymous submission * Notification Preferences are found at /profile/communication A. Setup 1. Enroll two students 2. Create an anonymous assignment, due in the future * allow resubmissions 3. Create a non-anonymous assignment, due in the future * allow resubmissions B. Test Plan for Immediate Email 1. Set your "All Submissions" notification preferences for immediate email 2. Perform the Submission Comment Steps above 3. As the teacher, find the resubmission emails 4. Verify the student names are present for the non-anonymous email 5. Verify the student names are absent for the anonymous email C. Test Plan for Daily/Weekly Email 1. Set your "All Submissions" notification preferences for daily/weekly email 2. Perform the Submission Comment Steps above 3. Wait a day, or a week, ... or whatever 4. As the teacher, find the resubmission emails 5. Verify the student names are present for the non-anonymous email 6. Verify the student names are absent for the anonymous email D. Test Plan for Twitter 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, check your Twitter 4. Verify the student names are present for the non-anonymous message 5. Verify the student names are absent for the anonymous message E. Test Plan for SMS 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, fumble with your phone while using the bathroom If you drop it in the toilet, you MUST repeat all steps above. 4. Verify the student names are present for the non-anonymous text 5. Verify the student names are absent for the anonymous text Change-Id: I9d08df409e5bb925cf5c479ddd822b66987a2ccf Reviewed-on: https://gerrit.instructure.com/181208 Tested-by: Jenkins Reviewed-by: Keith Garner <kgarner@instructure.com> Reviewed-by: Adrian Packel <apackel@instructure.com> QA-Review: James Butters <jbutters@instructure.com> Product-Review: Keith Garner <kgarner@instructure.com>
2019-02-08 03:12:11 +08:00
<% presenter = Messages::SubmissionCommentForTeacher::EmailPresenter.new(self) %>
2011-02-01 09:57:29 +08:00
<% define_content :link do %>
anonymize submission comment for teacher notifications fixes GRADE-1988 When an assignment is anonymous and still muted, comments from students will not have their names exposed in notifications to the teacher. test plan: * Submission Comment Steps 1. Sign in or act as the first student 2. Submit to the anonymous assignment 3. Submit to the non-anonymous assignment 4. Sign in or act as either student 5. Comment on the anonymous submission 6. Comment on the non-anonymous submission * Notification Preferences are found at /profile/communication A. Setup 1. Enroll two students 2. Create an anonymous assignment, due in the future * allow resubmissions 3. Create a non-anonymous assignment, due in the future * allow resubmissions B. Test Plan for Immediate Email 1. Set your "All Submissions" notification preferences for immediate email 2. Perform the Submission Comment Steps above 3. As the teacher, find the resubmission emails 4. Verify the student names are present for the non-anonymous email 5. Verify the student names are absent for the anonymous email C. Test Plan for Daily/Weekly Email 1. Set your "All Submissions" notification preferences for daily/weekly email 2. Perform the Submission Comment Steps above 3. Wait a day, or a week, ... or whatever 4. As the teacher, find the resubmission emails 5. Verify the student names are present for the non-anonymous email 6. Verify the student names are absent for the anonymous email D. Test Plan for Twitter 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, check your Twitter 4. Verify the student names are present for the non-anonymous message 5. Verify the student names are absent for the anonymous message E. Test Plan for SMS 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, fumble with your phone while using the bathroom If you drop it in the toilet, you MUST repeat all steps above. 4. Verify the student names are present for the non-anonymous text 5. Verify the student names are absent for the anonymous text Change-Id: I9d08df409e5bb925cf5c479ddd822b66987a2ccf Reviewed-on: https://gerrit.instructure.com/181208 Tested-by: Jenkins Reviewed-by: Keith Garner <kgarner@instructure.com> Reviewed-by: Adrian Packel <apackel@instructure.com> QA-Review: James Butters <jbutters@instructure.com> Product-Review: Keith Garner <kgarner@instructure.com>
2019-02-08 03:12:11 +08:00
<%= presenter.link %>
2011-02-01 09:57:29 +08:00
<% end %>
<% define_content :subject do %>
anonymize submission comment for teacher notifications fixes GRADE-1988 When an assignment is anonymous and still muted, comments from students will not have their names exposed in notifications to the teacher. test plan: * Submission Comment Steps 1. Sign in or act as the first student 2. Submit to the anonymous assignment 3. Submit to the non-anonymous assignment 4. Sign in or act as either student 5. Comment on the anonymous submission 6. Comment on the non-anonymous submission * Notification Preferences are found at /profile/communication A. Setup 1. Enroll two students 2. Create an anonymous assignment, due in the future * allow resubmissions 3. Create a non-anonymous assignment, due in the future * allow resubmissions B. Test Plan for Immediate Email 1. Set your "All Submissions" notification preferences for immediate email 2. Perform the Submission Comment Steps above 3. As the teacher, find the resubmission emails 4. Verify the student names are present for the non-anonymous email 5. Verify the student names are absent for the anonymous email C. Test Plan for Daily/Weekly Email 1. Set your "All Submissions" notification preferences for daily/weekly email 2. Perform the Submission Comment Steps above 3. Wait a day, or a week, ... or whatever 4. As the teacher, find the resubmission emails 5. Verify the student names are present for the non-anonymous email 6. Verify the student names are absent for the anonymous email D. Test Plan for Twitter 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, check your Twitter 4. Verify the student names are present for the non-anonymous message 5. Verify the student names are absent for the anonymous message E. Test Plan for SMS 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, fumble with your phone while using the bathroom If you drop it in the toilet, you MUST repeat all steps above. 4. Verify the student names are present for the non-anonymous text 5. Verify the student names are absent for the anonymous text Change-Id: I9d08df409e5bb925cf5c479ddd822b66987a2ccf Reviewed-on: https://gerrit.instructure.com/181208 Tested-by: Jenkins Reviewed-by: Keith Garner <kgarner@instructure.com> Reviewed-by: Adrian Packel <apackel@instructure.com> QA-Review: James Butters <jbutters@instructure.com> Product-Review: Keith Garner <kgarner@instructure.com>
2019-02-08 03:12:11 +08:00
<%= presenter.subject %>
2011-02-01 09:57:29 +08:00
<% end %>
anonymize submission comment for teacher notifications fixes GRADE-1988 When an assignment is anonymous and still muted, comments from students will not have their names exposed in notifications to the teacher. test plan: * Submission Comment Steps 1. Sign in or act as the first student 2. Submit to the anonymous assignment 3. Submit to the non-anonymous assignment 4. Sign in or act as either student 5. Comment on the anonymous submission 6. Comment on the non-anonymous submission * Notification Preferences are found at /profile/communication A. Setup 1. Enroll two students 2. Create an anonymous assignment, due in the future * allow resubmissions 3. Create a non-anonymous assignment, due in the future * allow resubmissions B. Test Plan for Immediate Email 1. Set your "All Submissions" notification preferences for immediate email 2. Perform the Submission Comment Steps above 3. As the teacher, find the resubmission emails 4. Verify the student names are present for the non-anonymous email 5. Verify the student names are absent for the anonymous email C. Test Plan for Daily/Weekly Email 1. Set your "All Submissions" notification preferences for daily/weekly email 2. Perform the Submission Comment Steps above 3. Wait a day, or a week, ... or whatever 4. As the teacher, find the resubmission emails 5. Verify the student names are present for the non-anonymous email 6. Verify the student names are absent for the anonymous email D. Test Plan for Twitter 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, check your Twitter 4. Verify the student names are present for the non-anonymous message 5. Verify the student names are absent for the anonymous message E. Test Plan for SMS 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, fumble with your phone while using the bathroom If you drop it in the toilet, you MUST repeat all steps above. 4. Verify the student names are present for the non-anonymous text 5. Verify the student names are absent for the anonymous text Change-Id: I9d08df409e5bb925cf5c479ddd822b66987a2ccf Reviewed-on: https://gerrit.instructure.com/181208 Tested-by: Jenkins Reviewed-by: Keith Garner <kgarner@instructure.com> Reviewed-by: Adrian Packel <apackel@instructure.com> QA-Review: James Butters <jbutters@instructure.com> Product-Review: Keith Garner <kgarner@instructure.com>
2019-02-08 03:12:11 +08:00
<%= presenter.body %>
2011-02-01 09:57:29 +08:00
anonymize submission comment for teacher notifications fixes GRADE-1988 When an assignment is anonymous and still muted, comments from students will not have their names exposed in notifications to the teacher. test plan: * Submission Comment Steps 1. Sign in or act as the first student 2. Submit to the anonymous assignment 3. Submit to the non-anonymous assignment 4. Sign in or act as either student 5. Comment on the anonymous submission 6. Comment on the non-anonymous submission * Notification Preferences are found at /profile/communication A. Setup 1. Enroll two students 2. Create an anonymous assignment, due in the future * allow resubmissions 3. Create a non-anonymous assignment, due in the future * allow resubmissions B. Test Plan for Immediate Email 1. Set your "All Submissions" notification preferences for immediate email 2. Perform the Submission Comment Steps above 3. As the teacher, find the resubmission emails 4. Verify the student names are present for the non-anonymous email 5. Verify the student names are absent for the anonymous email C. Test Plan for Daily/Weekly Email 1. Set your "All Submissions" notification preferences for daily/weekly email 2. Perform the Submission Comment Steps above 3. Wait a day, or a week, ... or whatever 4. As the teacher, find the resubmission emails 5. Verify the student names are present for the non-anonymous email 6. Verify the student names are absent for the anonymous email D. Test Plan for Twitter 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, check your Twitter 4. Verify the student names are present for the non-anonymous message 5. Verify the student names are absent for the anonymous message E. Test Plan for SMS 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, fumble with your phone while using the bathroom If you drop it in the toilet, you MUST repeat all steps above. 4. Verify the student names are present for the non-anonymous text 5. Verify the student names are absent for the anonymous text Change-Id: I9d08df409e5bb925cf5c479ddd822b66987a2ccf Reviewed-on: https://gerrit.instructure.com/181208 Tested-by: Jenkins Reviewed-by: Keith Garner <kgarner@instructure.com> Reviewed-by: Adrian Packel <apackel@instructure.com> QA-Review: James Butters <jbutters@instructure.com> Product-Review: Keith Garner <kgarner@instructure.com>
2019-02-08 03:12:11 +08:00
<%= presenter.comment_text %>
anonymize submission comment for teacher notifications fixes GRADE-1988 When an assignment is anonymous and still muted, comments from students will not have their names exposed in notifications to the teacher. test plan: * Submission Comment Steps 1. Sign in or act as the first student 2. Submit to the anonymous assignment 3. Submit to the non-anonymous assignment 4. Sign in or act as either student 5. Comment on the anonymous submission 6. Comment on the non-anonymous submission * Notification Preferences are found at /profile/communication A. Setup 1. Enroll two students 2. Create an anonymous assignment, due in the future * allow resubmissions 3. Create a non-anonymous assignment, due in the future * allow resubmissions B. Test Plan for Immediate Email 1. Set your "All Submissions" notification preferences for immediate email 2. Perform the Submission Comment Steps above 3. As the teacher, find the resubmission emails 4. Verify the student names are present for the non-anonymous email 5. Verify the student names are absent for the anonymous email C. Test Plan for Daily/Weekly Email 1. Set your "All Submissions" notification preferences for daily/weekly email 2. Perform the Submission Comment Steps above 3. Wait a day, or a week, ... or whatever 4. As the teacher, find the resubmission emails 5. Verify the student names are present for the non-anonymous email 6. Verify the student names are absent for the anonymous email D. Test Plan for Twitter 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, check your Twitter 4. Verify the student names are present for the non-anonymous message 5. Verify the student names are absent for the anonymous message E. Test Plan for SMS 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, fumble with your phone while using the bathroom If you drop it in the toilet, you MUST repeat all steps above. 4. Verify the student names are present for the non-anonymous text 5. Verify the student names are absent for the anonymous text Change-Id: I9d08df409e5bb925cf5c479ddd822b66987a2ccf Reviewed-on: https://gerrit.instructure.com/181208 Tested-by: Jenkins Reviewed-by: Keith Garner <kgarner@instructure.com> Reviewed-by: Adrian Packel <apackel@instructure.com> QA-Review: James Butters <jbutters@instructure.com> Product-Review: Keith Garner <kgarner@instructure.com>
2019-02-08 03:12:11 +08:00
<% if presenter.media_comment? %>
<%= t("This message includes media comments. To listen or reply, click this link: %{link}.", link: presenter.link) %>
<% elsif presenter.can_reply? %>
<%= t("You can reply to this comment by responding to this message, or review the submission details using this link: %{link}. When allowed, if you need to include an attachment, please log in to Canvas and reply to the submission", link: presenter.link) %>
<% else %>
anonymize submission comment for teacher notifications fixes GRADE-1988 When an assignment is anonymous and still muted, comments from students will not have their names exposed in notifications to the teacher. test plan: * Submission Comment Steps 1. Sign in or act as the first student 2. Submit to the anonymous assignment 3. Submit to the non-anonymous assignment 4. Sign in or act as either student 5. Comment on the anonymous submission 6. Comment on the non-anonymous submission * Notification Preferences are found at /profile/communication A. Setup 1. Enroll two students 2. Create an anonymous assignment, due in the future * allow resubmissions 3. Create a non-anonymous assignment, due in the future * allow resubmissions B. Test Plan for Immediate Email 1. Set your "All Submissions" notification preferences for immediate email 2. Perform the Submission Comment Steps above 3. As the teacher, find the resubmission emails 4. Verify the student names are present for the non-anonymous email 5. Verify the student names are absent for the anonymous email C. Test Plan for Daily/Weekly Email 1. Set your "All Submissions" notification preferences for daily/weekly email 2. Perform the Submission Comment Steps above 3. Wait a day, or a week, ... or whatever 4. As the teacher, find the resubmission emails 5. Verify the student names are present for the non-anonymous email 6. Verify the student names are absent for the anonymous email D. Test Plan for Twitter 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, check your Twitter 4. Verify the student names are present for the non-anonymous message 5. Verify the student names are absent for the anonymous message E. Test Plan for SMS 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, fumble with your phone while using the bathroom If you drop it in the toilet, you MUST repeat all steps above. 4. Verify the student names are present for the non-anonymous text 5. Verify the student names are absent for the anonymous text Change-Id: I9d08df409e5bb925cf5c479ddd822b66987a2ccf Reviewed-on: https://gerrit.instructure.com/181208 Tested-by: Jenkins Reviewed-by: Keith Garner <kgarner@instructure.com> Reviewed-by: Adrian Packel <apackel@instructure.com> QA-Review: James Butters <jbutters@instructure.com> Product-Review: Keith Garner <kgarner@instructure.com>
2019-02-08 03:12:11 +08:00
<%= t("You can review the submission details using this link: %{link}.", link: presenter.link) %>
<% end %>
anonymize submission comment for teacher notifications fixes GRADE-1988 When an assignment is anonymous and still muted, comments from students will not have their names exposed in notifications to the teacher. test plan: * Submission Comment Steps 1. Sign in or act as the first student 2. Submit to the anonymous assignment 3. Submit to the non-anonymous assignment 4. Sign in or act as either student 5. Comment on the anonymous submission 6. Comment on the non-anonymous submission * Notification Preferences are found at /profile/communication A. Setup 1. Enroll two students 2. Create an anonymous assignment, due in the future * allow resubmissions 3. Create a non-anonymous assignment, due in the future * allow resubmissions B. Test Plan for Immediate Email 1. Set your "All Submissions" notification preferences for immediate email 2. Perform the Submission Comment Steps above 3. As the teacher, find the resubmission emails 4. Verify the student names are present for the non-anonymous email 5. Verify the student names are absent for the anonymous email C. Test Plan for Daily/Weekly Email 1. Set your "All Submissions" notification preferences for daily/weekly email 2. Perform the Submission Comment Steps above 3. Wait a day, or a week, ... or whatever 4. As the teacher, find the resubmission emails 5. Verify the student names are present for the non-anonymous email 6. Verify the student names are absent for the anonymous email D. Test Plan for Twitter 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, check your Twitter 4. Verify the student names are present for the non-anonymous message 5. Verify the student names are absent for the anonymous message E. Test Plan for SMS 1. Set your "All Submissions" notification preferences for Twitter 2. Perform the Submission Comment Steps above 3. As the teacher, fumble with your phone while using the bathroom If you drop it in the toilet, you MUST repeat all steps above. 4. Verify the student names are present for the non-anonymous text 5. Verify the student names are absent for the anonymous text Change-Id: I9d08df409e5bb925cf5c479ddd822b66987a2ccf Reviewed-on: https://gerrit.instructure.com/181208 Tested-by: Jenkins Reviewed-by: Keith Garner <kgarner@instructure.com> Reviewed-by: Adrian Packel <apackel@instructure.com> QA-Review: James Butters <jbutters@instructure.com> Product-Review: Keith Garner <kgarner@instructure.com>
2019-02-08 03:12:11 +08:00
<% unless presenter.attachments.empty? %>
<%= t("Attached Files:") %>
<% presenter.attachments.each do |attachment| %>
<%= attachment.display_name %> - <%= attachment.readable_size %>
<%= file_download_url(attachment) %>
<% end %>
<% end %>