ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/app/messages/peer_review_invitation.summ...

15 lines
508 B
Plaintext
Raw Normal View History

Adds peer review notification for assigning peer reviewers Fixes: CNVS-3771 Adds a peer review notification to go out after a peer reviewer is added to the discussion. This also resolves the issue with a notification not being sent if a rubric is not attached. Test-Plan: 1.) Run bundle exec rake db:migrate in the console before doing anything else -- (This sets up your db by using notification_types.yml to populate notification types in the DB.) 2.) Create a graded discussion with at least 2 students 3.) Make sure both students have everything in their notifications set to ASAP. 4.) Edit the assignment settings and select the 'Require Peer Reviews' - Choose to manually select peer reviewers. 5.) Navigate to discussions as an admin 6.) Select the cog and go to peer reviews. 7.) Assign a peer reviewer and verify that the notification was sent out. Change-Id: I78212cb8043de0fcf809a9ffa56ffca327ffcacc Reviewed-on: https://gerrit.instructure.com/36646 Reviewed-by: Matthew Wheeler <mwheeler@instructure.com> Product-Review: Matthew Wheeler <mwheeler@instructure.com> Tested-by: Jenkins <jenkins@instructure.com> QA-Review: Steven Shepherd <sshepherd@instructure.com>
2014-06-20 03:09:50 +08:00
<% define_content :link do %>
use url helpers in messages fixes CNVS-11838 and then choose the host more intelligently to use one the user can actually log in to test plan - have accounts on two shards, referred to as "account 1" and "account 2" from now on - have account domains that are resolvable for the accounts, referred to as account1.canvas.dev and account2.canvas.dev from now on - have account 2 trust account 1 by POSTing to account2.canvas.dev/api/v1/accounts/<account 2 id>/trust_links with a site admin's auth token and setting trust_link[managing_account_id] to account 1's global id. you can now use users from account 1 on account 2 - regression test notifications, especially considering notifications generated by account 2 that are sent to account 1 users. - account 1 users should have links that use account1.canvas.dev and have global ids for referenced objects that live on account 2's shard, e.g. account1.canvas.dev/courses/2~1/discussion_topics/2~30 - avatars should use the avatar owner's account domain - account 2 users should have links that use account2.canvas.dev and have local ids, e.g. account2.canvas.dev/courses/1/discussion_topics/30 - following the links when the user receiving the notification is logged in should take the user to the linked object - following the links when not logged in should take the user to a login page that they are able to log in to - be sure to at least check: context file downloads links (e.g. discussion topic attachments) file downloads links (e.g. conversation message attachments) avatars links conversation notifications discussion notifications peer review notifications Change-Id: Idebd247fee99a2b973d3fa6f4f2fca0e723d99a5 Reviewed-on: https://gerrit.instructure.com/31867 Tested-by: Jenkins Reviewed-by: Matthew Wheeler <mwheeler@instructure.com> QA-Review: Steven Shepherd <sshepherd@instructure.com> Product-Review: Joel Hough <joel@instructure.com>
2014-03-14 01:44:09 +08:00
<%= polymorphic_url([asset.context, asset.asset.assignment, :submission], id: asset.asset.user_id) %>
Adds peer review notification for assigning peer reviewers Fixes: CNVS-3771 Adds a peer review notification to go out after a peer reviewer is added to the discussion. This also resolves the issue with a notification not being sent if a rubric is not attached. Test-Plan: 1.) Run bundle exec rake db:migrate in the console before doing anything else -- (This sets up your db by using notification_types.yml to populate notification types in the DB.) 2.) Create a graded discussion with at least 2 students 3.) Make sure both students have everything in their notifications set to ASAP. 4.) Edit the assignment settings and select the 'Require Peer Reviews' - Choose to manually select peer reviewers. 5.) Navigate to discussions as an admin 6.) Select the cog and go to peer reviews. 7.) Assign a peer reviewer and verify that the notification was sent out. Change-Id: I78212cb8043de0fcf809a9ffa56ffca327ffcacc Reviewed-on: https://gerrit.instructure.com/36646 Reviewed-by: Matthew Wheeler <mwheeler@instructure.com> Product-Review: Matthew Wheeler <mwheeler@instructure.com> Tested-by: Jenkins <jenkins@instructure.com> QA-Review: Steven Shepherd <sshepherd@instructure.com>
2014-06-20 03:09:50 +08:00
<% end %>
<% define_content :subject do %>
update email notification for peer review to be anonymous *Test Plan Create an assignment with anonymous peer reviews enabled create two students set one student up as a peer reviewer of other as first student submit assignment as student two peer review assignment make sure peer review notifications show anonymous Change-Id: If1a474192504a26ca09f4086514900809bdb6d81 fixes: PFS-2581 Reviewed-on: https://gerrit.instructure.com/62432 Tested-by: Jenkins Reviewed-by: Cameron Sutter <csutter@instructure.com> QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com> Product-Review: Allison Weiss <allison@instructure.com>
2015-09-03 08:51:15 +08:00
<%= t('#messages.peer_review_invitation.email.subject', "Assigned peer review for %{reviewee}", :reviewee => reviewee_name(asset, user))%>
Adds peer review notification for assigning peer reviewers Fixes: CNVS-3771 Adds a peer review notification to go out after a peer reviewer is added to the discussion. This also resolves the issue with a notification not being sent if a rubric is not attached. Test-Plan: 1.) Run bundle exec rake db:migrate in the console before doing anything else -- (This sets up your db by using notification_types.yml to populate notification types in the DB.) 2.) Create a graded discussion with at least 2 students 3.) Make sure both students have everything in their notifications set to ASAP. 4.) Edit the assignment settings and select the 'Require Peer Reviews' - Choose to manually select peer reviewers. 5.) Navigate to discussions as an admin 6.) Select the cog and go to peer reviews. 7.) Assign a peer reviewer and verify that the notification was sent out. Change-Id: I78212cb8043de0fcf809a9ffa56ffca327ffcacc Reviewed-on: https://gerrit.instructure.com/36646 Reviewed-by: Matthew Wheeler <mwheeler@instructure.com> Product-Review: Matthew Wheeler <mwheeler@instructure.com> Tested-by: Jenkins <jenkins@instructure.com> QA-Review: Steven Shepherd <sshepherd@instructure.com>
2014-06-20 03:09:50 +08:00
<% end %>
improve wording around links in plain text message templates prefer wording like "clicking this link: %{link}" over "clicking the link below" or "clicking the following link" fixes CNVS-24646 test plan: - verify that the following notifications work when delivered as plain text (not html) email: added_to_conversation announcement_reply conversation_created conversation_message group_membership_accepted group_membership_rejected new_context_group_membership new_context_group_membership_invitation new_discussion_entry new_student_organized_group peer_review_invitation submission_comment submission_comment_for_teacher - also verify that peer_review_invivataion works when delivered as an sms or in a summary email (again plain text) Change-Id: I6d36f797de3a3162fa27a4ce3f7cc423a85e3ff7 Reviewed-on: https://gerrit.instructure.com/66079 Tested-by: Jenkins QA-Review: Adrian Russell <arussell@instructure.com> Reviewed-by: Matthew Wheeler <mwheeler@instructure.com> Product-Review: Allison Weiss <allison@instructure.com>
2015-10-30 01:03:25 +08:00
<%=
t("You've been invited to peer review %{reviewee}. Follow this link to review them: %{link}.", {
reviewee: reviewee_name(asset, user),
link: content(:link)
})
%>