ylqjgm/canvas-lms - canvas-lms - Trustie: Git with trustie

2 lines

7 B

Plaintext

Raw Normal View History

Use node 8.9.4 If you are getting errors about “The engine "node" is incompatible with this module. Expected version ">=8.9.4”.” after applying this change, It means you need upgrade your node to 8.9.4. to do so: if you use nvm: `nvm install` inside the canvas dir If you use brew: `brew upgrade node` If you use apt-get: see https://github.com/nodesource/distributions If you use docker: rebuild your docker container Closes: CORE-704 Test plan: * js tests should pass * webpack and brandable_css should generate the exact same CSS and JS output as before. * all of our build tooling, including docker stuff, should continue to work and use Node 8. If you know of something else that needs to be updated to use node 8 everywhere, let me know Change-Id: Ic019710c219d8b8c627ce03e0dffde731cfa2856 Reviewed-on: https://gerrit.instructure.com/136802 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>

2018-01-04 01:44:25 +08:00

v8.9.4