ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/app/views/lti/full_width_launch.html.erb

9 lines
197 B
Plaintext
Raw Normal View History

use new lti views for rendering launches Test Plan: - Verify that the following launches still work: sessionless, borderless, module item selection, and direct link fixes PLAT-459 Change-Id: I2b5c4d448540292ff451dd3d77ba69610f0764ab Reviewed-on: https://gerrit.instructure.com/38790 Tested-by: Jenkins <jenkins@instructure.com> Reviewed-by: Nathan Mills <nathanm@instructure.com> QA-Review: Clare Strong <clare@instructure.com> Product-Review: Brad Humphrey <brad@instructure.com>
2014-08-06 06:52:37 +08:00
<%
(NUI) fix spacing around full-width LTI iframes Fixes: CNVS-22877 Test plan: 1) Test Commons (a full-width LTI iframe) - Turn on the Use New Styles feature flag and clear your cache - Make sure you have Commons installed, if you don't already - When you load Commons from the primary nav, it should now look like this: http://screencast.com/t/XsS5yDpH60 - Repeat in the legacy UI, to make sure nothing has changed from production 2) Test an LTI tool that loads in a non-full-width iframe, to make sure nothing is broken. Roll Call is a good choice. Instructions for local installation are here: https://gollum.instructure.com/Rollcall https://gollum.instructure.com/OtherServiceTestAccounts Change-Id: I7af2eecc2fda155d78433923b21fb61c81442e0b Reviewed-on: https://gerrit.instructure.com/64056 Tested-by: Jenkins Reviewed-by: Jennifer Stern <jstern@instructure.com> Product-Review: Jennifer Stern <jstern@instructure.com> QA-Review: Caleb Guanzon <cguanzon@instructure.com>
2015-09-25 21:13:49 +08:00
@show_left_side = false
remove all occurrences of use_new_styles? from ruby code closes: CNVS-31371 test plan: * do an lti launch, it should work * check a couple pages in this list of changes, they should work Change-Id: I8005162dd7e45711cc74204f47a76f9133870a6d Reviewed-on: https://gerrit.instructure.com/89024 Tested-by: Jenkins Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
2016-08-30 00:07:19 +08:00
@body_classes << 'full-width ic-no-flex-layout ic-full-screen-lti-tool'
(NUI) fix spacing around full-width LTI iframes Fixes: CNVS-22877 Test plan: 1) Test Commons (a full-width LTI iframe) - Turn on the Use New Styles feature flag and clear your cache - Make sure you have Commons installed, if you don't already - When you load Commons from the primary nav, it should now look like this: http://screencast.com/t/XsS5yDpH60 - Repeat in the legacy UI, to make sure nothing has changed from production 2) Test an LTI tool that loads in a non-full-width iframe, to make sure nothing is broken. Roll Call is a good choice. Instructions for local installation are here: https://gollum.instructure.com/Rollcall https://gollum.instructure.com/OtherServiceTestAccounts Change-Id: I7af2eecc2fda155d78433923b21fb61c81442e0b Reviewed-on: https://gerrit.instructure.com/64056 Tested-by: Jenkins Reviewed-by: Jennifer Stern <jstern@instructure.com> Product-Review: Jennifer Stern <jstern@instructure.com> QA-Review: Caleb Guanzon <cguanzon@instructure.com>
2015-09-25 21:13:49 +08:00
crumbs.clear
use new lti views for rendering launches Test Plan: - Verify that the following launches still work: sessionless, borderless, module item selection, and direct link fixes PLAT-459 Change-Id: I2b5c4d448540292ff451dd3d77ba69610f0764ab Reviewed-on: https://gerrit.instructure.com/38790 Tested-by: Jenkins <jenkins@instructure.com> Reviewed-by: Nathan Mills <nathanm@instructure.com> QA-Review: Clare Strong <clare@instructure.com> Product-Review: Brad Humphrey <brad@instructure.com>
2014-08-06 06:52:37 +08:00
%>
s/jammit_css/css_bundle with the new css stuff, we don't actually use jammit so jammit_css has been renamed to css_bundle. we left an aliased jammit_css and marked it deprecated so these all still worked but spit out a deprecation warning. Change-Id: Ib74037711f559f64851d9379644479587c1f83f2 Reviewed-on: https://gerrit.instructure.com/55888 Reviewed-by: Jacob Fugal <jacob@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
2015-06-08 13:36:10 +08:00
<% css_bundle :external_tool_full_width %>
use new lti views for rendering launches Test Plan: - Verify that the following launches still work: sessionless, borderless, module item selection, and direct link fixes PLAT-459 Change-Id: I2b5c4d448540292ff451dd3d77ba69610f0764ab Reviewed-on: https://gerrit.instructure.com/38790 Tested-by: Jenkins <jenkins@instructure.com> Reviewed-by: Nathan Mills <nathanm@instructure.com> QA-Review: Clare Strong <clare@instructure.com> Product-Review: Brad Humphrey <brad@instructure.com>
2014-08-06 06:52:37 +08:00
<%= render 'lti/lti_message' %>