ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
canvas-lms/.groovylintrc.json

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

99 lines
1.9 KiB
JSON
Raw Permalink Normal View History

apply autoformatter to all files refs DE-643 Change-Id: I9482afa27e6b8734640741fca784f971f782af26 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264050 Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-05-03 21:52:46 +08:00
{
"extends": "recommended",
"rules": {
skip linter rules skip the following linter rules: - ClassJavadoc - CompileStatic - FactoryMethodName - PropertyName - UnnecessarySetter - BuilderMethodWithSideEffects - Instanceof - EmptyCatchBlock refs DE-643 flag = none Change-Id: I9bf3667b2e875730a48de9d57ac3568b1afbf478 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264181 Reviewed-by: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-05 02:26:37 +08:00
"BuilderMethodWithSideEffects": {
"enabled": false
},
use selenium grid for karma tests refs DE-1334 Change-Id: I61e78a60498b9fd64ea9d5333504c4db10c8c03f Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/298285 Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com> Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com>
2022-08-11 02:15:25 +08:00
"CatchException": {
"enabled": false
},
skip linter rules skip the following linter rules: - ClassJavadoc - CompileStatic - FactoryMethodName - PropertyName - UnnecessarySetter - BuilderMethodWithSideEffects - Instanceof - EmptyCatchBlock refs DE-643 flag = none Change-Id: I9bf3667b2e875730a48de9d57ac3568b1afbf478 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264181 Reviewed-by: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-05 02:26:37 +08:00
"ClassJavadoc": {
"enabled": false
},
"CompileStatic": {
"enabled": false
},
fix linter rules Fix following linter issues: - ParameterName - CouldBeSwitchStatement - UnusedMethodParameter refs DE-690 flag = none test-plan: - Build passes - QA build that triggers FSC and executes the spec changed Change-Id: I11baf5094e96d33bc6be7f5f03d680f34cc1d026 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/265266 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Reviewed-by: Aaron Ogata <aogata@instructure.com>
2021-05-19 22:08:46 +08:00
"CouldBeSwitchStatement": {
"enabled": false
},
stop loading webpack-builder image twice before running JS specs refs DE-1345 saves ~90s when running JS stages Change-Id: I3cdb97193e8b420e7eed3f63eecedf7a12a5d907 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/298579 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com> Build-Review: Aaron Ogata <aogata@instructure.com> Reviewed-by: Alex Slaughter <aslaughter@instructure.com>
2022-08-16 04:54:28 +08:00
"DuplicateMapLiteral": {
"enabled": false
},
skip groovylinter rules refs DE-643 DE-662 skipping linter rules due to noise and difficulty of fixing the issue. Change-Id: Ic1a46538783a3fa0b849a1f765d6f6fd79c0db97 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264069 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Kyle Rosenbaum <krosenbaum@instructure.com> Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com> Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-04 00:43:03 +08:00
"DuplicateNumberLiteral": {
"enabled": false
},
"DuplicateStringLiteral": {
"enabled": false
},
skip linter rules skip the following linter rules: - ClassJavadoc - CompileStatic - FactoryMethodName - PropertyName - UnnecessarySetter - BuilderMethodWithSideEffects - Instanceof - EmptyCatchBlock refs DE-643 flag = none Change-Id: I9bf3667b2e875730a48de9d57ac3568b1afbf478 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264181 Reviewed-by: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-05 02:26:37 +08:00
"EmptyCatchBlock": {
"enabled": false
},
"FactoryMethodName": {
"enabled": false
},
skip linter rules Skip the following linter rules: - MethodName - LineLength - UnnecessaryGetter - FieldTypeRequired refs DE-643 flag=none test-plan: - build passes Change-Id: Ibcdaa50826b2243768691888e78d98b6ec94e7c5 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264113 Reviewed-by: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-04 05:40:53 +08:00
"FieldTypeRequired": {
"enabled": false
},
skip linter rules skip the following linter rules: - ClassJavadoc - CompileStatic - FactoryMethodName - PropertyName - UnnecessarySetter - BuilderMethodWithSideEffects - Instanceof - EmptyCatchBlock refs DE-643 flag = none Change-Id: I9bf3667b2e875730a48de9d57ac3568b1afbf478 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264181 Reviewed-by: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-05 02:26:37 +08:00
"Instanceof": {
"enabled": false
},
skip invertedifelse linter rule refs DE-643 flag = none test-plan: - Build passes Change-Id: I5fae5eb3d25bbefad02c9033124f2ab54c996bb8 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264721 Reviewed-by: Aaron Ogata <aogata@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-05-12 05:00:33 +08:00
"InvertedIfElse": {
"enabled": false
},
skip JUnitStyleAssertions linter rule refs DE-643 flag = none test-plan: - build passes Change-Id: I46a92b3b1020444f9a3b83373ff2428d3eb31bbf Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264105 Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-04 04:43:12 +08:00
"JUnitStyleAssertions": {
"enabled": false
},
skip linter rules Skip the following linter rules: - MethodName - LineLength - UnnecessaryGetter - FieldTypeRequired refs DE-643 flag=none test-plan: - build passes Change-Id: Ibcdaa50826b2243768691888e78d98b6ec94e7c5 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264113 Reviewed-by: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-04 05:40:53 +08:00
"LineLength": {
"enabled": false
},
"MethodName": {
"enabled": false
},
skip groovylinter rules refs DE-643 DE-662 skipping linter rules due to noise and difficulty of fixing the issue. Change-Id: Ic1a46538783a3fa0b849a1f765d6f6fd79c0db97 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264069 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Kyle Rosenbaum <krosenbaum@instructure.com> Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com> Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-04 00:43:03 +08:00
"MethodParameterTypeRequired": {
"enabled": false
},
"MethodReturnTypeRequired": {
"enabled": false
},
"NestedBlockDepth": {
"enabled": false
},
"NoDef": {
"enabled": false
},
skip linter rules skip the following linter rules: - ClassJavadoc - CompileStatic - FactoryMethodName - PropertyName - UnnecessarySetter - BuilderMethodWithSideEffects - Instanceof - EmptyCatchBlock refs DE-643 flag = none Change-Id: I9bf3667b2e875730a48de9d57ac3568b1afbf478 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264181 Reviewed-by: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-05 02:26:37 +08:00
"PropertyName": {
"enabled": false
},
skip throw exception linter rule refs DE-643 flag = none test-plan: - build passes Change-Id: I321dac92e8b2458e152177389349dce15e3b657e Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264520 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Aaron Ogata <aogata@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-10 23:04:36 +08:00
"ThrowException": {
"enabled": false
},
skip linter rules Skip the following linter rules: - MethodName - LineLength - UnnecessaryGetter - FieldTypeRequired refs DE-643 flag=none test-plan: - build passes Change-Id: Ibcdaa50826b2243768691888e78d98b6ec94e7c5 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264113 Reviewed-by: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-04 05:40:53 +08:00
"UnnecessaryGetter": {
"enabled": false
},
skip UnnecessaryObjectReferences linter rule refs DE-643 flag = none test-plan: - linter error does not appear Change-Id: I3c197044e7c7f9d26f476d11e36de3cd11f0480f Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264664 Reviewed-by: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-11 22:49:49 +08:00
"UnnecessaryObjectReferences": {
"enabled": false
},
skip UnnecessaryPackageReference linter issue refs DE-643 flag = none test-plan: - build passes Change-Id: I2b10d6da84975cb0fb1862fea8c7dd0b788448a1 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264831 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: James Butters <jbutters@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-13 02:50:40 +08:00
"UnnecessaryPackageReference": {
"enabled": false
},
skip linter rules skip the following linter rules: - ClassJavadoc - CompileStatic - FactoryMethodName - PropertyName - UnnecessarySetter - BuilderMethodWithSideEffects - Instanceof - EmptyCatchBlock refs DE-643 flag = none Change-Id: I9bf3667b2e875730a48de9d57ac3568b1afbf478 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264181 Reviewed-by: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-05 02:26:37 +08:00
"UnnecessarySetter": {
"enabled": false
},
fix VariableName linter issues Fix the linter issues and restore the previous behaviour of codeNarc for final variables refs DE-643 flag = none test-plan: - build passes Change-Id: I16f5e388e32fe0aec6789f1f87b0da03b1eacc83 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264362 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Aaron Ogata <aogata@instructure.com> QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com> Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-06 23:38:35 +08:00
"VariableName": {
"finalRegex": "[A-Z][A-Z0-9_]*"
},
skip groovylinter rules refs DE-643 DE-662 skipping linter rules due to noise and difficulty of fixing the issue. Change-Id: Ic1a46538783a3fa0b849a1f765d6f6fd79c0db97 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264069 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Kyle Rosenbaum <krosenbaum@instructure.com> Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com> Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-04 00:43:03 +08:00
"VariableTypeRequired": {
"enabled": false
apply autoformatter to all files refs DE-643 Change-Id: I9482afa27e6b8734640741fca784f971f782af26 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264050 Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-05-03 21:52:46 +08:00
},
"formatting.ClassEndsWithBlankLine": {
apply formatting.ClassStartsWithBlankLine to linter refs DE-643 Change-Id: I27c696a4c34a3109247b9da3c0158d19f44252c3 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264053 Reviewed-by: James Butters <jbutters@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com>
2021-05-03 22:17:38 +08:00
"blankLineRequired": false
apply autoformatter to all files refs DE-643 Change-Id: I9482afa27e6b8734640741fca784f971f782af26 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264050 Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-05-03 21:52:46 +08:00
},
skip groovylinter rules refs DE-643 DE-662 skipping linter rules due to noise and difficulty of fixing the issue. Change-Id: Ic1a46538783a3fa0b849a1f765d6f6fd79c0db97 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264069 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> QA-Review: Kyle Rosenbaum <krosenbaum@instructure.com> Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com> Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-05-04 00:43:03 +08:00
"formatting.ClassStartsWithBlankLine": {
"blankLineRequired": false
},
apply autoformatter to all files refs DE-643 Change-Id: I9482afa27e6b8734640741fca784f971f782af26 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264050 Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-05-03 21:52:46 +08:00
"formatting.Indentation": {
"spacesPerIndentLevel": 2
}
}
}