xxq250
/
probot
forked from mirrors/probot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: fix mocked responses for pagination requests 

Responses are always arrays, never single objects
This commit is contained in:
Gregor 2019-01-07 23:18:01 -08:00
parent c8e72aeeed
commit a486f7c03b
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/github.test.ts
View File

@ -38,19 +38,19 @@ describe('GitHubAPI', () => {
})
nock('https://api.github.com')
.get('/repos/JasonEtco/pizza/issues?per_page=1').reply(200, issues[0], {
.get('/repos/JasonEtco/pizza/issues?per_page=1').reply(200, [issues[0]], {
link: '<https://api.github.com/repositories/123/issues?per_page=1&page=2>; rel="next"'
})
.get('/repositories/123/issues?per_page=1&page=2').reply(200, issues[1], {
.get('/repositories/123/issues?per_page=1&page=2').reply(200, [issues[1]], {
link: '<https://api.github.com/repositories/123/issues?per_page=1&page=3>; rel="next"'
})
.get('/repositories/123/issues?per_page=1&page=3').reply(200, issues[2], {
.get('/repositories/123/issues?per_page=1&page=3').reply(200, [issues[2]], {
link: '<https://api.github.com/repositories/123/issues?per_page=1&page=4>; rel="next"'
})
.get('/repositories/123/issues?per_page=1&page=4').reply(200, issues[3], {
.get('/repositories/123/issues?per_page=1&page=4').reply(200, [issues[3]], {
link: '<https://api.github.com/repositories/123/issues?per_page=1&page=5>; rel="next"'
})
.get('/repositories/123/issues?per_page=1&page=5').reply(200, issues[4], {
.get('/repositories/123/issues?per_page=1&page=5').reply(200, [issues[4]], {
link: ''
})
})
@ -65,7 +65,7 @@ describe('GitHubAPI', () => {
it('stops iterating if the done() function is called in the callback', async () => {
const spy = jest.fn((response, done) => {
if (response.data.id === 2) done()
if (response.data[0].id === 2) done()
})
const res = await github.paginate(github.issues.listForRepo({ owner: 'JasonEtco', repo: 'pizza', per_page: 1 }), spy)
expect(res.length).toBe(3)