diff --git a/src/manifest-creation.ts b/src/manifest-creation.ts index 6cbe1296..8d10f2df 100644 --- a/src/manifest-creation.ts +++ b/src/manifest-creation.ts @@ -79,6 +79,6 @@ export class ManifestCreation { get createAppUrl () { const githubHost = process.env.GHE_HOST || `github.com` - return `http://${githubHost}/settings/apps/new` + return `https://${githubHost}/settings/apps/new` } } diff --git a/test/fixtures/setup/response.json b/test/fixtures/setup/response.json index 3bd6b3bd..9f3871eb 100644 --- a/test/fixtures/setup/response.json +++ b/test/fixtures/setup/response.json @@ -1,7 +1,6 @@ - - { - "id": "6666", - "webhook_secret": "12345abcde", - "pem": "-----BEGIN RSA PRIVATE KEY-----\nsecrets\n-----END RSA PRIVATE KEY-----\n", - "html_url": "https://github.com/apps/testerino0000000" - } +{ + "id": "6666", + "webhook_secret": "12345abcde", + "pem": "-----BEGIN RSA PRIVATE KEY-----\nsecrets\n-----END RSA PRIVATE KEY-----\n", + "html_url": "https://github.com/apps/testerino0000000" +} diff --git a/test/manifest-creation.test.js b/test/manifest-creation.test.js index ce981a25..e0db57d9 100644 --- a/test/manifest-creation.test.js +++ b/test/manifest-creation.test.js @@ -45,12 +45,12 @@ describe('ManifestCreation', () => { }) test('creates an app url', () => { - expect(setup.createAppUrl).toEqual('http://github.com/settings/apps/new') + expect(setup.createAppUrl).toEqual('https://github.com/settings/apps/new') }) test('creates an app url when github host env is set', () => { process.env.GHE_HOST = 'hiimbex.github.com' - expect(setup.createAppUrl).toEqual('http://hiimbex.github.com/settings/apps/new') + expect(setup.createAppUrl).toEqual('https://hiimbex.github.com/settings/apps/new') }) })