xxq250
/
probot
forked from mirrors/probot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

httpSSSSSSS (#701)

This commit is contained in:
Bex Warner 2018-09-26 15:34:57 -04:00 committed by GitHub
parent 1da70093b2
commit 3be935bcd2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/manifest-creation.ts
View File

@ -79,6 +79,6 @@ export class ManifestCreation {
get createAppUrl () {
const githubHost = process.env.GHE_HOST || `github.com`
return `http://${githubHost}/settings/apps/new`
return `https://${githubHost}/settings/apps/new`
}
}

13
test/fixtures/setup/response.json vendored
View File

@ -1,7 +1,6 @@
{
"id": "6666",
"webhook_secret": "12345abcde",
"pem": "-----BEGIN RSA PRIVATE KEY-----\nsecrets\n-----END RSA PRIVATE KEY-----\n",
"html_url": "https://github.com/apps/testerino0000000"
}
{
"id": "6666",
"webhook_secret": "12345abcde",
"pem": "-----BEGIN RSA PRIVATE KEY-----\nsecrets\n-----END RSA PRIVATE KEY-----\n",
"html_url": "https://github.com/apps/testerino0000000"
}

4
test/manifest-creation.test.js
View File

@ -45,12 +45,12 @@ describe('ManifestCreation', () => {
})
test('creates an app url', () => {
expect(setup.createAppUrl).toEqual('http://github.com/settings/apps/new')
expect(setup.createAppUrl).toEqual('https://github.com/settings/apps/new')
})
test('creates an app url when github host env is set', () => {
process.env.GHE_HOST = 'hiimbex.github.com'
expect(setup.createAppUrl).toEqual('http://hiimbex.github.com/settings/apps/new')
expect(setup.createAppUrl).toEqual('https://hiimbex.github.com/settings/apps/new')
})
})