feat: Update @octokit/rest to 16.22.0 (#901)

package.json

@@ -56,7 +56,7 @@
     "@octokit/plugin-enterprise-compatibility": "^1.0.0",
     "@octokit/plugin-retry": "^2.1.1",
     "@octokit/plugin-throttling": "^2.3.0",
-    "@octokit/rest": "^16.13.3",
+    "@octokit/rest": "^16.23.2",
     "@octokit/webhooks": "^5.3.1",
     "@types/supports-color": "^5.3.0",
     "bottleneck": "^2.15.3",
@@ -97,7 +97,7 @@
     "@types/js-yaml": "^3.10.1",
     "@types/jsonwebtoken": "^8.3.0",
     "@types/nock": "^9.1.0",
-    "@types/node": "^11.9.0",
+    "@types/node": "^11.13.0",
     "@types/qs": "^6.5.1",
     "@types/raven": "^2.1.5",
     "@types/resolve": "^0.0.4",
@@ -120,7 +120,7 @@
     "tslint-config-prettier": "^1.10.0",
     "tslint-config-standard": "^8.0.0",
     "typedoc": "^0.14.0",
-    "typescript": "^2.9.2"
+    "typescript": "^3.4.1"
   },
   "standard": {
     "env": [

src/index.ts

@@ -190,7 +190,7 @@ export class Probot {
 
   public setup (appFns: Array<string | ApplicationFunction>) {
     // Log all unhandled rejections
-    process.on('unhandledRejection', this.errorHandler)
+    (process as NodeJS.EventEmitter).on('unhandledRejection', this.errorHandler)
 
     // Load the given appFns along with the default ones
     appFns.concat(defaultAppFns).forEach(appFn => this.load(appFn))

src/serializers.ts

@@ -1,10 +1,10 @@
-import { PayloadRepository, Webhooks } from '@octokit/webhooks'
+import { PayloadRepository, WebhookEvent } from '@octokit/webhooks'
 import bunyan from 'bunyan'
 import express from 'express'
 
 export const serializers: bunyan.StdSerializers = {
 
-  event: (event: Webhooks.WebhookEvent<any> | any) => {
+  event: (event: WebhookEvent<any> | any) => {
     if (typeof event !== 'object' || !event.payload) {
       return event
     } else {

src/wrap-logger.ts

@@ -7,33 +7,32 @@ import { Logger } from './'
 //     app.log.trace("verbose details");
 //
 export const wrapLogger = (logger: Logger, baseLogger?: Logger): LoggerWithTarget => {
-  const fn = logger.info.bind(logger)
+  const fn = Object.assign(logger.info.bind(logger), {
+    // Add level methods on the logger
+    debug: logger.debug.bind(logger),
+    error: logger.error.bind(logger),
+    fatal: logger.fatal.bind(logger),
+    info: logger.info.bind(logger),
+    trace: logger.trace.bind(logger),
+    warn: logger.warn.bind(logger),
 
-  // Add level methods on the logger
-  fn.trace = logger.trace.bind(logger)
-  fn.debug = logger.debug.bind(logger)
-  fn.info = logger.info.bind(logger)
-  fn.warn = logger.warn.bind(logger)
-  fn.error = logger.error.bind(logger)
-  fn.fatal = logger.fatal.bind(logger)
+    // Expose `child` method for creating new wrapped loggers
+    child: (attrs: ChildArgs) => {
+      // Bunyan doesn't allow you to overwrite name…
+      const name = attrs.name
+      delete attrs.name
+      const log = logger.child(attrs, true)
 
-  // Expose `child` method for creating new wrapped loggers
-  fn.child = (attrs: ChildArgs) => {
-    // Bunyan doesn't allow you to overwrite name…
-    const name = attrs.name
-    delete attrs.name
-    const log = logger.child(attrs, true)
+      // …Sorry, bunyan, doing it anyway
+      if (name) {
+        log.fields.name = name
+      }
 
-    // …Sorry, bunyan, doing it anyway
-    if (name) {
-      log.fields.name = name
-    }
-
-    return wrapLogger(log, baseLogger || logger)
-  }
-
-  // Expose target logger
-  fn.target = baseLogger || logger
+      return wrapLogger(log, baseLogger || logger)
+    },
+    // Expose target logger
+    target: baseLogger || logger
+  }) as LoggerWithTarget
 
   return fn
 }

test/github.test.ts

@@ -83,7 +83,7 @@ describe('GitHubAPI', () => {
     it('stops iterating if the done() function is called in the callback', async () => {
       const spy = jest.fn((response, done) => {
         if (response.data[0].id === 2) done()
-      })
+      }) as any
       const res = await github.paginate(github.issues.listForRepo.endpoint.merge({ owner: 'JasonEtco', repo: 'pizza', per_page: 1 }), spy)
       expect(res.length).toBe(3)
       expect(spy).toHaveBeenCalledTimes(3)