xxq250
/
mindspore
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update pull request template.

This commit is contained in:
liuchongming 2022-05-12 13:10:45 +08:00
parent 40c1f9743a
commit a9ee95737d
1 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
.gitee/PULL_REQUEST_TEMPLATE.md
View File

@ -23,6 +23,28 @@ Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes #
**Code review checklist**:
<!-- Code review guidebook: https://gitee.com/mindspore/community/blob/master/security/code_review_checklist_mechanism.md -->
- **Typical problems of security coding [[historical security coding cases reference]](https://gitee.com/mindspore/community/blob/master/security/security_coding_violation_cases.md)**
- [ ] whether to verify the pointer is null/nullptr
- [ ] whether to verify the function's return value
- [ ] whether new/malloc memory is released correctly
- **Performance analysis (if a sub-item is involved, please outline the implementation idea or modification content)**
- [ ] whether to modify hotspot ***function / algorithm / operation***
- [ ] whether to consider concurrent scenarios
- [ ] whether to consider communication scenario
+ - [ ] **Whether to comply with coding specifications [[coding specification reference]](https://gitee.com/mindspore/community/blob/master/security/coding_guild_cpp_zh_cn.md)**
+ - [ ] **Whether to comply with ***SOLID principle / Demeter's law*****
+ - [ ] **Whether the ***interaction between modules / features*** is involved (if yes, please outline the implementation ideas)**
+ - [ ] **Whether there is UT test case && the test case is a valid (if there is no test case, please explain the reason)**
+ - [ ] **whether the secret key is loaded/released correctly**
- **Error handling and recording**
- [ ] whether the interface exception scenarios are fully considered
- [ ] whether the error is recorded appropriately
**Special notes for your reviewers**:
<!-- + - [ ] **Whether document (installation, tutorial, design, reference, API, migration guide, FAQ, etc.) modification is involved** -->
<!-- + - [ ] **Whether it causes forward compatibility failure** -->
<!-- + - [ ] **Whether the API change is involved** -->
<!-- + - [ ] **Whether the dependent third-party library change is involved** -->