f5d312e4a0
Avoid casting NaN to int
...
Apparently it's possible for dbSizeEstimate to be negative
2021-06-04 09:47:06 -07:00
6992f5814b
Avoid casting NaN to int64_t
...
If the queue is empty, consider the queue to be 100% processed
2021-06-04 09:44:49 -07:00
1ee25e9b91
Avoid casting NaN to uint8_t
2021-06-04 09:43:50 -07:00
9f3db80eca
Fix applying offset to NULL in C
...
This fix should be safe since it (apparently) worked in practice before,
which likely means that zEnd is not used in the case where zCsr is NULL.
This means it likely doesn't matter what value we assign to zEnd when
zCsr is NULL as long as it has defined behavior.
2021-06-04 09:35:03 -07:00
a655ae3e48
Try not marking buffer undefined
2021-06-02 16:25:25 -07:00
5f04c2c7f5
Merge pull request #4877 from sfc-gh-clin/fix-datadistribution-special-key
...
Fix the place when changing dd system key without changing the lock key
2021-06-01 15:52:33 -07:00
d67184163b
Merge pull request #4556 from sfc-gh-jslocum/tss
...
Testing Storage Server
2021-06-01 09:11:10 -07:00
d35da1aeae
Merge pull request #4873 from sfc-gh-ajbeamon/close-files-in-simulation
...
Actually close files in simulation
2021-05-28 15:32:10 -07:00
f6253db7dc
Addressing final PR comments
2021-05-28 18:19:42 +00:00
5baeed3e2f
Add test for the fix
2021-05-28 17:59:57 +00:00
4a753a0bce
Merge pull request #4623 from dlambrig/issue4252
...
CDs reject requests using different connection descriptor
2021-05-28 10:45:51 -07:00
cc3175fc50
remove forwarding
2021-05-28 11:41:42 -04:00
10289ef8f1
Respond to AJs comments
2021-05-27 09:14:32 -04:00
64c10d3625
fix joshua failures, formatting
2021-05-27 08:08:07 -04:00
53d0ecc2fa
respond to comments made on 5/4
2021-05-27 08:08:07 -04:00
fc65154b5d
forward back new coordinator
2021-05-27 08:08:07 -04:00
fcfb78162c
misc cleanup for publishing
2021-05-27 08:08:07 -04:00
742c22cef2
Don't allow changing desriptor if knob is set
2021-05-27 08:08:07 -04:00
60d27d05d8
add knob enabling cross cluster support (default true)
2021-05-27 08:08:07 -04:00
065c4fdd5a
issue 4252
2021-05-27 08:08:07 -04:00
a756469670
Use a weak reference in the open files cache (abstracted from a similar cache in AsyncFileCached) to avoid a problem where removing an item from the cache could cause us to reentrantly remove it again.
2021-05-26 13:38:24 -07:00
2799b4f592
Merge pull request #4868 from sfc-gh-jslocum/redwood_test_patches
...
Fixing multiple small redwood test bugs
2021-05-25 15:47:49 -07:00
d68cb9b048
Changing role names and enabling tss by default in consistency check
2021-05-25 22:21:43 +00:00
95ab07fcb6
Adding comments for clarity
2021-05-25 20:42:07 +00:00
4257ac2b4d
More TSS Changes/Fixes
2021-05-25 20:37:48 +00:00
ce82c9653e
Testing Storage Server implementation
2021-05-25 20:28:50 +00:00
c31196ab01
Update fdbserver/FDBExecHelper.actor.cpp
...
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-05-25 10:24:00 -07:00
a39dec1380
Fixing multiple small redwood test bugs
2021-05-25 17:18:03 +00:00
07edc1db9a
Removing spaces in SevWarn trace event names
2021-05-25 17:06:48 +00:00
4133e79c1f
Merge pull request #4770 from sbodagala/master
...
Expose "bounce impact" and Storage Server "version catch-up rate" metrics
2021-05-21 08:34:18 -07:00
ee3e569055
Merge pull request #4843 from sfc-gh-mpilman/features/configure-simulator
...
allow simulation properties to be overwritten
2021-05-20 16:41:38 -07:00
64608fe86b
allow simulation properties to be overwritten
2021-05-20 13:48:41 -06:00
2fa80e7912
Address review comments
2021-05-19 22:04:43 +00:00
907248dcd4
fixed a rare simulation bug where missingFinalCommit could be skipped by two successive logSystem changes
2021-05-19 13:26:01 -07:00
3066e856c9
Expose "bounce impact" and Storage Server "version catch-up rate" metrics
...
Changes:
storageserver.actor.cpp: Use counters to capture (a) how fast a storage
server is catching up in versions and (b) the version fetch frequency.
Status.actor.cpp: Report the captured counter metrics as part of storage
metrics.
2021-05-19 16:08:32 +00:00
0752fb693e
Merge pull request #4780 from sfc-gh-satherton/arena-page
...
Zero-copy reads in Redwood via Arena-based pages and ability to allocate 4k-aligned memory in Arenas
2021-05-18 16:31:34 -07:00
c68bc03a59
Merge pull request #4819 from RenxuanW/tlog-fix
...
Bring #4518 (Logging more detailed information during Tlog recruitment) back.
2021-05-18 14:20:47 -07:00
319e77eef1
Add severity in logWorkerUnavailable(). Also, only log when fitness is GoodFit or BestFit.
2021-05-18 12:57:39 -07:00
f30793fd85
Implement getValuePrefix() using getValue() rather than the other way around to avoid the common getValue()'s actor state increasing from 128 to 256 bytes since it is a very hot code path.
2021-05-17 19:37:03 -07:00
60504e12ac
Address review comments.
2021-05-17 18:02:09 -07:00
e40538729e
Update fdbserver/IPager.h
...
Co-authored-by: Andrew Noyes <andrew.noyes@snowflake.com>
2021-05-17 14:46:06 -07:00
f88596bfd0
Applied clang-format after conflict resolution.
2021-05-16 05:24:19 -07:00
390b026f08
Merge branch 'master' into arena-page
2021-05-16 05:06:50 -07:00
bd0c4a4892
Avoid callers of getValue() and getValuePrefix() from being able to add arena dependencies to the source page arena.
2021-05-16 03:03:55 -07:00
b4e766bd13
Bug fix, returned value wasn't pointing into the correct arena.
2021-05-16 02:00:43 -07:00
cfeff9aa4b
Clarity improvement, loop was reusing variable name from enclosing scope.
2021-05-16 01:41:40 -07:00
6a5bf120f8
Bug fix: It is possible for the pager to be shut down while a cursor operation is acquiring its mutex, specifically after the permit is available but before the delay(0) inside take() is ready, causing the cursor to operate on an invalid pager.
2021-05-15 23:00:21 -07:00
2298567c2b
Use of aligned_alloc() for 4k pages causes too much wasted virtual memory. Added new 4k-aligned fast allocator, and changed Arena::allocatedAlignedBuffer() to be 4k-specific, now called Arena::allocate4kAlignedBuffer().
2021-05-14 23:12:00 -07:00
6275adc5a0
Address build failure
...
LogSystemPeekCursor.actor.cpp:
Check if "interf" is set before referencing it.
2021-05-13 21:38:07 +00:00
8a15d7d14b
Bring #4518 (Logging more detailed information during Tlog recruitment) back.
2021-05-13 12:20:31 -07:00
Andrew Noyes