Commit Graph

24929 Commits

Author SHA1 Message Date
A.J. Beamon f3b58a063f Fix some merge issues and review comments 2023-02-13 15:32:44 -08:00
A.J. Beamon 958ff862e0 Fix some merge issues 2023-02-13 12:59:48 -08:00
A.J. Beamon 98407809d9 Merge branch 'main' into metacluster-mgmt-restore
# Conflicts:
#	fdbcli/MetaclusterCommands.actor.cpp
#	fdbclient/Metacluster.cpp
#	fdbclient/include/fdbclient/MetaclusterManagement.actor.h
#	fdbserver/workloads/MetaclusterManagementWorkload.actor.cpp
#	tests/CMakeLists.txt
2023-02-13 12:30:33 -08:00
A.J. Beamon 0127dd4b5a
Merge pull request #9356 from sfc-gh-ajbeamon/metacluster-concurrency-testing
Add metacluster concurrency test and fix various bugs that it found
2023-02-13 11:57:47 -08:00
A.J. Beamon 93b1e04aa9
Merge pull request #9355 from sfc-gh-ajbeamon/fix-assigned-cluster-test-retry-logic
Fix logic in MetaclusterManagementWorkload when retrying a tenant creation with an invalid assigned cluster
2023-02-13 10:43:09 -08:00
Jingyu Zhou fa7f15e46a
Merge pull request #9353 from sfc-gh-yiwu/redwood_restart
Redwood: fix restart test failure with XOR encoding
2023-02-13 09:24:57 -08:00
Steve Atherton 844890bf93
Merge pull request #9042 from imperatorx/add-redwood-slack-knob
Introduced a new knob to control Redwood slack balance when splitting a page
2023-02-12 20:37:08 -08:00
Steve Atherton 41fa3eada9
Merge branch 'main' into add-redwood-slack-knob 2023-02-12 19:31:20 -08:00
A.J. Beamon a261c1d94c Run tenant management concurrency alongside metacluster management concurrency. Fix a few issues where performing tenant operations returned undesirable errors when the associated cluster was removed. 2023-02-11 19:46:47 -08:00
Xiaoxi Wang 93f892c085
Merge pull request #9340 from sfc-gh-xwang/fix/main/tenantList
fix the way verifyListFilter detect tenant state change
2023-02-11 17:20:46 -08:00
A.J. Beamon e6021f8326 Add Jon's metacluster concurrency test and fix various bugs that it found 2023-02-11 15:15:32 -08:00
Xiaoxi Wang 21a2378de5
Merge pull request #9298 from sfc-gh-xwang/feature/main/clearRange
Split raw clear ranges across tenants in required mode
2023-02-11 14:29:46 -08:00
Xiaoxi Wang a9c7632c83 Merge branch 'main' of https://github.com/apple/foundationdb into fix/main/tenantList 2023-02-11 13:54:27 -08:00
Xiaoxi Wang ac1ddc81b0 remove debug trace; change function comment 2023-02-11 13:17:59 -08:00
A.J. Beamon 6a2f63029e
Merge pull request #9354 from sfc-gh-ajbeamon/disable-tenants-in-downgrade-tests
Disable tenants in downgrade tests to versions before 7.3
2023-02-11 12:11:46 -08:00
A.J. Beamon b4f45a0a87 Fix logic in MetaclusterManagementWorkload when retrying a tenant creation with an invalid assigned cluster 2023-02-11 12:09:17 -08:00
A.J. Beamon ee1b48323d
Merge pull request #9346 from sfc-gh-nwijetunga/nim/global-tenant-ids
Support for Two Byte Prefix for Tenant IDs
2023-02-11 11:31:24 -08:00
A.J. Beamon b32eebac30
Merge pull request #9241 from sfc-gh-ajbeamon/storage-quota-in-tenant-metadata-space
Refactor storage quotas to store them in a key backed map in the tenant metadata space
2023-02-11 10:12:46 -08:00
A.J. Beamon 69fd1addec Disable tenants in downgrade tests to versions before 7.3. For some tests, use an alternate method to disable tenants. 2023-02-11 09:58:29 -08:00
A.J. Beamon 4579a4319d Merge branch 'main' into storage-quota-in-tenant-metadata-space 2023-02-11 09:04:15 -08:00
Xiaoxi Wang a0f7943fc3 simplify implementation of lowerBoundTenantId and withinSingleTenant 2023-02-10 22:14:59 -08:00
Yi Wu a37d8f757c Redwood: fix restart test failure with xor encoding 2023-02-10 21:01:52 -08:00
Jingyu Zhou 1ea8d63a39
Merge pull request #9348 from sfc-gh-satherton/status-details-rss
Since FDB now limits memory by RSS, report RSS in `status details` view.
2023-02-10 19:25:33 -08:00
Nim Wijetunga 640f1afd77 address pr comments 2023-02-10 16:39:06 -08:00
Nim Wijetunga 9e5c61e127 address pr comments 2023-02-10 15:56:41 -08:00
Jingyu Zhou 814350c4e6
Merge pull request #9338 from jzhou77/fix
Fix DD stuck when remote DC is dead
2023-02-10 15:19:17 -08:00
Nim Wijetunga de9eef72ff address pr comments 2023-02-10 13:49:15 -08:00
Xiaoxi Wang ffc5733e9c add comments 2023-02-10 12:51:13 -08:00
Xiaoxi Wang bb8d96c026 Merge branch 'main' of https://github.com/apple/foundationdb into feature/main/clearRange 2023-02-10 12:30:16 -08:00
Xiaoxi Wang ffadea08cb change isSingleTenant check; add unit tests 2023-02-10 12:29:38 -08:00
Jingyu Zhou 5232a21005
Merge pull request #9344 from sfc-gh-akejriwal/valgrind 2023-02-10 12:04:31 -08:00
Steve Atherton df165e43ad Since FDB now limits memory by RSS, report RSS in `status details` view. 2023-02-10 11:30:29 -08:00
A.J. Beamon a6b47c1da4 Fix merge issue 2023-02-10 11:12:36 -08:00
Jingyu Zhou 622520bd2d Return the source team if remote DC is dead
Also refactor the code with findTeamFromServers().
2023-02-10 11:11:07 -08:00
Jingyu Zhou 9aa15b459c Clean up trace events 2023-02-10 11:11:07 -08:00
Jingyu Zhou 6c4a9b5f23 Fix DD stuck when remote DC is dead
When remote DC is down, the remote team collection of DD can initializing
waiting for the remote to recover (all_tlog_recruited state). However, the
getTeam request can already be served by the remote team collection. So, for
a RelocateShard (data movement such as split, move), it will get a team for
the remote DC. But the data movement can't make progress on the remote team
because the remote DC hasn't recovered yet. Because of the stuck of data
movement, the primary cannot reach the "storage_recovered" state and stay in
accepting_commit state.

The specifc test failure: slow/ApiCorrectness.toml -s 339026305 -b on
at commit:  0edd899d65

In this test, primary DC has 1 SS killed, remote DC has 2 TLog and 2 SS killed.
So the remote is dead, the remaining 2 SSes can't make progress because of the
loss of 2 TLogs. The repairDeadDatacenter() can't reach the "storage_recovered"
state due to DD's failure of moving shards away from the killed SS in the
primary.

The fix is to exclude all remote in repairDeadDatacenter() so that tells DD to
mark all SSes in the remote as unhealthy. Another fix is to return empty
results for getTeam request if the remote team collection is not ready. This
will allow the data movement to continue, essentially remote team is not changed
for the data movement.
2023-02-10 11:11:07 -08:00
A.J. Beamon 13eee09ce8 Merge branch 'main' into metacluster-mgmt-restore 2023-02-10 10:58:01 -08:00
A.J. Beamon 0e078435ab Remove unnecessary try/catch 2023-02-10 10:57:37 -08:00
A.J. Beamon 4b13c9c211 Make a few minor fixes, refactor some code for clarity, and improve throughput of repopulating a management cluster 2023-02-10 10:41:55 -08:00
Ata E Husain Bohra ce49bfb8ac
EaR: Fix RandomUnitTest (#9339)
Description

Set `enable_configurable_encryption` knob in the unit test to make
RandomUnitTest runs happy

Testing

BlobCipherUnitTest
EncryptionOps
RandomUnitTest
2023-02-10 10:35:08 -08:00
Nim Wijetunga f775116214 fix test 2023-02-10 02:26:32 -08:00
Nim Wijetunga 8a3f3ea674 clean up code 2023-02-10 01:01:16 -08:00
dependabot[bot] 905af6ccf8
Bump github.com/emicklei/go-restful in /fdbkubernetesmonitor (#9336)
Bumps [github.com/emicklei/go-restful](https://github.com/emicklei/go-restful) from 2.9.5+incompatible to 2.16.0+incompatible.
- [Release notes](https://github.com/emicklei/go-restful/releases)
- [Changelog](https://github.com/emicklei/go-restful/blob/v3/CHANGES.md)
- [Commits](https://github.com/emicklei/go-restful/compare/v2.9.5...v2.16.0)

---
updated-dependencies:
- dependency-name: github.com/emicklei/go-restful
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-10 08:15:57 +01:00
Nim Wijetunga dd57e85064 remove traces 2023-02-09 23:05:43 -08:00
Xiaoxi Wang 09da7efdc0 handle clear range when tenantMap.size() == 0 2023-02-09 22:28:18 -08:00
Ata E Husain Bohra f30c5a13ac
EaR: Configurable Encryption feature support for BlobGranules (#9343)
Description

Patch update BlobGranule encryption code to support Configurable
encryption semantics

Testing

BlobGranuleCorrectness* - 100K
2023-02-09 21:13:56 -08:00
Nim Wijetunga fed650894d working version 2023-02-09 21:10:40 -08:00
Ankita Kejriwal f5a01ebac1 Add a default value for version in `WaitMetricsRequest` 2023-02-09 19:37:45 -08:00
Xiaoxi Wang 53923c77cb Merge branch 'main' of https://github.com/apple/foundationdb into fix/main/tenantList 2023-02-09 17:27:54 -08:00
Yi Wu f17024e615
Redwood: fix btree unit test reopen memory only pager (#9334)
The Redwood btree test are not suppose to reopen the pager if it is memory only, which will open an empty pager.
2023-02-09 17:12:50 -08:00