mpilman
7fe56ccb00
always build correctnes package
2020-03-25 18:01:08 -07:00
mpilman
ce6c4cb8d8
Build and package TestHarness
2020-03-25 17:36:47 -07:00
Evan Tschannen
bb5799bd20
Merge pull request #2642 from xumengpanda/mengxu/new-backup-format-PR
...
FastRestore:Integrate with new backup format
2020-03-25 15:47:55 -07:00
Jingyu Zhou
0f57bf9685
Remove a SevError event
...
The same mutation can be present in overlapping mutation logs. Thus we cannot
assert its absence. This can be caused for multiple reasons. One possibility
is that new TLogs can copy mutations from old generation TLogs; another one
is backup worker is recruited without knowning previously saved progress.
2020-03-25 15:23:21 -07:00
Meng Xu
a93f13cfd7
Remove redundant restoreRequestDone break in backup.actor
2020-03-25 15:19:46 -07:00
Meng Xu
495afe2e0b
Improve how to wati for restore to finish
...
Remove default parameter for atomicRestore as suggested in review.
2020-03-25 13:54:21 -07:00
tclinken
7d5ed53215
Allow trace log group to be set after database is created
2020-03-25 13:40:43 -07:00
Meng Xu
f240d393f2
Add ParallelRestoreApiCorrectnessAtomicRestore.txt into ctests
2020-03-25 11:23:19 -07:00
Meng Xu
1ba11dc74b
Apply clang format
2020-03-25 11:20:17 -07:00
A.J. Beamon
0547cf2b4c
Merge pull request #2854 from dongxinEric/doc/update-api-docs-for-getEstimatedRangeBytes
...
Doc/update api docs for get estimated range bytes
2020-03-25 11:08:25 -07:00
Meng Xu
120272f025
Change unlockDB from RestoreMaster to Agent
2020-03-25 11:04:49 -07:00
Jingyu Zhou
472f7bdd32
Rename a trace event to avoid confusion
...
Change from BackupRange to BackupVersionRange.
2020-03-25 11:03:05 -07:00
Evan Tschannen
e0fbd9ecbe
Merge pull request #2847 from atn34/atn34/assert-no-return
...
Assert recoverAndEndEpoch does not become ready
2020-03-25 10:23:38 -07:00
Xin Dong
353fcb2096
Update Go binding documentations for the new API to be consistent with others
2020-03-25 10:02:38 -07:00
Xin Dong
30f3753699
Replace the Version to Int64Future
2020-03-25 09:41:47 -07:00
Xin Dong
1501a365fb
Address review comments
2020-03-25 09:33:19 -07:00
Jingyu Zhou
e2f317a0da
Fix a crash failure
2020-03-25 09:18:49 -07:00
Meng Xu
130b91c820
Fix segmentation fault in submitParallelRestore
2020-03-24 23:52:34 -07:00
Jingyu Zhou
00fb4c1a35
Fix an off by one error
...
Backup worker's saved version should start from its startVersion - 1, i.e.,
the startVersion is not saved yet. Otherwise, if the version range is just
the startVersion itself and there is no data, then the range [startVersion,
startVersion + 1) will be missing. This causes non-continuous partitioned logs.
2020-03-24 23:40:36 -07:00
Meng Xu
ca8966a28b
Move lockDB into submitRestore request from restore worker
...
AtomicRestore needs to lock DB before we start the restore worker.
So we cannot lock DB in restore worker with a different randomUID.
2020-03-24 23:39:35 -07:00
Meng Xu
e59becdec8
Refactor atomicRestore for atomicParallelRestore
2020-03-24 22:37:12 -07:00
Meng Xu
6a8d6ddb8e
Introduce ParallelRestoreApiCorrectnessAtomicRestore.txt test
...
This covers ApiCorrectnessTest as workload for parallel restore.
2020-03-24 22:30:51 -07:00
Jingyu Zhou
669916467e
Add missing transaction reset call
2020-03-24 20:14:37 -07:00
Jingyu Zhou
5e729a5bcf
Merge branch 'master' of https://github.com/apple/foundationdb into backup-worker-bak
2020-03-24 19:54:36 -07:00
Jingyu Zhou
edcbeb8992
Address review comments
...
Move transaction object outside of the loop and rename trace events.
2020-03-24 18:22:20 -07:00
Meng Xu
d185359422
ApiCorrectnessAtomicRestore test: Increase timeout value
2020-03-24 17:36:17 -07:00
Meng Xu
241c2703c8
Fix atomicParallelRestore interface
2020-03-24 17:00:55 -07:00
Xin Dong
233a6bb2a7
Address review comments
2020-03-24 16:31:46 -07:00
Meng Xu
80d62f3cb8
Fix:Add atomicParallelRestore to header
2020-03-24 16:28:08 -07:00
Meng Xu
ffb0a439ea
atomicParallelRestore should not return a version
2020-03-24 16:05:09 -07:00
Meng Xu
b173929316
Add atomicParallelRestore to AtomicRestore workload
2020-03-24 15:58:49 -07:00
Meng Xu
01921c3953
Move FileBackupAgent parallel restore impl to FileBackupAgentImpl
...
For consistency with existing code, and
state variable can only occur in ACTOR.
2020-03-24 15:11:34 -07:00
Meng Xu
81f7181c9e
Refactor submitParallelRestore function into FileBackupAgent
2020-03-24 14:44:55 -07:00
Meng Xu
5584884c12
Refactor parallelRestoreFinish function into FileBackupAgent
2020-03-24 14:15:15 -07:00
Meng Xu
4e477f5489
Copy atomicRestore to atomicParallelRestore
2020-03-24 13:59:35 -07:00
Xin Dong
91037114e5
Fix documentation build
2020-03-24 13:35:07 -07:00
Xin Dong
0fb728d019
Updated API documentations for the new getEstimatedRangeBytes api
2020-03-24 13:27:20 -07:00
Xin Dong
5876d694cb
Use snake case to be consistent with conventions
2020-03-24 13:26:59 -07:00
Jingyu Zhou
7831bec2b0
Address review comments on trace events
2020-03-24 10:54:12 -07:00
Xin Dong
241b24b358
Merge pull request #2852 from dongxinEric/feature/binding-tests-for-storage-server-metrics-api
...
Added a test in API tests for the new API(getEstimagedRangeSize).
2020-03-24 10:41:00 -07:00
Xin Dong
69b572cc86
Added specs for the new tests.
2020-03-24 09:59:40 -07:00
Xin Dong
338c62b176
Moved up the new test cases to comply the convention there.
2020-03-24 09:53:52 -07:00
Xin Dong
527686ffe0
Added a test in API tests for the new API(getEstimagedRangeSize).
2020-03-24 09:26:56 -07:00
Jingyu Zhou
a3058e7d96
Fix incorrectly marking a backup job as stopped
...
This causes missing version ranges for mutation logs.
2020-03-23 22:05:58 -07:00
Jingyu Zhou
1155304cd5
Remove a spurious assertion
...
It's possible that there is a gap between backup's contiguousLogEnd and snapshot
version.
2020-03-23 21:39:40 -07:00
Jingyu Zhou
82a1790776
Fix backup worker crash due to aborted backup job
...
If a backup job is aborted, the "startedBackupWorkers" key can be cleared, thus
triggering the assertion failure.
2020-03-23 21:11:25 -07:00
Jingyu Zhou
243d078596
Fix off by one error
...
Epoch end version is saved version + 1, so need +1 for minBackupVersion.
2020-03-23 20:44:31 -07:00
Jingyu Zhou
9b0a3787c7
Merge pull request #2850 from xumengpanda/mengxu/fr-enable-rollback-and-abort-test-PR
...
Performant restore [23/xx]: Enable Rollback test workload and abortAndRestartAfter option for restore tests
2020-03-23 18:51:36 -07:00
Jingyu Zhou
f1d7fbafb4
Stop actors for displaced backup workers
...
If the worker is displaced, it should not update backup containers.
2020-03-23 18:48:06 -07:00
Meng Xu
d7cf562ec4
Enable rollback workload for multi cycle restore test
2020-03-23 16:33:11 -07:00