Commit Graph

4882 Commits

Author SHA1 Message Date
Balachandar Namasivayam ac8ad07b45 Address review comments. 2019-03-22 18:48:49 -07:00
Balachandar Namasivayam 4ed323ac52 Fixed bug and addressed review comments. 2019-03-22 18:48:49 -07:00
Balachandar Namasivayam d75020b44a Fix bug where accessing shared memory created by boost 1.52 leads to error when accessed by boost 1.67. 2019-03-22 18:48:49 -07:00
Andrew Noyes eacde47050 Disable setMemoryQuota for ASAN 2019-03-22 18:47:38 -07:00
Evan Tschannen 36ab852bb1 Merge branch 'master' into ratekeeper
# Conflicts:
#	fdbserver/ClusterController.actor.cpp
2019-03-22 18:41:00 -07:00
Evan Tschannen add66350f6 Merge branch 'master' of github.com:apple/foundationdb 2019-03-22 18:38:32 -07:00
Evan Tschannen e3400c13ae fixed a performance regression related to broadcasting a read version to too many transactions simultaneously 2019-03-22 18:37:39 -07:00
Evan Tschannen e37e45723c fix: CompareAndClear does not coalesce with itself 2019-03-22 18:37:39 -07:00
Evan Tschannen 6254a1a8e4 fix: restarting the provisional proxy causes all tlog peeks to restart, so if tlog peeks take longer than 1 second this could end in an infinite loop 2019-03-22 18:37:39 -07:00
Evan Tschannen 7dd1c1b60c fix: processClassFitness could be wrong if the client changed their class while rebooting 2019-03-22 18:37:39 -07:00
Evan Tschannen ddb6058770 simplified ratekeeper monitoring loop 2019-03-22 18:22:45 -07:00
Jingyu Zhou 12917d8c7d Add actors to store halt request futures
Address best fitness in checking better DD or RK.
2019-03-22 18:06:38 -07:00
Jingyu Zhou e8977aeb98 Remove clusterControllerDcId check
This is no longer needed since it'll be set in the ctor.
2019-03-22 18:01:54 -07:00
Evan Tschannen 82bc447e29 startRatekeeper is responsible for updating serverDBInfo 2019-03-22 17:56:16 -07:00
Evan Tschannen 82c80c225d make sure id_worker is updated before setting ratekeeper or data distribution 2019-03-22 17:08:54 -07:00
Evan Tschannen 6a9c9d79cc
Update fdbserver/ClusterController.actor.cpp 2019-03-22 17:00:58 -07:00
Evan Tschannen 70b1c88cdd
Update fdbserver/ClusterController.actor.cpp 2019-03-22 17:00:52 -07:00
Stephen Atherton 382a7bdc5f Changed behavior regarding ~ and ~user paths to treat them as unresolvable symbolic links. 2019-03-22 16:21:12 -07:00
Evan Tschannen efbcd18987 fixed a performance regression related to broadcasting a read version to too many transactions simultaneously 2019-03-22 16:05:20 -07:00
Evan Tschannen 6905db816e fix: CompareAndClear does not coalesce with itself 2019-03-22 15:55:09 -07:00
A.J. Beamon 01590fc14e
Merge pull request #1323 from alecgrieser/00775-database-level-tr-options
Resolves #775: Support setting Transaction options at the Database level
2019-03-22 15:16:10 -07:00
Jingyu Zhou 16f54577ee Restore master PID in cluster controller worker registration
CC may think master failed and clear the master PID, which can block both data
distributor and ratekeeper recruitment. Fix by restoring it during worker
registration.
2019-03-22 14:53:05 -07:00
A.J. Beamon 3a69d1da8e Add PR number to release notes 2019-03-22 14:24:33 -07:00
A.J. Beamon fc48b6050e When tabulating read workload metrics, ignore the absence of any particular storage server. 2019-03-22 14:22:22 -07:00
Evan Tschannen 78f7a2e40b fix: restarting the provisional proxy causes all tlog peeks to restart, so if tlog peeks take longer than 1 second this could end in an infinite loop 2019-03-22 14:13:58 -07:00
Alec Grieser 63f23c0818
add tests for new database behavior to python scripted tests
This also fixes the behavior for the tests of the options which are no longer reset when on_error is called.
2019-03-22 15:10:08 -04:00
Stephen Atherton 524a666290 Added back previous handling of ~ in paths, with the improvement that it only treats ~ as special if it is the first character. 2019-03-22 11:44:46 -07:00
Alec Grieser e6e2ea2af6
Merge remote-tracking branch 'upstream/master' into 00775-database-level-tr-options 2019-03-22 14:41:27 -04:00
A.J. Beamon f3a85f62c1
Merge pull request #1346 from alecgrieser/fix-scripted-bindingtester-test
Fix scripted bindingtester test
2019-03-22 11:38:43 -07:00
A.J. Beamon fd30969139
Merge pull request #1344 from satherton/fix-parsetime-linux
Stopped using %z to parse timezone offset with strptime()...
2019-03-22 11:04:04 -07:00
A.J. Beamon 76e6a3f56d
Update fdbclient/BackupAgentBase.actor.cpp
Co-Authored-By: satherton <stevea@apple.com>
2019-03-22 11:02:38 -07:00
Andrew Noyes 56955deed9 Set TRACE_FORMAT network option in fdbbackup 2019-03-22 10:39:13 -07:00
Andrew Noyes 555405d1ab Set TRACE_FORMAT network option in fdbcli
Previously --trace_format did not work since the network option has the
last say in what trace format to use.
2019-03-22 10:35:05 -07:00
Alec Grieser 5e8e2ef2a6
rename the function where it is defined as well as where it is called 2019-03-22 13:26:41 -04:00
Alec Grieser 9e15872418
remove test that is now extraneous 2019-03-22 13:20:00 -04:00
Alec Grieser 1342cc7f48
update generated.go after vexillographer change (docs only) 2019-03-22 13:12:10 -04:00
A.J. Beamon 001fde718c
fix comments to mark things that throw as throwing rather than not throwing
Co-Authored-By: alecgrieser <alloc@apple.com>
2019-03-22 13:04:11 -04:00
Alec Grieser 55a9db1994
spaces to tabs 🤮 2019-03-22 12:58:32 -04:00
A.J. Beamon 67cc274f10
add a missing "is" to parameter description
Co-Authored-By: alecgrieser <alloc@apple.com>
2019-03-22 12:57:01 -04:00
Alec Grieser 4ac3e790ad
modify the reset and timeout option unit tests to handle new on_error cancellation behavior 2019-03-22 12:45:59 -04:00
A.J. Beamon 4eb5715689 Add support for a client or worker having multiple issues. 2019-03-22 08:29:41 -07:00
Jingyu Zhou da338c3ad6 Avoid unnecessary recuriting of DD or RK
While waiting for recruting data distributor or ratekeeper, a previous one
could already joined. So we can skip this unnecessary recruiting.

Revert the change of worker.actor.cpp for ratekeeper. Instead, recruiting
ratekeeper should avoid the process with an existing one. This fixes a bug
where the ratekeeper interface became zombie, killing other healthy ratekeeper
but doing no useful work. Found by:

-r simulation --crash -f tests/fast/WriteDuringRead.txt -s 31858110 -b on
2019-03-21 22:40:07 -07:00
Stephen Atherton cabe7ca844 Stopped using %z to parse timezone offset with strptime() because it only seems to work as expected on MacOS. Updated time input/output unit tests so that they don't assume what the local timezone is. 2019-03-21 19:38:07 -07:00
Stephen Atherton 6c42e42334 Fix compiler complaint about ignored return codes being ignored. Added commented call to testPathOps() for convenience. 2019-03-21 18:05:30 -07:00
Evan Tschannen fe4464e786 fix: processClassFitness could be wrong if the client changed their class while rebooting 2019-03-21 17:56:04 -07:00
Stephen Atherton a6b598f236 Missing include. 2019-03-21 17:51:00 -07:00
Jingyu Zhou 299961aecb Move ratekeeper or data distributor from excluded servers 2019-03-21 17:17:33 -07:00
Stephen Atherton c6d96498ca parentDirectory() is now based on popPath(). Bug fix, abspath() would prepend current working directory even when not resolving symlinks. Added more unit tests. Ported path operation unit tests to fdbmonitor() since the path manipulation function implementations are significantly different. Clarified some comments. The flow project version of abspath() does not allow resolveLinks to be false, for now, because behavior of this on Windows is not well thought out or tested. 2019-03-21 16:56:36 -07:00
A.J. Beamon 12e755114b
whitespace fix in release notes
Co-Authored-By: alecgrieser <alloc@apple.com>
2019-03-21 18:50:49 -04:00
Alec Grieser 64e45e6826
retry limit and max delay transaction options are no longer reset after onError 2019-03-21 18:50:02 -04:00