Commit Graph

18689 Commits

Author SHA1 Message Date
sfc-gh-tclinkenbeard 9158564bfc Fix formatting 2022-02-11 10:27:41 -08:00
root 9bf11ac2f3 Removed condition for arch64 2022-02-11 13:45:17 +00:00
root 459dd83583 resolved format error 2022-02-11 12:11:50 +00:00
Vikas Gupta 9cd133eeb0
Merge branch 'apple:main' into ppc64le_support 2022-02-11 17:37:26 +05:30
root d61519c53d resolved format error 2022-02-11 10:24:56 +00:00
root 15159a5deb resolved format error 2022-02-11 09:57:24 +00:00
sfc-gh-tclinkenbeard 3f8c1e2e69 Encapsulate TCServerInfo::id 2022-02-10 23:04:25 -08:00
Bharadwaj V.R faf74b2563 Removed some trace statements that were accidentally left behind in the code 2022-02-10 22:23:03 -08:00
vikasgupta8 edfff755bf added support for ppc64le 2022-02-11 06:17:15 +00:00
Trevor Clinkenbeard ef68e6fe0d
Merge pull request #6353 from sfc-gh-ljoswiak/fixes/dynamic-knobs
Fix dynamic knobs correctness issues
2022-02-10 22:13:02 -08:00
Bharadwaj V.R 41bd39a82a Fix code formatting 2022-02-10 22:10:50 -08:00
Bharadwaj V.R b306288c62
Merge branch 'main' into dd-utest 2022-02-10 22:00:52 -08:00
Bharadwaj V.R df2f5c5709 Make UT parameters sensitive to server-knobs 2022-02-10 21:52:30 -08:00
Bharadwaj V.R 83b7f1fcbf Add test descriptions for DD unit tests 2022-02-10 19:29:34 -08:00
sfc-gh-tclinkenbeard 6e87c01404 Move implementations of TC*Info methods to TCInfo.actor.cpp 2022-02-10 19:19:50 -08:00
Bharadwaj V.R 7790d57c06 Mask the use of the delay in getTeam and the buildTeams path in the DD unit test
delay doesn't work as expected in the UT envionment
2022-02-10 18:52:40 -08:00
sfc-gh-tclinkenbeard 2165635478 Make printSnapshotTeamsInfo a static function of DDTeamCollection 2022-02-10 18:45:52 -08:00
sfc-gh-tclinkenbeard 9bc38ae73e Make DDTeamCollection::distributorId private 2022-02-10 18:26:06 -08:00
sfc-gh-tclinkenbeard 14c8483e9d Mark DDTeamCollection::primary private 2022-02-10 18:16:57 -08:00
sfc-gh-tclinkenbeard 8e7963172b Mark DDTeamCollection::excludedServers private 2022-02-10 17:58:59 -08:00
sfc-gh-tclinkenbeard 7ba250a991 Fix -Wreorder-ctor warnings 2022-02-10 17:54:57 -08:00
sfc-gh-tclinkenbeard 1f64477938 Make more DDTeamCollection fields private 2022-02-10 17:44:49 -08:00
sfc-gh-tclinkenbeard 6e60e26730 Make some DDTeamCollection fields private 2022-02-10 16:48:26 -08:00
sfc-gh-tclinkenbeard 641a38bd0b Make more DDTeamCollection methods private.
The methods only used by DDTeamCollection::run can now be made private.
2022-02-10 16:19:32 -08:00
sfc-gh-tclinkenbeard c4508330d2 Make dataDistributionTeamCollection a static function of DDTeamCollection 2022-02-10 16:19:32 -08:00
sfc-gh-tclinkenbeard 5477012ad8 Change DDTeamCollection method signatures to accept references.
Passing nullptr to these methods is invalid, but previously the
signature didn't indicate this. We previously needed to pass pointers
due to actor compiler restrictions, but these restrictions no longer
apply.
2022-02-10 16:19:32 -08:00
sfc-gh-tclinkenbeard b51944b262 Pass constant reference to DDTeamCollection::isCorrectDC 2022-02-10 16:19:32 -08:00
sfc-gh-tclinkenbeard c024fbe845 Mark DDTeamCollection::waitUntilHealthy const 2022-02-10 16:19:32 -08:00
Sam Gwydir 8bff389fe3 add overwrite op 2022-02-10 15:17:13 -08:00
Sam Gwydir cf19452277 typo 2022-02-10 15:17:07 -08:00
Trevor Clinkenbeard f7118ad406
Merge pull request #6371 from sfc-gh-tclinkenbeard/dd-refactor
Move `DDTeamCollection` method implementations into `.cpp` file
2022-02-10 15:03:01 -08:00
Bharadwaj V.R 5096a312ae Mark new DD unit tests as such in cmakelists 2022-02-10 14:56:54 -08:00
Jon Fu 2e63ac6963 code review changes: additional test checks, cleanup extra code, mark internal option hidden 2022-02-10 17:01:09 -05:00
Zhe Wang d684508540 Add RatekeeperLimitReasonDetails traceevent for RK 2022-02-10 13:59:47 -08:00
A.J. Beamon 0a1bcf7a29 Log protocol version as a hex string rather than a uint64_t. 2022-02-10 13:57:48 -08:00
sfc-gh-tclinkenbeard 0dce252c92 Make many DDTeamCollection methods private 2022-02-10 13:44:39 -08:00
Jon Fu 458e708272 addressed code review comments: renamed variables, small functional changes, style changes 2022-02-10 16:17:54 -05:00
sfc-gh-tclinkenbeard 36700791a1 Use structured bindings in some for loops in DDTeamCollection.actor.cpp 2022-02-10 12:10:45 -08:00
sfc-gh-tclinkenbeard 3141698c41 Use special ASSERT_* macros for numeric comparison in data distribution
code.

This helps debugging by printing the exact input values when an
assertion fails.
2022-02-10 11:59:19 -08:00
sfc-gh-tclinkenbeard 975b9f3b32 Remove get helper function from DataDistribution.actor.cpp 2022-02-10 11:32:33 -08:00
sfc-gh-tclinkenbeard f16aa56d4c Fix comment grammar 2022-02-10 11:26:39 -08:00
sfc-gh-tclinkenbeard b5cefdbcc2 Mark DDTeamCollection methods const 2022-02-10 11:26:04 -08:00
sfc-gh-tclinkenbeard 3c00a66f36 Remove public DDTeamCollection::zeroServerLeftLoggerActor method 2022-02-10 11:19:34 -08:00
sfc-gh-tclinkenbeard b96c2477a3 Mark TSSPairState methods const 2022-02-10 11:12:40 -08:00
sfc-gh-tclinkenbeard c37be7a898 Move DDTeamCollection method implementations into cpp file 2022-02-10 11:09:31 -08:00
Ben Collins 017f9b2308 ApiWorkload ctor failed to perform null check on g_simulator 2022-02-10 09:51:37 -08:00
Bharadwaj V.R ab34d0553d Add unit tests for DD to test the team selection logic 2022-02-09 22:50:01 -08:00
Bharadwaj V.R 6d46b03651 Add some unit tests for DD team selection 2022-02-09 22:22:56 -08:00
A.J. Beamon d10dc300de
Merge pull request #6365 from sfc-gh-ajbeamon/remove-configure-test-restart
Disallow starting the ConfigureTestRestart test from any version before 7.1.
2022-02-09 17:17:18 -08:00
Kao Makino 886ee280d8
Merge pull request #6297 from sfc-gh-zyang/zyang/fdo
support Profile Guided Optimization
2022-02-09 16:03:41 -08:00