Commit Graph

1294 Commits

Author SHA1 Message Date
Zhe Wu 07ee4029f2 Addressing comments. 2021-06-17 14:53:15 -07:00
Zhe Wu 4e3e2b0392 Create health monitor in FDB workers to monitor network condition. This change is only inside the worker. 2021-06-16 14:50:44 -07:00
Steve Atherton f7554b8fcb Move FlowMutex unit test to FlowTests. 2021-06-08 16:58:35 -07:00
sfc-gh-tclinkenbeard 371a38e6e5 Merge remote-tracking branch 'origin/master' into remove-extra-copies 2021-06-07 10:26:06 -07:00
Andrew Noyes 402622ace9
Merge pull request #4909 from apple/anoyes/fix-ub
Fix several instances of undefined behavior
2021-06-07 08:58:45 -07:00
Andrew Noyes d6a6a8b3dd
Remove header that's no longer needed 2021-06-06 08:36:48 -07:00
Josh Slocum 9b36f69b8d
Merge pull request #4892 from sfc-gh-jslocum/tss_mappingv2
TSS Mapping Change
2021-06-04 14:57:51 -07:00
Andrew Noyes ce25a99000 Disallow conversion from float in specialCounter 2021-06-04 12:09:13 -07:00
Andrew Noyes 5fbadb66c2 Clamp to max int if large float is not representable as int 2021-06-04 09:42:39 -07:00
A.J. Beamon 24d17c013b Add an assert to confirm that try_emplace is inserting a new entry 2021-06-03 13:51:47 -07:00
A.J. Beamon 7d83340993 Fix: when a file open completes synchronously, it wasn't being stored in the openFiles map. 2021-06-03 13:30:28 -07:00
Josh Slocum ac209b32fd Addressing review comments 2021-06-03 15:31:16 +00:00
Josh Slocum b3e4f182ef TSS Mapping Change 2021-06-02 17:30:09 +00:00
Josh Slocum d67184163b
Merge pull request #4556 from sfc-gh-jslocum/tss
Testing Storage Server
2021-06-01 09:11:10 -07:00
A.J. Beamon d35da1aeae
Merge pull request #4873 from sfc-gh-ajbeamon/close-files-in-simulation
Actually close files in simulation
2021-05-28 15:32:10 -07:00
A.J. Beamon 69dbe04d42 Rename WeakFutureReference to UnsafeWeakFutureReference and add warning comment 2021-05-28 14:34:20 -07:00
Josh Slocum f6253db7dc Addressing final PR comments 2021-05-28 18:19:42 +00:00
A.J. Beamon d82eac4062 Fix a test issue where closing an AsyncFileNonDurable could permanently prevent you from reopening the file if the machine was in a failed state during cleanup 2021-05-27 20:41:49 -07:00
Dan Lambright 10289ef8f1 Respond to AJs comments 2021-05-27 09:14:32 -04:00
Dan Lambright 64c10d3625 fix joshua failures, formatting 2021-05-27 08:08:07 -04:00
Dan Lambright fcfb78162c misc cleanup for publishing 2021-05-27 08:08:07 -04:00
Dan Lambright 742c22cef2 Don't allow changing desriptor if knob is set 2021-05-27 08:08:07 -04:00
A.J. Beamon 944a03d575 For files that use the atomic write and create mechanism, attempt to remove the file from the openFiles map at both its old and new name 2021-05-26 16:26:45 -07:00
A.J. Beamon a756469670 Use a weak reference in the open files cache (abstracted from a similar cache in AsyncFileCached) to avoid a problem where removing an item from the cache could cause us to reentrantly remove it again. 2021-05-26 13:38:24 -07:00
Markus Pilman cbce2f6f11 delete dead code 2021-05-26 11:12:07 -07:00
Markus Pilman 7b4de4e037 Revert change 2021-05-26 11:11:51 -07:00
Markus Pilman 7cb767fd3c only remove files from the open map if they have no modifications in flight 2021-05-26 11:11:44 -07:00
Markus Pilman 04613c3b13 handle file renames properly 2021-05-26 11:11:37 -07:00
Markus Pilman f32ce0c4b5 fix typo 2021-05-26 11:11:24 -07:00
Markus Pilman 6bd7fa4036 Actually close files in simulation 2021-05-26 11:11:12 -07:00
Josh Slocum 4257ac2b4d More TSS Changes/Fixes 2021-05-25 20:37:48 +00:00
Josh Slocum ce82c9653e Testing Storage Server implementation 2021-05-25 20:28:50 +00:00
Steve Atherton 390b026f08
Merge branch 'master' into arena-page 2021-05-16 05:06:50 -07:00
Steve Atherton 2298567c2b Use of aligned_alloc() for 4k pages causes too much wasted virtual memory. Added new 4k-aligned fast allocator, and changed Arena::allocatedAlignedBuffer() to be 4k-specific, now called Arena::allocate4kAlignedBuffer(). 2021-05-14 23:12:00 -07:00
Lukas Joswiak 4ea760b2a9 Revert "Merge pull request #4136 from sfc-gh-mpilman/features/actor-lineage"
This reverts commit da41534618, reversing
changes made to e6300905d6.
2021-05-10 20:26:12 -07:00
sfc-gh-tclinkenbeard f28ac955c3 Remove unnecessary temporary objects while growing objects of type std::vector<std::pair<A, B>> 2021-05-10 16:32:50 -07:00
Steve Atherton f8a8bf315b Added Arena::allocateAlignedBuffer() to get an aligned memory block owned by an Arena, and ArenaPage uses this. 2021-05-05 15:00:12 -07:00
Andrew Noyes 6bffbdf7e3
Revert "Actually close files in simulation" 2021-05-04 15:38:24 -07:00
Jingyu Zhou 1c92588cca
Merge pull request #4562 from sfc-gh-mpilman/bugfixes/simulator-close-files
Actually close files in simulation
2021-05-03 13:47:44 -07:00
Jingyu Zhou d49e0091ce
Merge pull request #4727 from sfc-gh-etschannen/fix-rewrite-bme
Simulation could still stall writes for 10 seconds even when speedUpSimulation was on
2021-05-03 13:37:04 -07:00
Lukas Joswiak 8dcd779fc4
Merge branch 'master' into features/actor-lineage 2021-05-02 14:11:42 -07:00
Lukas Joswiak cf4218dfd1 Fixes simulation failures
Fixes the following issues:

1. Use the right index when initializing the WriteOnlySet's vector of
   atomics. Also switch to std::atomic_init to initialize each atomic in
   the vector (cannot default construct the atomics in the vector
   because std::atomic does not have a copy constructor).
2. Add failure check for when items cannot be inserted into the
   WriteOnlySet due to capacity constraints. This situation occurs when
   `copy` is not called on the WriteOnlySet, such as when sampling is
   disabled. The `copy` function is what clears the WriteOnlySet.
3. Remove a global config feature I added to update the ClientDBInfo
   object used by the global config listener function. This needs more
   investigation, but the effect of this change could be that global
   config changes are not correctly recognized on fdbserver processes.
4. Add various ASSERTs to verify data in WriteOnlySet.
2021-05-01 15:26:28 -07:00
Andrew Noyes 904a39e473
Merge pull request #4667 from sfc-gh-ajbeamon/feature-mvc-monitor-protocol-version
Use fewer connections in the multi-version client
2021-04-28 14:13:17 -07:00
Evan Tschannen 65fcf4014e Fix: simulation could still stall writes for 10 seconds even when speedUpSimulation was on
Fix: disable connection failures in simulation when there are too many generations outstanding
2021-04-28 12:41:48 -07:00
A.J. Beamon 7158bfa82e Merge branch 'master' into load-balance-remove-make-request-actor 2021-04-28 10:31:41 -07:00
A.J. Beamon 135cc9c69a Make parameter const& 2021-04-28 10:30:30 -07:00
Markus Pilman 4fab2ecd30 Merge remote-tracking branch 'origin/master' into features/actor-lineage 2021-04-28 09:20:54 -06:00
A.J. Beamon 9009780aa8 Fix bug that could cause the server to crash when an old client connected 2021-04-27 11:15:16 -07:00
Evan Tschannen a02da36e85 fixed the problem with the GrvProxyClass the proper way my keeping the enum the same between versions 2021-04-26 18:45:44 -07:00
Evan Tschannen 451609e6be code cleanup 2021-04-26 10:16:18 -07:00