d78b29625c
Make fdbcli gracefully handle malformed and partial command errors.
...
Previously, running a command like `set \xffx\02abcded/` would cause a crash.
The `x\02` is a malformed typo of `\x02`, and the previously existing code to
handle this case looks like
loop {
err = parse_command
if (err) continue;
// do things
}
Thus, if we hit an error, we'd go back to the top of the loop, and try again.
This should be an infinite loop. However, the actor compiler implementation of
loops involves function calls, so this actually turns into a series of the loop
head calling the loop body calling the loop head calling ... and we eventually
crash due to running out of stack.
This is now fixed by simply letting the code continue on to the check later
that does
if (there was an error) {
print nasty message
return error
}
With output that looks like
ERROR: malformed escape sequence
WARNING: the previous command failed, the remaining commands will not be executed.
And therefore the world becomes a happy place.
2017-08-15 17:49:39 -07:00
5ee07b1a9e
Merge branch 'release-5.0'
2017-08-14 16:56:58 -07:00
448fccbdaf
Merge pull request #140 from cie/remove-wd40-refs
...
Remove wd40 refs
2017-08-14 10:22:52 -07:00
62990fd8a4
Merge pull request #139 from cie/exclusion-free-space-calc
...
change exclusions so that they calculate free space based on storage …
2017-08-14 10:18:24 -07:00
de1b590a8a
The TLog did not delete data from removed logs
...
The TLog continued to make data from removed logs persistent
2017-08-11 18:08:09 -07:00
f6d282e66a
change exclusions so that they calculate free space based on storage servers only
2017-08-11 17:20:28 -07:00
50fb44be92
Merge branch 'release-5.0'
...
# Conflicts:
# versions.target
2017-08-09 23:36:12 -07:00
8cd43692bf
Update versions.target for next release.
2017-08-09 23:34:14 -07:00
4b8e2adb8e
Updated WIX Installer GUID.
2017-08-09 23:24:05 -07:00
95cd5dc3a2
Updated installer package GUID, updated docs for 5.0.3.
2017-08-09 22:29:02 -07:00
2335fc73f2
fix: peek cursors were being timed out every 10 minutes, instead of 10 minutes after the last use
...
fix: if an interface is changed while we are not waiting in getMore, we will not reset the sequence to 0.
2017-08-09 15:58:06 -07:00
f8be643662
Merge branch 'release-5.0'
2017-08-09 15:30:43 -07:00
29a38d1a51
Add warning that the slow task profiling network option is not recommended for use in production.
2017-08-09 14:39:05 -07:00
2c3920c7b3
Merge branch 'release-5.0' of github.com:apple/foundationdb into release-5.0
2017-08-09 14:36:34 -07:00
853a98053c
Move some memory related activities outside of the timed block
2017-08-09 14:36:19 -07:00
677cf10168
Merge branch 'release-5.0'
2017-08-09 12:00:52 -07:00
d608152069
fdbversion -> 5.0.3 after downgrade to 5.0.2 for docs publish
2017-08-09 11:59:20 -07:00
a576b9c8a8
Merge branch 'release-5.0' of github.com:apple/foundationdb into release-5.0
2017-08-09 11:40:45 -07:00
9df8c266e9
fix docs links for 5.0.2
2017-08-09 11:40:42 -07:00
cf1d65f5fd
Merge branch 'release-5.0'
2017-08-09 10:52:10 -07:00
9ce8d3ae4f
Merge branch 'release-5.0'
2017-08-09 10:37:43 -07:00
aac82074af
Avoid calling setCachedLocation twice
2017-08-08 10:03:04 -07:00
5a8cd34224
Disable profiling if we aren't using the cached dl_iterate_phdr values.
2017-08-08 09:03:04 -07:00
c7402eb10c
fix: call initSignalSafeUnwind in fdbcli and backup to avoid hangs in slow task profiling.
2017-08-07 15:55:08 -07:00
47a37f3f1e
Merge pull request #135 from cie/switch-for-data-distribution
...
Add a switch to turn off data distribution in CLI
2017-08-07 12:54:08 -07:00
0e38063038
Added min version compilation option for OS X
2017-08-07 11:56:12 -07:00
baa9998e4d
Merge branch 'release-5.0'
2017-08-07 10:44:04 -07:00
47b4a81710
Merge pull request #136 from cie/circus-c-perf-tests
...
<rdar://problem/33247796> 🎪 C perf test in circus
2017-08-07 10:00:34 -07:00
2499aac09d
for once, a whitespace change
2017-08-07 09:51:53 -07:00
03915ce4ea
Merge branch 'release-5.0'
2017-08-03 15:49:54 -07:00
f66e22c89d
fix: machine metrics could sometimes default to 0, which cause underflows when compared with prior results.
2017-08-03 15:49:30 -07:00
ca7437ecf6
Merge branch 'release-5.0'
2017-08-02 22:07:01 -07:00
b8b61a66b3
maybeLogError uses logError ; FDB_API_VERSION defined in test.h
2017-08-02 21:58:51 -07:00
604be02f62
spaces to tabs 😢
2017-08-02 21:55:36 -07:00
646bb0725d
Merge pull request #134 from cie/alexmiller/sidechanges
...
Assorted mostly docker/gdb related changes for dev workflow
2017-08-02 14:19:36 -07:00
15961e8326
Merge branch 'circus-bundle-specific-config' into release-5.0
2017-07-31 18:08:17 -07:00
d34e301dc6
added c performance test ; make packages now includes archive of them
2017-07-31 18:08:13 -07:00
d0fbc41338
set LOCK_AWARE on several transactions used for getting cluster info for the consistency check
2017-07-28 18:50:32 -07:00
6a8a5c41b0
Add a switch to turn off data distribution in CLI
2017-07-28 18:14:55 -07:00
4243486f54
fix: TLogMetrics was being track latested with the wrong ID
2017-07-28 14:37:23 -07:00
9fb709cf73
Merge branch 'release-5.0'
...
# Conflicts:
# versions.target
2017-07-27 16:51:57 -07:00
7061d34e94
updated version.target for next release
2017-07-27 16:50:27 -07:00
6bc87b5837
updated wix guid
2017-07-27 16:39:46 -07:00
7e69a09e0e
updated release notes, updated WIX guid
2017-07-27 14:40:49 -07:00
19fa31ffff
fix: uncancellable was not forwarding errors to the result promise
2017-07-27 13:29:08 -07:00
37e5e2acbb
Fix parentheses issue in StorageMetrics.actor.h
2017-07-27 12:03:36 -07:00
cdc62e265c
Merge pull request #133 from cie/shard-system-keyspace
...
Shard system keyspace
2017-07-26 17:09:13 -07:00
41c90bcdea
Merge commit '89ac94853c70d08289e7fb58055bc5d0cd4e494d'
2017-07-26 15:35:36 -07:00
8c5268f2f8
Merge pull request #132 from cie/use-incremental-delete
...
Enable use of incremental delete when deleting disk queue and KVS sqlite files.
2017-07-26 15:35:02 -07:00
311d0e3815
Remove outdated comment from incrementalDelete function.
2017-07-26 15:27:37 -07:00
Alex Miller