Commit Graph

12250 Commits

Author SHA1 Message Date
A.J. Beamon 0e03fbe7b3
Merge pull request #3659 from AlvinMooreSr/dev_docker_update
Updated Development Docker
2020-08-19 10:41:58 -07:00
Meng Xu d9ea14ea6c FastRestore:fix:loader can receive reply from vb that has been processed and deleted 2020-08-19 10:39:49 -07:00
XiaoxiWang aa253742ec add getRecommendedTags to ThrottleApi 2020-08-19 17:39:43 +00:00
Jingyu Zhou 4867bad46e
Merge pull request #3661 from sfc-gh-kmakino/kaomakino/remove_unnecessary_test_harness_tweaks
Remove unnecessary special case handling from JsonParser
2020-08-19 09:54:20 -07:00
XiaoxiWang 8a1b9394b8 do not send auto-throttled tags to proxy is autoThrottleEnabled == false 2020-08-19 16:23:11 +00:00
Meng Xu 22a2fac689 FastRestore:Fix segmentation fault when previous duplicate request is sent too late
This seg fault was not caught by simulation test;
It is only reproduced very easily in circus test.

Add an ASSERT to check if the scenario happens in simulation
2020-08-19 09:15:18 -07:00
Meng Xu 7bfb0a4cc5
Merge pull request #3662 from sfc-gh-tclinkenbeard/modernize-copy-disable
Use =delete to disable special member functions
2020-08-19 00:13:12 -07:00
Meng Xu 88b94a3e59 FastRestore:Fix:Delayed request can be skipped from processing
When a request of sending mutations to appliers is delayed and the request for future version batches have been processed,
loader will increase its counter. The previous implementation will use the counter to decide if a request is too old and
have been processed. If the counter is larger than the batch index of the request, the request will be ignored although
it may not have been processed.

This causes correctness test failure for fast restore.
2020-08-18 23:48:06 -07:00
Xiaoxi Wang 599675cba8 modify some details to get better performance 2020-08-19 04:23:23 +00:00
Steve Atherton 9c0c2db4b2
Merge pull request #3658 from sfc-gh-tclinkenbeard/construct-flowlock-releaser
Construct FlowLock::Releaser before AsyncFileBlobStore upload
2020-08-18 18:00:42 -07:00
Steve Atherton d53e6cf687 Bug fix in KV byte counts. 2020-08-18 17:58:57 -07:00
Meng Xu 33f5ce98c7 Merge branch 'release-6.3' into mengxu/fr-sched-PR 2020-08-18 17:41:31 -07:00
Meng Xu e1d150662f FastRestore:small fix on compile error 2020-08-18 16:15:11 -07:00
Meng Xu 6729b4143b FastRestore:Requests:Add const for toString function 2020-08-18 16:05:23 -07:00
Meng Xu a32cf7d293 FastRestore:Loader:Add sanity check before remove batch data 2020-08-18 15:44:22 -07:00
Meng Xu 9b2f667bbe FastRestore:Fix uninitialized variable 2020-08-18 11:58:57 -07:00
sfc-gh-tclinkenbeard 7b210aee24 Use =delete to disable special member functions
This has the benefits of:
- Easier to understand compiler error messages
- Moves some errors from link-time to compile-time
- NonCopyable classes can still specify default move constructors
2020-08-18 11:07:00 -07:00
Kao Makino 2f76dd0b76 Remove unnecessary special case handling from JsonParser 2020-08-18 10:46:06 -07:00
Xiaoxi Wang 69914d4909 defer write throttling until found proper statistics for write saturation 2020-08-18 15:46:02 +00:00
Evan Tschannen 8ede143941 Track tlog push latencies and reset connections if they are above 500ms 2020-08-18 08:43:14 -07:00
Alvin Moore aa8bac49b2 Added cgdb package 2020-08-18 08:43:45 -04:00
sfc-gh-tclinkenbeard b8c06b3d15 Ensure FlowLock::Releaser is always constructed before AsyncFileBlobStore upload 2020-08-17 23:19:51 -07:00
Evan Tschannen 9e2ee1ed4c fixed lastedZeroBusy; added a knob 2020-08-17 23:16:59 -07:00
Meng Xu 046260b9d7 FastRestore:Applier:Assert to ensure batchData will not be used after deleted 2020-08-17 22:42:41 -07:00
Meng Xu 4a0315483b FastRestore:Safeguard when request of earlier vb may be sent after the vb has finished 2020-08-17 22:20:54 -07:00
Meng Xu 7b7490efe7 FastRestore:Debug trace for seg fault 2020-08-17 20:34:33 -07:00
Jingyu Zhou 8f9ae86212
Merge pull request #3655 from dongxinEric/bugfix/fix-potential-invalid-memory-access-bug
Fix potential invalid memory access bug.
2020-08-17 15:56:24 -07:00
Xiaoxi Wang 24dbb3961c Knob adjustment 2020-08-17 22:38:22 +00:00
Xin Dong 130bd7ac22 Fixed a bug that would potentially cause invalid memory access, i.e. segmentation fault. 2020-08-17 13:16:17 -07:00
Jingyu Zhou 7752fd700c
Merge pull request #3651 from jzhou77/release-6.3
Backport restarting test fix to 6.3
2020-08-16 22:04:23 -07:00
Meng Xu 01255b7ead FastRestoreLoader:Sched:Add trace field and misc code style improvement 2020-08-16 09:43:04 -07:00
Jingyu Zhou 2295bb223a Bump to 5.0.0 as 4.6.4 is using version larger than hasMultiGenerationTLog() 2020-08-16 09:29:14 -07:00
Jingyu Zhou 1a59926d75 Limit Storefront and Cycle restart tests to 4.6.0 and up
The assertion in DBCoreState.h insists on hasMultiGenerationTLog(), which is
only available on 4.6.0 and up versions.
2020-08-16 09:29:06 -07:00
Meng Xu be75fd4894 Workaround flow limitation:state variable must be initialized at the beginning of actors 2020-08-16 08:45:13 -07:00
Meng Xu c2dfc5a00a Fix compile error 2020-08-16 08:13:28 -07:00
Meng Xu cb0e44ff42 FastRestoreLoader:Sched send mutations per loadingParam requests 2020-08-16 07:38:51 -07:00
Meng Xu 98167a6d20 FastRestoreLoader:Fix:sched may stuck due to race condition 2020-08-16 06:29:09 -07:00
Meng Xu 015397be74 FastRestore:LoaderScheduler:Control number of load request to release at once 2020-08-15 22:18:48 -07:00
Meng Xu 1e571a5a1a FastRestore:Loader:Kick off scheduler when loader starts to have new requests 2020-08-15 21:57:00 -07:00
Meng Xu a035e7a872 FastRestore:LoaderScheduler:Add knobs 2020-08-15 21:44:51 -07:00
Meng Xu 7e302b5910 FastRestore:Loader:Add scheduler to dispatch requests based on resource utilization and request priority 2020-08-15 21:21:51 -07:00
Steve Atherton 090241f0df Count BTreeCursor page reads that come from the cursor's cache of pages as cache hits in RedwoodMetrics. BTree Unit Test now verifies all data at the initial version after recovery from disk. 2020-08-15 14:30:49 -07:00
Steve Atherton 84a4d040c1 Merge branch 'release-6.3' of github.com:apple/foundationdb into feature-redwood 2020-08-15 14:09:03 -07:00
Markus Pilman dee8df9b48
Merge pull request #3646 from sfc-gh-xwang/valgrind-option
turn off avx instruction when enable valgrind
2020-08-15 08:53:53 -06:00
Steve Atherton 421f44f4cc
Merge pull request #3640 from sfc-gh-tclinkenbeard/fix-asyncfileblobstore-lock
Fix potential memory leak in AsyncFileBlobStore
2020-08-14 18:09:34 -07:00
Xiaoxi Wang ffa1973242 move OPERATION_COST_BYTE_FACTOR to CLIENT_KNOB; skip the first call of refreshBusiestTag. 2020-08-14 22:49:20 +00:00
Russell Sears 89d1df4a5c
Merge pull request #3645 from Daniel-B-Smith/rocks-opt-checkpoint
Add some RocksDB optimizations and configuration knobs
2020-08-14 14:25:52 -07:00
XiaoxiWang 1c96a37a77 turn off avx instruction when enable valgrind 2020-08-14 21:14:48 +00:00
Xiaoxi Wang 548ba06510 change map to deque; code style problem 2020-08-14 18:30:58 +00:00
Daniel Smith 94571786bf Add RocksDB work 2020-08-14 17:16:20 +00:00