Commit Graph

7526 Commits

Author SHA1 Message Date
Meng Xu e676348710
Merge pull request #1955 from fzhjon/mark-ss-failed
Add fdbcli and API command to mark storage servers as permanently failed
2019-10-22 23:36:30 -07:00
Meng Xu 96d463bab6 FastRestore:Fix bug in applying mutations and increase atomicOp test worload
When Applier applies mutations to the destination cluster, it advances the
mutation cursor twice when it should only advance it once.
This makes restore miss some mutations when the applying txn includes
more than 1 mutations.
2019-10-22 23:24:23 -07:00
Alex Miller 1e5b8c74e3 Continuing a parallel peek after a timeout would hang.
This is to guard against the case where

1. Peeks with sequence numbers 0-39 are submitted
2. A 15min pause happens, in which timeout removes the peek tracker data
3. Peeks with sequence numbers 40-59 are submitted, with the same peekId

The second round of peeks wouldn't have the data left that it's allowed
to start running peek 40 immediately, and thus would hang for 10min
until it gets cleaned up.

Also, guard against overflowing the sequence number.
2019-10-22 19:24:05 -07:00
Evan Tschannen f65f0cd37a
Merge pull request #2274 from etschannen/feature-cleanup-destuidlookup
Automatically cleanup backup and DR sharing metadata
2019-10-22 19:11:23 -07:00
Alex Miller c008e7f8b3 When switching parallel->single->parallel, reset sequence and peekId
This fixes an issue where one could hang for 10min for the second
parallel peek to time out, if one happened to catch the edge of a
onlySpilled transition wrong.
2019-10-22 19:10:58 -07:00
Evan Tschannen 3bebcca846
Merge pull request #2266 from mpilman/bugfixes/catalina
Fix compiler errors on Catalina
2019-10-22 19:09:49 -07:00
Evan Tschannen 15f82a2295
Merge pull request #2270 from etschannen/feature-limit-updates
Limit the number of simultaneous committed version updates
2019-10-22 19:09:28 -07:00
Stephen Atherton 6a57fab431 Bug fixes in lazy subtree deletion, queue pushFront(), queue flush(), and advancing the oldest pager version. CommitSubtree no longer forces page rewrites due to boundary changes. IPager2 and IVersionedStore now have explicit async init() functions to avoid returning futures from some frequently used functions. 2019-10-22 17:17:29 -07:00
Evan Tschannen 35ac0071a8 fixed a compiler error 2019-10-22 17:06:54 -07:00
Evan Tschannen 2d74288d16 Added a comment to clarify why cleanup work is done in status 2019-10-22 16:33:44 -07:00
Xin Dong af72d15566
Update fdbserver/Knobs.cpp
From AJ: to match typical aligned format used on other variables.

Co-Authored-By: A.J. Beamon <ajbeamon@users.noreply.github.com>
2019-10-22 13:53:28 -07:00
Xin Dong e6f5748791 Use a large value for read sampling size threshold. Also at sampling site, don't round up small values to avoid sampling every key. 2019-10-22 13:47:58 -07:00
Evan Tschannen 3478652d06
Apply suggestions from code review
Co-Authored-By: A.J. Beamon <ajbeamon@users.noreply.github.com>
2019-10-22 13:32:09 -07:00
Evan Tschannen d5c2147c0c
Update fdbserver/Status.actor.cpp
Co-Authored-By: A.J. Beamon <ajbeamon@users.noreply.github.com>
2019-10-22 13:27:52 -07:00
Evan Tschannen 2caad04d9c Keys in the destUIDLookupPrefix can be cleaned up automatically if they do not have an associated entry in the logRangesRange keyspace 2019-10-22 11:58:40 -07:00
Jon Fu e39d0dde9b Merge branch 'master' of https://github.com/apple/foundationdb into modify-attrition 2019-10-22 11:51:08 -07:00
Xin Dong 6f18976dcc
Merge pull request #2272 from ajbeamon/fix-bandwidth-typo
Fix "bandwith" typo
2019-10-22 10:41:36 -07:00
A.J. Beamon 29a0014b41 Fix "bandwith" typo 2019-10-22 09:51:59 -07:00
Alex Miller b83a080601
Merge pull request #2269 from xumengpanda/mengxu/fastrestore-multifiles-has-sameversion-mutations-PR-testPR
Performant restore [6/XX]: Add simple restore test case that has atomic operations
2019-10-21 16:35:43 -07:00
Evan Tschannen 12c517ab16 limit the number of committed version updates in progress simultaneously to prevent running out of memory 2019-10-21 16:01:45 -07:00
Meng Xu 01b4fb5e5e CMake:Add performant restore test to CMake 2019-10-21 14:52:03 -07:00
Meng Xu 970327b554 FastRestore:Add ParallelRestoreCorrectnessAtomicOpTinyData.txt 2019-10-21 14:42:11 -07:00
Meng Xu 2dbbce55a8 FastRestore:Applier:Mute debug trace 2019-10-21 14:36:07 -07:00
Meng Xu 4af69fd94f Merge branch 'master' into mengxu/fastrestore-multifiles-has-sameversion-mutations-PR-testPR 2019-10-21 14:35:04 -07:00
Xin Dong fca9aab17a
Merge pull request #2046 from dongxinEric/feature/hot-read-key-detection
Added metrics for read hot key detection
2019-10-21 14:31:48 -07:00
Meng Xu f08ad48b7b FastRestore:Applier:handleSendMutationVectorRequest:Add comment 2019-10-21 14:31:21 -07:00
Meng Xu 4efddc9b89 FastRestore:Applier:Reduce LoC
When a key does not exist in a map, it is created by default when it is accessed by []
2019-10-21 14:31:21 -07:00
Meng Xu 6f1ecd1b11 FastRestore:handleSendMutationVectorRequest:Receive mutations in order of versions 2019-10-21 14:31:21 -07:00
Jon Fu d2b6626d5c Merge branch 'master' of https://github.com/apple/foundationdb into mark-ss-failed 2019-10-21 13:47:06 -07:00
Evan Tschannen 621e07efee
Merge pull request #2268 from etschannen/master
Merge 6.2 into master
2019-10-21 12:39:53 -07:00
Evan Tschannen 688940b685 merge 6.2 into master 2019-10-21 11:43:46 -07:00
A.J. Beamon c25f6b8ae3
Merge pull request #2267 from mpilman/bugfixes/fix-version
fixed cmake version
2019-10-21 11:42:01 -07:00
mpilman 2d0722b0c7 fixed cmake version 2019-10-21 11:22:05 -07:00
mpilman a79757a788 Fix compiler errors on Catalina
Fixes #2263
2019-10-21 11:15:37 -07:00
Evan Tschannen 8709d78555
Merge pull request #2264 from etschannen/post-release-cleanup-6.2.6
Post release cleanup 6.2.6
2019-10-21 10:32:02 -07:00
Evan Tschannen 200608f7d9 update installer WIX GUID following release 2019-10-21 10:31:17 -07:00
Evan Tschannen 809e451cff update versions target to 6.2.7 2019-10-21 10:31:17 -07:00
A.J. Beamon 49cedd5080
Merge pull request #2262 from tclinken/remove-dead-code
Removed dead code
2019-10-21 10:21:15 -07:00
Xin Dong 9a81948843
Accept review suggestions.
Co-Authored-By: A.J. Beamon <ajbeamon@users.noreply.github.com>
2019-10-21 10:08:43 -07:00
A.J. Beamon 27b6875fd9
Merge pull request #2246 from davisp/clarify-kill-on-configuration-change-docs
Clarify docs on `kill_on_configuration_change`
2019-10-21 09:56:43 -07:00
Meng Xu e9a48cb63b FastRestore:Fix bug in handleInitVersionBatchRequest
We should unconditionally resetPerVersionBatch()
2019-10-19 17:40:50 -07:00
Meng Xu ab946eb24f FastRestore:Applier:Turn on debug 2019-10-19 17:07:31 -07:00
tclinken bb0ae31002 Removed dead code. 2019-10-18 17:06:48 -07:00
Meng Xu 6d0c9e9198 FastRestore:AtomicOpTestCase:Add the test case
Also add trace events for AtomicOps.actor.cpp
2019-10-18 16:58:45 -07:00
Xin Dong 6a40ef25e5 Credit to Evan for pointing out the missing line which costs me weeks debugging some weird behaviors. 2019-10-18 16:46:19 -07:00
Jon Fu 4d8cfc00f6 added comment explaining quorum 2019-10-18 15:00:00 -07:00
Jon Fu f38d52b82d re-introduced coordinator quorum and added some comments 2019-10-18 14:52:07 -07:00
Evan Tschannen bb23ce18aa
Merge pull request #2261 from etschannen/prepare-release-6.2.6
update installer WIX GUID following release
2019-10-18 13:38:33 -07:00
Evan Tschannen be531bdab5 update installer WIX GUID following release 2019-10-18 13:37:37 -07:00
Meng Xu a70771e3a0 Merge branch 'master' into mengxu/fastrestore-multifiles-has-sameversion-mutations-PR-applierPR 2019-10-18 12:31:46 -07:00