Commit Graph

2260 Commits

Author SHA1 Message Date
sfc-gh-tclinkenbeard 475abe301c Merge remote-tracking branch 'origin/master' into fix-ub 2021-07-14 10:47:02 -07:00
Markus Pilman ba5c2b647c
Merge pull request #5158 from sfc-gh-tclinkenbeard/use-variant-for-erroror
Use std::variant for ErrorOr implementation
2021-07-12 15:35:19 -06:00
Steve Atherton 9fd5f54992
Merge pull request #5142 from Daniel-B-Smith/threads-in-simulation
Enable IThreadPool in simulation
2021-07-12 14:24:34 -07:00
Jingyu Zhou 741c46f344
Merge pull request #5145 from nblintao/fix-printable
Fix printable bytes that may be escaped incorrectly
2021-07-12 13:51:37 -07:00
Josh Slocum 02f243c821
Merge pull request #5110 from sfc-gh-jslocum/tss_streaming_master
Added Streaming Read comparison for TSS
2021-07-12 10:44:15 -07:00
Tao Lin e422d42fb2 Remove ASSERT_WE_THINK because of dependency 2021-07-12 10:20:27 -07:00
Tao Lin 5f7add5b8b Change ASSERT to ASSERT_WE_THINK 2021-07-12 10:08:28 -07:00
sfc-gh-tclinkenbeard 2276397159 Add perfect forwarding to Optional::map and Optional::orDefault 2021-07-12 02:33:51 -07:00
sfc-gh-tclinkenbeard 90c6d76349 Add rvalue reference overload for ErrorOr::map 2021-07-12 02:22:03 -07:00
sfc-gh-tclinkenbeard c31fa43b9d Use std::variant for ErrorOr implementation 2021-07-12 02:17:57 -07:00
Tao Lin 79ae18f97a Fix printable bytes that may be escaped incorrectly 2021-07-09 14:37:51 -07:00
sfc-gh-tclinkenbeard 382533c4e1 Add FDB_ prefix to BOOLEAN_PARAM macros 2021-07-09 05:42:14 -07:00
sfc-gh-tclinkenbeard bbce95da5f Undo changes unrelated to BOOLEAN_PARAM macro 2021-07-09 05:24:42 -07:00
Daniel Smith acfd0b6c1c Don't check the random number generator state at the end 2021-07-08 19:19:02 -04:00
Daniel Smith 3fbd6b6143 Enable IThreadPool in simulation 2021-07-08 18:51:01 -04:00
sfc-gh-tclinkenbeard 020371a78f Merge remote-tracking branch 'origin/master' into add-boolean-param 2021-07-07 16:50:51 -07:00
Trevor Clinkenbeard f5ade03538
Merge pull request #4233 from sfc-gh-tclinkenbeard/encrypt-backup-files
Added AsyncFileEncrypted
2021-07-07 13:28:28 -07:00
sfc-gh-tclinkenbeard 4ed23b8ee6 Addressed review comments 2021-07-06 21:20:59 -07:00
sfc-gh-tclinkenbeard 5144d153e9 Fix "backslash-newline at end of file" warning 2021-07-04 16:42:03 -07:00
sfc-gh-tclinkenbeard a646b3cf42 Added set method to boolean parameters 2021-07-04 12:32:45 -07:00
sfc-gh-tclinkenbeard 8cc40e3a2b Expand use of BOOLEAN_PARAM 2021-07-02 21:41:50 -07:00
sfc-gh-tclinkenbeard 79ff07a071 Added *BOOLEAN_PARAM macros to enforce documentation of boolean parameters 2021-07-02 15:04:42 -07:00
Josh Slocum 9f1afbb709 Added Streaming Read comparison for TSS 2021-07-01 19:00:05 -05:00
Russell Sears 6c84594e2f
Merge pull request #5099 from sears/log_thread_id
Add a ThreadID field to each TraceEvent.
2021-07-01 14:14:12 -07:00
Russell Sears 18cde28d6e Add a ThreadID field to each TraceEvent. This is needed for multithreaded client debugging, and should also be helpful for multithreaded storage engines, SSL handshake threadpools, and so on 2021-06-30 14:31:53 -07:00
Daniel Smith 0df49e1bee
Run IThreadPool naming test outside simulation 2021-06-30 15:06:58 -04:00
Daniel Smith 1b62fc76e7
Merge pull request #5092 from Daniel-B-Smith/thread-naming-fix
Fix IThreadPool thread naming
2021-06-29 17:30:33 -04:00
Daniel Smith 299eaef858
Update flow/IThreadPoolTest.actor.cpp
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-06-29 16:39:50 -04:00
Daniel Smith ac01e5bcfd
Update flow/IThreadPoolTest.actor.cpp
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-06-29 16:37:06 -04:00
Daniel Smith f58c7fd8bc Fix IThreadPool thread naming 2021-06-29 16:27:37 -04:00
A.J. Beamon 00050098ff
Merge pull request #5075 from sfc-gh-tclinkenbeard/set-crash-error-kind
Set error kind to BugDetected for Crash trace events
2021-06-29 14:02:52 -04:00
sfc-gh-tclinkenbeard a73570e538 Added comment for crashHandler 2021-06-29 11:00:05 -07:00
A.J. Beamon 63b286706a
Merge pull request #5069 from Daniel-B-Smith/thread-helper-doc
Add some documentation for the onMainThread functions
2021-06-29 13:32:47 -04:00
Daniel Smith 23fc685518
Update flow/ThreadHelper.actor.h
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-06-29 13:31:36 -04:00
Daniel Smith 119a52c2e9
Update flow/ThreadHelper.actor.h
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-06-29 13:31:23 -04:00
Daniel Smith 1c2d4119c2
Update flow/ThreadHelper.actor.h
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-06-29 13:31:15 -04:00
Josh Slocum ab0ab765c8
Merge pull request #4965 from sfc-gh-jslocum/tss_mapping_changes
TSS Mismatch Changes
2021-06-29 08:24:25 -07:00
sfc-gh-tclinkenbeard a33a0a7fff Add include to DeterministicRandom.cpp 2021-06-28 14:50:35 -07:00
sfc-gh-tclinkenbeard 8855c7ee8d Set error kind to BugDetected for Crash trace events 2021-06-27 16:47:54 -07:00
sfc-gh-tclinkenbeard cbdf5bf6b7 Fix failing BackupCorrectness test with encryption 2021-06-26 17:38:57 -07:00
sfc-gh-tclinkenbeard 27e44c1bb9 Add support for encryption testing in BackupCorrectness workload 2021-06-26 11:15:12 -07:00
sfc-gh-tclinkenbeard c5b612510d Added invalid_encryption_key_file error 2021-06-26 11:14:23 -07:00
sfc-gh-tclinkenbeard 53f5cd2453 Support passing encryption file to BackupContainer::openContainer 2021-06-25 14:11:21 -07:00
sfc-gh-tclinkenbeard 81b8292094 Merge remote-tracking branch 'origin' into encrypt-backup-files 2021-06-25 12:21:12 -07:00
sfc-gh-tclinkenbeard 9862fec764 Merge remote-tracking branch 'origin' into remove-boost-dependencies 2021-06-25 11:53:29 -07:00
Daniel Smith 1e0c233d40 Add some documentation for the onMainThread functions 2021-06-24 17:44:54 -04:00
Xiaoge Su 048eee55a5
Merge pull request #5061 from xis19/master
Add static_assert to serializeBinaryItem
2021-06-23 22:13:18 -07:00
Xiaoge Su 5089459bd2 Add static_assert to *Writer::serializeBinaryItem
BinaryWriter::serializeBinaryItem will accept *any* objects and
serialize them by memory copy. If the object is a struct, padding bytes
will also be copied, which is not expected (at this stage, the
serializer will NOT include any padding). If padding exists, the caller
is required to use _Reader::serializeBinaryItem when reading.

Due to this inconsistency, it is helpful to restrict
serializedBinaryItem calls to limited types. Base on the current
implementation, one reasonable approach is allowing only those types
are BINARY_SERIALIZABLE. This patch addresses such restriction.

The restriction is also applied to other classes:

 * OverWriter
 * _Reader
 * PacketWriter
2021-06-23 18:45:51 -07:00
Andrew Noyes af0f286e17 Fix a few instances of UB
Member access to address which does not point to correct type
2021-06-22 21:44:59 -07:00
Evan Tschannen fcb8bd6475
Revert "Make the sim2 run loop match the behavior of the net2 run loop." 2021-06-22 14:50:01 -07:00