Commit Graph

2722 Commits

Author SHA1 Message Date
sfc-gh-tclinkenbeard ec64890ac1 Remove some usages of PRId64 by using fmt library 2021-11-30 23:35:36 -08:00
A.J. Beamon c47535245b
Merge pull request #6033 from sfc-gh-ajbeamon/improved-client-db-logging
Client logging improvements
2021-11-29 13:23:10 -08:00
Trevor Clinkenbeard 6429b82796
Merge pull request #6053 from RenxuanW/fromHostname
Change member variable fromHostname to type bool.
2021-11-29 13:13:21 -08:00
A.J. Beamon b8bd89f88d Shorten the name of external client threads. Add a thread name for trace logging threads. 2021-11-29 09:57:10 -08:00
A.J. Beamon 264c75b9a6 Add some extra client logging details:
1. Add a trace event when a database is created and move the cluster file / connection string from ClientStart to the new trace event
2. Add a detail for the path to the image being loaded
3. Add a detail for whether a client library is primary or not
4. Set a thread name for each external client thread that includes the release version
2021-11-29 09:57:10 -08:00
Renxuan Wang 09fedc429a Remove unnecessary boost/bind.hpp.
Complement of #6026.
2021-11-24 16:33:05 -08:00
Ata E Husain Bohra 0962fcb243 Override commit/grv proxies_count if mutation supplied new value is -1
Patch improves on handling scenarios where either commit or grv proxies
value is update to -1 OR `proxies_count` is being reset.
The code splits the proxies between two proxies by ensuring for invalid
input configuration, the min (read as 1) proxies gets provisioned, otherwise,
the split is done based on input values

Patch handles the scenario where mutation supplied values to update grv_proxies
and/or commit_proxies is -1, however, the total proxy count > 1,
uses DEFAULT_COMMIT_GRV_PROXIES_RATIO to split proxies between
grv_proxies & commit_proxies.
2021-11-24 12:52:31 -08:00
Renxuan Wang 46d17d748f Change member variable fromHostname to type bool.
So that it can be serialized.
2021-11-23 14:25:02 -10:00
Renxuan Wang 22e34bd6b9 Replace <boost/bind.hpp> with <boost/bind/bind.hpp>.
This eliminates many useless warnings when compiling.
`#pragma message: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior.`
2021-11-18 14:00:13 -08:00
Lukas Joswiak 18243351e7 Fix possible data race
Transactions (created on a separate thread) can read the `globals` field
at the same time as `setGlobal` is called on the main thread, causing a
potential race. TSAN surfaced this issue.
2021-11-18 10:16:20 -08:00
negoyal 8b0938c7b3 Added a TODO 2021-11-17 09:45:50 -08:00
Steve Atherton 3caca74ac2 Merge commit 'fd707c6d7ee80de6d9fda5796da2d0add10abd79' into bit-flipping-workload 2021-11-16 21:54:27 -08:00
Markus Pilman b2019cd4f2
Merge pull request #5992 from sfc-gh-mpilman/features/fmt
added fmt dependency to flow
2021-11-16 18:58:55 -07:00
Steve Atherton 035e0d6e52
Merge branch 'master' into bit-flipping-workload 2021-11-16 14:42:22 -08:00
Markus Pilman b1633b90f1 Added fmt to flow 2021-11-16 12:03:49 -07:00
Steve Atherton 867999a41a Rename wrong_format_version to unsupported_format_version. 2021-11-16 03:25:54 -08:00
Renxuan Wang 4630b0ccea Move DNS mock from SimExternalConnection to Sim2.
This is a revise PR of #5934. In simulation, we don't have direct access to SimExternalConnection.
2021-11-15 17:02:51 -08:00
Evan Tschannen 964d0209ca
Merge pull request #5637 from sfc-gh-ljoswiak/features/data-loss-prevention
Data loss protection when joining new cluster
2021-11-15 15:26:32 -08:00
Jingyu Zhou 02d0c43bc2
Merge pull request #5982 from sfc-gh-tclinkenbeard/improve-error-descriptions
Make snapshot errors more descriptive
2021-11-15 13:18:19 -08:00
Evan Tschannen a546fb63ea
Merge pull request #5985 from sfc-gh-etschannen/feature-changefeed-empty-versions
Added a whenAtLeast function to change feeds to efficiently learn about empty versions
2021-11-15 10:51:28 -08:00
Markus Pilman daf6dc22d4
Merge pull request #5959 from mpilman/features/apple-silicon-3
FDB compiles on Apple Sillicon
2021-11-15 11:21:28 -07:00
Evan Tschannen 94a51e57a5 Merge branch 'master' into feature-changefeed-empty-versions
# Conflicts:
#	fdbclient/StorageServerInterface.h
2021-11-14 19:13:05 -08:00
Evan Tschannen 6909754b21 changefeeds now have a whenAtLeast function for efficiently learning when the version has updated but no mutations have been committed 2021-11-14 19:08:46 -08:00
sfc-gh-tclinkenbeard dc756228f2 Make snapshot errors more descriptive 2021-11-14 13:46:17 -08:00
Steve Atherton 508429f30d
Redwood chunked file growth and low priority IO starvation prevention (#5936)
* Redwood files now growth in large page chunks controlled by a knob to reduce truncate() calls for expansion.   PriorityMultiLock has limit on consecutive same-priority lock release.  Increased Redwood max priority level to 3 for more separation at higher BTree levels.

* Simulation fix, don't mark certain IO timeout errors as injected unless the simulated process has been set to have an unreliable disk.

* Pager writes now truncate gradually upward, one chunk at a time, in response to writes, which wait on only the necessary truncate operations.   Increased buggified chunk size because truncate can be very slow in simulation.

* In simulation, ioTimeoutError() and ioDegradedOrTimeoutError() will wait until at least the target timeout interval past the point when simulation is sped up.

* PriorityMultiLock::toString() prints more info and is now public.

* Added queued time to PriorityMultiLock.

* Bug fix to handle when speedUpSimulation changes later than the configured time.

* Refactored mutation application in leaf nodes to do fewer comparisons and do in place value updates if the new value is the same size as the old value.

* Renamed updatingInPlace to updatingDeltaTree for clarity.  Inlined switchToLinearMerge() since it is only used in one place.

* Updated extendToCover to be more clear by passing in the old extension future as a parameter.  Fixed initialization warning.
2021-11-12 13:47:07 -08:00
Josh Slocum 329091e14f Merge branch 'master' into bg_bindings 2021-11-11 10:13:37 -06:00
Markus Pilman 28dde27cb1 Fix Linux compiler errors 2021-11-11 08:49:51 -07:00
Markus Pilman 0e6dd46f5a Correct code formatting 2021-11-11 08:38:25 -07:00
Josh Slocum b8ac4213a1 Switched BG APIs to transaction instead of database 2021-11-11 08:59:06 -06:00
Markus Pilman 5af465aa29 FDB compiles on Apple Sillicon 2021-11-10 20:05:38 -07:00
Lukas Joswiak 069a04c5e5 Removed outdated definition 2021-11-10 13:33:49 -08:00
Lukas Joswiak 1da288822f Remove distributed trace database option 2021-11-10 13:33:49 -08:00
Lukas Joswiak 8bc0c3e8a2 Convert distributed trace sampling rate to a database option 2021-11-10 13:33:49 -08:00
Lukas Joswiak c93052121f Fix issue where transaction spans would not be recorded 2021-11-10 13:33:49 -08:00
Lukas Joswiak 5ed7abdc05 Fix bug where spans were not being properly constructed 2021-11-10 13:33:49 -08:00
Josh Slocum 2e5699c6d3 bump protocol version on master to 7.1 2021-11-10 09:38:51 -06:00
Tao Lin fdb3b72e35 Introduce GetRangeAndFlatMap to push computations down to FDB
Re-introduce #5609
2021-11-09 13:52:28 -08:00
Lukas Joswiak 3988b11fd6 Cleanup 2021-11-09 12:29:48 -08:00
Lukas Joswiak 30867750b5 Add protection against storage and tlog data deletion when joining a new cluster 2021-11-09 12:29:47 -08:00
Renxuan Wang 85dff214a4 Address comments. 2021-11-04 11:42:28 -07:00
Renxuan Wang f15ceb5489 Add Hostname struct, and fromHostname in NetworkAddress struct. 2021-11-04 11:42:28 -07:00
Tao Lin 586cc3b102
Revert "Introduce GetRangeAndFlatMap to push computations down to FDB" 2021-11-04 08:46:56 -07:00
Tao Lin 6c98e35893 Rename Hop to FlatMap 2021-11-03 13:32:01 -07:00
Tao Lin 0853661d13 Introduce getRangeAndHop to push computations down to FDB 2021-11-03 13:21:16 -07:00
sfc-gh-tclinkenbeard 841e6b211b Run clang-format on flow/serialize.cpp 2021-11-01 14:54:24 -07:00
Trevor Clinkenbeard 70b5ee35b9 Add comment to flow/serialize/Downgrade/WriteNew unit test
Co-authored-by: Andrew Noyes <andrew.noyes@snowflake.com>
2021-11-01 14:54:24 -07:00
sfc-gh-tclinkenbeard 2e3f3ea2af Remove unused constants from serialize.cpp 2021-11-01 14:54:24 -07:00
sfc-gh-tclinkenbeard e08721c7f4 Added flow/serialize/Downgrade unit tests 2021-11-01 14:54:24 -07:00
sfc-gh-tclinkenbeard c7b28abaf0 Enable unknown-pragmas warning for clang 2021-11-01 14:18:31 -07:00
sfc-gh-tclinkenbeard d0c9cf4fb0 Enable mismatched-tags clang warning 2021-11-01 14:18:31 -07:00
sfc-gh-tclinkenbeard ebcc023b6f Enable missing-field-initializers clang warning 2021-11-01 14:18:31 -07:00
sfc-gh-tclinkenbeard 25257f6f87 Enable unused-function warning for clang 2021-11-01 14:18:31 -07:00
negoyal 1e7338b6c3 Merge branch 'master' into bit-flipping-workload 2021-10-28 14:24:49 -07:00
Vaidas Gasiunas 40da5a80f9 Merge remote-tracking branch 'apple/master' into multi-version-client-2 2021-10-26 19:29:10 +02:00
Evan Tschannen 2208b04174
Merge pull request #5855 from sfc-gh-etschannen/blob_full_clean
Blob Granules V0
2021-10-26 09:57:35 -07:00
Vaidas Gasiunas 37bc41abbb Merge remote-tracking branch 'apple/master' into multi-version-client-2 2021-10-26 18:51:43 +02:00
Josh Slocum c003c1266b Doing fixmes for protocol version 2021-10-26 08:30:52 -05:00
sfc-gh-tclinkenbeard 49a667c29b Improve const-correctness of INetwork 2021-10-25 14:42:31 -07:00
sfc-gh-tclinkenbeard 63b241c60b Improve const-correctness of ITraceLogFormatter 2021-10-25 14:42:31 -07:00
Josh Slocum 0ff8ddc2b6 Merge branch 'master' into blob_full_clean 2021-10-25 13:38:48 -05:00
Evan Tschannen 92e0c92fd3
Merge pull request #5842 from sfc-gh-etschannen/feature-range-feed
Add support for change feeds
2021-10-25 11:31:55 -07:00
A.J. Beamon aebd12a9aa
Fix indentation issue with actor compiler (#5828) 2021-10-25 10:36:37 -07:00
Josh Slocum 773886515e Merge branch 'feature-range-feed' into blob_full_clean 2021-10-22 11:07:51 -05:00
Vaidas Gasiunas 39b2cb8125 Merge remote-tracking branch 'apple/master' into multi-version-client-2 2021-10-21 17:45:32 +02:00
Evan Tschannen f1158371a7 Merge branch 'master' of https://github.com/apple/foundationdb into feature-range-feed
# Conflicts:
#	flow/error_definitions.h
2021-10-21 00:55:12 -07:00
Evan Tschannen 3ebabb6edc fixed incorrect use of change feed errors 2021-10-20 22:37:31 -07:00
Evan Tschannen 3f7df58a77 fixed a number of issues 2021-10-19 13:56:52 -07:00
A.J. Beamon 6cf731d5aa Add comment to run loop blocked message about timestamp order 2021-10-19 10:05:29 -07:00
A.J. Beamon abab45760d Add some additional logging if the network thread finishes, fails with an error, gets stopped, or is blocked. 2021-10-19 10:05:29 -07:00
Josh Slocum 912ef76f1c cleanup before merge 2021-10-18 17:11:14 -05:00
Josh Slocum b5074fd597 Reworked all of the system data to encode granule data more efficiently for persistence 2021-10-13 16:28:04 -05:00
Josh Slocum 5f0ec0612a Merge branch 'feature-range-feed' into blob_full 2021-10-13 15:44:35 -05:00
negoyal f913dfed97 Merge branch 'master' into bit-flipping-workload 2021-10-11 16:34:57 -07:00
Yao Xiao c8e6819a10
Add FastAlloc memory utilization trace. (#5739)
Co-authored-by: Yao Xiao <yaoxiao@Yaos-MacBook-Pro.local>
2021-10-11 15:06:43 -07:00
Markus Pilman 5066d67dec
Merge pull request #5715 from sfc-gh-ljoswiak/fixes/tracing-various
Add knob to control distributed trace recording percentage
2021-10-11 14:03:53 -06:00
Markus Pilman cd6049f178
Merge pull request #5708 from sfc-gh-ljoswiak/fixes/sampling-crashes
Fix some common sampling crashes at high sampling frequencies
2021-10-11 14:02:11 -06:00
Evan Tschannen 5c642f706e Merge branch 'master' of https://github.com/apple/foundationdb into feature-range-feed
# Conflicts:
#	fdbcli/fdbcli.actor.cpp
2021-10-09 19:34:16 -07:00
Steve Atherton 45e19c8072 Merge branch 'master' of https://github.com/apple/foundationdb into kvs-write-version
# Conflicts:
#	fdbserver/VersionedBTree.actor.cpp
2021-10-07 20:48:21 -07:00
Zhe Wu c07a07dbbe Take uptime into account when making failover decision 2021-10-07 11:19:34 -07:00
Vaidas Gasiunas 39017c3b41 MVC2.0: Use page-aligned buffers and offsets, enable async IO for reading & writing client lib files 2021-10-06 18:01:46 +02:00
Vaidas Gasiunas 816e8703d6 MVC2.0: Operation to download a client library from the system keyspace to a file 2021-10-06 18:01:46 +02:00
Vaidas Gasiunas cda0a5f931 Operation to upload client library binary in to system keyspace 2021-10-06 18:01:46 +02:00
Josh Slocum 6a24ef9258 adding priorities to blob worker and fixing monitoring in blob manager 2021-10-05 16:51:19 -05:00
Suraj Gupta 95166796cd Address PR comments. 2021-10-04 20:16:22 -04:00
Suraj Gupta 4d54669ccd Recruit the blob workers via blob manager.
In this PR, the blob manager now recruits blob workers
(via communication with the cluster controller). Blob workers
are onboarded as blob worker processes enter the cluster.
2021-10-04 11:07:08 -04:00
Lukas Joswiak e034f66fc2 Add knob to control trace recording percentage 2021-10-01 16:30:46 -07:00
Lukas Joswiak 4cd642be7a Fix some common sampling crashes at high sampling frequencies 2021-09-30 17:25:09 -07:00
A.J. Beamon 77c3122391 Slight modification to comment to remove the indication that we flush the trace log explicitly. 2021-09-27 13:17:00 -07:00
A.J. Beamon 0fc3cf44dc When we have a large trace log buffer in simulation, that suggests we may be stuck in a loop that prevents us from running the trace flush. Detect when this has happened and fail the test early, which allows us to do the flush and have logging for the offending loop. 2021-09-27 13:17:00 -07:00
A.J. Beamon d51b93390d Proper handling of reset and transaction destruction. Add some comments. 2021-09-17 18:10:56 -06:00
Xiaoge Su e68b131e4a fixup! Reformat source code 2021-09-16 19:40:28 -07:00
Xiaoge Su abf73047ca Enforce std:: specifier rather than using namespace 2021-09-16 19:40:28 -07:00
Mohamed Oulmahdi ce4bef2cec Allow / and - for fdbserver command line parameter values 2021-09-15 16:30:58 -06:00
sfc-gh-tclinkenbeard 8e523c5bae Fixed grv_proxy_failed error message 2021-09-12 17:33:25 -07:00
sfc-gh-tclinkenbeard 368e217adf Fixed commit_proxy_failed error message 2021-09-12 17:33:25 -07:00
negoyal a7721d9786 Remove debug trace events and clang-format. 2021-09-10 15:41:22 -07:00
Kao Makino f7c7a31478 Disable clang-format on flow/aarch64/asmdefs.h 2021-09-10 15:33:40 -07:00
negoyal 078cc7ee55 Merge branch 'master' into bit-flipping-workload 2021-09-10 10:26:21 -07:00
Josh Slocum c2d1d1704f Merge branch 'feature-range-feed' into blob_full 2021-09-10 11:21:52 -05:00
Steve Atherton b06cf7a328 Redwood commit versions are now FDB commit versions for storage instances. Redwood no longer makes internal commits during Pager or BTree recovery so that commit version is always set by the user. 2021-09-10 03:28:46 -07:00
Evan Tschannen ac5b580e2d Merge branch 'master' into feature-range-feed
# Conflicts:
#	fdbcli/fdbcli.actor.cpp
#	fdbclient/StorageServerInterface.cpp
#	fdbclient/StorageServerInterface.h
#	fdbserver/ApplyMetadataMutation.cpp
#	fdbserver/TLogServer.actor.cpp
#	flow/error_definitions.h
2021-09-09 23:13:22 -07:00
negoyal 7729a282ce Misc fixes and updated test toml file. 2021-09-08 14:31:09 -07:00
Evan Tschannen af0792b1f5 fixes that allow change feeds to pass correctness in tests with no failures 2021-09-03 17:24:33 -07:00
negoyal a8baeb75d0 Misc fixes. 2021-09-03 15:03:12 -07:00
Xiaoge Su cb9ee75d9b Fix the self-assign warning in Atomic.h
When compiling FDB using clang++, self-assign warning appears due to the
code

	pos = littleEndian32(pos);

in Atomic.h, which expands to

	pos = pos;

as littleEndian32 is defined as

        #define littleEndian32(value) value

This warning is not interesting, but annoying, by adding a
no-side-effect casting, the warning is suppressed.
2021-08-31 23:54:56 -07:00
negoyal 3b34423248 Merge branch 'master' into bit-flipping-workload 2021-08-31 12:14:51 -07:00
sfc-gh-tclinkenbeard 86c6c2b643 Merge remote-tracking branch 'origin/master' into paxos-config-db 2021-08-27 23:24:14 -07:00
FDB Formatster 2c788c233d apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-08-27 17:07:47 -07:00
A.J. Beamon a51988ff3a Refactor our PRIVATE_EXCEPT_FOR_TLSCONFIG_CPP macro to be compatible with clang-format. Remove one use of it that is no longer needed now that actors can access private members. 2021-08-27 16:41:45 -07:00
Josh Slocum 3b011408f8 Added sequence numbers and locks to blob worker and manager 2021-08-27 16:33:07 -05:00
sfc-gh-tclinkenbeard ad99f025e3 Merge remote-tracking branch 'origin/master' into paxos-config-db 2021-08-27 14:13:34 -07:00
Fuheng Zhao 2a147b53cb update the logReport function 2021-08-27 13:47:30 -07:00
Fuheng Zhao 0516b2b24f add clear to writeToLog 2021-08-27 13:45:11 -07:00
sfc-gh-tclinkenbeard 7f8a1385d5 Merge remote-tracking branch 'origin/master' into paxos-config-db 2021-08-26 17:00:43 -07:00
sfc-gh-fzhao e81927e801
Merge branch 'apple:master' into HistogramCountDetailFormatChange 2021-08-26 14:44:52 -07:00
Andrew Noyes 05853b97c5
Merge pull request #4920 from apple/anoyes/aarch64-memcmp
Use custom mem{cmp,cpy} impl on Arm
2021-08-26 14:30:05 -07:00
Fuheng Zhao d8c257e263 resolve conflicts 2021-08-26 13:13:01 -07:00
Fuheng Zhao 8a19dac2f7 update the count and precetage to countLinear and percentageLinear 2021-08-26 13:08:11 -07:00
Fuheng Zhao 656dccae08 fix type 2021-08-26 13:02:55 -07:00
Steve Atherton be440ab954
Merge pull request #5260 from FuhengZhao/RedwoodHistogram
Redwood local histograms
2021-08-26 12:05:44 -07:00
Andrew Noyes 8b7e598feb Disallow usage of `wait` outside of ACTORs
Before this change, calling `wait` outside of an ACTOR would compile (!!)
2021-08-26 08:47:50 -07:00
Fuheng Zhao 5eb92ae65c reomve registry 2021-08-24 15:47:04 -07:00
sfc-gh-tclinkenbeard a047782db2 Merge remote-tracking branch 'origin/master' into paxos-config-db 2021-08-24 11:08:20 -07:00
Fuheng Zhao 57652a0cae Format 2021-08-24 10:00:24 -07:00
Fuheng Zhao b65a66fab7 log redwood histogram seperatly 2021-08-24 09:57:39 -07:00
Lukas Joswiak b756667d5b
Merge pull request #5402 from Doxense/fix-sampling-projects-conflicts-with-msbuild
Add dependencies between sampling and non-sampling actors projects
2021-08-24 09:25:31 -07:00
Jingyu Zhou eafe5b31ca
Merge pull request #5432 from Doxense/fix-windows-std-mutex-crash
Fix Windows std::mutex crash
2021-08-24 08:41:52 -07:00
Mohamed Oulmahdi c1bb977a93 Set sampling dependencies for Windows only 2021-08-24 10:48:31 +02:00
Mohamed Oulmahdi 2c5510011c Add dependencies between sampling and non-sampling actors projects 2021-08-24 10:48:31 +02:00
Kao Makino ab318880a5 Add ACKNOWLEDGEMENTS. Replace memcpy with advsimd implementation. 2021-08-23 19:12:52 -07:00
Lukas Joswiak d554205db3 Move common knob initialization macros to header 2021-08-23 11:41:01 -07:00
Lukas Joswiak e2d897a2c2 Clean up types 2021-08-23 11:41:01 -07:00
Lukas Joswiak 4c92026213 Use existing error when triggering local config restart 2021-08-23 11:41:01 -07:00
Lukas Joswiak 7998ec4232 Add atomicity to knobs 2021-08-23 11:41:00 -07:00
Trevor Clinkenbeard 66df75c570
Merge pull request #5385 from sfc-gh-tclinkenbeard/debug-dd
Capture deep copy of `machine_info` in `printSnapshotTeamsInfo`
2021-08-20 13:25:50 -07:00
sfc-gh-tclinkenbeard 3a067b9cc8 Expand scope of GetGenerationQuorum object in PaxosConfigTransactionImpl 2021-08-20 10:15:01 -07:00
Fuheng Zhao 5aeb6249a5 change unit::cout format into %u 2021-08-20 09:24:59 -07:00
Mohamed Oulmahdi bff33372f6 Use WIN32 mutex instead of std::mutex for singleton 2021-08-20 17:39:57 +02:00
Jingyu Zhou 32142bdec2
Merge pull request #5422 from sfc-gh-xwang/master
fix spelling error
2021-08-19 15:48:27 -07:00
Xiaoxi Wang 09342f43ea fix spelling error 2021-08-19 13:55:30 -07:00
Fuheng Zhao dc31064e96 change histogram counts write to log format 2021-08-18 18:52:44 -07:00
Chaoguang Lin b9628bdb50 Merge branch 'master' of github.com:apple/foundationdb into add-flow-db-interface 2021-08-17 20:24:41 +00:00
Evan Tschannen 0a78c84a3e
Merge pull request #5183 from sfc-gh-xwang/tlog_dev
TLog Streaming Peek
2021-08-17 11:51:34 -07:00
sfc-gh-tclinkenbeard 3418c20867 Merge remote-tracking branch 'origin/master' into paxos-config-db 2021-08-16 10:49:47 -07:00
Evan Tschannen a278d2977a renamed range feeds to change feeds, data distribution support almost complete 2021-08-13 14:27:15 -07:00
sfc-gh-tclinkenbeard 904deb9516 Improve DDTeamCollection const-correctness 2021-08-12 18:52:57 -07:00
sfc-gh-fzhao 29b4f221a7
Merge branch 'apple:master' into RedwoodHistogram 2021-08-12 17:07:05 -07:00
sfc-gh-tclinkenbeard cfe677c100 storageRecruiter only responds to changes in recruitStorage endpoint 2021-08-12 16:24:03 -07:00
Daniel Smith 0cc317124e
Merge pull request #5354 from liquid-helium/thread-safe-promis-stream
Introduced ThreadReturnPromiseStream
2021-08-12 12:19:13 -04:00
Xiaoxi Wang a97570bd06 solve mis-spelling, trace log and format problems 2021-08-11 18:26:00 -07:00
helium f445d94baf Comments resolved. 2021-08-11 17:01:12 -07:00
Chaoguang Lin bf0d0598dc Refactor all ThrottleAPI functions using template and remove duplicate copies 2021-08-11 23:59:25 +00:00
helium e988ac53d9 clang-format 2021-08-11 16:21:06 -07:00
Lukas Joswiak a605fb3852
Merge pull request #5026 from sfc-gh-ljoswiak/fixes/alp6
Actor sampling
2021-08-11 13:44:17 -07:00
helium c043b21974 Added test for sending error 2021-08-11 11:37:12 -07:00
helium f8edf6e1f2 Switched to a separate test ThreadPoolReceiver 2021-08-11 10:47:51 -07:00
Chaoguang Lin 618c72f7e2 Draft to use template to rewrite ThrottleApi 2021-08-11 01:07:36 +00:00
Evan Tschannen ed28aecde0 Merge branch 'master' into feature-range-feed 2021-08-09 20:40:55 -07:00
helium 15d050ece5 Added unit test, and bug fixes. 2021-08-09 16:26:29 -07:00
Fuheng Zhao 5e76650d9b update constructor 2021-08-09 15:26:58 -07:00
sfc-gh-fzhao 40e674a6ba
Merge branch 'apple:master' into RedwoodHistogram 2021-08-09 15:14:15 -07:00
Andrew Noyes 7706b47085 Fix another TSAN warning
```
  Read of size 1 at 0x7f02082ac578 by main thread:
    #0 TraceLog::close() /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/_build/../flow/Trace.cpp:487:7 (libfdb_c.so+0xf4928c)
    #1 closeTraceFile() /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/_build/../flow/Trace.cpp:759:13 (libfdb_c.so+0xf3992a)
    #2 stopNetwork() /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/fdbclient/NativeAPI.actor.cpp:2052:2 (libfdb_c.so+0x58315c)
    #3 ThreadSafeApi::stopNetwork() /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/_build/../fdbclient/ThreadSafeTransaction.cpp:466:2 (libfdb_c.so+0xce8ad3)
    #4 MultiVersionApi::stopNetwork() /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/fdbclient/MultiVersionTransaction.actor.cpp:1756:20 (libfdb_c.so+0x4f7da3)
    #5 fdb_stop_network /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/_build/../bindings/c/fdb_c.cpp:134:2 (libfdb_c.so+0x4c84e5)
    #6 main /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/_build/../bindings/c/test/unit/trace_partial_file_suffix_test.cpp:93:12 (trace_partial_file_suffix_test+0x40b3d0)

  Previous write of size 1 at 0x7f02082ac578 by thread T1 (mutexes: write M100):
    #0 TraceLog::open(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned long, unsigned long, Optional<NetworkAddress>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/_build/../flow/Trace.cpp:344:10 (libfdb_c.so+0xf48aaa)
    #1 openTraceFile(NetworkAddress const&, unsigned long, unsigned long, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >) /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/_build/../flow/Trace.cpp:741:13 (libfdb_c.so+0xf3828c)
    #2 Database::createDatabase(Reference<ClusterConnectionFile>, int, IsInternal, LocalityData const&, DatabaseContext*) /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/fdbclient/NativeAPI.actor.cpp:1695:4 (libfdb_c.so+0x57d57e)
    #3 ThreadSafeDatabase::ThreadSafeDatabase(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, int)::$_7::operator()() const /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/_build/../fdbclient/ThreadSafeTransaction.cpp:124:8 (libfdb_c.so+0xcf018c)
    #4 internal_thread_helper::DoOnMainThreadVoidActorState<ThreadSafeDatabase::ThreadSafeDatabase(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, int)::$_7, internal_thread_helper::DoOnMainThreadVoidActor<ThreadSafeDatabase::ThreadSafeDatabase(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, int)::$_7> >::a_body1cont1(Void const&, int) /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/flow/ThreadHelper.actor.h:45:4 (libfdb_c.so+0xcf018c)
    #5 internal_thread_helper::DoOnMainThreadVoidActorState<ThreadSafeDatabase::ThreadSafeDatabase(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, int)::$_7, internal_thread_helper::DoOnMainThreadVoidActor<ThreadSafeDatabase::ThreadSafeDatabase(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, int)::$_7> >::a_body1when1(Void const&, int) /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/_build/flow/ThreadHelper.actor.g.h:148:15 (libfdb_c.so+0xcf018c)
    #6 internal_thread_helper::DoOnMainThreadVoidActorState<ThreadSafeDatabase::ThreadSafeDatabase(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, int)::$_7, internal_thread_helper::DoOnMainThreadVoidActor<ThreadSafeDatabase::ThreadSafeDatabase(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, int)::$_7> >::a_callback_fire(ActorCallback<internal_thread_helper::DoOnMainThreadVoidActor<ThreadSafeDatabase::ThreadSafeDatabase(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, int)::$_7>, 0, Void>*, Void const&) /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/_build/flow/ThreadHelper.actor.g.h:169:4 (libfdb_c.so+0xcefdef)
    #7 ActorCallback<internal_thread_helper::DoOnMainThreadVoidActor<ThreadSafeDatabase::ThreadSafeDatabase(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, int)::$_7>, 0, Void>::fire(Void const&) /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/_build/../flow/flow.h:1074:78 (libfdb_c.so+0xcefdef)
    #8 void SAV<Void>::send<Void>(Void&&) /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/_build/../flow/flow.h:462:23 (libfdb_c.so+0x4dd542)
    #9 void Promise<Void>::send<Void>(Void&&) const /home/jenkins/fdb/extra/long/path/to/work/around/strange/cpack/debug/rpm/behavior/_build/../flow/flow.h:699:8
    ```
2021-08-09 14:06:38 -07:00
helium 32b1bead62 Introduced ThreadReturnPromisStream, the stream version of ThreadReturnPromise. 2021-08-09 10:26:48 -07:00
sfc-gh-tclinkenbeard 79ba9c4e3a Add GetGenerationQuorum to get generation from a quorum of config nodes 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard 82546853c0 Rename UseConfigDB to ConfigDBType 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard cdbcb69d86 Add configuration database type to ISimulator 2021-08-09 10:04:35 -07:00
Trevor Clinkenbeard 3992b0591c
Merge pull request #5213 from sfc-gh-tclinkenbeard/async-task-thread
Several AsyncTaskThread improvements
2021-08-05 14:33:30 -07:00
yao-xiao-github 876c6d72c4
Merge pull request #5278 from yao-xiao-github/histogram
Add histogram in GrvProxyServer.
2021-08-04 16:34:35 -07:00
sfc-gh-tclinkenbeard 76bf75e026 Replace parseIntegral with standard parsing functions 2021-08-03 15:30:14 -07:00
Fuheng Zhao 7170c99220 fix a bug after merge 2021-08-03 14:36:50 -07:00
Fuheng Zhao 782a47f45d update histogram constructor 2021-08-03 14:01:39 -07:00
Fuheng Zhao 18eadfae33 format 2021-08-03 13:58:45 -07:00
Andrew Noyes a77fcb5448 Finalize partial trace files during trace clean up 2021-08-03 13:26:48 -07:00
Andrew Noyes 39eff8c569 Add trace_partial_file_suffix network option 2021-08-03 09:43:42 -07:00
Andrew Noyes ce4b2de6e7
Merge pull request #5290 from apple/anoyes/avoid-network-thread
Bring back optimization that avoids hop to network thread
2021-08-02 15:07:27 -07:00
Andrew Noyes 1d64a53b34
Apply suggestions from code review
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-08-02 13:42:30 -07:00
Andrew Noyes ba13b86bff Fix comment grammar (add a period) 2021-08-02 13:41:03 -07:00
Andrew Noyes 1b1cd1e856 Fix releaseMemory deadlock and add comments 2021-08-02 13:37:09 -07:00
Lukas Joswiak 5dc9a97230 Merge branch 'master' into fixes/alp6 2021-08-01 20:42:52 -07:00
Lukas Joswiak d606392c68 Disable more ALP work when sampling disabled 2021-08-01 20:11:50 -07:00
Yao Xiao 74a7da0179 Add histogram in GrvProxyServer. 2021-07-30 17:54:51 -07:00
negoyal 9e7197faba Bunch of changes based on review comments and discussions. 2021-07-30 01:32:43 -07:00
Andrew Noyes 353efe7db2
Merge pull request #5264 from sfc-gh-tclinkenbeard/fix-more-clang-warnings
Enable more warnings for `clang`
2021-07-29 15:43:54 -07:00
sfc-gh-fzhao e8cefacbbe
Merge branch 'apple:master' into RedwoodHistogram 2021-07-28 21:17:06 -07:00
negoyal 4b87716475 Turn the chaos knob off by default. 2021-07-28 18:19:55 -07:00
negoyal 40b4f3b2f1 Merge branch 'master' into bit-flipping-workload 2021-07-28 18:06:07 -07:00
negoyal 050c218502 New Disk Delay Logic and ChaosMetrics. 2021-07-28 16:03:37 -07:00
Xiaoge Su 0173d86be3 Revert "Merge pull request #5286 from xis19/master"
This reverts commit f533317b73, reversing
changes made to 82603ff764.
2021-07-28 15:43:24 -07:00
sfc-gh-fzhao 09d7ee4741
Merge branch 'apple:master' into RedwoodHistogram 2021-07-28 14:35:53 -07:00
Chaoguang Lin 9eec9376bd
Merge pull request #5285 from sfc-gh-clin/refactor-throttle-command
Refactor throttle command
2021-07-28 13:43:15 -07:00
sfc-gh-tclinkenbeard 94a65865d9 Merge remote-tracking branch 'origin/master' into fix-clang-warnings 2021-07-28 12:29:27 -07:00
sfc-gh-tclinkenbeard c74047c665 Merge remote-tracking branch 'origin/master' into fix-more-clang-warnings 2021-07-28 11:51:02 -07:00
Evan Tschannen 2b2ba10179
Merge pull request #5288 from sfc-gh-etschannen/fix-ordered-delay
Flow transport uses an ordered delay to avoid out of order reply promise stream messages
2021-07-28 09:44:38 -07:00
Fuheng Zhao 1804c6e417 add a default output for histogram 2021-07-27 20:05:17 -07:00
Fuheng Zhao edea7f4fe5 addRef 2021-07-27 19:23:47 -07:00
Evan Tschannen 406562b282 Merge branch 'master' of https://github.com/apple/foundationdb into feature-range-feed 2021-07-27 17:04:58 -07:00
Fuheng Zhao ee2be2f95f modify histogram destructor 2021-07-27 16:27:32 -07:00
Fuheng Zhao 20b01defa0 Merge branch 'RedwoodHistogram' of https://github.com/FuhengZhao/foundationdb into RedwoodHistogram 2021-07-27 16:19:25 -07:00
Fuheng Zhao 1a609abc68 remove registry in redwood 2021-07-27 16:11:00 -07:00
sfc-gh-fzhao 995b1fa5fc
Merge branch 'apple:master' into RedwoodHistogram 2021-07-27 14:19:25 -07:00