* main:
Moving rocksdb read iterator destruction from commit path to actor. (#8970)
Nit fix
apply format in fdbclient/FDBTypes.cpp
Update physical shard tracking document.
Fix issue with KeyRangeRef original data gone.
Add code document.
During initialization, keyRangePhysicalShardIDMap may not contain full range. Adjust assertion in checkKeyRangePhysicalShardMapping
Create per physical shard tracking data stucture. Not populate yet
Do not compress debug sections in release builds (#9005)
Fix assertion failure from changeFeedTSSValidator()
metrics: Fix windows build
Fix feed metadata reset (#8751)
MultiVersionTransaction: Improve Comments
MultiVersionTransaction: Add comments
MultiverstionTransaction: Remove redundant setOption calls
The pair name will only match when we are deleting the source tenant entry
Add an assert in deleteTenantFromManagementCluster that the tenant's pair name matches the locally stored pair name
DeleteTenantImpl::markTenantInRemovingState needs to record the pair name even if the tenant is already in a removing state (it could be a pair in the process of being removed). Use better asserts in tenant consistency.
* main: (68 commits)
Fix clang 15 warning in mako
Fix more clang 15 warnings
Fix clang 15 compiler warnings
metrics: Break down OTELSum into smaller chunks to avoid UDP max packet size
metrics: Make NumberDataPoint contain a variant<int, double> of the value
ddsketch: Fix undefined behaviour in DDSketch::getValue
metrics: Make DDSketch buckets uint32_t but double precision
metrics: Add OTEL metric definitions
metrics: Add simulation testing and fix incorrect TraceEvent names - Added a background actor that listens on METRICS_EMISSION_UDP_PORT for incoming metrics (and verifies they are in the correct format) - TraceEvent details have certain requirements for naming. This commit makes a seperate name for Counter/LatencySample and its underlying IMetric to avoid those issues
metrics: Add verifyStatsdMessage() for testing
metrics: Avoid name conflicts in MetricCollection - In Counter constructor, make sure that we combine CounterCollection name - In IMetric constructor, add a trace event and assertion in case of collision - Rename ClusterRecoveryData CounterCollection name from master to ClusterRecoveryData
metrics: Fix bug in LatencySample::flush() - Make sure that we check batch.statsd_message to be non-empty before adding a newline - Make sure to actually add the message to the batch in flush()
metrics: Added runMetrics() to workerServer
metrics: Add IMetricClient and StatsdMetric to send batches over UDP
metrics: Add MetricsLogger loop and more knobs
metrics: Make sure LatencyBand counters are unique
metrics: Add knobs and make Counter, LatencySample implement flush() method
metrics: Add flush() definitions to Counter and LatencySample
metrics: Make LatencySample and Counter inherit from IMetric
metrics: Initial code - Define new IMetric interface - Rename MetricUpdateBatch to MetricBatch - Move previous fields of MetricUpdateBatch into a new struct called FDBScope - Define global MetricCollection class and enMetric enumerate
...
- Added a background actor that listens on METRICS_EMISSION_UDP_PORT for incoming metrics (and verifies they are in the correct format)
- TraceEvent details have certain requirements for naming. This commit makes a seperate name for Counter/LatencySample and its underlying IMetric to avoid
those issues
- In Counter constructor, make sure that we combine CounterCollection name
- In IMetric constructor, add a trace event and assertion in case of collision
- Rename ClusterRecoveryData CounterCollection name from master to ClusterRecoveryData
Nim Wijetunga