Commit Graph

3612 Commits

Author SHA1 Message Date
Evan Tschannen c1306f94fd replaced usage of “data center” with “datacenter”, and clarified the definition of a datacenter 2018-11-15 13:14:25 -08:00
Evan Tschannen 1036e42ef7
Merge pull request #927 from etschannen/release-6.0
added additional information to region documentation
2018-11-15 09:43:06 -08:00
Evan Tschannen 86f5139640 added additional information to region documentation 2018-11-15 09:42:15 -08:00
Stephen Atherton 1f2223fcf5 Bug fix in backup expiration. After the range file scan, it was being asserted that the range files found have a version < expiration version but this isn't guaranteed because the expiration version is likely shifted backward a bit after the file scan based on the log files found. 2018-11-15 02:15:25 -08:00
Evan Tschannen 33f99b69b2
Merge pull request #925 from etschannen/release-6.0
added documentation for configuring regions
2018-11-14 23:37:07 -08:00
Evan Tschannen 3bb17e69fd added whitespace 2018-11-14 23:34:20 -08:00
Evan Tschannen ea300a150a fixed spelling mistakes 2018-11-14 23:31:58 -08:00
Evan Tschannen 6433388c0d one more formatting change 2018-11-14 23:24:27 -08:00
Evan Tschannen b8a3f0e623 changed formatting 2018-11-14 23:22:21 -08:00
Evan Tschannen f7a400375b added documentation for configuring regions 2018-11-14 23:15:49 -08:00
John Brownlee 60908f77cb Combine multiple run commands into one command in the dockerfile.
Add more copyright headers to the docker sample files.
Make the cluster file creation logic in the docker image into a function.
2018-11-14 08:13:43 -08:00
Evan Tschannen 4649d63b4c
Merge pull request #923 from satherton/fix-s3-compatibility
BlobStoreEndpoint will only try to create a Bucket if it does not already exist.
2018-11-13 17:21:44 -08:00
Stephen Atherton 3711229970 Added release note for blobstore client compatibility fix. 2018-11-13 17:20:00 -08:00
Stephen Atherton 1c052b6090 Merge branch 'release-6.0' of github.com:apple/foundationdb into fix-s3-compatibility 2018-11-13 17:09:55 -08:00
Evan Tschannen dbaaaac354
Merge pull request #922 from etschannen/master
fixed merge error
2018-11-13 16:36:05 -08:00
Evan Tschannen 7862a8bb88 fixed merge error 2018-11-13 16:35:16 -08:00
Stephen Atherton ca6a6d4906 Added BlobStoreEndpoint::bucketExists() to check for existence of a bucket, and createBucket() now uses this to avoid trying to create a bucket that already exists. 2018-11-13 16:18:43 -08:00
Alex Miller d076999f9b Fix the fix of the build of the bindings target.
The bindings build was broken becaue fdb_c_performance_test failed to
link with errors of the form:

    /tmp/ccym9LhK.o: In function `clearAll':
    /opt/foundationdb/bindings/c/test/performance_test.c:130: undefined reference to `fdb_transaction_clear_range'
    /tmp/ccym9LhK.o: In function `insertRange':
    /opt/foundationdb/bindings/c/test/performance_test.c:139: undefined reference to `fdb_transaction_set'
    /tmp/ccym9LhK.o: In function `singleKey':
    /opt/foundationdb/bindings/c/test/performance_test.c:540: undefined reference to `fdb_transaction_set'
    ...

PR #901's e8f20e4 fixed this by adding `-shared` to the invocation line,
and thus doing a dynamic linking of libfdb_c.

As dynamically linking produced a working executable, this suggests that
the correct set of libraries are being linked, as the symbols can be
located eventually, just not in the right order, as the linker will
proactively not include unnecessary object files from static libraries.
And unfortunately, our performance test framework likely expects to be able
to copy the binary, and not have to worry about associated dynamically
linked libraries, so a statically linked binary is preferred.

The underlying cause of this link error is that the static library
preceeded the source code in the command line:

    /usr/bin/gcc -Werror -Wno-error=format -fPIC -DNO_INTELLISENSE -fvisibility=hidden -DNDEBUG=1 -Wreturn-type -fno-omit-frame-pointer -O2 -g -Llib -lfdb_c -lpthread -Ibindings/c -o bin/fdb_c_performance_test bindings/c/test/performance_test.c

This comes from the line in the Makefile:

    @$(CC) $(CFLAGS) $(fdb_c_tests_LIBS) $(fdb_c_tests_HEADERS) -o $@ bindings/c/test/performance_test.c

As we pass `-lfdb_c` before `performance_test.c`, when the linker is
considering libfdb_c.a, it sees that no symbols from any of the object
files are currently needed, and thus doesn't include them.  When we
proceprocess performance_test.c, we suddenly need these symbols, but
it's too late, as the linker only processes files left-to-right.

Thus, we can resolve this problem by passing -lfdb_c after performance_test.c

Also of note is that we only seem to have this problem because the link
line was crafted by hand instead of using link-wrapper.sh, which already
does the right thing.
2018-11-13 16:15:32 -08:00
Evan Tschannen cb59571273
Merge pull request #920 from etschannen/master
merge 6.0 into master
2018-11-13 16:09:12 -08:00
Evan Tschannen e45952bc53 Merge branch 'release-6.0'
# Conflicts:
#	documentation/sphinx/source/release-notes.rst
#	fdbclient/BackupContainer.actor.cpp
#	fdbclient/BlobStore.actor.cpp
#	fdbclient/HTTP.actor.cpp
#	tests/BlobStore.txt
#	versions.target
2018-11-13 16:06:39 -08:00
Evan Tschannen 354ad2604d
Merge pull request #919 from etschannen/post-release-cleanup-6.0.15
Post release cleanup 6.0.15
2018-11-13 15:54:41 -08:00
Evan Tschannen 283b85b54a update installer WIX GUID following release 2018-11-13 15:53:58 -08:00
Evan Tschannen b0d38389a8 update versions target to 6.0.16 2018-11-13 15:53:58 -08:00
Evan Tschannen 8903c5f621
Merge pull request #918 from etschannen/release-6.0
updated download links for 6.0.15
2018-11-13 13:17:10 -08:00
Evan Tschannen e6b4c0431d updated download links for 6.0.15 2018-11-13 13:16:15 -08:00
Evan Tschannen b2524a3443
Merge pull request #917 from etschannen/prepare-release-6.0.15
update installer WIX GUID following release
2018-11-13 13:13:07 -08:00
Evan Tschannen 0791683029 update installer WIX GUID following release 2018-11-13 13:12:17 -08:00
Balachandar Namasivayam dccf2e6fba
Merge pull request #916 from etschannen/release-6.0
minor bug fix
2018-11-13 12:49:31 -08:00
Evan Tschannen 080133c146 updated release notes 2018-11-13 12:38:17 -08:00
Evan Tschannen 1bd615f954 fix: remoteDcIds will not actually have transaction logs unless usable regions is > 1 2018-11-13 12:36:04 -08:00
Evan Tschannen abb7299e1d
Merge pull request #901 from AlvinMooreSr/bindings-build
Fixed build of bindings target
2018-11-13 12:31:35 -08:00
Evan Tschannen 483b6d557b
Merge pull request #897 from AlvinMooreSr/build-compose
Docker Compose Build Services
2018-11-13 12:31:18 -08:00
Evan Tschannen b6cac2a8e1
Merge pull request #914 from satherton/fix-s3-compatibility
Fix backup S3 API compatibility
2018-11-13 12:28:57 -08:00
Alec Grieser 4afccb4811
Merge pull request #915 from alecgrieser/feature-bigint-support-go-ruby-aj
Support integers up to 255 bytes in Go and Ruby
2018-11-13 11:56:31 -08:00
Alec Grieser 8424fc57ec
add period to comment 2018-11-13 11:55:54 -08:00
Alec Grieser 6ab59b2ec2
update PR number to (hopefully) final PR for bigint feature 2018-11-13 11:47:28 -08:00
Alec Grieser 3c8347e724
add comments for some tricky int-packing code 2018-11-13 11:41:23 -08:00
Alec Grieser 7e4f84c60e
Merge remote-tracking branch 'upstream/release-6.0' into feature-bigint-support-go-ruby-aj 2018-11-13 11:28:10 -08:00
Stephen Atherton 3125b807b3 Added documentation of the 'bucket' URL parameter for blobstore:// backup URLs. 2018-11-13 06:23:58 -08:00
Stephen Atherton 4d74648dd8 Merge commit '3841b8a9436cde771f0503645a85e94e20050727' into fix-s3-compatibility
# Conflicts:
#	documentation/sphinx/source/release-notes.rst
2018-11-13 05:39:23 -08:00
Stephen Atherton 5236ff9f7a Added release note for PR #904. 2018-11-13 05:37:03 -08:00
Stephen Atherton c89d1bfd98 Added release note for PR #826. 2018-11-13 05:36:43 -08:00
Stephen Atherton 3841b8a943 Added release note for PR #904. 2018-11-13 05:34:41 -08:00
Stephen Atherton 92eae5b942 Added release notes for backup related fixes in PR #914. 2018-11-13 05:33:59 -08:00
Stephen Atherton 9fc564dde6 Merge branch 'release-6.0' of github.com:apple/foundationdb into fix-s3-compatibility 2018-11-13 05:16:36 -08:00
Stephen Atherton 6bd0cc250b Removing test spec for old test which no longer exists. 2018-11-13 03:10:03 -08:00
Stephen Atherton 983bd3346a BackupContainerBlobStore no longer uses a hardcoded bucket name. BlobStoreEndpoint creating from a URL string now supports having additional parameters in the URL which it does not consume but rather returns to the caller, and BackupContainerBlobStore uses this to accept a "bucket" parameter. 2018-11-13 03:00:59 -08:00
Stephen Atherton ff7e570679 Compatibility fix. RapidXML's "find first node with a specific name" functionality will not return a root node of a document which has the required name but also specifies an xmlns attribute. Minio specifies an xmlns attribute (of a defunct namespace at a dead link at Amazon) so its responses were not being parsed successfully. 2018-11-13 01:00:56 -08:00
Stephen Atherton 1009599662 Blobstore client now sends HTTP requests with a header indicating that only XML responses are accepted. JSON responses are no longer supported and xml2json has been removed. The request Date header format is now the standard ISO 8601 format indicated by the S3 documentation. 2018-11-13 00:49:13 -08:00
Evan Tschannen 7df06022b9
Merge pull request #913 from etschannen/master
merge 6.0 into master
2018-11-12 20:28:23 -08:00