Commit Graph

14730 Commits

Author SHA1 Message Date
Trevor Clinkenbeard 0db28f6ea0
Merge pull request #4535 from jzhou77/fix-dd
Fix DD Assertion failed in canBeSet
2021-03-24 10:50:04 -07:00
Andrew Noyes c186d363c6 Add unit test 2021-03-24 17:32:07 +00:00
Andrew Noyes d0e64d176b
Merge pull request #4544 from sfc-gh-jfu/jfu-fix-valgrind-errors
Initialize extraDB in simulationConfig according to TestConfig parameter
2021-03-24 10:09:05 -07:00
A.J. Beamon ed811008ca
Merge pull request #4504 from sfc-gh-nwijetunga/network_busyness
Monitor Network Thread Busyness
2021-03-24 09:44:09 -07:00
Steve Atherton a6136ffc62 Applied clang-format to recent changes. 2021-03-24 06:51:08 -07:00
Steve Atherton 17a19021fb Added mutation batch filtering during restore, to the extent possible where each restore mutation log task only sees one block of data (usually 1MB) which can contain incomplete and therefore unfilterable mutation sets. 2021-03-24 06:38:50 -07:00
Evan Tschannen e8ed192647
Merge pull request #4548 from sfc-gh-etschannen/fix-master-config-change
Do not call expectedLogSets() with the wrong configuration
2021-03-23 18:31:08 -07:00
Nim Wijetunga ea16d2cccd address pr comments 2021-03-23 23:09:08 +00:00
Nim Wijetunga e174ea0dfd fix comment typo 2021-03-23 22:04:32 +00:00
Markus Pilman 816e583277
Merge pull request #4547 from sfc-gh-etschannen/fix-bme-satellite-fallback
Fixed an assertion failure in better master exists
2021-03-23 16:03:35 -06:00
Markus Pilman dbf34c3e1d
Merge pull request #4550 from sfc-gh-etschannen/fix-open-atomic
Fixed a simulation only durability error
2021-03-23 16:03:21 -06:00
Markus Pilman c3fdbe355b
Merge pull request #4549 from sfc-gh-etschannen/fix-rss-safety-check
Fixed simulation timeouts of the RemoveServerSafely workload
2021-03-23 16:02:59 -06:00
Jon Fu 9fd3c559c2 Added some missing comments for structs 2021-03-23 17:24:00 -04:00
Andrew Noyes 170c197c4c Truncate marks everything after size modified 2021-03-23 21:07:12 +00:00
Andrew Noyes e83de2b799 Fix bug: minSizeAfterPendingModifications needs to be maxed 2021-03-23 21:00:21 +00:00
Nim Wijetunga de1c354b12 address pr comments 2021-03-23 20:56:37 +00:00
Evan Tschannen a893309112 Opening a file with OPEN_ATOMIC_WRITE_AND_CREATE should create a new file handle, so that if a file with the same name is still in use, operations against it will not happen to the new file. This can happen when the disk queue replaces a file. 2021-03-23 13:47:46 -07:00
Evan Tschannen 272e649a3c The checkSafeExclusions function only ensures the exclusion is safe from the storage server prospective, but does not confirm it is safe in terms of the tlog replication 2021-03-23 13:31:16 -07:00
Evan Tschannen 0ea513b503 It is not safe to call expectedLogSets() with a potentially newer configuration than the one from the recovery 2021-03-23 13:21:48 -07:00
Evan Tschannen 10b6b5d710 If the current configuration does not have a satellite fallback policy we do not care if the old configuration is in fallback mode 2021-03-23 13:02:31 -07:00
Markus Pilman 35700f919f
Merge pull request #4495 from sfc-gh-etschannen/feature-fix-exlude-failed
Execute exclude failed commands after shutting down the rest of data distribution
2021-03-23 13:59:00 -06:00
Andrew Noyes 0daf6cf632 Consider extending a file with truncate as a "pending modification"
Before this, truncating and reading concurrently could cause to read
uninitialized memory. So could truncating then reading, since the effect
of the truncate in the actual file was allowed to be delayed. Now reads
will wait for a truncate that extends the file to complete if they
intersect the newly-zeroed region.
2021-03-23 19:44:36 +00:00
Jon Fu 1254a21caa Initialize extraDB in simulationConfig according to TestConfig parameter 2021-03-23 14:58:00 -04:00
Markus Pilman af869ac265 minor formatting fix 2021-03-23 10:59:01 -06:00
Markus Pilman 219a0b98d7 Add documentation 2021-03-23 10:51:16 -06:00
Markus Pilman 0ba99c8e83 Pretty-print topology when starting simulation 2021-03-23 09:38:07 -06:00
Lukas Joswiak 43c81e550c
Merge pull request #4539 from sfc-gh-nwijetunga/fix_fast_triggered_watches
Increase watch trigger time limit in FastTriggeredWatches
2021-03-22 23:12:22 -07:00
Nim Wijetunga b8c3cf7f82 remove comment 2021-03-23 00:46:40 +00:00
Nim Wijetunga ff10528eaf removed whitespace 2021-03-22 23:56:35 +00:00
Nim Wijetunga 376f5bc90a Increase watch trigger time limit in simulation 2021-03-22 23:37:54 +00:00
Evan Tschannen c14327f75c
Merge pull request #4537 from sfc-gh-jfu/jfu-check-test-conf-update
Factor out the checks for test configuration in simulation tests + added new parameter
2021-03-22 13:48:42 -07:00
A.J. Beamon 99f3bb6d7d
Merge pull request #4509 from sfc-gh-etschannen/feature-bme-count
Do not trigger BetterMasterExists if it lowers the number of processes
2021-03-22 13:43:24 -07:00
Jon Fu 44d4b1c540 Use const ref to avoid copying of TestConfig struct 2021-03-22 16:10:26 -04:00
Jon Fu c4a374a014 Added comments to checkTestConf 2021-03-22 15:28:26 -04:00
Jon Fu db80674877 Added comments to modified functions 2021-03-22 15:24:46 -04:00
Jingyu Zhou 0739c736a1
Merge pull request #4533 from vishesh/task/update-gitignore
Add some entries to `.gitignore`
2021-03-22 11:41:12 -07:00
Jingyu Zhou 0d30420e01
Merge pull request #4531 from sfc-gh-nwijetunga/fix_commit_proxy
Update Release Notes
2021-03-22 11:40:19 -07:00
Jon Fu a086d66a24 Merge branch 'master' of github.com:apple/foundationdb into jfu-check-test-conf-update 2021-03-22 14:31:12 -04:00
Jon Fu 711a21094b Factor out test config parameters into a single structure 2021-03-22 14:30:22 -04:00
Evan Tschannen bff7b9dcae
Merge pull request #4454 from vishesh/task/tlog-rf-old-tlog
status: Ignore LogSets with no tLogs when computing FT
2021-03-22 11:18:00 -07:00
Vishesh Yadav d6530c17c9
Merge pull request #4534 from jzhou77/master
Fix a race between configuration change and recovery
2021-03-22 11:10:44 -07:00
Xiaoge Su 6746bbaba7 Update the document per comments III 2021-03-22 10:36:45 -07:00
Jingyu Zhou 0c3bc09524 Remove the shuttingDown flag 2021-03-21 20:12:37 -07:00
Jingyu Zhou cb26576b95 Fix DD assertion failure
This fixes #4493, where DDTeamCollection::~DDTeamCollection creates new teams
that hold pointer to the DDTeamCollection, thus later causes assertion failure
because the memory is invalid.

The fix is to cancel teamBuilder at the begining of the ~DDTeamCollection.
2021-03-21 19:54:44 -07:00
Vishesh Yadav 308436c513 gitignore: Ignore emacs project files 2021-03-21 00:41:28 +00:00
Vishesh Yadav a8b940e1de gitignore: Add .cache directory to ignores 2021-03-21 00:38:34 +00:00
Jingyu Zhou b0fa735a27 Fix a race between configuration change and recovery
The problem is described in Issue #4376, where a configuration change can
occure before the database is fully recovered, thus triggering the assertion
failure.

Because of the configuration change, the master needs to do the recovery. So
the fix is to trigger the recovery when this happens.
2021-03-20 17:35:49 -07:00
Nim Wijetunga 9350ae3355 update release notes 2021-03-19 23:51:09 +00:00
Meng Xu 554667466a
Merge pull request #4528 from halfprice/zhewu/tlog-recruitment-failure-show-dc
Add targeting DC ids in the tlog recruitment event trace.
2021-03-19 14:38:04 -07:00
Zhe Wu 15f3699e22 Add targeting DC ids in the tlog recruitment event trace. 2021-03-19 14:10:38 -07:00