Commit Graph

17226 Commits

Author SHA1 Message Date
Sreenath Bodagala 852fc96200 Address simulation test failures caused by:
- Assertion failures in MoveKeys.actor.cpp
- Wrong results returned by getRange()

Changes:

DatabaseContext.h, NativeAPI.actor.[h,cpp]:
- Introduce a new flag, TransactionInfo::readVersionObtainedFromGrvProxy.
- Set this flag to true by default, and clear it when the read version of a
transaction is explicitly set (by using setVersion()).
- Modify getLatestCommitVersions() to not populate "latestCommitVersions" if
this flag is not set. (This will cause storage server to read at the specified
read version.)

- Modify getRange() actor to always use the specified version as the read
version (except when the specified version is latestVersion).

- Modify waitForCommittedVersion(), getRawVersion(), and getConsistentReadVersion()
to update local version vector cache after receiving GetReadVersionReply.

IClientApi.h, IConfigTransaction.h, ISingleThreadTransaction.h,
MultiVersionTransaction[.actor].[h,cpp], ThreadSafeTransaction.[h,cpp],
ApiWorkload.h:
- Add methods to get the spanID of a transaction and also the version vector
cached in a transaction. (Likely to be useful for debugging simulation test
failures.)

VersionVector.h:
- Update "maxVersion" when populating/applying a delta. (Note that empty
mutation messages only update VersionVector::maxVersion.)

BackupWorker.actor.cpp:
- Update local version vector cache after receiving GetReadVersionReply message.

Status.actor.cpp:
- Update local version vector cache and
TransactionInfo::info.readVersionObtainedFromGrvProxy after setting the
read version.
2021-09-16 12:00:26 -04:00
Mohamed Oulmahdi f83d97ee39 Enable documentation for Windows 2021-09-15 16:31:25 -06:00
Mohamed Oulmahdi 13e55f7b7a Format code 2021-09-15 16:30:58 -06:00
Mohamed Oulmahdi 5df51ee979 Add output for ignored Windows tests 2021-09-15 16:30:58 -06:00
Mohamed Oulmahdi 906f7cf876 Ignore fdbserver tests on Windows 2021-09-15 16:30:58 -06:00
Mohamed Oulmahdi e93f6e323a Fix test paths for on Windows 2021-09-15 16:30:58 -06:00
Mohamed Oulmahdi ce4bef2cec Allow / and - for fdbserver command line parameter values 2021-09-15 16:30:58 -06:00
Josh Slocum 5728c97fd0 fixing tss enablement with fault injections 2021-09-15 09:26:19 -06:00
Josh Slocum 6673540553 TSS Metrics fix 2021-09-14 13:15:05 -05:00
Chaoguang Lin e7d3516084 solve comments 2021-09-14 11:04:02 -07:00
Chaoguang Lin 6cca6b9e6f Refactor exclude command 2021-09-14 11:04:02 -07:00
Chaoguang Lin 1b3bae899b update comments 2021-09-14 11:04:02 -07:00
Chaoguang Lin ff54ba8626 Refactor coordinators and include command 2021-09-14 11:04:02 -07:00
Chaoguang Lin 5c5a5d249e Update auto_coordinators special key error message 2021-09-14 11:04:02 -07:00
A.J. Beamon 76ed965139 Switch from GO111MODULE=off to GO111MODULE=auto (to match what is on release-7.0 and what we ultimately decided on) 2021-09-14 09:44:17 -07:00
Hari Bhaskaran ee1056cacd Remove incorrect comment
As described in this comment, https://forums.foundationdb.org/t/questions-on-status-json/2843/3?u=harikb , removing the comment that will make reader think this is about RAM. No new comment is necessary since the key is already "disk"
2021-09-14 09:39:23 -07:00
Josh Slocum 5ac97154d5 Update documentation/sphinx/source/command-line-interface.rst
Co-authored-by: Xiaoxi Wang <xiaoxi.wang@snowflake.com>
2021-09-14 09:55:41 -05:00
Josh Slocum 23c690f0d3 Expanding documentation on storage_migration_type 2021-09-14 09:55:41 -05:00
Josh Slocum 9992a7b33f Added StorageMigrationType and cli commands 2021-09-14 09:55:41 -05:00
Neethu Haneesha Bingi 0fd4cc14d7 Disable rocksdb in simulation to unblock CI. 2021-09-13 16:17:44 -07:00
Chaoguang Lin 325a7881f4 Clang-format fdbserver/workloads/SpecialKeySpaceCorrectness.actor.cpp 2021-09-13 13:28:48 -07:00
Chaoguang Lin cb9dde358c Solve comments, refatctor the error handling part 2021-09-13 13:28:48 -07:00
Chaoguang Lin e81748e732 Fix all tr->get, hold the ThreadFuture for the memory 2021-09-13 13:28:48 -07:00
Chaoguang Lin 7e33e19feb Simplify the code using the function getSpecialKeysFailureErrorMessage 2021-09-13 13:28:48 -07:00
Chaoguang Lin 07ebc2013c Print the updated help message 2021-09-13 13:28:48 -07:00
Chaoguang Lin cfb9b56067 Refactor lock/unlock command, fix the related correctness test, add the documentation for updating usage of the special key 2021-09-13 13:28:48 -07:00
Lukas Joswiak 1dade88916 Add override 2021-09-13 12:28:17 -07:00
Lukas Joswiak 96bf4268eb Implement IClosable in OnDemandStore 2021-09-13 12:28:17 -07:00
Lukas Joswiak 95710f5f49 Add fix for KillWorker unit test
The fix here is essentially to add additional work to the unit test. The
problem seems to be that during setup, some initial work is being done
with the key value store the ConfigNode opens. The simulator seems to be
doing work in the background to make the key value store "durable", but
because the unit test ends so quickly, the simulation is interrupted
(the key value files get deleted after the unit test is finished).
2021-09-13 12:28:17 -07:00
sfc-gh-tclinkenbeard 8e523c5bae Fixed grv_proxy_failed error message 2021-09-12 17:33:25 -07:00
sfc-gh-tclinkenbeard 368e217adf Fixed commit_proxy_failed error message 2021-09-12 17:33:25 -07:00
sfc-gh-tclinkenbeard 27c08b04e5 s/subcription/subscription 2021-09-12 17:33:25 -07:00
Xiaoge Su c32c3b6ec4 fixup! Reformat the code per github's requirement 2021-09-12 14:17:19 -07:00
Xiaoge Su 40648dbb31 fixup! Update code per comment
Also fix the issue that TagPartitionedLogSystem.actor.cpp should include
TagPartitionedLogSystem.actor.h
2021-09-12 14:17:19 -07:00
Xiaoge Su 909a5ff73a Extract methods in LogSystemConfig.h to corresponding cpp file 2021-09-12 14:17:19 -07:00
Xiaoge Su 067c1cc55b Extract methods in LogSystem.h to corresponding cpp file 2021-09-12 14:17:19 -07:00
Xiaoge Su ecca4edeb4 Create TagPartitionedLogSystem.actor.h
TagPartitionedLogSystem.actor.h contains the struct of TagPartitionedLogSystem.
2021-09-12 14:17:19 -07:00
Kao Makino f7c7a31478 Disable clang-format on flow/aarch64/asmdefs.h 2021-09-10 15:33:40 -07:00
Neethu Haneesha Bingi 627ef2e739 Enable rocksdb storage in simulation with some simulation fixes. 2021-09-10 11:11:29 -07:00
Chaoguang Lin 9df392f447
Merge pull request #5528 from sfc-gh-clin/refactor-fdbcli
Refactor fdbcli, get rid of RYWTransaction, refactor status command
2021-09-09 10:31:34 -07:00
Dan Lambright 0e9ce5c6fc
Merge pull request #5549 from dlambrig/newstat
add per ss latency metrics for how vv code blocks waiting for data.
2021-09-09 12:47:22 -04:00
Dan Lambright d8d64ecc6f Add TODO 2021-09-09 12:47:00 -04:00
Lukas Joswiak 30e7469b19
Update fdbclient/MultiVersionTransaction.actor.cpp 2021-09-08 17:37:33 -07:00
Chaoguang Lin ab29bf05af Solve PR comments 2021-09-08 16:38:42 -07:00
Chaoguang Lin 8cc3f3f49d Code format 2021-09-08 10:56:32 -07:00
Chaoguang Lin 84a2672a33 Merge branch 'master' of github.com:apple/foundationdb into refactor-fdbcli 2021-09-08 10:42:59 -07:00
Chaoguang Lin 8cef044a8b Remove commented code; simplify code 2021-09-08 10:42:46 -07:00
Chaoguang Lin af5643c998 Fix the issue in CheckStatus where it stuck as we cannot talk to any of the coordinators 2021-09-08 10:05:13 -07:00
Dan Lambright ea748f3273 Add latency metrics for blocking peek 2021-09-08 09:50:01 -04:00
Meng Xu 52a2f56fe2
Merge pull request #5553 from apple/documentation_setuptoolz
put upper bound on setuptools version
2021-09-07 20:02:38 -07:00