Meng Xu
aa19da6977
TC:TraceAllInfo:Remove unused variable
...
Also change some code format in self review
2019-07-12 10:41:05 -07:00
Meng Xu
4da2071b49
ServerTeamRemover:Believe all servers are healthy when we start to remove
...
Before the serverTeamRemover tries to pick a team to remove,
it waits for all data movement to finish, which means all teams are healthy.
When the serverTeamRemover starts to pick a team to remove,
we believe all servers are healthy.
2019-07-11 23:47:31 -07:00
Meng Xu
cf935ff9e6
Remove debug message and format code
2019-07-11 22:05:20 -07:00
Meng Xu
cd28a0b604
Reenable check each server must have at least 1 team
2019-07-11 17:58:14 -07:00
Meng Xu
bb758c18ee
ServerTracker:Not always mark server undesired when no healthy team exists
...
A storage server is not desired to be colocated with tLogs.
So we want to mark the server as undesired.
However, if there is not enough process in the system, we will
have no choice but do so.
The old logic makes the server undesired if optimalTeamCount > 0;
However, there is a rare case when optimalTeamCount is 1 when it is supposed to be 0.
To overcome the situation, we add another condition healthyTeamCount > 0
as a guard to mark such a colocated server undesired.
2019-07-11 17:36:57 -07:00
Meng Xu
221e6945db
TeamTracker:Fix bug in counting optimalTeamCount
...
When a teamTracker is cancelled, e.g, by redundant teamRemover or badTeamRemover,
we should decrease the optimalTeamCount if the team is considered as an
optimal team, i.e., all members' machine fitness is no worse than unset, and
the team is healthy.
2019-07-11 17:22:41 -07:00
Meng Xu
4c32593f59
QuietDB:Do not check when machineId is not zoneID
2019-07-11 10:37:16 -07:00
Meng Xu
c6e42d6119
ReplicationPolicy:Add trace for the name of each keyIndex
2019-07-10 19:29:29 -07:00
Meng Xu
4fae510633
AddBestMachineTeams:BugFix:Must build team when it has remainingMachineTeamBudget
2019-07-10 11:55:06 -07:00
Meng Xu
9816fb6aca
ConsistencyCheck:Check minServerTeamOnServer larger than 0
2019-07-10 11:53:47 -07:00
Meng Xu
aa459a2b03
AddTeamsBestOf:Calculate minTeamNumPerServer before use it
2019-07-09 14:28:39 -07:00
Meng Xu
522230f050
ConsistencyCheck:getTeamCollectionValid tries 10 times before return false
...
Because serverTeamRemover takes time to remove teams,
getTeamCollectionValid() need to wait for a while before concluding that
the number of server teams is larger than the desired number.
2019-07-09 11:46:57 -07:00
Meng Xu
cf03b274a2
TeamTracker:Add traceTeamCollectionInfo
2019-07-08 23:01:25 -07:00
Meng Xu
bf8af985b9
ServerTeamRemover: Change unit test to include the remover
...
Also further speed up serverTeamRemover in simulation, and
Add comments
2019-07-08 20:12:16 -07:00
Meng Xu
3b9618fe11
ServerTeamRemover:Speedup removing teams in simulation
...
Otherwise, simulation may time out when team remover needs to
remove hundreds of teams.
2019-07-08 18:17:21 -07:00
Meng Xu
08d76a7bbe
ServerTeamRemover:Bug fix and clang-format
2019-07-08 17:08:32 -07:00
Meng Xu
9cc11e88c5
TeamBuilder:Reduce unnecessary calculation of remainingTeamBudget
2019-07-08 16:56:06 -07:00
Meng Xu
874539149a
ServerTeamRemover: Resolve review comments
...
Pick the team whose minimum team number of a server is the largest one to remove.
AddTeamsBestOf should keep building teams until each server has at least the
target number of teams.
2019-07-08 16:40:37 -07:00
Meng Xu
08a721b320
Merge branch 'master' into mengxu/server-team-remover-PR
2019-07-08 16:30:32 -07:00
Evan Tschannen
7f427b60e2
Merge pull request #1807 from etschannen/master
...
Merge 6.1 into master
2019-07-08 09:05:03 -07:00
Evan Tschannen
e4193b125b
Merge branch 'master' of github.com:apple/foundationdb
2019-07-08 09:04:02 -07:00
Evan Tschannen
ec11ef024b
Merge pull request #1798 from ajbeamon/merge-release-6.1-into-master
...
Merge release 6.1 into master
2019-07-08 09:02:56 -07:00
A.J. Beamon
dd85edb08c
Merge pull request #1802 from xumengpanda/mengxu/DD-ensure-redundant-team-priority-as700-PR
...
TeamTracker:Set redundant team priority as PRIORITY_TEAM_REDUNDANT
2019-07-08 08:47:28 -07:00
Evan Tschannen
b146da0dd1
Merge branch 'release-6.1'
...
# Conflicts:
# documentation/sphinx/source/release-notes.rst
# fdbserver/DataDistribution.actor.cpp
# versions.target
2019-07-07 20:54:59 -07:00
Evan Tschannen
b7e762bd25
pull from master
2019-07-07 20:50:57 -07:00
Evan Tschannen
6ca3ca7944
Merge pull request #1806 from etschannen/post-release-cleanup-6.1.11
...
Post release cleanup 6.1.11
2019-07-07 20:49:14 -07:00
Evan Tschannen
f80279d8c4
update installer WIX GUID following release
2019-07-07 20:48:22 -07:00
Evan Tschannen
f840d40e05
update versions target to 6.1.12
2019-07-07 20:48:22 -07:00
Vishesh Yadav
8d3a826c63
Merge pull request #1804 from alexmiller-apple/cycle-verify-only
...
Add a checkOnly parameter to Cycle workload.
2019-07-05 21:59:52 -07:00
Jingyu Zhou
50e7593c5b
Merge pull request #1796 from ajbeamon/remove-trace-event-underscores
...
Remove trace event underscores
2019-07-05 21:45:55 -07:00
Alex Miller
14e5dd74fe
Add a checkOnly parameter to Cycle workload.
...
So that it can be used in the real world for consistency checking of
backup and DR.
2019-07-05 19:09:09 -07:00
Evan Tschannen
310a5fe9a3
fix: we cannot reject 100% of requests, because a storage server which is stuck needs to get a future version error to trigger an all alternatives failed message from load balance so that clients will re-grab storage server interfaces from the proxy
2019-07-05 17:28:22 -07:00
Meng Xu
e8fb7564f5
Merge branch 'master' into mengxu/DD-ensure-redundant-team-priority-as700-PR
2019-07-05 17:28:12 -07:00
Meng Xu
c7a996267c
TeamRemover: Remove unused declaration
...
Also change state variable to variable.
2019-07-05 16:54:06 -07:00
Evan Tschannen
e7c0ecf729
fix: we cannot reject 100% of requests, because a storage server which is stuck needs to get a future version error to trigger an all alternatives failed message from load balance so that clients will re-grab storage server interfaces from the proxy
2019-07-05 15:46:16 -07:00
Meng Xu
46d28a3b79
TeamTracker:Set redundant team priority as redundant
...
The redundant team removed by teamRemover will not exist
in the global teams data structure. So we will not find
the redundant team from shard-to-team mapping in the system key.
Before this change, teamTracker marks such team as PRIORITY_TEAM_UNHEALTHY.
With this change, it marks it as PRIORITY_TEAM_REDUNDANT
2019-07-05 15:24:00 -07:00
Andrew Noyes
6d74af93d3
Use true instead of 1
2019-07-05 14:07:02 -07:00
Andrew Noyes
15c6f2b864
Explain SFINAE for has_serialization_done
2019-07-05 14:07:02 -07:00
Andrew Noyes
9ed8eb2cdb
Explain strange use of literal byte strings
2019-07-05 14:07:02 -07:00
Andrew Noyes
7350b3db30
Don't assume serializeReplicationPolicy succeeds
2019-07-05 14:07:02 -07:00
Andrew Noyes
889e153b81
Add object serializer flag to fdbcli
2019-07-05 14:07:02 -07:00
Andrew Noyes
e2ed56fa56
Convert ownedPtr to unownedPtr for IReplicationPolicy
...
Remove WriteRawMemory feature
Remove deserialization_done
2019-07-05 14:07:02 -07:00
Andrew Noyes
9894d928a1
Re-use identical vtables
2019-07-05 14:07:02 -07:00
Andrew Noyes
4c5ebd7609
Avoid assert when collecting vtables
2019-07-05 14:07:02 -07:00
A.J. Beamon
d06b961a4a
Merge pull request #1747 from alexmiller-apple/flowlock-api
...
A giant translation of TaskFooPriority -> TaskPriority::Foo
2019-07-05 14:06:14 -07:00
A.J. Beamon
2a56e011ea
Merge branch 'release-6.1' into merge-release-6.1-into-master
...
# Conflicts:
# documentation/sphinx/source/release-notes.rst
# fdbserver/DataDistribution.actor.cpp
2019-07-05 13:52:29 -07:00
Meng Xu
7ba6cd2d9d
ServerTeamRemover:Reduce the overshot server team number to build
...
Each server has the maximum of DESIRED_TEAMS_PER_SERVER and
(DESIRED_TEAMS_PER_SERVER * storageTeamSize) / 2)
2019-07-05 11:01:50 -07:00
A.J. Beamon
9f4b6fd770
Remove additional underscores
2019-07-05 08:12:25 -07:00
A.J. Beamon
a3ac9c7eea
Remove underscores from some trace event names
2019-07-05 08:08:29 -07:00
Alex Miller
888f4f92e0
Fix errors and TaskPriority more priorities.
2019-07-03 21:03:58 -07:00