Commit Graph

15245 Commits

Author SHA1 Message Date
Lukas Joswiak 1c1125c5c0
Merge pull request #23 from sfc-gh-ljoswiak/fixes/gcc
Fix gcc build
2021-05-02 17:41:57 -07:00
Lukas Joswiak f275fd3c32 Fix gcc compilation 2021-05-02 17:27:18 -07:00
Lukas Joswiak 8dcd779fc4
Merge branch 'master' into features/actor-lineage 2021-05-02 14:11:42 -07:00
Markus Pilman 20ab65a0b1
Merge pull request #22 from sfc-gh-ljoswiak/fixes/fix-simulation
Fixes/fix simulation
2021-05-02 14:25:36 -06:00
Lukas Joswiak c016e154a7 Remove global config fdbserver fix
This is causing problems with the 5.2.0 restarting test. Removing this
line disables fdbserver processes from receiving global config updates,
instead requiring a restart to see them.
2021-05-02 11:03:07 -07:00
Lukas Joswiak 637699be32 Fix issue with fdbserver not receiving global config change
notifications
2021-05-01 21:41:10 -07:00
Lukas Joswiak cf4218dfd1 Fixes simulation failures
Fixes the following issues:

1. Use the right index when initializing the WriteOnlySet's vector of
   atomics. Also switch to std::atomic_init to initialize each atomic in
   the vector (cannot default construct the atomics in the vector
   because std::atomic does not have a copy constructor).
2. Add failure check for when items cannot be inserted into the
   WriteOnlySet due to capacity constraints. This situation occurs when
   `copy` is not called on the WriteOnlySet, such as when sampling is
   disabled. The `copy` function is what clears the WriteOnlySet.
3. Remove a global config feature I added to update the ClientDBInfo
   object used by the global config listener function. This needs more
   investigation, but the effect of this change could be that global
   config changes are not correctly recognized on fdbserver processes.
4. Add various ASSERTs to verify data in WriteOnlySet.
2021-05-01 15:26:28 -07:00
A.J. Beamon e6300905d6
Merge pull request #4733 from sfc-gh-ajbeamon/fix-mvc-thread-future-cancellation
Fix: explicitly cancel MVC thread futures for version monitors
2021-04-30 16:05:17 -07:00
sbodagala f7e28c50d4
Merge pull request #4735 from sbodagala/master
Expose CommitBatchingWindowSize metric to fdbcli status
2021-04-30 15:52:29 -04:00
A.J. Beamon ab3f96f16d Fix: simulation doesn't have a protocol version monitor and can't cancel it. 2021-04-30 11:56:35 -07:00
A.J. Beamon eaf1e0f64e Be more defensive with cancellation by not capturing the this pointer in lambdas, instead capturing a full Reference. 2021-04-30 11:11:02 -07:00
A.J. Beamon cb3d2bfec7 Add cancellation of the protocol monitor when the database is destroyed. Avoid using any state when cancelled. Fix race between setting up the protocol version monitor and destroying the database. 2021-04-30 10:35:44 -07:00
Renxuan Wang 652c5c4e84
Merge pull request #4668 from RenxuanW/worker
Improve logging on worker joining cluster
2021-04-30 10:24:02 -07:00
A.J. Beamon f61f13a0ba Explicitly cancel thread futures for the protocol version monitors in MVC 2021-04-29 22:02:38 -07:00
Steve Atherton fbd59d310a
Merge pull request #4725 from RenxuanW/firstConsistentVersion-fix
Fix the logic of getting firstConsistentVersion.
2021-04-29 18:04:57 -07:00
RenxuanW 5e045bd21c Move the read of logsOnly and inconsistentSnapshotOnly to a loop where other RestoreConfig vars are fetched. 2021-04-29 17:00:34 -07:00
Sreenath Bodagala f151df3203 Expose CommitBatchingWindowSize metric to fdbcli status
Changes:

Schemas.cpp:
- Extend JSON schema to include aggregated information about
CommitBatchingWindowSize samples.

Status.actor.cpp:
- Extend getStorageServersAndMetrics() to gather metrics about
CommitBatchingWindowSize.
- Extend CommitProxy AddRole() to populate the status-JSON object
with the metrics about CommitBatchingWindowSize.
2021-04-29 22:11:09 +00:00
Andrew Noyes fecb10b94b
Merge pull request #4731 from sfc-gh-anoyes/anoyes/fix-install-data-dir
Fix the data dir for DEB and EL7 to be /usr/lib/foundationdb/data
2021-04-29 15:03:36 -07:00
Andrew Noyes 41e0eac450 Fix the data dir for DEB and EL7 to be /usr/lib/foundationdb/data
Also remove the unused legacy mapping for install dirs
2021-04-29 21:25:55 +00:00
Markus Pilman 5c1279ceb7 make actorlineage inherit from threadsaferefcounted 2021-04-29 15:23:46 -06:00
Markus Pilman e616545949 use std::atomic for threadsaferefcounted 2021-04-29 15:23:33 -06:00
RenxuanW 44197644be Reset transaction after a commit and before start a read. 2021-04-29 12:19:58 -07:00
Chaoguang Lin 283b774c2f Merge branch 'master' of github.com:apple/foundationdb into refactor-fdbcli 2021-04-29 12:04:54 -07:00
Markus Pilman 7ab6fedb5b fix refcounting in WriteOnlySet 2021-04-29 11:34:42 -06:00
Russell Sears ccee778753
Merge pull request #4683 from Mythra/mythra/4588/stderr
fdbcli prints error on TLS File not found
2021-04-28 17:13:03 -07:00
Russell Sears 5fed5640d3
Merge pull request #4718 from sears/build-k8s-images
Build k8s images
2021-04-28 17:09:38 -07:00
Evan Tschannen a1436406b7 fix compile error 2021-04-28 16:27:48 -07:00
Evan Tschannen 709df795c0 Added a new option to bypass unreadable protection in read your writes for calls to get 2021-04-28 16:22:34 -07:00
Lukas Joswiak 539a419f29
Merge pull request #19 from sfc-gh-mpilman/features/actor-lineage-fluentd
fix special keyspace register
2021-04-28 15:43:51 -07:00
Markus Pilman aa25f48223
Merge pull request #20 from sfc-gh-ljoswiak/fixes/pointer-check
Check validity of ActorLineage
2021-04-28 16:42:43 -06:00
Lukas Joswiak 045d20ab7a Check validity of ActorLineage 2021-04-28 15:40:13 -07:00
Markus Pilman f513543305 fix special keyspace register 2021-04-28 16:35:09 -06:00
Lukas Joswiak 7d308c7199
Merge pull request #18 from sfc-gh-mpilman/features/actor-lineage-fluentd
add default constructor to Sample
2021-04-28 15:04:36 -07:00
Markus Pilman b256c6822d add default constructor to Sample 2021-04-28 15:44:06 -06:00
Lukas Joswiak 1c62a9209c
Merge pull request #17 from sfc-gh-mpilman/features/actor-lineage-fluentd
FluentD ingest
2021-04-28 14:25:50 -07:00
Andrew Noyes 904a39e473
Merge pull request #4667 from sfc-gh-ajbeamon/feature-mvc-monitor-protocol-version
Use fewer connections in the multi-version client
2021-04-28 14:13:17 -07:00
Markus Pilman 32ee206675 delete copy constructor of Sample 2021-04-28 14:11:09 -06:00
Markus Pilman d946e90d75 Use new Sample interface 2021-04-28 14:10:45 -06:00
Evan Tschannen 65fcf4014e Fix: simulation could still stall writes for 10 seconds even when speedUpSimulation was on
Fix: disable connection failures in simulation when there are too many generations outstanding
2021-04-28 12:41:48 -07:00
Evan Tschannen 54ed5de648
Merge pull request #4561 from sfc-gh-ajbeamon/load-balance-remove-make-request-actor
Improve load balancing performance
2021-04-28 11:52:03 -07:00
A.J. Beamon 7158bfa82e Merge branch 'master' into load-balance-remove-make-request-actor 2021-04-28 10:31:41 -07:00
A.J. Beamon 135cc9c69a Make parameter const& 2021-04-28 10:30:30 -07:00
Markus Pilman 05dba91dd4 fix OPEN_FOR_IDE 2021-04-28 10:36:41 -06:00
Markus Pilman 868ec17223 Merge remote-tracking branch 'sfc/features/actor-lineage' into features/actor-lineage-fluentd 2021-04-28 10:27:28 -06:00
Markus Pilman 3400ab5b36
Merge pull request #15 from sfc-gh-ljoswiak/features/actor-lineage-interface
Add API to read samples from worker
2021-04-28 10:26:22 -06:00
A.J. Beamon 8eb78fd317
Merge pull request #4714 from sfc-gh-anoyes/anoyes/more-thread-safety-ctest
Add /fdbclient/multiversionclient/ to ctest, and fix thread safety
2021-04-28 08:54:16 -07:00
Markus Pilman f5b0008346 Merge branch 'features/actor-lineage' into features/actor-lineage-fluentd 2021-04-28 09:31:20 -06:00
Markus Pilman 6f71a811b6 fix memory leak 2021-04-28 09:27:11 -06:00
Markus Pilman 0ee0b8a76f
Fixed typo
Co-authored-by: Lukas Joswiak <lukas.joswiak@snowflake.com>
2021-04-28 09:25:28 -06:00
Markus Pilman e2b8a2734b
Fix typo
Co-authored-by: Lukas Joswiak <lukas.joswiak@snowflake.com>
2021-04-28 09:24:58 -06:00