Commit Graph

8159 Commits

Author SHA1 Message Date
Zhe Wu 9da735c38e Batch empty peek reply 2022-02-16 15:28:56 -08:00
sfc-gh-tclinkenbeard 32bbabefd7 Merge remote-tracking branch 'origin/main' into dd-refactor 2022-02-15 14:11:30 -08:00
Bharadwaj V.R 39e7e4cdaa
Merge branch 'apple:main' into dd-utest 2022-02-14 19:01:28 -08:00
Vaidas Gasiunas 092b5cee4b MVC2.0: Rollback added code 2022-02-14 13:50:42 -08:00
Bharadwaj V.R eaef2a373e Remove superfluous wait statements in DD unit tests. They wait on the getTeam future 2022-02-14 10:11:00 -08:00
Bharadwaj V.R a14377641c Renamed a couple of test-only collection methods and make the test case waits more succinct 2022-02-13 23:53:12 -08:00
sfc-gh-tclinkenbeard e77b70c508 Encapsulate TCMachineTeamInfo fields 2022-02-12 15:50:51 -08:00
sfc-gh-tclinkenbeard 51afe403d1 Encapsulate TCMachineTeamInfo::id field 2022-02-11 22:56:16 -08:00
sfc-gh-tclinkenbeard a958fd2fbc Encapsulate TCServerInfo::serverMetrics 2022-02-11 22:05:57 -08:00
sfc-gh-tclinkenbeard 62dbd29ddc Remove unnecessary whitespace 2022-02-11 21:47:36 -08:00
sfc-gh-tclinkenbeard 10f40294a3 Encapsulate TCServerInfo::teams field 2022-02-11 21:44:28 -08:00
sfc-gh-tclinkenbeard 45f68c7db7 Add TCServerInfo::removeTeamsContainingServer method 2022-02-11 21:29:52 -08:00
sfc-gh-tclinkenbeard 5bfb2669a2 Add TCServerInfo::removeTeam method 2022-02-11 21:05:45 -08:00
sfc-gh-tclinkenbeard 3959ee6c27 Encapsulate TCServerInfo::dataInFlightToServer 2022-02-11 19:41:04 -08:00
sfc-gh-tclinkenbeard 0fe4dcf469 Make several more TCServerInfo fields private 2022-02-11 19:41:04 -08:00
sfc-gh-tclinkenbeard 4aa5a329ac Encapsulate TCServerInfo::collection and TCServerInfo::tracker 2022-02-11 19:41:04 -08:00
sfc-gh-tclinkenbeard 711462dfd7 Encapsulate TCServerInfo::inDesiredDC 2022-02-11 19:41:04 -08:00
Bharadwaj V.R c3bb248d61 Adapt to members of DDCollection class that were accessed directly in test cases becoming private 2022-02-11 13:56:00 -08:00
Bharadwaj V.R 36c5d3a1e6
Merge branch 'main' into dd-utest 2022-02-11 12:25:31 -08:00
Trevor Clinkenbeard b8d8eafdec
Merge pull request #6379 from sfc-gh-tclinkenbeard/dd-refactor
Shrink public interface of `DDTeamCollection`
2022-02-11 11:44:15 -08:00
sfc-gh-tclinkenbeard 9158564bfc Fix formatting 2022-02-11 10:27:41 -08:00
sfc-gh-tclinkenbeard 3f8c1e2e69 Encapsulate TCServerInfo::id 2022-02-10 23:04:25 -08:00
Bharadwaj V.R faf74b2563 Removed some trace statements that were accidentally left behind in the code 2022-02-10 22:23:03 -08:00
Trevor Clinkenbeard ef68e6fe0d
Merge pull request #6353 from sfc-gh-ljoswiak/fixes/dynamic-knobs
Fix dynamic knobs correctness issues
2022-02-10 22:13:02 -08:00
Bharadwaj V.R 41bd39a82a Fix code formatting 2022-02-10 22:10:50 -08:00
Bharadwaj V.R b306288c62
Merge branch 'main' into dd-utest 2022-02-10 22:00:52 -08:00
Bharadwaj V.R df2f5c5709 Make UT parameters sensitive to server-knobs 2022-02-10 21:52:30 -08:00
Bharadwaj V.R 83b7f1fcbf Add test descriptions for DD unit tests 2022-02-10 19:29:34 -08:00
sfc-gh-tclinkenbeard 6e87c01404 Move implementations of TC*Info methods to TCInfo.actor.cpp 2022-02-10 19:19:50 -08:00
Bharadwaj V.R 7790d57c06 Mask the use of the delay in getTeam and the buildTeams path in the DD unit test
delay doesn't work as expected in the UT envionment
2022-02-10 18:52:40 -08:00
sfc-gh-tclinkenbeard 2165635478 Make printSnapshotTeamsInfo a static function of DDTeamCollection 2022-02-10 18:45:52 -08:00
sfc-gh-tclinkenbeard 9bc38ae73e Make DDTeamCollection::distributorId private 2022-02-10 18:26:06 -08:00
sfc-gh-tclinkenbeard 14c8483e9d Mark DDTeamCollection::primary private 2022-02-10 18:16:57 -08:00
sfc-gh-tclinkenbeard 8e7963172b Mark DDTeamCollection::excludedServers private 2022-02-10 17:58:59 -08:00
sfc-gh-tclinkenbeard 7ba250a991 Fix -Wreorder-ctor warnings 2022-02-10 17:54:57 -08:00
sfc-gh-tclinkenbeard 1f64477938 Make more DDTeamCollection fields private 2022-02-10 17:44:49 -08:00
sfc-gh-tclinkenbeard 6e60e26730 Make some DDTeamCollection fields private 2022-02-10 16:48:26 -08:00
sfc-gh-tclinkenbeard 641a38bd0b Make more DDTeamCollection methods private.
The methods only used by DDTeamCollection::run can now be made private.
2022-02-10 16:19:32 -08:00
sfc-gh-tclinkenbeard c4508330d2 Make dataDistributionTeamCollection a static function of DDTeamCollection 2022-02-10 16:19:32 -08:00
sfc-gh-tclinkenbeard 5477012ad8 Change DDTeamCollection method signatures to accept references.
Passing nullptr to these methods is invalid, but previously the
signature didn't indicate this. We previously needed to pass pointers
due to actor compiler restrictions, but these restrictions no longer
apply.
2022-02-10 16:19:32 -08:00
sfc-gh-tclinkenbeard b51944b262 Pass constant reference to DDTeamCollection::isCorrectDC 2022-02-10 16:19:32 -08:00
sfc-gh-tclinkenbeard c024fbe845 Mark DDTeamCollection::waitUntilHealthy const 2022-02-10 16:19:32 -08:00
Trevor Clinkenbeard f7118ad406
Merge pull request #6371 from sfc-gh-tclinkenbeard/dd-refactor
Move `DDTeamCollection` method implementations into `.cpp` file
2022-02-10 15:03:01 -08:00
Zhe Wang d684508540 Add RatekeeperLimitReasonDetails traceevent for RK 2022-02-10 13:59:47 -08:00
sfc-gh-tclinkenbeard 0dce252c92 Make many DDTeamCollection methods private 2022-02-10 13:44:39 -08:00
sfc-gh-tclinkenbeard 36700791a1 Use structured bindings in some for loops in DDTeamCollection.actor.cpp 2022-02-10 12:10:45 -08:00
sfc-gh-tclinkenbeard 3141698c41 Use special ASSERT_* macros for numeric comparison in data distribution
code.

This helps debugging by printing the exact input values when an
assertion fails.
2022-02-10 11:59:19 -08:00
sfc-gh-tclinkenbeard 975b9f3b32 Remove get helper function from DataDistribution.actor.cpp 2022-02-10 11:32:33 -08:00
sfc-gh-tclinkenbeard f16aa56d4c Fix comment grammar 2022-02-10 11:26:39 -08:00
sfc-gh-tclinkenbeard b5cefdbcc2 Mark DDTeamCollection methods const 2022-02-10 11:26:04 -08:00