Commit Graph

83 Commits

Author SHA1 Message Date
Andrew Noyes cbadccaad5 Reject preprocessor directives in ACTORs 2022-01-14 11:37:29 -08:00
Andrew Noyes fd33d31ff5 Enable -Wdelete-non-virtual-dtor for clang build
We had been disabling -Wdelete-non-virtual-dtor, because this seems to be done intentionally in the generated code of the actor compiler. I spent some time trying to rewrite it in a way that doesn't literally delete/destroy through a pointer to a base class without a virtual destructor, but I was unable to come up with something that passes correctness. My best guess is that we do this so that we can destroy actor state classes, call callbacks registered on the actor SAV, and then destroy the SAV.

Anyway now we'll detect new usages of deleting through a pointer to a base class without a virtual destructor.
2021-12-20 16:19:31 -08:00
A.J. Beamon aebd12a9aa
Fix indentation issue with actor compiler (#5828) 2021-10-25 10:36:37 -07:00
Xiaoxi Wang 09342f43ea fix spelling error 2021-08-19 13:55:30 -07:00
Lukas Joswiak 5dc9a97230 Merge branch 'master' into fixes/alp6 2021-08-01 20:42:52 -07:00
Lukas Joswiak e9a1679467 Disable sampling everywhere except fdbserver 2021-07-27 09:53:23 -07:00
Lukas Joswiak dcaf1c1c38 Enable sampling on fdbserver only 2021-07-22 12:47:35 -07:00
sfc-gh-tclinkenbeard e62e6503ac Fix most delete-non-virtual-dtor clang warnings 2021-07-21 23:32:44 -07:00
Lukas Joswiak 65e3ead37e Cleanup 2021-06-21 10:59:15 -07:00
Lukas Joswiak 805c4200ce Add collector to get running actor name 2021-06-16 18:08:51 -07:00
Lukas Joswiak 6041d7e201 Remove stack lineage 2021-06-15 15:18:52 -07:00
Lukas Joswiak 250d20e7bf Even more cleanup 2021-06-15 15:17:54 -07:00
Lukas Joswiak eb3fb811d4 Cleanup 2021-06-15 15:03:44 -07:00
Lukas Joswiak 0ff041222a Add removals back 2021-06-13 18:23:59 -07:00
Lukas Joswiak 112be7a763 Remove most work 2021-06-13 16:19:02 -07:00
Lukas Joswiak 23f4aec641 Remove bad line 2021-06-12 22:38:22 -07:00
Lukas Joswiak cbc42389ab Add stacks back 2021-06-11 14:34:12 -07:00
Lukas Joswiak 0301072690 Refactor 2021-06-11 13:01:32 -07:00
Lukas Joswiak e9fdbb9c86 Enable sampling 2021-06-07 18:01:14 -07:00
Lukas Joswiak 7d56038e5e Remove restore_lineage 2021-06-04 16:38:12 -07:00
Lukas Joswiak 486a04659f Lazy inititialization 2021-06-04 15:01:18 -07:00
Lukas Joswiak ca79b8eaab Various ALP fixes 2021-06-04 15:01:18 -07:00
Lukas Joswiak 153de33f57 Revert "Merge pull request #4802 from sfc-gh-ljoswiak/revert/actor-lineage"
This reverts commit 6499fa178e, reversing
changes made to 1512631957.
2021-06-04 13:31:55 -07:00
Lukas Joswiak 4ea760b2a9 Revert "Merge pull request #4136 from sfc-gh-mpilman/features/actor-lineage"
This reverts commit da41534618, reversing
changes made to e6300905d6.
2021-05-10 20:26:12 -07:00
Markus Pilman 7307750e5e Merge remote-tracking branch 'origin/master' into features/actor-lineage 2021-04-19 11:29:52 -06:00
Steve Atherton b4e42476b7 Unit test parameters are no longer global, they are accessible via a parameter to the unit test and initialized from otherwise unconsumed test options for the UnitTests workload in the test spec or from the fdbserver command line when using the unittests role. 2021-04-06 02:36:10 -07:00
Markus Pilman eb036b7b02 Merge remote-tracking branch 'origin/master' into features/actor-lineage 2021-03-17 11:59:54 -06:00
Markus Pilman 945d0246cd add actor stacktrace feature 2020-12-09 13:28:15 -07:00
sfc-gh-tclinkenbeard d15441e85c Replace non-standard sealed with final 2020-12-08 09:09:30 -08:00
Markus Pilman 05f77f905f Added actor lineage 2020-12-07 15:15:25 -07:00
Daniel Smith a88bbd6405 s/fake/declval/ 2020-07-15 23:33:01 +00:00
A.J. Beamon b09dddc07e Merge branch 'release-6.2' into merge-release-6.2-into-release-6.3
# Conflicts:
#	cmake/ConfigureCompiler.cmake
#	documentation/sphinx/source/downloads.rst
#	fdbrpc/FlowTransport.actor.cpp
#	fdbrpc/fdbrpc.vcxproj
#	fdbserver/DataDistributionQueue.actor.cpp
#	fdbserver/Knobs.cpp
#	fdbserver/Knobs.h
#	fdbserver/LogSystemPeekCursor.actor.cpp
#	fdbserver/MasterProxyServer.actor.cpp
#	fdbserver/Status.actor.cpp
#	fdbserver/storageserver.actor.cpp
#	flow/flow.vcxproj
2020-07-10 15:06:34 -07:00
Andrew Noyes 42159ccfe0 Add -Wpessimizing-move and -Wredundant-move for clang 2020-06-22 23:45:03 +00:00
tclinken 885a2e020e Generate rvalue reference overloads with actor compiler 2020-04-21 15:18:59 -07:00
Steve Atherton 022b77e288 Actor compiler will std::move() return expressions that exactly match a state variable. 2020-04-20 04:19:33 -07:00
Alex Miller 2e53c8c5e2
Merge pull request #2915 from tclinken/move-optimizations
Avoid unnecessary copies in PromiseStream
2020-04-13 21:15:16 -07:00
tclinken 3a01d24970 Pass const ref to a_callback_fire 2020-04-08 14:50:41 -07:00
Markus Pilman d4542dbb5a Delete old build system 2020-04-07 11:03:45 -07:00
Andrew Noyes 36fd1ec0e4 Add sealed as a valid class-virt-specifier 2019-09-12 10:53:17 -07:00
Andrew Noyes 703e7fd944 Put generated code back in anonymous namespace where possible 2019-09-11 16:30:37 -07:00
Andrew Noyes f983b3c786 Remove stale comment 2019-09-10 14:29:16 -07:00
Andrew Noyes 9d531db985 Handle nested classes 2019-09-10 13:25:58 -07:00
Andrew Noyes c487f021f0 WIP - seems to work for 1 level of nesting 2019-09-10 13:09:37 -07:00
Andrew Noyes eeb2da5c9d WIP - simple example compiles 2019-09-09 22:56:19 -07:00
Andrew Noyes 0a1fecfc2e Update flow/actorcompiler/ActorParser.cs
Co-Authored-By: A.J. Beamon <ajbeamon@users.noreply.github.com>
2019-08-16 09:24:57 -07:00
Andrew Noyes 356abc2f9a Update flow/actorcompiler/ParseTree.cs
Co-Authored-By: A.J. Beamon <ajbeamon@users.noreply.github.com>
2019-08-16 09:24:57 -07:00
Andrew Noyes ad9bc06dd7 Make unknown flow attributes an error 2019-08-16 09:24:57 -07:00
Andrew Noyes 5751e8a95b Remove flow_* attributes in actor compiler 2019-08-16 09:24:57 -07:00
Andrew Noyes e4de4783bf Add [[flow_allow_discard]] 2019-08-16 09:24:57 -07:00
Andrew Noyes 971b857c51 Avoid using new c sharp features 2019-08-16 09:24:57 -07:00