Commit Graph

10032 Commits

Author SHA1 Message Date
Vishesh Yadav 8c9a646744 go: Don't complain about unsafe pointer conversion in stringRefToSlice
Running Go bindings with `-race` argument will enable instrumentation to check
pointer conversions, and complain about potential unsafe conversion in
`stringRefToSlice`.

This patch adds annotation `go:nocheckptr` annotation to skip that check, since
our conversion is safe, and can let users take advantage of check for their code
without this false positive.

It will be useful to check if, we can potentially rewrite this code to obey Go
pointer conversion rules.

FIXES #2843

Signed-off-by: Vishesh Yadav <vishesh_yadav@apple.com>
2020-04-26 22:06:57 -07:00
Vishesh Yadav ecb1d9b8c6 go: Subspace doesn't have to inherit fmt.Stringer
Go does duck-typing, so any `struct` can choose to implement String()
and it will automatically be Stringer(). There is no need to enforce in
out interface.
2020-04-26 20:44:23 -07:00
Vishesh Yadav 22fa93264f go: Implment Stringer interface for DirectorySubspace 2020-04-26 20:31:49 -07:00
Vishesh Yadav e592901551 go: Rename Subspace member `b` to `rawPrefix`
Naming stays consistent with other Python/Java.
2020-04-26 19:28:47 -07:00
Vishesh Yadav 642840a3f4 go: Update tuple/subspace String() to output readable strings 2020-04-26 19:26:33 -07:00
Pieter Joost 2a61823106 iimplement fmt.Stringer interface on Subspace 2020-04-26 19:26:33 -07:00
Pieter Joost 16f3a2480b implement fmt.Stringer interface on Tuple 2020-04-26 19:26:33 -07:00
Andrew Noyes 110edc7453 Fix build on gcc9 2020-04-26 20:53:41 +00:00
Andrew Noyes 0a8474e995 Install /var/lib/foundationdb/data
This is what the old buildrpms.sh and builddebs.sh seemed to do
2020-04-26 20:53:41 +00:00
Evan Tschannen cdeed25f63
Merge pull request #2996 from satherton/feature-redwood
Update Redwood
2020-04-26 11:05:24 -07:00
Andrew Noyes fee9a5117f Don't config TLS if OpenSSL is missing OPENSSL_INIT_NO_ATEXIT 2020-04-25 17:59:17 -07:00
tclinken d654f75c46 Move instead of copy in VectorRef::reallocate 2020-04-25 12:24:06 -07:00
Steve Atherton cd95c8e191
Merge pull request #3024 from atn34/atn34/reserve
Avoid some unnecessary copies in generic actors
2020-04-24 18:19:04 -07:00
Steve Atherton a345e4b7fe
Merge pull request #3003 from atn34/atn34/fix-incr-compilation
Depend on actorcompiler.exe
2020-04-24 18:09:21 -07:00
Alvin Moore 72ecc02224
Merge pull request #3013 from mpilman/features/cmake-and-docker-improvements
Features/cmake and docker improvements
2020-04-24 15:32:50 -07:00
Steve Atherton dda0993d16 Apply clang-format to Redwood source. 2020-04-24 14:12:40 -07:00
Meng Xu ee5051792a Add BUGGIFY back to DESIRED_TEAMS_PER_SERVER knob
Kudos to A.J. who found this bug.
2020-04-24 12:54:31 -07:00
Andrew Noyes 2daf228e10 Avoid some unnecessary copies 2020-04-24 12:21:35 -07:00
Evan Tschannen 3fb91e8f0c
Merge pull request #3016 from etschannen/master
Merge release 6.2 into master
2020-04-23 15:44:47 -07:00
Vishesh Yadav ed0032fa2c
Merge pull request #3019 from xumengpanda/mengxu/backup-rm-check-PR
Remove sanity check on backup metadata file
2020-04-23 15:38:55 -07:00
tclinken 0efce542c8 Removed outdated comments 2020-04-23 15:27:11 -07:00
Steve Atherton 93e9360d2f Merge branch 'master' of github.com:apple/foundationdb into feature-redwood 2020-04-23 15:10:08 -07:00
Meng Xu 59217ddf1e Remove sanity check on metadata
The sanity check parses each range file to get the key range of each
range file.
The parsing incurs restore_unsupported_file_version error.

We need to include this sanity check before 6.3 release.
2020-04-23 14:59:58 -07:00
Meng Xu ec437807e1
Merge pull request #3007 from jzhou77/backup-progress
Add design doc for the new backup system
2020-04-23 14:39:31 -07:00
Markus Pilman e870925b80 fixed documentation for USE_LD 2020-04-23 14:37:20 -07:00
Meng Xu 9ea173ecc1
Merge pull request #3018 from atn34/atn34/remove-brittle-assert
Remove brittle ASSERT
2020-04-23 14:34:58 -07:00
Andrew Noyes 99f5808118 Remove brittle ASSERT
The vtables are sorted by address, so ASLR makes this test
non-deterministic
2020-04-23 14:08:44 -07:00
Evan Tschannen c87aa33941 Merge branch 'release-6.2'
# Conflicts:
#	CMakeLists.txt
#	bindings/go/src/fdb/generated.go
#	documentation/sphinx/source/api-common.rst.inc
#	documentation/sphinx/source/api-ruby.rst
#	documentation/sphinx/source/release-notes.rst
#	fdbclient/FailureMonitorClient.actor.cpp
#	fdbclient/NativeAPI.actor.cpp
#	fdbclient/vexillographer/fdb.options
#	fdbrpc/FlowTransport.actor.cpp
#	fdbserver/OldTLogServer_6_0.actor.cpp
#	fdbserver/TLogServer.actor.cpp
#	fdbserver/fdbserver.actor.cpp
#	versions.target
2020-04-23 13:47:53 -07:00
Evan Tschannen c0d549511a
Merge pull request #3014 from etschannen/post-release-cleanup-6.2.20
Post release cleanup 6.2.20
2020-04-23 13:22:01 -07:00
Evan Tschannen 44cf59ca81 update installer WIX GUID following release 2020-04-23 13:16:46 -07:00
Evan Tschannen 8eef766546 update version to 6.2.21 2020-04-23 13:16:46 -07:00
Markus Pilman b313e63a77 another MacOS fix 2020-04-23 13:11:09 -07:00
tclinken 2049b3802a Only use -Wclass-memaccess when compiling C++ files 2020-04-23 12:42:26 -07:00
Markus Pilman b58b035871 next attempt for fixing macos build 2020-04-23 12:33:18 -07:00
Markus Pilman 430cf4dbaa don't explicitely set `LLD` on MacOS 2020-04-23 12:29:36 -07:00
Markus Pilman 159b97517b Chose sensible compiler defaults 2020-04-23 12:24:12 -07:00
Evan Tschannen 77b5171e81
Merge pull request #3012 from etschannen/release-6.2
updated documentation for 6.2.20
2020-04-23 11:20:44 -07:00
Evan Tschannen 010592a415 updated documentation for 6.2.20 2020-04-23 10:59:28 -07:00
Evan Tschannen 76d4570d5d
Merge pull request #3008 from etschannen/release-6.2
Added logging for parallel peeks from TLogs
2020-04-23 10:27:49 -07:00
Markus Pilman f8ad7ffd91 Use foundationdb-dev docker image 2020-04-23 10:25:26 -07:00
Markus Pilman c551258018 pass working directory to `fdb-dev`
This allows a user to run commands without using the
docker shell (for example `fdb-dev ninja`)
2020-04-23 10:25:20 -07:00
Vishesh Yadav c30010f5b8 FlowTransport: Increase delay for connecting to failed connections 2020-04-23 09:44:30 -07:00
Meng Xu d4509090d4 Generate fastrestore_agent symlink in CMake 2020-04-23 07:55:44 -07:00
Steve Atherton ab46405bf4 Improvement to an edge case where writePages() would unexpectedly return only 1 page but not attempt to reuse the existing BTreePageID for it. 2020-04-23 04:23:05 -07:00
Evan Tschannen a835123680 exit fdbserver after a ReceiverError, because a packet which should be delivered will never be received 2020-04-22 23:38:46 -07:00
Evan Tschannen 37f9456010 added logging when encountering an inverted range 2020-04-22 23:37:29 -07:00
Evan Tschannen 810bba2067 cleanup calls to FlowTransport::isClient() 2020-04-22 23:36:40 -07:00
Evan Tschannen 91fba9106d ported peek metrics to old tlog 6.0 2020-04-22 23:35:48 -07:00
Evan Tschannen 0c84ad4bc6
Merge pull request #2917 from bnamasivayam/fail-slow-ss
Mark the storage servers that are continually lagging as unhealthy
2020-04-22 23:18:35 -07:00
tclinken b1f525583a Added -Wclass-memaccess compiler option and fixed warnings 2020-04-22 21:53:42 -07:00