Commit Graph

429 Commits

Author SHA1 Message Date
sfc-gh-tclinkenbeard ef711d405c Add fdbbackup tags command 2022-01-24 13:34:54 -08:00
A.J. Beamon ff1cb58174 Convert hyphens to underscores for all prefix-based arguments (e.g. --knob-, --locality-) 2021-12-14 12:01:44 -08:00
A.J. Beamon f24adc7b6a Fix a bunch of places where we used old-style arguments. Allow hyphens for profiler args. 2021-12-14 09:59:14 -08:00
A.J. Beamon f29f487823
Unify flags (#25)
* Unify flags implementation and change help text in backup.actor.cpp
Description

Testing

* Keep LOG_GROUP unchanged

Description

Testing

* Transfer the hyphens to underscores for internal options and user's input, EXCEPT leading hyphens

Description

Testing

* Use a deep copy of the user's input flag to do the match

Description

Testing

* Convert the _ to - in Option arrays of backup.actor.cpp

Description

Testing

* Transter _ to - for files:
        TLSConfig.actor.h, fdbcli.actor.cpp, fdbserver.actor.cpp, FileConverter.h, FileConverter.cpp

Description

Testing

* Change another way to unify flag: using SO_O_ICASE_HYPHEN_AND_UNDERSCORE to determine whether we do the conversion in function IsEqual

Description

Testing

* Change the config command's name from SO_O_ICASE_HYPHEN_AND_UNDERSCORE to SO_O_HYPHEN_TO_UNDERSCORE

Description

Testing

* Update the comment for the SO_O_HYPHEN_TO_UNDERSCORE

Description

Testing

* Fix left underscore in SOption arrays

Description

Testing

* Convert _ to - in several files for commands

Description

Testing

* Make the FDBService and fdbmonitor backward compatible

Description

Testing

* Fix bugs about pointers

Description

Testing

* Check underscore and hyphen at the same time for --knob_, --localily_ and --test_
And fix bugs in fdbmonitor and FDBService
Description

Testing

* Simplify the function in fdbmonitor and FDBService about retrieving arguments.
And fix some documents in masterserver.actor.cpp

Description

Testing

* Convert _ to - for knob in the setKnob functions

Description

Testing

* Convert - to _ in the setKnob functions

Description
Since key in the knob related maps only contain _

Testing

* Rename varialbe name in the fdbmonitor and FDBService for clarification

Description

Testing

Co-authored-by: Chang Liu <chang.liu@snowflake.com>
2021-12-14 08:44:39 -08:00
sfc-gh-tclinkenbeard 464d9488ef Merge remote-tracking branch 'origin/master' into fix-unused-warnings 2021-12-01 23:52:09 -08:00
sfc-gh-tclinkenbeard 90ced244eb Fix -Wunused-but-set-variable warnings 2021-12-01 18:15:53 -08:00
sfc-gh-tclinkenbeard ec64890ac1 Remove some usages of PRId64 by using fmt library 2021-11-30 23:35:36 -08:00
sfc-gh-tclinkenbeard deb0eb85e8 Initialize global flow knobs in setupNetwork 2021-11-16 00:41:34 -08:00
A.J. Beamon e882eb33fc Abstract the cluster file into a cluster connection record that can be backed by something other than the filesystem. 2021-10-22 11:05:18 -07:00
Xiaoge Su e68b131e4a fixup! Reformat source code 2021-09-16 19:40:28 -07:00
Xiaoge Su abf73047ca Enforce std:: specifier rather than using namespace 2021-09-16 19:40:28 -07:00
FDB Formatster 2c788c233d apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-08-27 17:07:47 -07:00
A.J. Beamon d4c67eb13d Fix crash when DR binaries are invoked without a source cluster file. Update the usage text for dr_agent cluster files to include the long form options. 2021-08-20 12:55:13 -07:00
Steve Atherton e5e8a56b66 Merge branch 'master' of https://github.com/apple/foundationdb into debugging-cleanup
# Conflicts:
#	fdbbackup/FileDecoder.actor.cpp
2021-08-09 23:36:57 -07:00
Steve Atherton 2bf7b9b7a9 Remove many calls to .toString(), .printable(), and printable(...) from TraceEvent .detail() values to avoid double-escaping characters such that the same values look different in different events and can't be easily searched for. Also fixed a few warnings found by clang. 2021-08-08 00:04:54 -07:00
Vishesh Yadav de93e2f854
Update fdbbackup/backup.actor.cpp
Co-authored-by: Jingyu Zhou <jingyuzhou@gmail.com>
2021-08-04 20:27:43 -07:00
Vishesh Yadav 98fa70da11 backup: Show error info for RemovedDeadBackupLayerStatus 2021-08-04 13:28:47 -07:00
Jingyu Zhou 5346213e7f Fix trace event UnfishedBlocks 2021-08-02 09:26:42 -07:00
Jingyu Zhou 31a64106fb Avoid memory copies after decoding a new file block 2021-08-02 09:21:33 -07:00
Jingyu Zhou 426e906a87 Remove duplicated code 2021-08-01 22:39:28 -07:00
Jingyu Zhou 8f1946f522 Remove unused code 2021-08-01 21:55:39 -07:00
Jingyu Zhou 1a97c3942a Fix trace events 2021-08-01 19:25:39 -07:00
Jingyu Zhou 4f5bcaf050 Remove verbose stdout messages 2021-08-01 19:11:23 -07:00
Jingyu Zhou e3629ef356 Refactor decoder 2021-08-01 19:09:09 -07:00
Jingyu Zhou d7ac5830e6 Fix decoder bug of shadowing loop index 2021-08-01 13:48:45 -07:00
Jingyu Zhou de1e9000a2 Add --hex_prefix flag 2021-07-31 21:08:13 -07:00
Jingyu Zhou 2282d8455a Fix trace format json 2021-07-31 19:02:33 -07:00
Meng Xu 9e4bee9e30 Handle ascii special characters 2021-08-01 01:50:33 +00:00
Jingyu Zhou b930faf520 Log prefix filter 2021-07-31 12:52:39 -07:00
Jingyu Zhou 1145087543 Add UID to the events for decoders 2021-07-31 12:45:47 -07:00
Jingyu Zhou 0a98c76747 Fix trace event throttling by using different types 2021-07-31 12:24:59 -07:00
Jingyu Zhou 7054bf7054 Set max field length for long mutations 2021-07-31 11:28:13 -07:00
Jingyu Zhou 0ea432a638 Add traceevent for all printed mutations 2021-07-30 18:34:13 -07:00
Jingyu Zhou 52368eafbc Filter by version for mutations as well 2021-07-30 17:45:21 -07:00
Jingyu Zhou 1a4f6a4ccf Implement prefix key filter 2021-07-30 16:31:53 -07:00
Jingyu Zhou c21fadeaea Add begin and end version filtering for files 2021-07-30 15:58:22 -07:00
sfc-gh-tclinkenbeard c74047c665 Merge remote-tracking branch 'origin/master' into fix-more-clang-warnings 2021-07-28 11:51:02 -07:00
Steve Atherton 507c1f11e3 Add .log() to bare TraceEvent() invocations without any .detail()s to avoid clang-tidy warning about immediate destruction of object without use. 2021-07-26 19:55:10 -07:00
sfc-gh-tclinkenbeard b9a22a61ef Fix many -Wreorder-ctor warnings 2021-07-23 17:33:18 -07:00
Steve Atherton f596a81073 Rename ::TRUE and ::FALSE in BooleanParams to ::True and ::False so as to not conflict with the TRUE and FALSE macros provided by the Windows and MacOS SDKs. 2021-07-17 00:11:40 -07:00
sfc-gh-tclinkenbeard 020371a78f Merge remote-tracking branch 'origin/master' into add-boolean-param 2021-07-07 16:50:51 -07:00
Trevor Clinkenbeard f24581b644
Merge pull request #5120 from sfc-gh-tclinkenbeard/improve-poll-delay-safety
Improve safety of backup agent poll delay
2021-07-07 14:42:33 -07:00
sfc-gh-tclinkenbeard 3d0536dcec Improve safety of backup agent poll delay 2021-07-05 13:22:31 -07:00
sfc-gh-tclinkenbeard 8370d92c20 Expand use of BOOLEAN_PARAM in backup code 2021-07-04 18:30:55 -07:00
sfc-gh-tclinkenbeard cadfdc551e Use BOOLEAN_PARAM for backup agents 2021-07-04 16:27:26 -07:00
sfc-gh-tclinkenbeard 8cc40e3a2b Expand use of BOOLEAN_PARAM 2021-07-02 21:41:50 -07:00
sfc-gh-tclinkenbeard 79ff07a071 Added *BOOLEAN_PARAM macros to enforce documentation of boolean parameters 2021-07-02 15:04:42 -07:00
sfc-gh-tclinkenbeard 27e44c1bb9 Add support for encryption testing in BackupCorrectness workload 2021-06-26 11:15:12 -07:00
sfc-gh-tclinkenbeard 1afae7623b Added /backup/containers/localdir/encrypted unit test 2021-06-25 22:33:26 -07:00
sfc-gh-tclinkenbeard f5aa3df917 Add --encryption_key_file command line argument to fdbbackup and fdbrestore 2021-06-25 15:11:03 -07:00