Commit Graph

305 Commits

Author SHA1 Message Date
Chaoguang Lin 8ed041132f Rewrite cache_range related functions to template code; Remove duplicate code; fix the existing bug in cache_range; 2021-08-20 13:42:50 -07:00
Steve Atherton f596a81073 Rename ::TRUE and ::FALSE in BooleanParams to ::True and ::False so as to not conflict with the TRUE and FALSE macros provided by the Windows and MacOS SDKs. 2021-07-17 00:11:40 -07:00
Xiaoxi Wang 2abdbff11f add Knobs 2021-07-12 05:33:23 +00:00
sfc-gh-tclinkenbeard 8cc40e3a2b Expand use of BOOLEAN_PARAM 2021-07-02 21:41:50 -07:00
Lukas Joswiak f9d7c874ac Fix invalid read 2021-07-01 21:40:02 -07:00
Neethu Haneesha Bingi decfb610ff Minor review comments. 2021-06-25 15:04:49 -07:00
Neethu Haneesha Bingi 66f2518405 exclude to work with any locality data match. 2021-06-23 18:03:27 -07:00
Neethu Haneesha Bingi cbe714acd0 Status json schema update, includelocalities back for consistency check, review comments. 2021-06-23 18:03:27 -07:00
Neethu Haneesha Bingi 4ad5926a25 Snake naming of keys and added comments to all new functions. 2021-06-23 18:03:27 -07:00
Neethu Haneesha Bingi 73752f441b exclude locality:clang-format, ranged loops, documentation, tracking addStoragesever for exclusion. 2021-06-23 18:03:27 -07:00
Neethu Haneesha Bingi 62355571d0 exclude servers based on locality match 2021-06-23 18:03:27 -07:00
sfc-gh-tclinkenbeard 371a38e6e5 Merge remote-tracking branch 'origin/master' into remove-extra-copies 2021-06-07 10:26:06 -07:00
Andrew Noyes fbe96939ba Avoid likely use after destruction
This manifested in UBSAN as use of an invalid vptr, which usually means
use after destruction. Give shared ownership to the getDesired actor to
avoid use after destruction. It is not clear to me when this doesn't
seem to manifest as a heap-use-after-free in e.g. ASAN or valgrind.
2021-06-04 09:54:06 -07:00
Josh Slocum d67184163b
Merge pull request #4556 from sfc-gh-jslocum/tss
Testing Storage Server
2021-06-01 09:11:10 -07:00
Evan Tschannen 4a753a0bce
Merge pull request #4623 from dlambrig/issue4252
CDs reject requests using different connection descriptor
2021-05-28 10:45:51 -07:00
Dan Lambright 10289ef8f1 Respond to AJs comments 2021-05-27 09:14:32 -04:00
Dan Lambright 64c10d3625 fix joshua failures, formatting 2021-05-27 08:08:07 -04:00
Dan Lambright fcfb78162c misc cleanup for publishing 2021-05-27 08:08:07 -04:00
Dan Lambright 742c22cef2 Don't allow changing desriptor if knob is set 2021-05-27 08:08:07 -04:00
Josh Slocum 4257ac2b4d More TSS Changes/Fixes 2021-05-25 20:37:48 +00:00
Josh Slocum ce82c9653e Testing Storage Server implementation 2021-05-25 20:28:50 +00:00
Xiaoxi Wang 8b1f9f7337 Add command line support 2021-05-17 20:57:54 +00:00
sfc-gh-tclinkenbeard f28ac955c3 Remove unnecessary temporary objects while growing objects of type std::vector<std::pair<A, B>> 2021-05-10 16:32:50 -07:00
sfc-gh-tclinkenbeard 5c2d7b6080 Create RangeResult type alias 2021-05-03 13:14:16 -07:00
FDB Formatster df90cc89de apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-03-10 10:18:07 -08:00
Andrew Noyes 79cec09255 Apply clang-tidy's performance-inefficient-vector-operation fix
I ran this command in my build directory after compiling with
OPEN_FOR_IDE. It took a few small tweaks to get it to compile, which is
outside the scope of this commit.

    $ python run-clang-tidy.py -j $(nproc) -checks='-*,performance-inefficient-vector-operation' -fix
2021-03-04 03:58:25 +00:00
negoyal e9b7e22e02 Merge branch 'rel-6.3' 2021-02-22 08:47:22 -08:00
negoyal e49cc68bbc Merge branch 'rel-6.2' into rel-6.3 2021-02-21 00:15:31 -08:00
Andrew Noyes 9fb396e372
Merge pull request #4255 from sfc-gh-clin/add-coordinators-into-special-keys
Add coordinators into special keys
2021-02-18 18:26:07 -08:00
A.J. Beamon af77fae131 Fix bug in code I recently added where the process name memory was not long-lived and was later used. 2021-02-18 18:33:23 +00:00
Andrew Noyes bcd9a00a50 Backport #4285 and 1513df22f3 to release-6.2
Fixes #4342
2021-02-17 00:35:25 +00:00
Chaoguang Lin 731ee8a121 Update ChangeConfig to test coordinators special keys 2021-02-16 13:01:37 -08:00
Steve Atherton 76a4293d1d Merge branch 'release-6.3'
# Conflicts:
#	fdbserver/fdbserver.actor.cpp
2021-02-15 02:13:06 -08:00
A.J. Beamon 5b74556733 Fix bug in code I recently added where the process name memory was not long-lived and was later used. 2021-02-10 10:46:02 -08:00
Chaoguang Lin 3def9731a4 Merge branch 'master' of github.com:apple/foundationdb into add-coordinators-into-special-keys 2021-02-08 18:52:45 -08:00
A.J. Beamon be57b70dbb Fix function call where the signature changed 2021-02-08 14:00:47 -08:00
A.J. Beamon aaf0a9aa7b Merge branch 'release-6.3' into merge-release-6.3-into-master
# Conflicts:
#	build/docker-compose.yaml
#	cmake/ConfigureCompiler.cmake
#	fdbclient/FileBackupAgent.actor.cpp
#	fdbrpc/AsyncFileCached.actor.h
#	fdbrpc/IAsyncFile.h
#	fdbrpc/IRateControl.h
#	fdbrpc/simulator.h
#	fdbserver/KeyValueStoreSQLite.actor.cpp
#	fdbserver/storageserver.actor.cpp
#	fdbservice/ServiceBase.cpp
2021-02-08 12:58:34 -08:00
A.J. Beamon 84be77958e Add a simulator guard 2021-02-05 22:47:49 -08:00
A.J. Beamon 53d8bd5799 If a quorum change has to retry, it's possible that one of our previously chosen coordinators could be rebooting. 2021-02-05 22:36:54 -08:00
A.J. Beamon 5c4863b33e Fix unit test that set coordinators to fake processes that the simulator didn't know about 2021-02-05 22:07:40 -08:00
A.J. Beamon 618585f9dd Fix a bug in simulated coordinator selection that could allow an unreliable process to be chosen as coordinator despite the intent that this not happen. 2021-02-05 15:59:14 -08:00
Chaoguang Lin 766de6574a Add trace 2021-01-29 15:32:53 -08:00
Chaoguang Lin 5a62e0c084 Fix repeated code usage 2021-01-29 12:20:30 -08:00
Chaoguang Lin e1182f2f86 Add coordinators to special keys 2021-01-29 11:45:52 -08:00
David Youngworth d64cf8b9e3 Merge branch 6.3 into master 2020-11-17 11:22:45 -08:00
Jon Fu cc13ef08bd Sort the failed sets before modifying them in attempts to make changes consistent 2020-11-12 16:26:34 -05:00
sfc-gh-tclinkenbeard 0718329705 Make getDesiredClusterKeyName const
This fixes a virtual function overload in NameQuorumChange
2020-10-15 10:39:38 -07:00
sfc-gh-tclinkenbeard ccf2ca73f3 Fix Windows CMake build 2020-10-08 23:58:58 -07:00
sfc-gh-tclinkenbeard a9607bdcec Explicitly seal classes that inherit but aren't inherited from 2020-10-07 21:58:24 -07:00
sfc-gh-tclinkenbeard a3de8c333b Use override where applicable in fdbclient 2020-10-07 16:57:38 -07:00