Commit Graph

158 Commits

Author SHA1 Message Date
Jingyu Zhou 801258e916
Merge pull request #3404 from sfc-gh-tclinkenbeard/add-vectorref-clear
Added VectorRef::clear
2021-06-07 13:44:08 -07:00
Andrew Noyes c88750a5a9 Avoid passing null as second arg to memcmp 2021-06-04 09:53:23 -07:00
sfc-gh-tclinkenbeard 03ce46bb5d Merge remote-tracking branch 'origin/master' into add-vectorref-clear 2021-05-25 21:41:22 -07:00
Steve Atherton 60504e12ac Address review comments. 2021-05-17 18:02:09 -07:00
Steve Atherton a31e4f622f Changed ArenaBlockRef to use 32 bit aligned4kBuffer size. 2021-05-16 03:58:05 -07:00
Steve Atherton 2298567c2b Use of aligned_alloc() for 4k pages causes too much wasted virtual memory. Added new 4k-aligned fast allocator, and changed Arena::allocatedAlignedBuffer() to be 4k-specific, now called Arena::allocate4kAlignedBuffer(). 2021-05-14 23:12:00 -07:00
Steve Atherton f8a8bf315b Added Arena::allocateAlignedBuffer() to get an aligned memory block owned by an Arena, and ArenaPage uses this. 2021-05-05 15:00:12 -07:00
Josh Slocum 4b5bca6761 Minor Redwood comparison optimizations 2021-04-23 18:49:43 +00:00
FDB Formatster df90cc89de apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-03-10 10:18:07 -08:00
A.J. Beamon aaf0a9aa7b Merge branch 'release-6.3' into merge-release-6.3-into-master
# Conflicts:
#	build/docker-compose.yaml
#	cmake/ConfigureCompiler.cmake
#	fdbclient/FileBackupAgent.actor.cpp
#	fdbrpc/AsyncFileCached.actor.h
#	fdbrpc/IAsyncFile.h
#	fdbrpc/IRateControl.h
#	fdbrpc/simulator.h
#	fdbserver/KeyValueStoreSQLite.actor.cpp
#	fdbserver/storageserver.actor.cpp
#	fdbservice/ServiceBase.cpp
2021-02-08 12:58:34 -08:00
A.J. Beamon 449e4b98b4 Attempt to fix a build warning that's now blocking the compile due to werror. 2021-02-08 12:06:51 -08:00
sfc-gh-tclinkenbeard 8191a38b88 Support rvalue reference overload for Optional::get 2020-10-24 21:05:42 -07:00
Young Liu 8cc3e4d3c6 Merge release-6.3 into master 2020-10-19 22:51:56 -07:00
Evan Tschannen f03a355c4e Merge branch 'release-6.2' into release-6.3
# Conflicts:
#	CMakeLists.txt
#	documentation/sphinx/source/downloads.rst
#	fdbrpc/FlowTransport.actor.cpp
#	fdbrpc/FlowTransport.h
#	flow/Arena.h
#	flow/Knobs.cpp
#	flow/Knobs.h
#	packaging/msi/FDBInstaller.wxs
2020-10-07 12:28:22 -07:00
A.J. Beamon 76da0a7cbc Backport #3426 to release-6.2 2020-10-05 13:53:51 -07:00
Evan Tschannen 12edadd059 Merge branch 'release-6.3'
# Conflicts:
#	CMakeLists.txt
#	fdbclient/Knobs.cpp
#	fdbclient/MasterProxyInterface.h
#	fdbrpc/simulator.h
#	fdbserver/MasterProxyServer.actor.cpp
#	tests/fast/CycleAndLock.txt
#	tests/fast/TxnStateStoreCycleTest.txt
#	tests/fast/VersionStamp.txt
#	tests/slow/ParallelRestoreOldBackupApiCorrectnessAtomicRestore.txt
#	tests/slow/ParallelRestoreOldBackupCorrectnessCycle.txt
#	versions.target
2020-08-31 19:33:34 -07:00
Evan Tschannen e7a1892947 fixed a compiler warning 2020-08-31 15:01:19 -07:00
sfc-gh-tclinkenbeard 7b210aee24 Use =delete to disable special member functions
This has the benefits of:
- Easier to understand compiler error messages
- Moves some errors from link-time to compile-time
- NonCopyable classes can still specify default move constructors
2020-08-18 11:07:00 -07:00
Evan Tschannen 05306e9c12
Merge pull request #3581 from sfc-gh-anoyes/anoyes/remove-bogus-operator
I don't think 1 - <iter> makes sense, so let's remove this
2020-08-05 10:35:20 -07:00
Andrew Noyes 9ec91cd660 I don't think 1 - <iter> makes sense, so let's remove this 2020-07-30 20:02:44 +00:00
Trevor Clinkenbeard 602b0f9dea
Merge branch 'master' into vectorref-emplace-back 2020-07-28 17:17:11 -07:00
Andrew Noyes 4c17019f37 Fix memory error in SmallVectorRef 2020-07-27 21:11:50 +00:00
Andrew Noyes 75ecc3e2f4 Add difference between two iterators operator 2020-07-22 19:57:47 +00:00
Andrew Noyes 4195d3ab3b Fix compilation, test copies 2020-07-22 19:57:47 +00:00
Andrew Noyes a25689e6e5 Add append tests, fix append 2020-07-22 19:57:47 +00:00
Andrew Noyes 03a45e979d Add unit tests for VectorRef and SmallVectorRef 2020-07-22 19:57:47 +00:00
Russell Sears ab0d8b0626
Merge pull request #3509 from sfc-gh-anoyes/anoyes/remove-using-relops
Remove using namespace std::rel_ops
2020-07-22 11:58:25 -07:00
sfc-gh-tclinkenbeard abaae40453 Modified ComposedIdentifier to prevent file identifier conflicts at
compile-time
2020-07-20 18:52:44 -07:00
Evan Tschannen 7affda3c8b Merge branch 'release-6.3'
# Conflicts:
#	CMakeLists.txt
2020-07-14 14:57:24 -07:00
Jingyu Zhou 773e533a09 Make Arena's impl private 2020-07-13 21:39:36 -07:00
Meng Xu 8048fea51d
Merge pull request #3485 from sfc-gh-mpilman/cleanup/tracing-cleanup
Address review comments from tracing work
2020-07-13 14:27:20 -07:00
Meng Xu 8ae0d9b73d Resolve merge conflict 2020-07-13 10:21:53 -07:00
Meng Xu ef8c1060a2 Merge branch 'master' into mengxu/tmp-merge-6.3 2020-07-13 10:15:56 -07:00
Andrew Noyes f470ba8316 Remove using namespace std::rel_ops
This causes the following to not compile anymore

\#include <utility>
\#include <vector>

using namespace std::rel_ops;

int main() {
    std::vector<int> xs;
    return xs.rbegin() != xs.rend();
}

See https://godbolt.org/z/s1977n
2020-07-10 22:58:15 +00:00
A.J. Beamon b09dddc07e Merge branch 'release-6.2' into merge-release-6.2-into-release-6.3
# Conflicts:
#	cmake/ConfigureCompiler.cmake
#	documentation/sphinx/source/downloads.rst
#	fdbrpc/FlowTransport.actor.cpp
#	fdbrpc/fdbrpc.vcxproj
#	fdbserver/DataDistributionQueue.actor.cpp
#	fdbserver/Knobs.cpp
#	fdbserver/Knobs.h
#	fdbserver/LogSystemPeekCursor.actor.cpp
#	fdbserver/MasterProxyServer.actor.cpp
#	fdbserver/Status.actor.cpp
#	fdbserver/storageserver.actor.cpp
#	flow/flow.vcxproj
2020-07-10 15:06:34 -07:00
Markus Pilman cc05447b9e Address review comments from tracing work
This mostly simplifies the SmallVectorRef class to use
VectorRef (instead of replicating code...)
2020-07-10 11:22:05 -06:00
Markus Pilman a6e38f258d fixed a compiler warning 2020-07-09 17:20:55 -06:00
Markus Pilman cc60597739
Merge branch 'master' into bugfixes/visibility-perf-regression 2020-07-09 17:04:04 -06:00
Andrew Noyes 6446b4c082 WIP 2020-07-09 22:02:43 +00:00
Markus Pilman 0d994514e1 fixed bug in SmallVectorRef 2020-07-09 14:30:24 -06:00
Markus Pilman 69864c9f96 Make Spans not allocate heap memory 2020-07-09 11:49:33 -06:00
Meng Xu 1b68665228 Merge branch 'master' into release-6.3 2020-07-08 18:52:05 -07:00
Markus Pilman 0fbe7101c3 Revert "Revert "Request tracing""
This reverts commit 327cc31e35.
2020-07-07 10:06:13 -06:00
sfc-gh-tclinkenbeard 20c5b0f824 Addressed review comments 2020-07-06 19:24:28 -07:00
sfc-gh-tclinkenbeard 1b55d75896 Remove TRIVIALLY_DESTRUCTIBLE macro 2020-07-04 19:28:10 -07:00
sfc-gh-tclinkenbeard 9ab9bc09c7 Use std::optional for Optional 2020-07-04 19:28:09 -07:00
A.J. Beamon b7189f5168
Merge pull request #3426 from Clikengo/fix-3424
fix ClientVersionRef versionString should be passed by ref
2020-07-02 08:06:04 -07:00
Vincent Rouillé 1082ab2caa
fix ClientVersionRef versionString should be passed by ref 2020-06-29 21:23:56 +02:00
Meng Xu 22f7f804b8 Merge branch 'release-6.3' into mengxu/merge-6.3-PR 2020-06-28 11:19:39 -07:00
sfc-gh-tclinkenbeard 8de70432a6 Fix memory leaks in VectorRef
VectorRef<T> relies on T being trivially destructible, but this was not
yet enforced. By statically asserting that T is trivially destructible,
we avoid leaking memory by not calling the destructor for non-trivially
destructible types
2020-06-24 10:54:19 -07:00