Commit Graph

2216 Commits

Author SHA1 Message Date
Russell Sears 6c84594e2f
Merge pull request #5099 from sears/log_thread_id
Add a ThreadID field to each TraceEvent.
2021-07-01 14:14:12 -07:00
Russell Sears 18cde28d6e Add a ThreadID field to each TraceEvent. This is needed for multithreaded client debugging, and should also be helpful for multithreaded storage engines, SSL handshake threadpools, and so on 2021-06-30 14:31:53 -07:00
Daniel Smith 0df49e1bee
Run IThreadPool naming test outside simulation 2021-06-30 15:06:58 -04:00
Daniel Smith 1b62fc76e7
Merge pull request #5092 from Daniel-B-Smith/thread-naming-fix
Fix IThreadPool thread naming
2021-06-29 17:30:33 -04:00
Daniel Smith 299eaef858
Update flow/IThreadPoolTest.actor.cpp
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-06-29 16:39:50 -04:00
Daniel Smith ac01e5bcfd
Update flow/IThreadPoolTest.actor.cpp
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-06-29 16:37:06 -04:00
Daniel Smith f58c7fd8bc Fix IThreadPool thread naming 2021-06-29 16:27:37 -04:00
A.J. Beamon 00050098ff
Merge pull request #5075 from sfc-gh-tclinkenbeard/set-crash-error-kind
Set error kind to BugDetected for Crash trace events
2021-06-29 14:02:52 -04:00
sfc-gh-tclinkenbeard a73570e538 Added comment for crashHandler 2021-06-29 11:00:05 -07:00
A.J. Beamon 63b286706a
Merge pull request #5069 from Daniel-B-Smith/thread-helper-doc
Add some documentation for the onMainThread functions
2021-06-29 13:32:47 -04:00
Daniel Smith 23fc685518
Update flow/ThreadHelper.actor.h
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-06-29 13:31:36 -04:00
Daniel Smith 119a52c2e9
Update flow/ThreadHelper.actor.h
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-06-29 13:31:23 -04:00
Daniel Smith 1c2d4119c2
Update flow/ThreadHelper.actor.h
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-06-29 13:31:15 -04:00
Josh Slocum ab0ab765c8
Merge pull request #4965 from sfc-gh-jslocum/tss_mapping_changes
TSS Mismatch Changes
2021-06-29 08:24:25 -07:00
sfc-gh-tclinkenbeard a33a0a7fff Add include to DeterministicRandom.cpp 2021-06-28 14:50:35 -07:00
sfc-gh-tclinkenbeard 8855c7ee8d Set error kind to BugDetected for Crash trace events 2021-06-27 16:47:54 -07:00
sfc-gh-tclinkenbeard 9862fec764 Merge remote-tracking branch 'origin' into remove-boost-dependencies 2021-06-25 11:53:29 -07:00
Daniel Smith 1e0c233d40 Add some documentation for the onMainThread functions 2021-06-24 17:44:54 -04:00
Xiaoge Su 048eee55a5
Merge pull request #5061 from xis19/master
Add static_assert to serializeBinaryItem
2021-06-23 22:13:18 -07:00
Xiaoge Su 5089459bd2 Add static_assert to *Writer::serializeBinaryItem
BinaryWriter::serializeBinaryItem will accept *any* objects and
serialize them by memory copy. If the object is a struct, padding bytes
will also be copied, which is not expected (at this stage, the
serializer will NOT include any padding). If padding exists, the caller
is required to use _Reader::serializeBinaryItem when reading.

Due to this inconsistency, it is helpful to restrict
serializedBinaryItem calls to limited types. Base on the current
implementation, one reasonable approach is allowing only those types
are BINARY_SERIALIZABLE. This patch addresses such restriction.

The restriction is also applied to other classes:

 * OverWriter
 * _Reader
 * PacketWriter
2021-06-23 18:45:51 -07:00
Evan Tschannen fcb8bd6475
Revert "Make the sim2 run loop match the behavior of the net2 run loop." 2021-06-22 14:50:01 -07:00
Evan Tschannen 154332a94b Merge branch 'master' of https://github.com/apple/foundationdb into feature-sim-time-batching
# Conflicts:
#	fdbserver/VersionedBTree.actor.cpp
2021-06-22 09:37:40 -07:00
Evan Tschannen 244e8f3527 Merge branch 'master' of https://github.com/apple/foundationdb into feature-streaming-reply-master
# Conflicts:
#	fdbclient/CMakeLists.txt
#	fdbclient/Knobs.h
#	fdbserver/Knobs.h
2021-06-21 16:35:21 -07:00
sfc-gh-tclinkenbeard a424abe5c2 Remove some boost dependencies 2021-06-21 13:46:04 -07:00
Evan Tschannen 1cec223434 cherry pick streaming replies to master 2021-06-19 09:47:13 -07:00
sfc-gh-tclinkenbeard 6619545c30 Merge remote-tracking branch 'origin/master' into config-db 2021-06-18 19:59:56 -07:00
Zhe Wu e3c9d9f6a0
Merge pull request #4987 from halfprice/zhewu/worker-health-monitor
Create health monitor in FDB workers to monitor peer network condition
2021-06-17 16:58:24 -07:00
Zhe Wu 07ee4029f2 Addressing comments. 2021-06-17 14:53:15 -07:00
sfc-gh-tclinkenbeard 826e70916c Merge remote-tracking branch 'origin/master' into config-db 2021-06-17 09:47:41 -07:00
Zhe Wu 4e3e2b0392 Create health monitor in FDB workers to monitor network condition. This change is only inside the worker. 2021-06-16 14:50:44 -07:00
Markus Pilman 05aea49d16
Merge pull request #4986 from sfc-gh-mpilman/bugfixes/double-ss
Bugfixes/double ss
2021-06-16 14:43:32 -06:00
sfc-gh-tclinkenbeard 4105a9f530 Improved error handling test coverage in LocalConfiguration 2021-06-16 13:10:14 -07:00
sfc-gh-tclinkenbeard 9d62887f35 Addressed review comments 2021-06-16 11:34:20 -07:00
Markus Pilman 9a24a57007 refactor templates to make them more readable and reusable 2021-06-16 10:46:21 -06:00
Trevor Clinkenbeard 0120a6ba72
Merge pull request #4936 from sfc-gh-tclinkenbeard/remove-string-copies
Remove unnecessary std::string copies from flow
2021-06-14 13:49:20 -07:00
Josh Slocum 56dadaa428 TSS Mismatch Changes 2021-06-11 23:13:16 +00:00
sfc-gh-tclinkenbeard 41c790b299 Merge remote-tracking branch 'origin/master' into config-db 2021-06-10 22:31:23 -07:00
sfc-gh-tclinkenbeard 669ca0bb14 Add comments to configuration database code 2021-06-10 17:14:37 -07:00
Steve Atherton 389d6fcbe9
Merge pull request #4933 from sfc-gh-satherton/redwood-deltatree2-master
Redwood DeltaTree2 Refactor, Evict obsolete Pages sooner, FlowMutex
2021-06-10 10:17:36 -07:00
sfc-gh-tclinkenbeard c272304e60 Manage global flow knobs with global knob collection 2021-06-09 22:33:00 -07:00
sfc-gh-tclinkenbeard 83a0e473e8 Refactor IKnobCollection code 2021-06-09 20:50:00 -07:00
Steve Atherton 0253463a9f
Remove redundant "or"
Co-authored-by: Andrew Noyes <andrew.noyes@snowflake.com>
2021-06-09 15:41:30 -07:00
Andrew Noyes 74c6d2fda5 Allow FlowLock::kill to delete self
Calling broken_on_destruct.sendError() calls arbitrary callbacks, which
might delete the FlowLock. It's more robust to copy to a local variable
before sending.
2021-06-09 12:27:07 -07:00
sfc-gh-tclinkenbeard 399c2c96f0 Remove unnecessary std::string copies from flow 2021-06-09 11:40:01 -07:00
Steve Atherton 293559bb61 Moved FlowMutex to genericactors. 2021-06-08 16:58:35 -07:00
Evan Tschannen 08a5f17660 Merge branch 'master' of https://github.com/apple/foundationdb into feature-sim-time-batching
# Conflicts:
#	fdbserver/DataDistribution.actor.cpp
2021-06-08 10:04:06 -07:00
Evan Tschannen 52ef8b94fb added comments 2021-06-08 09:57:37 -07:00
Jingyu Zhou 801258e916
Merge pull request #3404 from sfc-gh-tclinkenbeard/add-vectorref-clear
Added VectorRef::clear
2021-06-07 13:44:08 -07:00
sfc-gh-tclinkenbeard 371a38e6e5 Merge remote-tracking branch 'origin/master' into remove-extra-copies 2021-06-07 10:26:06 -07:00
Andrew Noyes 402622ace9
Merge pull request #4909 from apple/anoyes/fix-ub
Fix several instances of undefined behavior
2021-06-07 08:58:45 -07:00