Commit Graph

1704 Commits

Author SHA1 Message Date
Markus Pilman 69864c9f96 Make Spans not allocate heap memory 2020-07-09 11:49:33 -06:00
Meng Xu 1b68665228 Merge branch 'master' into release-6.3 2020-07-08 18:52:05 -07:00
Chaoguang Lin 5f6093b59e Add an option to enable write in special key space, which is by default not allowed 2020-07-08 15:49:34 -07:00
A.J. Beamon c94f46440b
Merge pull request #3094 from sfc-gh-dyoungworth/dyoungworth/asyncFindFiles
Make platform::findFiles asynchronous
2020-07-08 11:47:09 -07:00
Russell Sears 92ab2c84b6 Improved assert messages for numeric comparisons 2020-07-08 11:36:50 -07:00
Russell Sears 5e8eeadd7e
Merge pull request #3446 from sfc-gh-tclinkenbeard/use-stl-for-optional-variant
Use STL for optional and variant
2020-07-08 10:40:17 -07:00
David Youngworth 053eb59a46
Update flow/Platform.actor.cpp
Co-authored-by: A.J. Beamon <ajbeamon@users.noreply.github.com>
2020-07-08 13:34:52 -04:00
David Youngworth e45cfb1220
Update flow/Platform.actor.cpp
Co-authored-by: A.J. Beamon <ajbeamon@users.noreply.github.com>
2020-07-08 13:34:43 -04:00
Markus Pilman 0fbe7101c3 Revert "Revert "Request tracing""
This reverts commit 327cc31e35.
2020-07-07 10:06:13 -06:00
sfc-gh-tclinkenbeard 67f17ccf5c Remove duplicate BinaryReader code 2020-07-06 23:14:34 -07:00
sfc-gh-tclinkenbeard 20c5b0f824 Addressed review comments 2020-07-06 19:24:28 -07:00
Chaoguang Lin a43afb9d97 Merge remote-tracking branch 'upstream/master' into add-management-api-into-special-key-space 2020-07-06 15:47:00 -07:00
Jingyu Zhou cd75cce8fe
Merge pull request #3441 from yliucode/fix-joshua-real
Re-enable asking read version from master
2020-07-06 13:35:35 -07:00
Chaoguang Lin 38e2310530 Enable range clear in special key space 2020-07-06 12:11:01 -07:00
Russell Sears 4ce51c4cce
Merge pull request #2768 from atn34/atn34/arena-cpp
Check for memory errors in arena-allocated memory
2020-07-06 09:43:28 -07:00
sfc-gh-tclinkenbeard 1b55d75896 Remove TRIVIALLY_DESTRUCTIBLE macro 2020-07-04 19:28:10 -07:00
sfc-gh-tclinkenbeard 9ab9bc09c7 Use std::optional for Optional 2020-07-04 19:28:09 -07:00
sfc-gh-tclinkenbeard 60b893d423 Switch from boost::variant to std::variant 2020-07-04 19:28:05 -07:00
sfc-gh-tclinkenbeard 0c39006b07 Fixed some dangling pointers 2020-07-04 12:50:40 -07:00
Russell Sears fcaaf11678
Merge pull request #3402 from sfc-gh-tclinkenbeard/improve-const-correctness
Added more const-correctness improvements
2020-07-02 16:43:06 -07:00
Young Liu 286988c914 Report commit version later in the commit path 2020-07-02 16:14:50 -07:00
Young Liu 31c70a873f Report commit version to master as soon as possible 2020-07-02 15:13:28 -07:00
Young Liu ed89d69916 Change order between reporting commit version and setting committedVersion 2020-07-02 15:13:28 -07:00
sfc-gh-tclinkenbeard 37ffa8f443 Addressed review comment 2020-07-02 13:13:30 -07:00
A.J. Beamon b7189f5168
Merge pull request #3426 from Clikengo/fix-3424
fix ClientVersionRef versionString should be passed by ref
2020-07-02 08:06:04 -07:00
Vincent Rouillé 1082ab2caa
fix ClientVersionRef versionString should be passed by ref 2020-06-29 21:23:56 +02:00
Steve Atherton 5151f1167c Added TLS option to limit the number of glibc malloc arenas if TLS background threads are created. TLS initialization now has three phases in order to avoid creating TLS threads or limit the malloc arena count unnecessarily. 2020-06-28 17:29:13 -07:00
Meng Xu 22f7f804b8 Merge branch 'release-6.3' into mengxu/merge-6.3-PR 2020-06-28 11:19:39 -07:00
Chaoguang Lin 18ff6efbf3 Add failure module for special key space 2020-06-27 12:22:32 -07:00
Steve Atherton 648c870fec Merge branch 'release-6.3' of https://github.com/apple/foundationdb into tls-background-handshake 2020-06-26 00:21:57 -07:00
Steve Atherton 0da4c91ad5 Performance improvements in socket use and buffering which results in TLS network connections using around 3.5x less CPU.
PacketBuffers are 16k minimum sizes, using FastAlloc.  All calling paths to PacketBuffer creation now pass a size hint if known.  P2PNetworkTest improved in many ways, errors go to TraceEvents instead of stdout, error counts are reported in stats, range min/max parameters are combined into "min:max" strings, new options to "stutter" connections by delaying randomly before socket read or write, message size to send is now configured separately for incoming vs outgoing sessions.
2020-06-25 20:44:43 -07:00
Steve Atherton af6b141736
Merge pull request #3407 from sfc-gh-tclinkenbeard/fix-vectorref-memory-leaks
Fix memory leaks in VectorRef
2020-06-25 00:54:33 -07:00
Jingyu Zhou 5cd3dad986
Merge pull request #3409 from sears/assert_strings
Print out the text (to stderr and as trace) of the failed condition o…
2020-06-24 14:58:12 -07:00
Russell Sears 422003df34 Print out the text (to stderr and as trace) of the failed condition on assert failure 2020-06-24 14:21:48 -07:00
sfc-gh-tclinkenbeard 8de70432a6 Fix memory leaks in VectorRef
VectorRef<T> relies on T being trivially destructible, but this was not
yet enforced. By statically asserting that T is trivially destructible,
we avoid leaking memory by not calling the destructor for non-trivially
destructible types
2020-06-24 10:54:19 -07:00
Evan Tschannen 01030672a0
Merge pull request #3307 from yliucode/read-version
Serve GetReadVersion through master
2020-06-23 15:10:39 -07:00
Steve Atherton 813dbfb297 TLS handshake threads are now created with TLS initialization instead of when the network is created since they may not be needed and it avoids calling startThread() with a custom stack size too early in process execution. StartThread() now logs a warning if the given stack size can't be used. Reorganized TLS handshake thread state near the other TLS related stuff. 2020-06-23 03:09:56 -07:00
Steve Atherton c3ce0034bf Background threads for TLS handshakes use a stack size based on a knob. Platform::startThread() now accepts a stack size. The generic thread pool implementation takes an optional stack size override which is used for each added thread. 2020-06-23 02:08:01 -07:00
Steve Atherton 5b19233989 Implemented count of used background TLS handshake threads differently using a generic utility class that updates the count on destruction. 2020-06-23 00:45:07 -07:00
Andrew Noyes 42159ccfe0 Add -Wpessimizing-move and -Wredundant-move for clang 2020-06-22 23:45:03 +00:00
Steve Atherton 3853860cf1 Changed default TLS handshake thread count. 2020-06-22 16:28:30 -07:00
Steve Atherton a48d005f61 Bug fixes, stats improvements. 2020-06-22 13:37:13 -07:00
David Youngworth 0c4fdbb69a
Update flow/Platform.actor.cpp
Co-authored-by: A.J. Beamon <ajbeamon@users.noreply.github.com>
2020-06-22 10:28:43 -04:00
David Youngworth 333cb96fe4
Update flow/Platform.actor.cpp
Co-authored-by: A.J. Beamon <ajbeamon@users.noreply.github.com>
2020-06-22 10:28:21 -04:00
Steve Atherton d75b4c9a69 Bug fix, accidental local variable redeclaration. 2020-06-22 05:53:37 -07:00
Steve Atherton d681e9d350 Follow TLS_DISABLED macro setting. 2020-06-21 11:21:24 -07:00
Steve Atherton 6330f8b458 TLS handshakes can now be done using up to a configured number of background threads if any of them are not busy. 2020-06-21 06:23:32 -07:00
sfc-gh-tclinkenbeard d7cb54d2b2 Fixed Windows CMake build 2020-06-20 23:03:18 -07:00
sfc-gh-tclinkenbeard a59925dd73 Added more const-correctness improvements 2020-06-20 22:15:19 -07:00
sfc-gh-tclinkenbeard 57fbc1a074 Added VectorRef::emplace_back
Also added VectorRef::emplace_back_deep.
2020-06-19 23:02:24 -07:00
A.J. Beamon c01a345652
Merge pull request #3386 from sfc-gh-tclinkenbeard/improve-const-correctness
Improve const-correctness
2020-06-18 12:40:08 -07:00
A.J. Beamon 76ac5dfeaf Merge branch 'release-6.3' into merge-release-6.3-into-master
# Conflicts:
#	documentation/sphinx/source/release-notes/release-notes-630.rst
2020-06-17 18:31:06 -07:00
sfc-gh-tclinkenbeard 7a28ace7eb Mark IKeyValueContainer::getElementBytes constexpr 2020-06-17 18:20:44 -07:00
sfc-gh-tclinkenbeard 77e3b314f6 Mark IKeyValueStore::getStorageBytes const 2020-06-17 18:20:43 -07:00
sfc-gh-tclinkenbeard 2a393633b6 Improved const-correctness
Using the recently added IndexedSet::const_iterator
(https://github.com/apple/foundationdb/pull/3185), we can improve the
const-correctness of many functions. In this PR const is added where
applicable. Also, wherever I came across the following while adding
const, I made the following changes:

- virtual function overrides are marked as override
- NULL is replaced with nullptr
- git clang-format is applied
2020-06-17 18:20:43 -07:00
Young Liu 8cd97a2be8 Resolve Evan's comments:
- Only report commit version when commit version is larger than the known committed version.
- Fix task priorities of [Get/Report]LiveCommittedVersion [request/reply].
- Fix some code style issues.
2020-06-17 10:02:25 -07:00
Meng Xu bbdd451fb6 FastRestore:Add priorities for loader and applier endpoints
Endpoint for later restore step should have higher priority for
better performance: later step will not be blocked by the
next version batch's earlier steps.
2020-06-16 22:48:32 -07:00
Jingyu Zhou 327cc31e35
Revert "Request tracing" 2020-06-16 12:32:42 -07:00
Evan Tschannen 4c7d43271a merge 6.3 into 7.0 2020-06-15 11:14:11 -07:00
Meng Xu 8595813b7d
Merge pull request #3355 from apple/release-6.3
Merge Release 6.3 into master branch
2020-06-12 20:08:47 -07:00
Russell Sears 2cee47b235
Merge pull request #3314 from sfc-gh-tclinkenbeard/optimize-deque-copy-ctor
Use std::copy in Deque copy constructor
2020-06-12 16:47:35 -07:00
A.J. Beamon 9ac8a2007a
Merge pull request #3351 from xumengpanda/mengxu/proto-version-comment-PR
Explain the dev version in protocol version
2020-06-12 15:57:31 -07:00
sfc-gh-tclinkenbeard f7835ee2cf Made Deque copy constructor and assignment operator consistent 2020-06-12 15:02:19 -07:00
Trevor Clinkenbeard 9f0487506c
Style change in deque copy
Co-authored-by: Russell Sears <sears@cs.berkeley.edu>
2020-06-12 14:58:34 -07:00
Trevor Clinkenbeard f6051202df
Style change in deque copy
Co-authored-by: Russell Sears <sears@cs.berkeley.edu>
2020-06-12 14:58:21 -07:00
Trevor Clinkenbeard e223726c92
Update comment in Deque.h
Co-authored-by: Russell Sears <sears@cs.berkeley.edu>
2020-06-12 14:57:56 -07:00
Meng Xu 80334351c7
Merge pull request #3329 from sfc-gh-mpilman/features/flatbuffers-debugtx
Request tracing
2020-06-12 14:50:19 -07:00
Meng Xu 5da8f1b9aa Protocol dev version revision by A.J. 2020-06-12 14:48:11 -07:00
A.J. Beamon 6f4d6f1923 Refreshing TLS files was done to an incorrect location that resulted in random memory being wiped out. Also fixed a typo that loaded the key bytes into the CA bytes in some cases. 2020-06-12 14:40:10 -07:00
Meng Xu 9ed6780f35 Explain the dev version in protocol version 2020-06-12 14:19:30 -07:00
Russell Sears 87a53be22f silence macos x linker warning 2020-06-11 13:30:29 -07:00
Markus Pilman ae6b716820 addressed more review comments 2020-06-11 09:58:41 -07:00
Daniel Smith 2243ee0033
s/NULL/nullptr/
Co-authored-by: A.J. Beamon <ajbeamon@users.noreply.github.com>
2020-06-11 12:06:16 -04:00
Daniel Smith 8088bf7212 Move flush call onto main thread to make TraceBatch not thread hostile 2020-06-11 15:53:29 +00:00
sfc-gh-tclinkenbeard 4376f441f7 Added comment for Deque copy ctor 2020-06-11 08:45:44 -07:00
Andrew Noyes 10e094c6d7 Address review comments 2020-06-11 15:43:31 +00:00
Markus Pilman eb8a40b079 Put trace interfaces in separate file 2020-06-10 16:38:25 -07:00
Markus Pilman 9ef93714ac Address review comments 2020-06-10 15:48:49 -07:00
Markus Pilman f6c50c60f3 Fix Windows build failure 2020-06-10 15:31:37 -07:00
Markus Pilman 4ab3441a95 Merge remote-tracking branch 'origin/master' into features/flatbuffers-debugtx 2020-06-10 15:31:29 -07:00
Trevor Clinkenbeard c2587bd87c
Merge branch 'master' into optimize-deque-copy-ctor 2020-06-10 14:38:30 -07:00
sfc-gh-tclinkenbeard 99bf993815 Replace BOOST_NOEXCEPT with noexcept 2020-06-09 22:39:19 -07:00
sfc-gh-ngoyal 693d9e8b89
Merge branch 'master' into fdb_cache_wo_allocator 2020-06-09 15:09:58 -07:00
sfc-gh-tclinkenbeard 39a6c0a2f4 Use std::copy in Deque copy constructor 2020-06-08 22:36:07 -07:00
Markus Pilman 09c136e434 Framework for transaction tracing 2020-06-08 16:09:37 -07:00
Russell Sears 817b8df739
Merge pull request #3185 from tclinken/add-indexedset-const-iterator
Add IndexedSet::const_iterator
2020-06-08 09:42:48 -07:00
Russell Sears 3278222e2c
Merge pull request #3077 from tclinken/reenable-wclass-memaccess
Fix segmentation fault and reenable -Wclass-memaccess
2020-06-08 09:42:35 -07:00
Meng Xu 558fd6ba16
Merge pull request #3296 from apple/release-6.3
Merge release 6.3 to master
2020-06-05 10:49:06 -07:00
Evan Tschannen 30bfd606c0 Merge branch 'release-6.2' into release-6.3
# Conflicts:
#	CMakeLists.txt
#	documentation/sphinx/source/downloads.rst
#	documentation/sphinx/source/release-notes.rst
#	fdbserver/worker.actor.cpp
#	packaging/msi/FDBInstaller.wxs
#	versions.target
2020-06-04 19:21:32 -07:00
Steve Atherton bf072d68ec Workarounds for strange behaviors in Boost ssl sockets on MacOS and Linux. When writing to the ssl socket, write_some() would sometimes return BrokenPipe instead of WouldBlock unless onWriteable on the raw socket was checked first. On MacOS, even with the onWriteable check using a send size greater than 2016 (determined experimentally) would still result in the error. Also consolidated two identical copies of SendBufferIterator. 2020-06-04 01:44:05 -07:00
Russell Sears 3415bbcd09 Fix ARM build; add ACKNOWLEDGEMENTS entries 2020-06-02 16:09:43 -07:00
Russell Sears a99ceb9c42 Add cmake option to enable avx512 2020-06-02 15:07:00 -07:00
Russell Sears c5e2df99a2 comments 2020-06-02 15:07:00 -07:00
Russell Sears 11f658cfe2 Add cmake option to disable AVX 2020-06-02 15:07:00 -07:00
Russell Sears e77f9701f3 Settle on using rte_memcpy when we do not know the copy size at runtime, and builtin memcpy otherwise 2020-06-02 15:06:57 -07:00
Russell Sears b84fcbc828 folly_memcpy is ready for benchmarking 2020-06-02 14:51:21 -07:00
Russell Sears 937baedd44 add memcpy implementation from libfolly 2020-06-02 14:51:21 -07:00
Russell Sears 678b57c0d9 port rte_memcpy to flow; add -mavx compiler flag 2020-06-02 14:51:21 -07:00
Russell Sears a910fa9ac7 memcpy tests from dpdk 2020-06-02 14:51:21 -07:00
Russell Sears 89e6c2f57a copy relevant DPDK license into rte_memcpy.h header 2020-06-02 14:51:21 -07:00
Russell Sears b39cdc4633 check-in unmodified rte_memcpy.h from dpdk 19.11 2020-06-02 14:51:21 -07:00
negoyal cf13e00a8f Merge remote-tracking branch 'origin/release-6.3' into fdb_cache_wo_allocator 2020-06-01 17:38:31 -07:00
Markus Pilman ba63a66d12 Merge remote-tracking branch 'origin/master' into features/flatbuffers-debugtx 2020-05-29 15:38:09 -07:00
David Youngworth c12c11acd3 Merge branch 'master' into dyoungworth/asyncFindFiles 2020-05-27 17:51:08 -07:00
Markus Pilman 8a7d98ab21 Started instrumentation 2020-05-27 15:36:04 -07:00
A.J. Beamon 736a47837d
Merge pull request #3245 from apple/release-6.3
Merge release-6.3 into master
2020-05-27 13:27:47 -07:00
Meng Xu 856fb7b38f Revert "Merge pull request #3197 from tclinken/optimize-deque-copy-ctor"
This reverts commit e898cb7f38, reversing
changes made to 18c2c3d346.
2020-05-27 09:46:20 -07:00
Meng Xu 59132e2cc8
Merge pull request #3237 from ajbeamon/tag-throttling-documentation
Add documentation for the tag throttling feature
2020-05-27 09:33:30 -07:00
David Youngworth 37f7ec9a5f Fix windows compile bug 2020-05-27 09:17:40 -07:00
A.J. Beamon fa08384bc3
Merge pull request #3239 from apple/release-6.3
Merge release 6.3 into master
2020-05-27 08:29:28 -07:00
Meng Xu 755267a7db
Merge pull request #3229 from ajbeamon/calling-run-network-twice-is-error
Eliminate the undefined behavior of calling run_network twice, instead returning an error
2020-05-26 21:24:52 -07:00
A.J. Beamon 530da59d62 Add documentation for the tag throttling feature 2020-05-26 15:27:06 -07:00
A.J. Beamon 76f697fa9d
Merge pull request #3231 from sfc-gh-tclinkenbeard/add-woverloaded-virtual-warning
Added -Woverloaded-virtual warning for clang
2020-05-26 08:12:37 -07:00
Meng Xu 1c35ad884f Merge branch 'master' into mengxu/release-6.3-conflict-PR
Has conflict with master;
Next commit will fix the conflicts.
2020-05-25 12:01:49 -07:00
sfc-gh-tclinkenbeard b7160bab2d Added -Woverloaded-virtual warning for clang, and fixed accidental overloads in flow.h 2020-05-24 13:53:35 -07:00
sfc-gh-tclinkenbeard 8a98ea3320 Changed non_flow_ref to flow_ref for clarity.
Also updated comment to explain that std::is_trivially_copyable
cannot be used to determine whether or not a type is a flow ref.
2020-05-23 22:57:41 -07:00
Evan Tschannen 4b6e1d8a57 fix compile problem 2020-05-22 17:16:59 -07:00
Evan Tschannen ced65cd30b finished explicitly versioning everything stored in the database 2020-05-22 17:14:21 -07:00
Evan Tschannen 72ce997d22 explicitly versioned every key in systemData, so we only will update the associated protocolVersion when the serialization actually changes 2020-05-22 16:35:01 -07:00
Evan Tschannen 8fd926e08e serialize old tlog entries with old protocol versions to support downgrades 2020-05-22 14:00:07 -07:00
A.J. Beamon 86f712657e Eliminate the undefined behavior of calling run_network twice, instead returning an error. 2020-05-22 13:31:06 -07:00
Russell Sears e898cb7f38
Merge pull request #3197 from tclinken/optimize-deque-copy-ctor
Use std::copy in Deque copy constructor
2020-05-22 10:20:42 -07:00
A.J. Beamon d128252e90 Merge release-6.3 into master 2020-05-22 09:25:32 -07:00
David Youngworth 5381927102 Fix windows build 2020-05-21 17:32:16 -07:00
David Youngworth f22a8845e4 Finish putting actors in Platform.actor.cpp 2020-05-20 18:14:29 -07:00
Evan Tschannen f1dca05cf3
Merge pull request #3194 from etschannen/feature-small-endpoint
Optimized failure monitor performance
2020-05-20 14:48:13 -07:00
David Youngworth 9cdc96165e Rename to Platform.actor.cpp 2020-05-20 13:37:39 -07:00
David Youngworth 791d6e61a3 Consolidate Platform.cpp 2020-05-20 13:29:53 -07:00
Evan Tschannen 9d6d916cef fixed compiler error 2020-05-20 12:23:14 -07:00
Evan Tschannen b999b93fa2 added a hash function for endpoint 2020-05-20 12:21:57 -07:00
sfc-gh-tclinkenbeard 131534e4a1 Added =default for Standalone constructors for clarity 2020-05-20 10:28:33 -07:00
tclinken 9a64ec9343 Use std::copy in Deque copy ctor 2020-05-18 20:41:41 -07:00
Markus Pilman d748166ed3 Merge branch 'master' of github.com:apple/foundationdb into features/flatbuffers-debugtx 2020-05-18 10:15:58 -07:00
tclinken c8d3b56ff0 Removed unnecessary is_const_ref struct 2020-05-18 09:02:08 -07:00
tclinken 9d1d83640c Update return type for const_iterator::getKey and const_iterator::getValue 2020-05-17 17:30:07 -07:00
tclinken 3399f566db Fixed MacOS build 2020-05-17 17:29:59 -07:00
tclinken c054b47150 Fixed IndexedSet::getMetric 2020-05-17 12:13:49 -07:00
tclinken e16ec8beca Added cbegin and cend to IndexedSet
Also fixed/improved /flow/IndexedSet/const_iterator test
2020-05-16 18:50:00 -07:00
tclinken e58698d6f7 Added IndexedSet::previous(iterator) const 2020-05-16 18:38:04 -07:00
tclinken 70bd535707 Added IKeyValueContainer::const_iterator 2020-05-16 18:38:03 -07:00
tclinken 79b46c124e Added /flow/IndexedSet/const_iterator unit test 2020-05-16 18:38:03 -07:00
tclinken cbfe380b1d s/NULL/nullptr in IndexedSet.h 2020-05-16 18:38:03 -07:00
tclinken 8f883591d4 Renamed _moveIterator to moveIteratorImpl 2020-05-16 18:38:03 -07:00
tclinken dc11fb6b01 Removed IndexedSet::Impl::end 2020-05-16 18:38:03 -07:00
tclinken 52cb766b17 Renamed IndexedSet::IteratorImpl::i to IndexedSet::IteratorImpl::node 2020-05-16 18:38:02 -07:00
tclinken d9124abb02 Avoid implicit conversion from iterator to const_iterator 2020-05-16 18:38:02 -07:00
tclinken 9c9b56b8b1 Avoid implicit conversion from Node* to iterator 2020-05-16 18:38:02 -07:00
tclinken 864ddd316f Removed duplicate IndexedSet::moveIterator code 2020-05-16 18:38:02 -07:00
tclinken e11ba12da7 Added IndexedSet::ConstImpl and IndexedSet::NonConstImpl 2020-05-16 18:38:02 -07:00
tclinken 84cfafe164 Added IndexedSet::const_iterator 2020-05-16 18:38:01 -07:00
tclinken 7003a68ba1 Removed outdated comments and errorCounts() declaration 2020-05-15 11:04:26 -07:00
tclinken 3ff2fa9c2a Removed uses of outdated cpuTicks and errorCounts 2020-05-13 23:27:44 -07:00
tclinken ddd2814573 Fixed signature of hidden ActionWrapper assignment operator 2020-05-13 19:59:35 -07:00
tclinken eaad516f3a Removed const_cast from readEntireFile 2020-05-13 19:59:35 -07:00
Jingyu Zhou 2efbe7443b
Merge pull request #2873 from alexmiller-apple/mutation-debugging
Rework/redesign/reimplement mutation debugging/tracking for simulation
2020-05-13 19:30:34 -07:00
Alex Miller ccaac162e2 Resolve performance concerns of nearly-no-op debugMutation being frequently called
This introduces unhygenic macro variants that inline a `ENABLED &&`
before the TraceEvent.  This way, they get entirely compiled out unless
enabled.

Then rewrite all debugMutation uses via sed.
2020-05-13 18:44:15 -07:00
Alex Miller 27da91ab9e Merge remote-tracking branch 'upstream/master' into mutation-debugging 2020-05-13 12:51:44 -07:00
Evan Tschannen 19a9ae14c2 update master version to 7.0.0 2020-05-10 23:51:15 -07:00
Evan Tschannen f17f00fdd5 Merge branch 'release-6.2'
# Conflicts:
#	documentation/sphinx/source/release-notes.rst
2020-05-10 22:33:38 -07:00
Meng Xu d9c5a0c559
Merge pull request #3095 from atn34/atn34/special-key-versioning
Add api versioning and opt-in cross-module reads to special key space
2020-05-09 16:21:02 -07:00
Andrew Noyes 8bd5dcaff8 Merge branch 'master' into atn34/special-key-versioning 2020-05-09 15:34:20 -07:00
Kao Makino c2e80fe47b Linux aarch64 port 2020-05-09 22:14:03 +00:00
A.J. Beamon 02307ba7b6 Merge branch 'master' into transaction-tagging
# Conflicts:
#	fdbclient/DatabaseContext.h
2020-05-09 07:50:29 -07:00
Evan Tschannen f0f52fb2be Merge branch 'master' into feature-small-endpoint
# Conflicts:
#	fdbclient/StorageServerInterface.h
2020-05-08 16:37:35 -07:00
negoyal 749fcd13b0 Merge branch 'master' into fdb_cache_wo_allocator 2020-05-08 16:23:29 -07:00
Andrew Noyes 6b35b1b686 Disallow no-module read by default 2020-05-08 05:37:37 +00:00
Andrew Noyes 1d6209e304 Check for cross-module reads 2020-05-08 05:37:37 +00:00
Steve Atherton 62882f5552
Merge pull request #3088 from sears/lb_ub_perf_2
unrevert lb_ub_perf pull request
2020-05-07 18:23:17 -07:00
A.J. Beamon 0be453de0a
Merge pull request #3026 from atn34/atn34/tsan
Add USE_TSAN and fix some data races
2020-05-07 18:06:18 -07:00
Russell Sears 4098f3f48e pr comment 2020-05-07 17:22:04 -07:00
Andrew Noyes 449eac25ae Use DefaultOnMainThread if not on the main thread
Otherwise use the old behavior, which I'm told was intended to fix a
priority version long ago.
2020-05-07 23:22:22 +00:00
Russell Sears 42950eba91 fix two correctness bugs in the comparison logic 2020-05-07 15:50:40 -07:00
Andrew Noyes e772f3a3f1 Separate knob to control valgrind arena instrumentation 2020-05-07 22:07:33 +00:00
Evan Tschannen 6aec2b9c53
Merge pull request #3096 from ajbeamon/fix-invalid-type-detail
Fix invalid trace event detail named "Type" for invalid suppressions
2020-05-07 14:54:53 -07:00
A.J. Beamon aed97a9f20 Merge branch 'master' into transaction-tagging 2020-05-07 14:52:22 -07:00
A.J. Beamon 92730b2f05 Merge branch 'master' into transaction-tagging
# Conflicts:
#	fdbclient/NativeAPI.actor.cpp
2020-05-07 14:50:25 -07:00
Evan Tschannen 50a0753673
Merge pull request #3063 from atn34/atn34/improve-fb-empty-string
Reduce size of flatbuffers messages
2020-05-07 14:42:05 -07:00
Evan Tschannen 41732bc218
Merge pull request #3062 from tclinken/fix-backup-invalid-info-message
Fixed backup_invalid_info error message
2020-05-07 14:40:56 -07:00
Evan Tschannen 574914640a
Merge pull request #2999 from tclinken/more-move-optimizations
Generate rvalue reference overloads for actor callback functions
2020-05-07 14:32:27 -07:00
Russell Sears 945daf980d fix clang build 2020-05-07 12:09:40 -07:00
Russell Sears 5c17d5e054 fix MacOS + Windows build (std::random_shuffle has been deprecated + removed in newer versions of C++) 2020-05-07 12:09:40 -07:00
Russell Sears 1f102f7e16 pr comment: restore assert 2020-05-07 12:09:09 -07:00
Russell Sears 5e1c43f87b replace double invocations of operator<() with three way compare(). 2020-05-07 12:08:29 -07:00
Russell Sears 99a805517e reduce the number of calls to operator< made by lower_bound and upper_bound #2877 2020-05-07 12:08:21 -07:00
Russell Sears ae2d9744cb simple benchmarks of IndexedSet, VersionedMap and std::map 2020-05-07 12:08:00 -07:00
A.J. Beamon 47477382b1 Fix invalid trace event detail named "Type" 2020-05-07 11:22:32 -07:00
Markus Pilman 1c8db89ad4 Implement missing destructor 2020-05-06 14:18:53 -07:00
David Youngworth 65f299715a Fix yield timer in findFiles actor 2020-05-06 10:42:40 -07:00
David Youngworth 5877994f53 Make platform::findFiles asynchronous 2020-05-06 10:40:08 -07:00
Markus Pilman 1453ca6303 Added log writer 2020-05-05 17:58:41 -07:00
A.J. Beamon b1055a8501 Merge branch 'master' into transaction-tagging 2020-05-05 16:03:39 -07:00
A.J. Beamon 8125096e9b
Revert "reduce the number of calls to operator< made by lower_bound and upper…" 2020-05-05 08:17:10 -07:00
negoyal dd033736ed Merge branch 'master' into fdb_cache_subfeature2 2020-05-04 17:29:43 -07:00
Steve Atherton 4ae356b237
Merge pull request #2882 from sears/lb_ub_perf
reduce the number of calls to operator< made by lower_bound and upper…
2020-05-04 15:46:22 -07:00
Russell Sears 17c0ad5a62 switch to the more obvious "l < r ? -1 : l == r ? 0 : 1" since code generation for that seems a bit more stable, and it is probably more commonly used than "(l > r) - (l < r)" 2020-05-04 14:47:23 -07:00
Markus Pilman 362eb41509 Merge remote-tracking branch 'origin/master' into features/flatbuffers-debugtx 2020-05-04 14:17:26 -07:00
Alex Miller ce19156afd
Merge pull request #2909 from mpilman/bugfixes/cmake-includes
don't include source and binary dir
2020-05-04 14:08:25 -07:00
Markus Pilman d039e75ac4 Merge remote-tracking branch 'origin/master' into features/flatbuffers-debugtx 2020-05-04 14:04:52 -07:00
Evan Tschannen b68980d686
Merge pull request #2028 from negoyal/cache_storageq_results
Cache storageq results
2020-05-04 11:27:02 -07:00
A.J. Beamon 36454bb3b8 Merge branch 'master' into transaction-tagging
# Conflicts:
#	fdbclient/MasterProxyInterface.h
#	fdbclient/NativeAPI.actor.cpp
2020-05-04 10:23:25 -07:00